Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Andrey Rahmatullin
On Sun, Jun 21, 2015 at 05:24:09AM +0200, Joël Krähemann wrote:
> Hi Tobias Frost
> 
> Thank you for optimizing my work-flow.
> 
> The following does import the tag debian/0.4.2-69-1
> 
> gbp import-dsc ../ags_0.4.2-69-1.dsc
You should use --git-tag or --git-tag-only gbp switches to make debian/*
tags.

-- 
WBR, wRAR


signature.asc
Description: Digital signature


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Joël Krähemann
Hi Tobias Frost

Thank you for optimizing my work-flow.

The following does import the tag debian/0.4.2-69-1

gbp import-dsc ../ags_0.4.2-69-1.dsc


cheers,
Joël


On Sat, Jun 20, 2015 at 10:38 PM, gregor herrmann  wrote:

> On Sat, 20 Jun 2015 22:27:49 +0200, Tobias Frost wrote:
>
> > gbp-import-orig(1) takes --git-pristine-tar, so this is not needed.
> > You can also set this option to default via e.g debian/gbp.conf
> > Best practice would also to sign your tags, so either --sign-tags or
> > again via gbp.conf
>
> IMO it's easier to set both in ~/.gbp.conf instead of adding an
> identical debian/gbp.conf to each package.
>
> Cheers,
> gregor
>
> --
>  .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key
> 0xBB3A68018649AA06
>  : :' : Debian GNU/Linux user, admin, and developer -
> https://www.debian.org/
>  `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation
> Europe
>`-   NP: Dido: This Land Is Mine
>
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1
>
> iQJ8BAEBCgBmBQJVhc9dXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
> ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREMUUxMzE2RTkzQTc2MEE4MTA0RDg1RkFC
> QjNBNjgwMTg2NDlBQTA2AAoJELs6aAGGSaoGlsMP/09CwWiVHnNv9cTIoU2IoOpC
> yA9AgGk9KHBceCQOYg75GnOrKaGC0YBy0WRbuum6su0fWvr82LlOLMZ3FPR1dXmy
> MM0tDMSPVUPaxsf3LfmUnD8/bF/EDjs3RiiAWJaf4kXJwaXlkTjJfCxSVee6RlEm
> uEOhR+ZAbHMmng41bjAv98j9kOrw4zbkQPv/JBPyWFctHtyyuW4yLWDH77xKhK3D
> Ow2D8QM1+RodVsuau8yT9gg0Voyq4AExmwj4RXdws/tK0QU0ibDKR/T5Ip23y6Bn
> sSgIblLEeHApUbGJsWuuA0Sqxds08tcjQtR7m9ukIE6gtzQi1ZFTfW67GZF+LJYE
> eILs276NQ/f3vBiD6jYPZCQi83Re6bJOdfzu0ZMx/bITi5Yr0GOFHzDMkOATFNIe
> zK8s0gWP6kZH7SpZg2QovWacmik3zt0opB6c4w/b/+Kn4LU9SkXKAUpdLt46yQKK
> eM5hx2wMCuc/u6kcPp5QaTeupsZ5tyQKcjTfCMWFpUHYOgeqaYDVwxl9jbUKAH6Z
> BmDOKEVsRVP7IeJwwNlflck7tdPbn4yjEVoDQPokSmJ4l/k3hdJla/Docgwqy+P9
> frQkN9ONL96Y1m+76pB2+72qoJyy3u/VTJMMPjFnHM0jbIf97UFb7aT3Vfj6jFDv
> W2lFyyUgDkZC1SRVgnK3
> =dGCl
> -END PGP SIGNATURE-
>
>


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread gregor herrmann
On Sat, 20 Jun 2015 22:27:49 +0200, Tobias Frost wrote:

> gbp-import-orig(1) takes --git-pristine-tar, so this is not needed.
> You can also set this option to default via e.g debian/gbp.conf
> Best practice would also to sign your tags, so either --sign-tags or
> again via gbp.conf

IMO it's easier to set both in ~/.gbp.conf instead of adding an
identical debian/gbp.conf to each package.
 
Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Dido: This Land Is Mine


signature.asc
Description: Digital Signature


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Tobias Frost
Am Samstag, den 20.06.2015, 20:25 +0200 schrieb Joël Krähemann:
> Hi,
> 
> Here's a fixed version. I'm doing `git clean -d -x -f` instead of `make
> distclean` because it doesn't remove some generated files.

Thats a bug. The d/rules clean target is supposed to cleanup all
generated/modified files. To get rid of the .pc directory from quilt,
read https://wiki.debian.org/Diaspora/Packaging/quilt 

> 
> joel@debain:~/gsequencer.github$ make distcheck
> joel@debain:~/gsequencer.github$ cp ags-0.4.2-69.tar.gz
> ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.github$ cd ../gsequencer.alioth
> joel@debain:~/gsequencer.alioth$ gbp import-orig ../ags_0.4.2-69.orig.tar.gz

> joel@debain:~/gsequencer.alioth$ git checkout pristine-tar
> joel@debain:~/gsequencer.alioth$ pristine-tar commit
> ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.alioth$ git checkout master

gbp-import-orig(1) takes --git-pristine-tar, so this is not needed.
You can also set this option to default via e.g debian/gbp.conf
Best practice would also to sign your tags, so either --sign-tags or
again via gbp.conf

> joel@debain:~/gsequencer.alioth$ emacs -nw debian/changelog

you know dch(1) and gbp-dch(1)? Those tools helps to avoid mistakes
connected to d/changelogs.

> joel@debain:~/gsequencer.alioth$ git add debian/changelog
> joel@debain:~/gsequencer.alioth$ git commit -m "updated changelog"
> joel@debain:~/gsequencer.alioth$ gbp buildpack
> joel@debain:~/gsequencer.alioth$ lintian ../gsequencer_0.4.2-69-1_amd64.deb

personal style, but I prefer to use debhelper *and* pbuilder to check if
the package builds. You can also tweak those tools to automatically run
lintian after a build. For lintian, you should remember that some
sponsor are EvIL and pedantic, so use lintian -EvIL +pedantic ... [1]

> joel@debain:~/gsequencer.alioth$ git clean -d -x -f

As said, this is a sign that you need to cleanup a little harder after
the build. a debuild clean or make -f debian/rules clean should clean up
in a way that you can directly build afterwards again.

> joel@debain:~/gsequencer.alioth$ gbp buildpackage --git-pristine-tar
> joel@debain:~/gsequencer.alioth$ gbp import-dsc ../ags_0.4.2-69-1.dsc
> joel@debain:~/gsequencer.alioth$ git clean -d -x -f
> joel@debain:~/gsequencer.alioth$ git push --all
> joel@debain:~/gsequencer.alioth$ git push --tags

What do you want to archive with those commands? 

> joel@debain:~/gsequencer.alioth$ dput mentors
> ../ags_0.4.2-69-1_amd64.changes

Before putting to mentors, you should also build in a pbuilder /
cowbuilder or like.

--
tobi


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1434832069.14467.23.ca...@debian.org



Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Joël Krähemann
Hi,

I have just created a pre-commit hook for download page:

http://gsequencer.org/downloads/index.html

This should debian/watch enable to get the source package.

cheers,
Joël



On Sat, Jun 20, 2015 at 8:25 PM, Joël Krähemann 
wrote:

> Hi,
>
> Here's a fixed version. I'm doing `git clean -d -x -f` instead of `make
> distclean` because it doesn't remove some generated files.
>
> joel@debain:~/gsequencer.github$ make distcheck
> joel@debain:~/gsequencer.github$ cp ags-0.4.2-69.tar.gz
> ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.github$ cd ../gsequencer.alioth
> joel@debain:~/gsequencer.alioth$ gbp import-orig
> ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.alioth$ git checkout pristine-tar
> joel@debain:~/gsequencer.alioth$ pristine-tar commit
> ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.alioth$ git checkout master
> joel@debain:~/gsequencer.alioth$ emacs -nw debian/changelog
> joel@debain:~/gsequencer.alioth$ git add debian/changelog
> joel@debain:~/gsequencer.alioth$ git commit -m "updated changelog"
> joel@debain:~/gsequencer.alioth$ gbp buildpack
> joel@debain:~/gsequencer.alioth$ lintian
> ../gsequencer_0.4.2-69-1_amd64.deb
> joel@debain:~/gsequencer.alioth$ git clean -d -x -f
> joel@debain:~/gsequencer.alioth$ gbp buildpackage --git-pristine-tar
> joel@debain:~/gsequencer.alioth$ gbp import-dsc ../ags_0.4.2-69-1.dsc
> joel@debain:~/gsequencer.alioth$ git clean -d -x -f
> joel@debain:~/gsequencer.alioth$ git push --all
> joel@debain:~/gsequencer.alioth$ git push --tags
> joel@debain:~/gsequencer.alioth$ dput mentors
> ../ags_0.4.2-69-1_amd64.changes
>
>
>
> On Sat, Jun 20, 2015 at 1:36 PM, Andrey Rahmatullin 
> wrote:
>
>> On Sat, Jun 20, 2015 at 01:16:42PM +0200, Joël Krähemann wrote:
>> > Just forgot most important command:
>> >
>> > gbp import-dsc ../ags_0.4.2-70-1.1.dsc
>> This won't help the thing you've replying to.
>> Also, this "most important command" fully conflicts with the workflow you
>> listed.
>>
>> > As looking at the `uscan` manual I've discovered the `mk-origtargz`
>> command
>> You don't need this either.
>>
>> --
>> WBR, wRAR
>>
>
>


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Joël Krähemann
Hi,

Here's a fixed version. I'm doing `git clean -d -x -f` instead of `make
distclean` because it doesn't remove some generated files.

joel@debain:~/gsequencer.github$ make distcheck
joel@debain:~/gsequencer.github$ cp ags-0.4.2-69.tar.gz
../ags_0.4.2-69.orig.tar.gz
joel@debain:~/gsequencer.github$ cd ../gsequencer.alioth
joel@debain:~/gsequencer.alioth$ gbp import-orig ../ags_0.4.2-69.orig.tar.gz
joel@debain:~/gsequencer.alioth$ git checkout pristine-tar
joel@debain:~/gsequencer.alioth$ pristine-tar commit
../ags_0.4.2-69.orig.tar.gz
joel@debain:~/gsequencer.alioth$ git checkout master
joel@debain:~/gsequencer.alioth$ emacs -nw debian/changelog
joel@debain:~/gsequencer.alioth$ git add debian/changelog
joel@debain:~/gsequencer.alioth$ git commit -m "updated changelog"
joel@debain:~/gsequencer.alioth$ gbp buildpack
joel@debain:~/gsequencer.alioth$ lintian ../gsequencer_0.4.2-69-1_amd64.deb
joel@debain:~/gsequencer.alioth$ git clean -d -x -f
joel@debain:~/gsequencer.alioth$ gbp buildpackage --git-pristine-tar
joel@debain:~/gsequencer.alioth$ gbp import-dsc ../ags_0.4.2-69-1.dsc
joel@debain:~/gsequencer.alioth$ git clean -d -x -f
joel@debain:~/gsequencer.alioth$ git push --all
joel@debain:~/gsequencer.alioth$ git push --tags
joel@debain:~/gsequencer.alioth$ dput mentors
../ags_0.4.2-69-1_amd64.changes



On Sat, Jun 20, 2015 at 1:36 PM, Andrey Rahmatullin  wrote:

> On Sat, Jun 20, 2015 at 01:16:42PM +0200, Joël Krähemann wrote:
> > Just forgot most important command:
> >
> > gbp import-dsc ../ags_0.4.2-70-1.1.dsc
> This won't help the thing you've replying to.
> Also, this "most important command" fully conflicts with the workflow you
> listed.
>
> > As looking at the `uscan` manual I've discovered the `mk-origtargz`
> command
> You don't need this either.
>
> --
> WBR, wRAR
>


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Andrey Rahmatullin
On Sat, Jun 20, 2015 at 01:16:42PM +0200, Joël Krähemann wrote:
> Just forgot most important command:
> 
> gbp import-dsc ../ags_0.4.2-70-1.1.dsc
This won't help the thing you've replying to.
Also, this "most important command" fully conflicts with the workflow you
listed.

> As looking at the `uscan` manual I've discovered the `mk-origtargz` command
You don't need this either.

-- 
WBR, wRAR


signature.asc
Description: Digital signature


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Andrey Rahmatullin
On Fri, Jun 19, 2015 at 09:30:25PM +0200, Joël Krähemann wrote:
> joel@debain:~/gsequencer.alioth$ gbp import-orig ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.github$ git checkout pristine-tar
> joel@debain:~/gsequencer.github$ pristine-tar commit
> ../ags_0.4.2-69.orig.tar.gz
> joel@debain:~/gsequencer.github$ git checkout master
You could just enable pristine-tar in gbp.

> joel@debain:~/gsequencer.github$ emacs -nw debian/changelog
man dch

> joel@debain:~/gsequencer.github$ git add debian/changelog
> joel@debain:~/gsequencer.github$ git commit -m "updated changelog"
> joel@debain:~/gsequencer.github$ gbp buildpack
> joel@debain:~/gsequencer.github$ lintian ../gsequencer_0.4.2-69-1_amd64.deb
You should run lintian on .changes.

> joel@debain:~/gsequencer.github$ git clean -d -x -f
If you need this you are doing something wrong.

> joel@debain:~/gsequencer.github$ gbp buildpackage --git-pristine-tar
> joel@debain:~/gsequencer.github$ git clean -d -x -f
Huh?


-- 
WBR, wRAR


signature.asc
Description: Digital signature


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-20 Thread Joël Krähemann
Hi,

Just forgot most important command:

gbp import-dsc ../ags_0.4.2-70-1.1.dsc

As looking at the `uscan` manual I've discovered the `mk-origtargz` command

bests,
Joël

On Fri, Jun 19, 2015 at 11:38 PM, Andrey Rahmatullin 
wrote:

> On Fri, Jun 19, 2015 at 09:30:25PM +0200, Joël Krähemann wrote:
> > https://mentors.debian.net/package/ags
> Even mentors shows a lot of lintian-detected problems.
>
> --
> WBR, wRAR
>


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-19 Thread Andrey Rahmatullin
On Fri, Jun 19, 2015 at 09:30:25PM +0200, Joël Krähemann wrote:
> https://mentors.debian.net/package/ags
Even mentors shows a lot of lintian-detected problems. 

-- 
WBR, wRAR


signature.asc
Description: Digital signature


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-19 Thread Joël Krähemann
Hi all

Related to:

https://mentors.debian.net/package/ags
http://anonscm.debian.org/cgit/pkg-multimedia/gsequencer.git

What I'm basically doing to upload to debian, please give any advice to
improve.


joel@debain:~/gsequencer.github$ make distcheck
joel@debain:~/gsequencer.github$ cp ags-0.4.2-69.tar.gz
../ags_0.4.2-69.orig.tar.gz
joel@debain:~/gsequencer.github$ cd ../gsequencer.alioth
joel@debain:~/gsequencer.alioth$ gbp import-orig ../ags_0.4.2-69.orig.tar.gz
joel@debain:~/gsequencer.github$ git checkout pristine-tar
joel@debain:~/gsequencer.github$ pristine-tar commit
../ags_0.4.2-69.orig.tar.gz
joel@debain:~/gsequencer.github$ git checkout master
joel@debain:~/gsequencer.github$ emacs -nw debian/changelog
joel@debain:~/gsequencer.github$ git add debian/changelog
joel@debain:~/gsequencer.github$ git commit -m "updated changelog"
joel@debain:~/gsequencer.github$ gbp buildpack
joel@debain:~/gsequencer.github$ lintian ../gsequencer_0.4.2-69-1_amd64.deb
joel@debain:~/gsequencer.github$ git clean -d -x -f
joel@debain:~/gsequencer.github$ gbp buildpackage --git-pristine-tar
joel@debain:~/gsequencer.github$ git clean -d -x -f
joel@debain:~/gsequencer.github$ git push --all
joel@debain:~/gsequencer.github$ git push --tags
joel@debain:~/gsequencer.github$ dput mentors
../ags_0.4.2-69-1_amd64.changes



cheers,
Joël Krähemann


On Thu, Jun 18, 2015 at 5:24 PM, Ross Gammon  wrote:

> Hi Joël,
>
> On 06/16/2015 04:28 PM, Joël Krähemann wrote:
> > Hi, could someone please take a look at my repository:
> >
> > http://anonscm.debian.org/cgit/pkg-multimedia/gsequencer.git
>
> I am also a member of the multimedia team and have seen your commits
> rolling in. You are getting close to having something ready for
> sponsorship. But on a quick (not complete check) there is still some
> work to do (see below).
>
> > Please tell me what I have to do that it gets processed by the automatic
> > debian build system. Further what is still left to do so.
>
> Coming to the mentors list was a very good idea. There are many
> experienced guys here that can help out.
> The best thing to do next is to prove you can build your package by
> uploading the built package to the mentors website. The website will
> also tell any reviewer whether you have fixed all the relevant lintian
> errors. See here for information:
> https://mentors.debian.net/intro-maintainers
>
> > Note there aren't any signed tags, yet. Should I rebase and add tags for
> > old commits?
>
> Normal practise is to sign a tag when you import the upstream release.
> Then when the package is uploaded to the debian archive, there should be
> a signed tag for the last commit before the upload.
> There is information on tagging specific to the multimedia team here:
> https://wiki.debian.org/DebianMultimedia/DevelopPackaging
>
> > best regards
> > Joël Krähemann
> >
>
> Now for some comments:
> debian/changelog - Your changelog entry looks a little unfinished. It
> should close your ITP bug, and as it is a new package it really only
> needs one entry which is something like:
>   * Initial release (Closes: #)  
>
> debian/copyright - You only list the copyright for files in the debian
> directory. You should also list the copyright for the upstream source code.
>
> debian/debhelper.log - This file is the resulting log from a previous
> build of the package to help with troubleshooting. It should be deleted.
>
> debian/rules - You should remove all the unnecessary commenting. It is
> normally okay to leave the "verbose" option commented out so that it can
> be quickly added in when you are troubleshooting.
>
> Some references that you might want to read (again?):
> https://www.debian.org/doc/manuals/maint-guide/index.en.html
> https://wiki.debian.org/UpstreamGuide (* as I know you are also upstream).
>
> Keep going!
>
> Cheers,
>
> Ross
>
>


Re: packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-18 Thread Ross Gammon
Hi Joël,

On 06/16/2015 04:28 PM, Joël Krähemann wrote:
> Hi, could someone please take a look at my repository:
> 
> http://anonscm.debian.org/cgit/pkg-multimedia/gsequencer.git

I am also a member of the multimedia team and have seen your commits
rolling in. You are getting close to having something ready for
sponsorship. But on a quick (not complete check) there is still some
work to do (see below).

> Please tell me what I have to do that it gets processed by the automatic
> debian build system. Further what is still left to do so.

Coming to the mentors list was a very good idea. There are many
experienced guys here that can help out.
The best thing to do next is to prove you can build your package by
uploading the built package to the mentors website. The website will
also tell any reviewer whether you have fixed all the relevant lintian
errors. See here for information:
https://mentors.debian.net/intro-maintainers

> Note there aren't any signed tags, yet. Should I rebase and add tags for
> old commits?

Normal practise is to sign a tag when you import the upstream release.
Then when the package is uploaded to the debian archive, there should be
a signed tag for the last commit before the upload.
There is information on tagging specific to the multimedia team here:
https://wiki.debian.org/DebianMultimedia/DevelopPackaging

> best regards
> Joël Krähemann
> 

Now for some comments:
debian/changelog - Your changelog entry looks a little unfinished. It
should close your ITP bug, and as it is a new package it really only
needs one entry which is something like:
  * Initial release (Closes: #)  

debian/copyright - You only list the copyright for files in the debian
directory. You should also list the copyright for the upstream source code.

debian/debhelper.log - This file is the resulting log from a previous
build of the package to help with troubleshooting. It should be deleted.

debian/rules - You should remove all the unnecessary commenting. It is
normally okay to leave the "verbose" option commented out so that it can
be quickly added in when you are troubleshooting.

Some references that you might want to read (again?):
https://www.debian.org/doc/manuals/maint-guide/index.en.html
https://wiki.debian.org/UpstreamGuide (* as I know you are also upstream).

Keep going!

Cheers,

Ross



signature.asc
Description: OpenPGP digital signature


packaging Advanced Gtk+ Sequencer - automatic debian build

2015-06-16 Thread Joël Krähemann
Hi, could someone please take a look at my repository:

http://anonscm.debian.org/cgit/pkg-multimedia/gsequencer.git

Please tell me what I have to do that it gets processed by the automatic
debian build system. Further what is still left to do so.

Note there aren't any signed tags, yet. Should I rebase and add tags for
old commits?

best regards
Joël Krähemann