El sáb, 08-09-2012 a las 11:10 +0200, Bart Martens escribió:
> Hi Jose,
>
> I had a look at libgringotts at mentors uploaded there on 2012-09-05 13:50.
>
> The changes that were added in gringotts 1.2.10~pre3-1 are also relevant to
> libgringotts's history of changes, so I suggest to copy the changelog entry
> from gringotts 1.2.10~pre3-1 to your libgringotts debian/changelog.
Added.
> I see that you reverted the changes to config.h.in and that is not documented
> in debian/changelog. Are you sure about reverting these changes ?
I see:
--- gringotts-1.2.10~pre3.orig/libgringotts/config.h.in
+++ gringotts-1.2.10~pre3/libgringotts/config.h.in
@@ -72,6 +72,10 @@
/* The library version */
#undef LIBGRG_VERSION
+/* Define to the sub-directory in which libtool stores uninstalled
libraries.
+ */
+#undef LT_OBJDIR
+
/* Name of package */
#undef PACKAGE
But I'm using config.h.in from upstream source, I thing that file was
changed when source package was merged.
> If the change is the solution, then you can simply use "closes: #633167" in
> debian/changelog.
Changed but bug #633167 belongs to gringotts so we should close it
manually. And I get a lintian error.
> It is better to not override lintian false positives.
All right, removed.
> Regards,
>
> Bart Martens
Re-uploaded to mentors.
Thanks for your review, Bart!
P.D: I'm doing development here https://gitorious.org/deb-pkg, if you
prefer to review from a vcs.
signature.asc
Description: This is a digitally signed message part
