Re: FTBS of ardour
Hi Felipe, * Felipe Sateler <[EMAIL PROTECTED]> [2007-12-04 15:37]: > On Sunday 21 October 2007 08:19:23 Nico Golde wrote: > > Hi Ardour maintainers, > > Did someone of you already look into: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446597? > > I ask because this is the only thing missing from fixing the > > security flaw in ardour described on: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445889 > > The scons bug that was blocking this is gone[1], anyone with ardour > experience > care to fix that bug? AFAICS, it is just a matter of applying the attached > patch. I will take care of this! Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpCIGWifjejs.pgp Description: PGP signature
Re: FTBS of ardour
On Sunday 21 October 2007 08:19:23 Nico Golde wrote:
> Hi Ardour maintainers,
> Did someone of you already look into:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446597?
> I ask because this is the only thing missing from fixing the
> security flaw in ardour described on:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445889
The scons bug that was blocking this is gone[1], anyone with ardour experience
care to fix that bug? AFAICS, it is just a matter of applying the attached
patch.
[1]http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=444204
--
Felipe Sateler
diff -Nru trunk/gtk2_ardour/editor_mouse.cc trunk.new/gtk2_ardour/editor_mouse.cc
--- trunk/gtk2_ardour/editor_mouse.cc 2007-10-22 19:30:28.0 -0300
+++ trunk.new/gtk2_ardour/editor_mouse.cc 2007-10-22 19:38:39.0 -0300
@@ -1530,8 +1530,8 @@
*/
if (!drag_info.move_threshold_passed) {
- bool x_threshold_passed = (abs ((nframes64_t) (drag_info.current_pointer_x - drag_info.grab_x)) > 4LL);
- bool y_threshold_passed = (abs ((nframes64_t) (drag_info.current_pointer_y - drag_info.grab_y)) > 4LL);
+ bool x_threshold_passed = (((nframes64_t) abs (drag_info.current_pointer_x - drag_info.grab_x)) > 4LL);
+ bool y_threshold_passed = (((nframes64_t) abs (drag_info.current_pointer_y - drag_info.grab_y)) > 4LL);
drag_info.move_threshold_passed = (x_threshold_passed || y_threshold_passed);
signature.asc
Description: This is a digitally signed message part.
Re: FTBS of ardour
Hi Felipe,
* Felipe Sateler <[EMAIL PROTECTED]> [2007-10-27 11:53]:
> On Friday 26 October 2007 14:52:00 Nico Golde wrote:
[...]
> > + [ Delete ('$PREFIX/etc/ardour2'),
> > + Delete ('$PREFIX/lib/ardour2'),
> > + Delete ('$PREFIX/bin/ardour2')])
> >
> > env.Alias('revision', the_revision)
> > env.Alias('install', env.Install(os.path.join(config_prefix, 'ardour2'),
> > 'ardour_system.rc')) +env.Alias('uninstall', remove_ardour)
> >
> > I don't know if this is complete, I guess it's not but this is from
> > revision 2539 which is quite a big change.
>
> I think this is unrelated: it creates an uninstall target, which has nothing
> to do with cleaning the build.
That's what upstream told me in #ardour on freenode when I
asked him about the broken scons call.
Kind regards
Nico
--
Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.
pgpxhSaouHDnN.pgp
Description: PGP signature
Re: FTBS of ardour
On Friday 26 October 2007 14:52:00 Nico Golde wrote:
> Hi Felipe,
>
> * Felipe Sateler <[EMAIL PROTECTED]> [2007-10-26 18:50]:
> > On Wednesday 24 October 2007 05:42:49 Nico Golde wrote:
> > > Updating to the latest Scons build file in ardour svn should
> > > solve this, they added some uninstall rule referring to
> > > upstream.
> + [ Delete ('$PREFIX/etc/ardour2'),
> + Delete ('$PREFIX/lib/ardour2'),
> + Delete ('$PREFIX/bin/ardour2')])
>
> env.Alias('revision', the_revision)
> env.Alias('install', env.Install(os.path.join(config_prefix, 'ardour2'),
> 'ardour_system.rc')) +env.Alias('uninstall', remove_ardour)
>
> I don't know if this is complete, I guess it's not but this is from
> revision 2539 which is quite a big change.
I think this is unrelated: it creates an uninstall target, which has nothing
to do with cleaning the build.
--
Felipe Sateler
signature.asc
Description: This is a digitally signed message part.
Re: FTBS of ardour
Hi Felipe,
* Felipe Sateler <[EMAIL PROTECTED]> [2007-10-26 18:50]:
> On Wednesday 24 October 2007 05:42:49 Nico Golde wrote:
> > Updating to the latest Scons build file in ardour svn should
> > solve this, they added some uninstall rule referring to
> > upstream.
>
> What revision? I can't see anything in the websvn at
> http://viewcvs.ardour.org/log.php?repname=Ardour&path=%2Ftrunk%2FSConstruct&rev=0&sc=0&isdir=0
+ [ Delete ('$PREFIX/etc/ardour2'),
+ Delete ('$PREFIX/lib/ardour2'),
+ Delete ('$PREFIX/bin/ardour2')])
env.Alias('revision', the_revision)
env.Alias('install', env.Install(os.path.join(config_prefix, 'ardour2'),
'ardour_system.rc'))
+env.Alias('uninstall', remove_ardour)
I don't know if this is complete, I guess it's not but this is from revision
2539 which is quite a big change.
Kind regards
Nico
--
Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.
pgpq7fEH0wSsn.pgp
Description: PGP signature
Re: FTBS of ardour
On Wednesday 24 October 2007 05:42:49 Nico Golde wrote: > Updating to the latest Scons build file in ardour svn should > solve this, they added some uninstall rule referring to > upstream. What revision? I can't see anything in the websvn at http://viewcvs.ardour.org/log.php?repname=Ardour&path=%2Ftrunk%2FSConstruct&rev=0&sc=0&isdir=0 -- Felipe Sateler signature.asc Description: This is a digitally signed message part.
Re: FTBS of ardour
Hi Felipe, * Felipe Sateler <[EMAIL PROTECTED]> [2007-10-23 17:06]: > On 10/23/07, Nico Golde <[EMAIL PROTECTED]> wrote: [...] > > > I've been looking into this. The pkg-config issue is trivial, a pkg-config > > > build-dep was missing. > > > > Are you sure about this? I don't really think so I think > > this is a scons issue, if you look at the build log failing > > because of pkg-config you can see another place where > > pkg-config is there in the same build > > Ah, this is true. I failed to see that pkg-config was brought in by > some dependency earlier, and that the failure was when cleaning. I > know what the problem is, but unfortunately there is nothing we can > do, please see scons bug 444204. In short, the problem is that the > current snapshot in unstable doesn't actually execute configuration > directives when called with -c (clean) or -h (help). This has the side > effect that all configure calls return false, which makes cleaning and > asking for help break. This is apparently fixed in upstream svn, but > hasn't got here yet. > I wasn't able to reproduce the problem here since I have scons on hold > for exactly this reason (I do feel somewhat embarrased for not seeing > this before, though). Updating to the latest Scons build file in ardour svn should solve this, they added some uninstall rule referring to upstream. > > > I'm having a problem with the abs issue, though: I > > > can't understand why it is there, and it doesn't appear here on i386. > > > > From what I see the problem is that it does not know to > > which type the value should be converted, there is no > > variant for nframes64_t or int64_t and int64_t is assignment > > compatible with float and int for example. > > So typecasting should solve this. > > The strange thing is that this should happen in other 32-bit > architectures too, since the int64_t is defined as a long long int, > which has no abs implementation in the std:: namespace. Anyways, my > patch moved the casting from double to int64_t to after the abs is > done, which should resolve the ambiguity (double std::abs(double) is > present in the C++ standard). Yes this should be ok. Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpcz0IN2Zvuo.pgp Description: PGP signature
Re: FTBS of ardour
On 10/23/07, Nico Golde <[EMAIL PROTECTED]> wrote: > Hi Felipe, > * Felipe Sateler <[EMAIL PROTECTED]> [2007-10-23 10:22]: > > On Sunday 21 October 2007 08:19:23 Nico Golde wrote: > > > Hi Ardour maintainers, > > > Did someone of you already look into: > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446597? > > > I ask because this is the only thing missing from fixing the > > > security flaw in ardour described on: > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445889 > > > > I've been looking into this. The pkg-config issue is trivial, a pkg-config > > build-dep was missing. > > Are you sure about this? I don't really think so I think > this is a scons issue, if you look at the build log failing > because of pkg-config you can see another place where > pkg-config is there in the same build Ah, this is true. I failed to see that pkg-config was brought in by some dependency earlier, and that the failure was when cleaning. I know what the problem is, but unfortunately there is nothing we can do, please see scons bug 444204. In short, the problem is that the current snapshot in unstable doesn't actually execute configuration directives when called with -c (clean) or -h (help). This has the side effect that all configure calls return false, which makes cleaning and asking for help break. This is apparently fixed in upstream svn, but hasn't got here yet. I wasn't able to reproduce the problem here since I have scons on hold for exactly this reason (I do feel somewhat embarrased for not seeing this before, though). > > > I'm having a problem with the abs issue, though: I > > can't understand why it is there, and it doesn't appear here on i386. > > From what I see the problem is that it does not know to > which type the value should be converted, there is no > variant for nframes64_t or int64_t and int64_t is assignment > compatible with float and int for example. > So typecasting should solve this. The strange thing is that this should happen in other 32-bit architectures too, since the int64_t is defined as a long long int, which has no abs implementation in the std:: namespace. Anyways, my patch moved the casting from double to int64_t to after the abs is done, which should resolve the ambiguity (double std::abs(double) is present in the C++ standard). -- Felipe Sateler -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: FTBS of ardour
Hi Felipe, * Felipe Sateler <[EMAIL PROTECTED]> [2007-10-23 10:22]: > On Sunday 21 October 2007 08:19:23 Nico Golde wrote: > > Hi Ardour maintainers, > > Did someone of you already look into: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446597? > > I ask because this is the only thing missing from fixing the > > security flaw in ardour described on: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445889 > > I've been looking into this. The pkg-config issue is trivial, a pkg-config > build-dep was missing. Are you sure about this? I don't really think so I think this is a scons issue, if you look at the build log failing because of pkg-config you can see another place where pkg-config is there in the same build > I'm having a problem with the abs issue, though: I > can't understand why it is there, and it doesn't appear here on i386. From what I see the problem is that it does not know to which type the value should be converted, there is no variant for nframes64_t or int64_t and int64_t is assignment compatible with float and int for example. So typecasting should solve this. Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpAHEVL1LNyM.pgp Description: PGP signature
Re: FTBS of ardour
On Sunday 21 October 2007 08:19:23 Nico Golde wrote:
> Hi Ardour maintainers,
> Did someone of you already look into:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446597?
> I ask because this is the only thing missing from fixing the
> security flaw in ardour described on:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445889
I've been looking into this. The pkg-config issue is trivial, a pkg-config
build-dep was missing. I'm having a problem with the abs issue, though: I
can't understand why it is there, and it doesn't appear here on i386. I think
the problem is there because (for some strange reason) abs(long long) is
defined on i386 and other archs but not on mips. I (hopefully, I don't have a
mips machine to test on) work around that by making it an abs(double) and
then casting to nframes_t. This appears to work here.
Attached is a patch that makes the necessary changes.
--
Felipe Sateler
diff -Nru trunk/debian/control trunk.new/debian/control
--- trunk/debian/control 2007-10-22 19:27:07.0 -0300
+++ trunk.new/debian/control 2007-10-22 19:37:03.0 -0300
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: Debian Multimedia Team
Uploaders: Guenter Geiger (Debian/GNU) <[EMAIL PROTECTED]>, Robert Jordens <[EMAIL PROTECTED]>, Free Ekanayaka <[EMAIL PROTECTED]>
-Build-Depends: autotools-dev, quilt, patchutils (>= 0.2.25), cdbs (>= 0.4.27-1), debhelper (>= 4.1.0), scons, dh-buildinfo, libsigc++-2.0-dev, libxml2-dev (>= 2.5.7), libasound2-dev (>= 0.9.4), libsndfile1-dev, libsamplerate0-dev, liblrdf0-dev (>= 0.3.1-4), ladspa-sdk (>= 1.1-2), libjack-dev, libgtkmm-2.4-dev, libglade2-dev, libpango1.0-dev, libgnomecanvasmm-2.6-dev, libgnomecanvas2-dev, libglib2.0-dev, libglademm-2.4-dev, gettext, intltool, libboost-dev, libsoundtouch1-dev, liblo0-dev, libcairomm-1.0-dev (>= 1.2.4)
+Build-Depends: autotools-dev, quilt, patchutils (>= 0.2.25), cdbs (>= 0.4.27-1), debhelper (>= 4.1.0), scons, dh-buildinfo, libsigc++-2.0-dev, libxml2-dev (>= 2.5.7), libasound2-dev (>= 0.9.4), libsndfile1-dev, libsamplerate0-dev, liblrdf0-dev (>= 0.3.1-4), ladspa-sdk (>= 1.1-2), libjack-dev, libgtkmm-2.4-dev, libglade2-dev, libpango1.0-dev, libgnomecanvasmm-2.6-dev, libgnomecanvas2-dev, libglib2.0-dev, libglademm-2.4-dev, gettext, intltool, libboost-dev, libsoundtouch1-dev, liblo0-dev, libcairomm-1.0-dev (>= 1.2.4), pkg-config
Standards-Version: 3.7.2
Package: ardour
diff -Nru trunk/gtk2_ardour/editor_mouse.cc trunk.new/gtk2_ardour/editor_mouse.cc
--- trunk/gtk2_ardour/editor_mouse.cc 2007-10-22 19:30:28.0 -0300
+++ trunk.new/gtk2_ardour/editor_mouse.cc 2007-10-22 19:38:39.0 -0300
@@ -1530,8 +1530,8 @@
*/
if (!drag_info.move_threshold_passed) {
- bool x_threshold_passed = (abs ((nframes64_t) (drag_info.current_pointer_x - drag_info.grab_x)) > 4LL);
- bool y_threshold_passed = (abs ((nframes64_t) (drag_info.current_pointer_y - drag_info.grab_y)) > 4LL);
+ bool x_threshold_passed = (((nframes64_t) abs (drag_info.current_pointer_x - drag_info.grab_x)) > 4LL);
+ bool y_threshold_passed = (((nframes64_t) abs (drag_info.current_pointer_y - drag_info.grab_y)) > 4LL);
drag_info.move_threshold_passed = (x_threshold_passed || y_threshold_passed);
signature.asc
Description: This is a digitally signed message part.
FTBS of ardour
Hi Ardour maintainers, Did someone of you already look into: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=446597? I ask because this is the only thing missing from fixing the security flaw in ardour described on: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445889 Kind regards Nico -- Nico Golde - http://www.ngolde.de - [EMAIL PROTECTED] - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. pgpLFIAAkdZov.pgp Description: PGP signature
