Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-21 Thread Adeodato Simó
* Eduard Bloch [Thu, 20 Jul 2006 01:19:56 +0200]:

> (btw, packages.d.o still says it is there)

(JFTR, you're confusing 2.7.3-2 with 2.7.7-2.)

-- 
Adeodato Simó dato at net.com.org.es
Debian Developer  adeodato at debian.org
 
A hacker does for love what other would not do for money.




Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-20 Thread Samuel Mimram
Eduard Bloch wrote:
> #include 
> * Samuel Mimram [Thu, Jul 20 2006, 01:04:53AM]:
>> Eduard Bloch wrote:
>>> #include 
>> #include 
>>
>>> * Samuel Mimram [Thu, Jul 20 2006, 12:26:40AM]:
 Eduard Bloch wrote:
> Package: mldonkey-server
> Version: 2.7.3-2
> Severity: grave
>
> (Reading database ... 147973 files and directories currently installed.)
> Preparing to replace mldonkey-server 2.7.3-2 (using 
> .../mldonkey-server_2.7.7-4_amd64.deb) ...
> Stopping MLDonkey: mlnetNo process in pidfile 
> `/var/run/mldonkey/mlnet.pid' found running; none killed.
> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> dpkg: warning - old pre-removal script returned error exit status 1
> dpkg - trying script from the new package instead ...
> Stopping MLDonkey: mlnetNo process in pidfile 
> `/var/run/mldonkey/mlnet.pid' found running; none killed.
> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> dpkg: error processing 
> /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
>  subprocess new pre-removal script returned error exit status 1
> Starting MLDonkey: mlnet configuration file prevent mlnet to be started 
> (use force-start).
> Errors were encountered while processing:
>  /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
> E: Sub-process /usr/bin/dpkg returned an error code (1)
 Unfortunately, this was a bug in the 2.7.3-2 version of the package
 (which was removed from testing), see #338875, #363635 and #368118.
>>> I don't talk about testing. And the log message says the bug exists in
>>> the new version as well ("using .../mldonkey-server_2.7.7-4_amd64.deb"
>>> "dpkg - trying script from the new package instead ...").
>> The stop) action of the new script is fairly simple:
>>
>>   stop)
>> echo -n "Stopping $DESC: $NAME"
>> start-stop-daemon --stop --oknodo --pidfile $PIDFILE
>> echo "."
>>   ;;
>>
>> Let's try a little experiment (of course the "toto" file does not exist):
> 
> Well, that is not the point! When the new version of prerm is run, it
> does still execute the _old_ init script. So, how do you intend to solve
> this problem?

Ah! the "trying script from the new package instead" refers to the prerm
script, I thought you were saying that it referred to the init.d script.

> If I were you, I would stop using dh_installinit and make the prerm
> failure-resistant with custom code.

Well, since it was removed from testing and was not in stable I thought
it was ok to correct this error the way I did. Since you insist, I'll
come up with a hand crafted solution.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-20 Thread Samuel Mimram
Eduard Bloch wrote:
> * Eduard Bloch [Thu, Jul 20 2006, 01:19:56AM]:
> 
>>> The stop) action of the new script is fairly simple:
>>>
>>>   stop)
>>> echo -n "Stopping $DESC: $NAME"
>>> start-stop-daemon --stop --oknodo --pidfile $PIDFILE
>>> echo "."
>>>   ;;
>>>
>>> Let's try a little experiment (of course the "toto" file does not exist):
>> Well, that is not the point! When the new version of prerm is run, it
>> does still execute the _old_ init script. So, how do you intend to solve
>> this problem?
> 
> Oh, and the fun continues:
> 
> Setting up mldonkey-server (2.7.7-4) ...
> Please set both variables MLDONKEY_USER and MLDONKEY_GROUP in 
> /etc/default/mldonkey-server
> invoke-rc.d: initscript mldonkey-server, action "start" failed.
> dpkg: error processing mldonkey-server (--configure):
>  subprocess post-installation script returned error exit status 1
> Errors were encountered while processing:
>  mldonkey-server
> 
> Sorry, WTF? It was purged, of course there is no such setting.

This one is a real bug of mine, pending upload, see #378603.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-19 Thread Samuel Mimram
Eduard Bloch wrote:
> #include 

#include 

> * Samuel Mimram [Thu, Jul 20 2006, 12:26:40AM]:
>> Eduard Bloch wrote:
>>> Package: mldonkey-server
>>> Version: 2.7.3-2
>>> Severity: grave
>>>
>>> (Reading database ... 147973 files and directories currently installed.)
>>> Preparing to replace mldonkey-server 2.7.3-2 (using 
>>> .../mldonkey-server_2.7.7-4_amd64.deb) ...
>>> Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
>>> found running; none killed.
>>> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
>>> dpkg: warning - old pre-removal script returned error exit status 1
>>> dpkg - trying script from the new package instead ...
>>> Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
>>> found running; none killed.
>>> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
>>> dpkg: error processing 
>>> /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
>>>  subprocess new pre-removal script returned error exit status 1
>>> Starting MLDonkey: mlnet configuration file prevent mlnet to be started 
>>> (use force-start).
>>> Errors were encountered while processing:
>>>  /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
>>> E: Sub-process /usr/bin/dpkg returned an error code (1)
>> Unfortunately, this was a bug in the 2.7.3-2 version of the package
>> (which was removed from testing), see #338875, #363635 and #368118.
> 
> I don't talk about testing. And the log message says the bug exists in
> the new version as well ("using .../mldonkey-server_2.7.7-4_amd64.deb"
> "dpkg - trying script from the new package instead ...").

The stop) action of the new script is fairly simple:

  stop)
echo -n "Stopping $DESC: $NAME"
start-stop-daemon --stop --oknodo --pidfile $PIDFILE
echo "."
  ;;

Let's try a little experiment (of course the "toto" file does not exist):

% /sbin/start-stop-daemon --stop --pidfile toto; echo $?
No process in pidfile `toto' found running; none killed.
1

Now with the --oknodo option:

% /sbin/start-stop-daemon --stop --oknodo --pidfile toto; echo $?
No process in pidfile `toto' found running; none killed.
0

So, I don't see how /etc/init.d/mldonkey-server stop could return 1 with
the new script. Do you see any flaw in my analysis? Else I'll reassign
the bug to dpkg.

Cheers,

Samuel.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-19 Thread Eduard Bloch
#include 
* Eduard Bloch [Thu, Jul 20 2006, 01:19:56AM]:

> > The stop) action of the new script is fairly simple:
> > 
> >   stop)
> > echo -n "Stopping $DESC: $NAME"
> > start-stop-daemon --stop --oknodo --pidfile $PIDFILE
> > echo "."
> >   ;;
> > 
> > Let's try a little experiment (of course the "toto" file does not exist):
> 
> Well, that is not the point! When the new version of prerm is run, it
> does still execute the _old_ init script. So, how do you intend to solve
> this problem?

Oh, and the fun continues:

Setting up mldonkey-server (2.7.7-4) ...
Please set both variables MLDONKEY_USER and MLDONKEY_GROUP in 
/etc/default/mldonkey-server
invoke-rc.d: initscript mldonkey-server, action "start" failed.
dpkg: error processing mldonkey-server (--configure):
 subprocess post-installation script returned error exit status 1
Errors were encountered while processing:
 mldonkey-server

Sorry, WTF? It was purged, of course there is no such setting.

Eduard.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-19 Thread Eduard Bloch
#include 
* Samuel Mimram [Thu, Jul 20 2006, 01:04:53AM]:
> Eduard Bloch wrote:
> > #include 
> 
> #include 
> 
> > * Samuel Mimram [Thu, Jul 20 2006, 12:26:40AM]:
> >> Eduard Bloch wrote:
> >>> Package: mldonkey-server
> >>> Version: 2.7.3-2
> >>> Severity: grave
> >>>
> >>> (Reading database ... 147973 files and directories currently installed.)
> >>> Preparing to replace mldonkey-server 2.7.3-2 (using 
> >>> .../mldonkey-server_2.7.7-4_amd64.deb) ...
> >>> Stopping MLDonkey: mlnetNo process in pidfile 
> >>> `/var/run/mldonkey/mlnet.pid' found running; none killed.
> >>> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> >>> dpkg: warning - old pre-removal script returned error exit status 1
> >>> dpkg - trying script from the new package instead ...
> >>> Stopping MLDonkey: mlnetNo process in pidfile 
> >>> `/var/run/mldonkey/mlnet.pid' found running; none killed.
> >>> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> >>> dpkg: error processing 
> >>> /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
> >>>  subprocess new pre-removal script returned error exit status 1
> >>> Starting MLDonkey: mlnet configuration file prevent mlnet to be started 
> >>> (use force-start).
> >>> Errors were encountered while processing:
> >>>  /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
> >>> E: Sub-process /usr/bin/dpkg returned an error code (1)
> >> Unfortunately, this was a bug in the 2.7.3-2 version of the package
> >> (which was removed from testing), see #338875, #363635 and #368118.
> > 
> > I don't talk about testing. And the log message says the bug exists in
> > the new version as well ("using .../mldonkey-server_2.7.7-4_amd64.deb"
> > "dpkg - trying script from the new package instead ...").
> 
> The stop) action of the new script is fairly simple:
> 
>   stop)
> echo -n "Stopping $DESC: $NAME"
> start-stop-daemon --stop --oknodo --pidfile $PIDFILE
> echo "."
>   ;;
> 
> Let's try a little experiment (of course the "toto" file does not exist):

Well, that is not the point! When the new version of prerm is run, it
does still execute the _old_ init script. So, how do you intend to solve
this problem?

Removing a package from testing (btw, packages.d.o still says it is
there) does not automaticaly disable all such time bombs outthere.

If I were you, I would stop using dh_installinit and make the prerm
failure-resistant with custom code.

And I wish dh_installinit would have an option for
not-failing-on-restart-problems.

Eduard.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-19 Thread Eduard Bloch
#include 
* Samuel Mimram [Thu, Jul 20 2006, 12:26:40AM]:
> Hi,
> 
> Eduard Bloch wrote:
> > Package: mldonkey-server
> > Version: 2.7.3-2
> > Severity: grave
> > 
> > (Reading database ... 147973 files and directories currently installed.)
> > Preparing to replace mldonkey-server 2.7.3-2 (using 
> > .../mldonkey-server_2.7.7-4_amd64.deb) ...
> > Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
> > found running; none killed.
> > invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> > dpkg: warning - old pre-removal script returned error exit status 1
> > dpkg - trying script from the new package instead ...
> > Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
> > found running; none killed.
> > invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> > dpkg: error processing 
> > /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
> >  subprocess new pre-removal script returned error exit status 1
> > Starting MLDonkey: mlnet configuration file prevent mlnet to be started 
> > (use force-start).
> > Errors were encountered while processing:
> >  /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
> > E: Sub-process /usr/bin/dpkg returned an error code (1)
> 
> Unfortunately, this was a bug in the 2.7.3-2 version of the package
> (which was removed from testing), see #338875, #363635 and #368118.

Please. Read. The. Log. Now.

I don't talk about testing. And the log message says the bug exists in
the new version as well ("using .../mldonkey-server_2.7.7-4_amd64.deb"
"dpkg - trying script from the new package instead ...").

> Please change the line 100 (in the stop case) of
> /etc/init.d/mldonkey-server from
> 
> start-stop-daemon --stop --pidfile $PIDFILE
> 
> to
> 
> start-stop-daemon --stop --oknodo --pidfile $PIDFILE
> 
> (add the --oknodo) and the update should work. I'm sorry but I cannot
> figure out an easy way to workaround this bug and make the package
> upgrade properly. This is of course fixed in the current version of the
> package.

Of course not, see above.

Eduard.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-19 Thread Samuel Mimram
Hi,

Eduard Bloch wrote:
> Package: mldonkey-server
> Version: 2.7.3-2
> Severity: grave
> 
> (Reading database ... 147973 files and directories currently installed.)
> Preparing to replace mldonkey-server 2.7.3-2 (using 
> .../mldonkey-server_2.7.7-4_amd64.deb) ...
> Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
> found running; none killed.
> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> dpkg: warning - old pre-removal script returned error exit status 1
> dpkg - trying script from the new package instead ...
> Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
> found running; none killed.
> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> dpkg: error processing 
> /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
>  subprocess new pre-removal script returned error exit status 1
> Starting MLDonkey: mlnet configuration file prevent mlnet to be started (use 
> force-start).
> Errors were encountered while processing:
>  /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
> E: Sub-process /usr/bin/dpkg returned an error code (1)

Unfortunately, this was a bug in the 2.7.3-2 version of the package
(which was removed from testing), see #338875, #363635 and #368118.

Please change the line 100 (in the stop case) of
/etc/init.d/mldonkey-server from

start-stop-daemon --stop --pidfile $PIDFILE

to

start-stop-daemon --stop --oknodo --pidfile $PIDFILE

(add the --oknodo) and the update should work. I'm sorry but I cannot
figure out an easy way to workaround this bug and make the package
upgrade properly. This is of course fixed in the current version of the
package.

IMHO this bug could be closed, what do you think?

Cheers,

Samuel.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

2006-07-19 Thread Eduard Bloch
Package: mldonkey-server
Version: 2.7.3-2
Severity: grave

(Reading database ... 147973 files and directories currently installed.)
Preparing to replace mldonkey-server 2.7.3-2 (using 
.../mldonkey-server_2.7.7-4_amd64.deb) ...
Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
found running; none killed.
invoke-rc.d: initscript mldonkey-server, action "stop" failed.
dpkg: warning - old pre-removal script returned error exit status 1
dpkg - trying script from the new package instead ...
Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' 
found running; none killed.
invoke-rc.d: initscript mldonkey-server, action "stop" failed.
dpkg: error processing 
/var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
 subprocess new pre-removal script returned error exit status 1
Starting MLDonkey: mlnet configuration file prevent mlnet to be started (use 
force-start).
Errors were encountered while processing:
 /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)



-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17.4
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

Versions of packages mldonkey-server depends on:
pn  adduser(no description available)
ii  debconf [debconf-2.0] 1.5.2  Debian configuration management sy
ii  dpkg  1.13.22package maintenance system for Deb
pn  libbz2-1.0 (no description available)
ii  libc6 2.3.6-15   GNU C Library: Shared libraries
ii  libfreetype6  2.2.1-2FreeType 2 font engine, shared lib
ii  libgcc1   1:4.1.1-9  GCC support library
pn  libgd2-noxpm | libgd2-xpm  (no description available)
ii  libjpeg62 6b-13  The Independent JPEG Group's JPEG 
pn  libpng12-0 (no description available)
ii  libstdc++64.1.1-9The GNU Standard C++ Library v3
pn  mime-support   (no description available)
ii  ucf   2.0012 Update Configuration File: preserv
ii  zlib1g1:1.2.3-13 compression library - runtime

mldonkey-server recommends no packages.

-- debconf information:
  mldonkey-server/max_hard_download_rate: 0
* mldonkey-server/launch_at_startup: false
  mldonkey-server/config_exist_no_options:
  mldonkey-server/plugin: Directconnect, Opennap, Overnet, Soulseek, Bittorent, 
Gnutella
  mldonkey-server/mldonkey_group: mldonkey
  mldonkey-server/false_password:
  mldonkey-server/max_hard_upload_rate: 0
  mldonkey-server/max_alive: 48
  mldonkey-server/run_as_user: mldonkey
  mldonkey-server/reown_file: false
  mldonkey-server/mldonkey_niceness:
  mldonkey-server/config_exist_no_dir:
  mldonkey-server/fasttrack_problem:
  mldonkey-server/shared_directories: share
  mldonkey-server/mldonkey_dir: /var/lib/mldonkey
  mldonkey-server/client_name: zombie
  mldonkey-server/mldonkey_move: false
  mldonkey-server/mldonkey_umask: 0022


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]