Bug#992721: hplip: Scanning with Deskjet 3050A J611 crash

2021-09-15 Thread Bernhard Übelacker 

Hello Florence, dear Maintainer,

  
  Stack trace of thread 113079:

  #0  0x7f858b12ae71 raise 
(libc.so.6 + 0x3ce71)
  #1  0x7f858b114536 abort 
(libc.so.6 + 0x26536)
  #2  0x7f858b16c2b8 n/a 
(libc.so.6 + 0x7e2b8)
  #3  0x7f858b1fad42 
__fortify_fail (libc.so.6 + 0x10cd42)
  #4  0x7f858b1fad20 
__stack_chk_fail (libc.so.6 + 0x10cd20)
  #5  0x7f857c763146 
get_size (libsane-hpaio.so.1 + 0x14146)
  #6  0x n/a 
(n/a + 0x0)



Thanks for the fast response.
From looking at this stack trace I assume a stack variable in
function "get_size" gets overwritten. At the end of this function
the stack check gets triggered.

From looking at [1] I _think_ the issue might be with the
variable "char buffer[7]".
It looks like this buffer gets some hexadecimal size
information written to from a http connection.

Therefore my hypothesis is that either this "size" exceeds what
is with these 7 places possible (would be 268 MB ?),
or some unexpected input is read from the connection and
therefore the loop is not left before the buffer is overrun.

One easy thing might be to test if the resolution could be
changed to some lower value in the hope to get this "size" to
a lower value, does the scan then succeed ?

Kind regards,
Bernhard



[1] 
https://sources.debian.org/src/hplip/3.21.6+dfsg0-1/scan/sane/bb_ledm.c/#L1086
1084
1085int get_size(struct ledm_session* ps)
1086{
1087  struct bb_ledm_session *pbb = ps->bb_session;
1088  char buffer[7];
1089  int i=0, tmo=50, len;
1090
1091  if(ps->currentResolution >= 1200) tmo *= 5;
1092
1093  while(1)
1094  {
1095if(http_read_size(pbb->http_handle, buffer+i, 1, tmo, &len) == 
2) return 0;
1096if( i && *(buffer+i) == '\n' && *(buffer+i-1) == '\r') break;
1097i++;
1098  }
1099  *(buffer+i+1)='\0';
1100  return strtol(buffer, NULL, 16);
1101}
1102

[2] https://sources.debian.org/src/hplip/3.21.6+dfsg0-1/scan/sane/http.c/#L513

# Bullseye/stable amd64 qemu VM 2021-09-15


echo "set enable-bracketed-paste off" >> /etc/inputrc; bash


apt update
apt dist-upgrade

apt install mc gdb simple-scan hplip
apt install simple-scan-dbgsym libsane-hpaio-dbgsym
apt build-dep libsane-hpaio



mkdir /home/benutzer/source/libsane-hpaio/orig -p
cd/home/benutzer/source/libsane-hpaio/orig
apt source libsane-hpaio
cd






benutzer@debian:~$ gdb -q
(gdb) set width 0
(gdb) set pagination off
(gdb) file /usr/bin/simple-scan
Reading symbols from /usr/bin/simple-scan...
Reading symbols from 
/usr/lib/debug/.build-id/31/8e835860dafff5fa45c03cb758e8cae5a11fa0.debug...
(gdb) tb main
Temporary breakpoint 1 at 0xe160: file src/simple-scan.p/simple-scan.c, line 
2434.
(gdb) run
Starting program: /usr/bin/simple-scan 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Temporary breakpoint 1, main (argc=1, argv=0x7fffe618) at 
src/simple-scan.p/simple-scan.c:2434
2434src/simple-scan.p/simple-scan.c: Datei oder Verzeichnis nicht gefunden.
(gdb) call dlopen("/usr/lib/x86_64-linux-gnu/sane/libsane-hpaio.so.1",0x102)
$1 = (void *) 0x555da300
(gdb) b get_size
Breakpoint 2 at 0x73618080: file scan/sane/bb_ledm.c, line 1086.
(gdb) disassemble get_size,get_size+200
Dump of assembler code from 0x73618080 to 0x73618148:
   0x73618080 : push   %r15
   0x73618082 : push   %r14
   0x73618084 : push   %r13
   0x73618086 : push   %r12
   0x73618088 : mov$0x32,%r12d
   0x7361808e :push   %rbp
   0x7361808f :push   %rbx
   0x73618090 :sub$0x28,%rsp
   0x73618094 :mov0x89b0(%rdi),%r15
   0x7361809b :mov%fs:0x28,%rax
   0x736180a4 :mov%rax,0x18(%rsp)
   0x736180a9 :xor%eax,%eax
   0x736180ab :lea0x11(%rsp),%r13
   0x736180b0 :mov$0xfa,%eax
   0x736180b5 :cmpl   $0x4b0,0x744(%rdi)
   0x736180bf :cmovge %eax,%r12d
   0x736180c3 :mov%r13,%rbx
   0x736180c6 :lea0xc(%rsp),%r14
   0x736180cb :xor%ebp,%ebp
   0x736180cd :jmp0x736180d8 
   0x736180cf :nop
   0x736180d0 :add$0x1,%rbp
   0x736180d4 :add$0x1,%rbx
   0x736180d8 :mov0x1f0(%r15),%rdi
   0x736180df :mov%r14,%r8
   0x00

Bug#992721: hplip: Scanning with Deskjet 3050A J611 crash

2021-09-15 Thread Florence Birée 
Hi Bernhard,

Here is the stack trace (scanning with simple-scan):

sept. 15 18:55:47 lyra systemd[1]: Created slice Slice /system/systemd-coredump.
sept. 15 18:55:47 lyra systemd[1]: Started Process Core Dump (PID 113128/UID 0).
sept. 15 18:55:48 lyra systemd-coredump[113129]: [🡕] Process 113052 
(simple-scan) of user 1000 dumped core.
 
 Stack trace of thread 113079:
 #0  0x7f858b12ae71 raise 
(libc.so.6 + 0x3ce71)
 #1  0x7f858b114536 abort 
(libc.so.6 + 0x26536)
 #2  0x7f858b16c2b8 n/a 
(libc.so.6 + 0x7e2b8)
 #3  0x7f858b1fad42 
__fortify_fail (libc.so.6 + 0x10cd42)
 #4  0x7f858b1fad20 
__stack_chk_fail (libc.so.6 + 0x10cd20)
 #5  0x7f857c763146 
get_size (libsane-hpaio.so.1 + 0x14146)
 #6  0x n/a 
(n/a + 0x0)
sept. 15 18:55:48 lyra systemd[1]: systemd-coredump@0-113128-0.service:
Succeeded.

I hope it will be useful!

Cheers,
Florence

Le Mon, 13 Sep 2021 18:11:40 +0200,
Bernhard Übelacker  a écrit :

> Hello Florence,
> there might be still something that could be done
> to retrieve some more information (if you have still
> the versions installed that show the issue).
> 
> The easiest first thing might be to install the package
> systemd-coredump, if possible.
> 
> Then open in another terminal 'journalctl -f'.
> 
> And reproduce one of the "stack smashings".
> 
> Then in the other terminal a "Stack trace" should appear - this
> should point out the library and maybe function where the issue is.
> 
> Kind regards,
> Bernhard



-- 
Florence Birée (elle)
06 52 92 15 32

En ces temps d'état policier, ne les laissons pas lire nos mails,
chiffrons-les ! https://emailselfdefense.fsf.org/fr/index.html


pgpVSCXc5R4fJ.pgp
Description: Signature digitale OpenPGP

Processed: Re: cups: uses sides=one-sided by default

2021-09-15 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> found 994395 2.3.3op2-7
Bug #994395 [cups] cups: uses sides=one-sided by default
Marked as found in versions cups/2.3.3op2-7.
>
End of message, stopping processing here.

Please contact me if you need assistance.
-- 
994395: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994395
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#994395: cups: uses sides=one-sided by default

2021-09-15 Thread Vincent Lefevre 
Package: cups
Version: 2.3.3op2-3+deb11u1
Severity: important

On my Debian machine, files are printed one sided, even though I use
Duplex=DuplexNoTumble in my .cups/lpoptions file. I suppose that this
is due to the following issue.

cventin:~> lpoptions -p print-1
ColorModel=Gray copies=1 device-uri=ipps://print-1.lip.ens-lyon.fr:443 
Duplex=DuplexNoTumble finishings=3 job-cancel-after=10800 
job-hold-until=no-hold job-priority=50 job-sheets=none,none 
marker-change-time=1631710524 
marker-colors=#00,#FF00FF,#00,#00,none 
marker-high-levels=100,100,100,100,95 marker-levels=25,31,30,72,0 
marker-low-levels=5,5,5,5,0 marker-names='Cyan\ TK-8335C,Magenta\ 
TK-8335M,Yellow\ TK-8335Y,Black\ TK-8335K,Waste\ Toner\ Box' 
marker-types=toner,toner,toner,toner,waste-toner media=iso_a4_210x297mm 
number-up=1 output-bin=tray-1 print-color-mode=color printer-commands=none 
printer-info='print-1 (Kyocera TASKalfa 3253ci)' printer-is-accepting-jobs=true 
printer-is-shared=true printer-is-temporary=false printer-location='Bocal 
(left)' printer-make-and-model='3253ci - IPP Everywhere' printer-state=3 
printer-state-change-time=1631710539 printer-state-reasons=none 
printer-type=45180 printer-uri-supported=ipp://localhost/printers/print-1 
sides=one-sided

See the "sides=one-sided" at the end, which doesn't come from
my config, where .cups/lpoptions contains:

Default print-1 ColorModel=Gray Duplex=DuplexNoTumble

Ditto with cups 2.3.3op2-7.

Note that I had added this printer with:

# lpadmin -p print-1 -v ipps://print-1.lip.ens-lyon.fr:443 -E -m everywhere \
-L "Bocal (left)"

On a Debian 10 (buster) machine, with the same .cups/lpoptions:

patate:~> lpoptions
ColorModel=Gray copies=1 device-uri=ipps://print-1.lip.ens-lyon.fr:443 
Duplex=DuplexNoTumble finishings=3 job-cancel-after=10800 
job-hold-until=no-hold job-priority=50 job-sheets=none,none 
marker-change-time=1631709869 
marker-colors=#00,#FF00FF,#00,#00,none 
marker-high-levels=100,100,100,100,95 marker-levels=25,31,30,72,0 
marker-low-levels=5,5,5,5,0 marker-names='Cyan\ TK-8335C,Magenta\ 
TK-8335M,Yellow\ TK-8335Y,Black\ TK-8335K,Waste\ Toner\ Box' 
marker-types=toner,toner,toner,toner,waste-toner number-up=1 
printer-commands=none printer-info='print-1 (Kyocera TASKalfa 3253ci)' 
printer-is-accepting-jobs=true printer-is-shared=true 
printer-is-temporary=false printer-location='Le Bocal, on the left GN1.347' 
printer-make-and-model='3253ci - IPP Everywhere' printer-state=3 
printer-state-change-time=1631709892 printer-state-reasons=none 
printer-type=12412 printer-uri-supported=ipp://localhost/printers/print-1

i.e. without "sides=one-sided", which is OK.

So there has been some regression in recent cups versions.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-security'), (500, 
'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-8-amd64 (SMP w/12 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=POSIX, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages cups depends on:
ii  cups-client2.3.3op2-3+deb11u1
ii  cups-common2.3.3op2-3+deb11u1
ii  cups-core-drivers  2.3.3op2-3+deb11u1
ii  cups-daemon2.3.3op2-3+deb11u1
ii  cups-filters   1.28.10-2
ii  cups-ppdc  2.3.3op2-3+deb11u1
ii  cups-server-common 2.3.3op2-3+deb11u1
ii  debconf [debconf-2.0]  1.5.77
ii  ghostscript9.53.3~dfsg-8
ii  libavahi-client3   0.8-5
ii  libavahi-common3   0.8-5
ii  libc6  2.32-2
ii  libcups2   2.3.3op2-3+deb11u1
ii  libgcc-s1  11.2.0-5
ii  libstdc++6 11.2.0-5
ii  libusb-1.0-0   2:1.0.24-3
ii  poppler-utils  20.09.0-3.1
ii  procps 2:3.3.17-5

Versions of packages cups recommends:
ii  avahi-daemon  0.8-5
ii  colord1.4.5-3

Versions of packages cups suggests:
ii  cups-bsd   2.3.3op2-3+deb11u1
pn  cups-pdf   
pn  foomatic-db-compressed-ppds | foomatic-db  
pn  smbclient  
ii  udev   247.9-1

-- debconf information:
  cupsys/backend: lpd, socket, usb, snmp, dnssd
  cupsys/raw-print: true

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

ghostscript_9.54.0~dfsg-5_source.changes ACCEPTED into unstable

2021-09-15 Thread Debian FTP Masters 



Accepted:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Wed, 15 Sep 2021 14:04:05 +0200
Source: ghostscript
Architecture: source
Version: 9.54.0~dfsg-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Team 
Changed-By: Jonas Smedegaard 
Changes:
 ghostscript (9.54.0~dfsg-5) unstable; urgency=medium
 .
   * Revert to not mark /usr/share/ghostscript/* as not-installed:
 works but a clumsy approach
   * properly fix tracking installed files
 by expanding upstream ABI  in debhelper snippets
 (passing ABI-specific path dh_install options confuses dh_missing);
 thanks to Roderich Schupp (see bug#994270)
   * update symbols:
 + 20 private symbols added
 + 1 private symbol dropped
Checksums-Sha1:
 a6afdef7f4047a9f555f089a95711e18542bca76 2692 ghostscript_9.54.0~dfsg-5.dsc
 e486e48957b0f534d6e7d5efc5483a01450f3188 120320 
ghostscript_9.54.0~dfsg-5.debian.tar.xz
 3d66417ce9db26c95fe0e9083fec66f260e0217f 1 
ghostscript_9.54.0~dfsg-5_amd64.buildinfo
Checksums-Sha256:
 643dd3cd50db8a1130cda4d3c054176117067582f2ff467988188765e91b3f3d 2692 
ghostscript_9.54.0~dfsg-5.dsc
 702530ad69c10e5e8875d00078e64373ca7781b91c94d95050abe6b9f7bcf2f7 120320 
ghostscript_9.54.0~dfsg-5.debian.tar.xz
 d06885b275236f8b49b0480d3d651545008694bc11c7917db2b5f39117fbfe7b 1 
ghostscript_9.54.0~dfsg-5_amd64.buildinfo
Files:
 3a9b8e62903cb1b4fc16203e909a7edc 2692 text optional 
ghostscript_9.54.0~dfsg-5.dsc
 9a658cd789d40cd53a652f55d996a390 120320 text optional 
ghostscript_9.54.0~dfsg-5.debian.tar.xz
 1f338908311f4296ee9b84a34b3d6a00 1 text optional 
ghostscript_9.54.0~dfsg-5_amd64.buildinfo

-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAmFB4xIACgkQLHwxRsGg
ASEi5A/+NiVwqOmMRTk8HYiM4uZk00ZrOsqcldfBTqQhXbgTXk7RqPhZmBvknbT8
LALFA+1OqAVYlPhmgxlC8ac5HI227pFw/LWk8TYdi9HBaRWr4mVDj/om19oOUM5P
nZWF/vJRwHj8t20Dyfm4pTYgCRO2dIB9uJuXJpNU8wA9zRW6XNUuAc0zLfQCUNNO
TDiV0CU5RF5gsOF0r4KpxBUeej0itLJH5UN7GyOKakDv3HH0VzWj33u2MdUjoDPN
oXL+Pfa8g30mzQjw+kqSWeiju8WNHSl5OOxqqI988kRPMwVM/EGz6pHlz87YKFg7
oKVkS7Xb4ytR8h+tKHaDLTgxvMVVeHyFYwEMUFUk3X2HYk7yOGW3o1iBvkZ0OXOE
7A10LD7P35MYbna4KQuvCYkTEpjhhQq9sJsrh6oE+iQduegwfwz6xRIEXPQCaor0
aLHnvJCq7NxyCwSa8NCFbYnmT/vddI6dT5/2RCyIXeCE8AXd+qBzRrfTlXe2ApMO
r+JnmenzUyrr/2ZQFDF5bqkq7hyShq9gFrgt9IX5z/cPQRE574252xxyL8shUGoX
o7W6334BDT7sMhlwgG68rmnozDPVA8/qP3lQG701Pc5ne9THV/D2KmfeJ92ITfA6
KhAVxwYwFaK151oKcKLeXeGgWblINYdv22hVNN69TVGUhfEx8j0=
=yVz6
-END PGP SIGNATURE-


Thank you for your contribution to Debian.

Processing of ghostscript_9.54.0~dfsg-5_source.changes

2021-09-15 Thread Debian FTP Masters 
ghostscript_9.54.0~dfsg-5_source.changes uploaded successfully to localhost
along with the files:
  ghostscript_9.54.0~dfsg-5.dsc
  ghostscript_9.54.0~dfsg-5.debian.tar.xz
  ghostscript_9.54.0~dfsg-5_amd64.buildinfo

Greetings,

Your Debian queue daemon (running on host usper.debian.org)

Bug#992030: marked as done (ghostscript: ps2epsi does not find ps2epsi.ps any more)

2021-09-15 Thread Debian Bug Tracking System 
Your message dated Wed, 15 Sep 2021 14:07:30 +0200
with message-id <163170765087.685922.12583903273732444...@auryn.jones.dk>
and subject line Re: Bug#992030: ghostscript: ps2epsi does not find ps2epsi.ps 
any more
has caused the Debian Bug report #992030,
regarding ghostscript: ps2epsi does not find ps2epsi.ps any more
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
992030: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992030
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: ghostscript
Version: 9.53.3~dfsg-7
Severity: normal

Dear Maintainer,

In bullseye, the ps2epsi script appears broken.  ps2epsi something.ps
invariably ends in

  Error: /undefinedfilename in (/usr/bin/ps2epsi.ps)

(and a ghostscript stack dump).

Looking into the script, this doesn't seem surprising, given it explicitly
says

# Note, we expect 'ps2epsi.ps' to be in the same directory as 'ps2epsi'

Indeed, replacing the "$LIBDIR/ps2epsi.ps" in the next line with
/usr/share/ghostscript/9.53.3/lib/ps2epsi.ps restores functionality.
Well...  thinking again: just removing the "$LIBDIR/" and relying on
ghostscript's search path is fine, too.



-- System Information:
Debian Release: 11.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: i386 (x86_64)

Kernel: Linux 5.13.4-dirty (SMP w/4 CPU threads)
Kernel taint flags: TAINT_USER, TAINT_OOT_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)

Versions of packages ghostscript depends on:
ii  libc6   2.31-13
ii  libgs9  9.53.3~dfsg-7

ghostscript recommends no packages.

Versions of packages ghostscript suggests:
ii  ghostscript-x  9.53.3~dfsg-7

-- no debconf information
--- End Message ---
--- Begin Message ---
Version: 9.54.0~dfsg-1

Quoting Markus Demleitner (2021-08-09 14:36:54)
> In bullseye, the ps2epsi script appears broken.  ps2epsi something.ps
> invariably ends in
> 
>   Error: /undefinedfilename in (/usr/bin/ps2epsi.ps)
> 
> (and a ghostscript stack dump).

This was fixed upstream since release 9.54.0.

Thanks for reporting!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature
--- End Message ---

Bug#994270: another possible fix

2021-09-15 Thread Jonas Smedegaard 
Quoting Roderich Schupp (2021-09-15 12:22:55)
> > mark /usr/share/ghostscript/* as not-installed,
> > which is clearly bogus but seems the only (simple) way
> > to ignore only for arch-dependent builds;
> 
> 
> Another way to fix this is to use ${env:GS_DOT_VERSION} in 
> libgs9-common.install
> (since you're already using debhelper-compat 13), see patch below.
> Note that dh_install for libgs9-common - even for a build=any - generates a 
> file
> debian/.debhelper/generated/libgs9-common/installed-by-dh_install, but it only
> contains stuff gleaned from libgs9-common.install, not the explicit
> arguments given to dh_install.
> This is probably a debhelper bug.

Thanks, Roderich - that is indeed a more elegant approach!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature

Bug#994270: another possible fix

2021-09-15 Thread Roderich Schupp 
> mark /usr/share/ghostscript/* as not-installed,
> which is clearly bogus but seems the only (simple) way
> to ignore only for arch-dependent builds;


Another way to fix this is to use ${env:GS_DOT_VERSION} in libgs9-common.install
(since you're already using debhelper-compat 13), see patch below.
Note that dh_install for libgs9-common - even for a build=any - generates a file
debian/.debhelper/generated/libgs9-common/installed-by-dh_install, but it only
contains stuff gleaned from libgs9-common.install, not the explicit
arguments given to dh_install.
This is probably a debhelper bug.

Cheers, Roderich
diff --git a/debian/libgs9-common.install b/debian/libgs9-common.install
index 57913aa6..ce26d655 100644
--- a/debian/libgs9-common.install
+++ b/debian/libgs9-common.install
@@ -1 +1,2 @@
 usr/share/color/icc/
+usr/share/ghostscript/${env:GS_DOT_VERSION}/
diff --git a/debian/rules b/debian/rules
index 6403518f..b6c50e03 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,8 @@
 #!/usr/bin/make -f
 
 include base/version.mak
+# so that we can refer to it debian/libs9-common.install
+export GS_DOT_VERSION
 
 include /usr/share/dpkg/pkg-info.mk
 
@@ -90,9 +92,7 @@ override_dh_install:
 	mv debian/tmp/usr/share/ghostscript/$(GS_DOT_VERSION)/iccprofiles \
 		debian/tmp/usr/share/color/icc/ghostscript
 
-	dh_install --package=$(pkg-data) $(DEB_DH_INSTALL_ARGS_ALL) \
-		usr/share/ghostscript/$(GS_DOT_VERSION)/
-	dh_install --no-package=$(pkg-data) $(DEB_DH_INSTALL_ARGS_ALL)
+	dh_install $(DEB_DH_INSTALL_ARGS_ALL)
 
 	dh_link --package=$(pkg-data) -- $(DEB_DH_LINK_$(pkg-data))
 	dh_link --no-package=$(pkg-data)