RFS: dparser-1.16-1 [ITP] -- a scannerless GLR parser generator

[Markus Wanner]

Package: sponsorship-requests
Severity: wishlist

Dear mentors, dear python gurus,

I am looking for a sponsor for my package dparser

 * Package name: dparser
   Version : 1.26-1
   Upstream Author : John Bradley Plevyak jplev...@acm.org
 * URL : http://dparser.sourceforge.net/
 * License : mostly BSD-3-clause, one file GPL
   Section : devel
   Programming Lang: C and Python


It builds those binary packages:

 dparser - scannerless GLR parser generator
 dparser-doc - documentation for dparser
 python-dparser - Python bindings for dparser

To access further information about this package, please visit the
following URL. It took me some attempts to get lintian clean, so please
only look at the top-most, most recent version

  http://mentors.debian.net/package/dparser

Alternatively, one can download the package with dget using this command:

  dget -x
http://mentors.debian.net/debian/pool/main/d/dparser/dparser_1.26-1.dsc


There has been some discussion about the long description of the package
already, see the ITP bug #668556.

I'd especially appreciate review and comments about the python module
that comes with it.

Regards

Markus Wanner


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f8bb210.2070...@bluegap.ch

Re: RFS: python3-dateutil

[Jakub Wilk]

The extended description is supposed to make sense even when it's 
displayed alone, without the synposis. So it certainly cannot start with 
“It features:”.


See also:
* Debian Policy §3.4.2
* Developer's Reference §6.2.3

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120416203017.ga5...@jwilk.net

Re: RFS: dparser-1.16-1 [ITP] -- a scannerless GLR parser generator

[Jakub Wilk]

Please use X-Debbugs-Cc instead of regular Cc when filing bugs:
http://www.debian.org/Bugs/Reporting#xcc
Thanks!

I don't intend to sponsor this package, but here's my review:

* Markus Wanner mar...@bluegap.ch, 2012-04-16, 07:45:

http://mentors.debian.net/debian/pool/main/d/dparser/dparser_1.26-1.dsc


base-makefile-fixes.patch removes this line:
LIBS += -lm
But this is explained neither in the patch description nor in the 
changelog.


The fix-python-makefile patch will break if Python version is longer 
than 3 characters. (I know, unlikely, but it still bothers me. ;P) You 
could query distutils directly for the build directory using the 
following code:


python -c 'from distutils.command.build import build; from distutils.core 
import Distribution; b = build(Distribution()); b.finalize_options(); print 
b.build_platlib'

More importantly, the fix-python-makefile patch violates Policy §4.6.

Oh, and please don't add commented-out code, thanks.

Have you forwarded the manpage-hyphen-correction patch upstream?

Why priority extra? I'd use optional.

I'd rather not use ${python:Provides}. See: 
http://lists.debian.org/20110324164804.ga5...@jwilk.net


In debian/copyright, you need to either add newlines (escaped by dots) 
between list items or indent the whole list by an extra space. (License 
uses the same rules as Description in debian/control; see Policy §5.6.13 
for details.)


Please honour DEB_BUILD_OPTIONS=nocheck.

Please honour DEB_BUILD_OPTIONS=noopt.

This part of upstream makefile:

ifeq ($(ARCH),x86_64)
  CFLAGS += -fPIC
endif

smells like a violation of Policy §10.2.

The package fails to build in a minimal environment:

python2.6 setup.py build
make[2]: python2.6: Command not found
make[2]: *** [all] Error 127

I see lots of
make[3]: svnversion: Command not found
in the build log. Is that intentional?

What is debian/dparser-doc.install for?

Version declared in setup.py is 1.9. Shouldn't that be 1.26?

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120416213550.ga7...@jwilk.net