Re: Re: Request for joining DPMT
Hi Jakub,
many thanks for your thorough review of the package.
Distribution in the changelog should be experimental, not unstable (as
the package cannot be currently built within unstable).
Missing ")" in the changelog.
Pet peeve: I'd use "debhelper (>= 8)" instead of "debhelper (>= 8.0.0)".
Typo in debian/control: Pytho2 -> "Python2".
What's up with debian/rules.working? :)
You declare "X-Python3-Version: >= 3.0", but this:
return "File('{}')".format(self.path)
requires Python 3.1 or later. (Admittedly it doesn't matter at all in
practice, because Python 3.0 has been never in Debian.)
debian/copyright says "License: GPL-3+", but the following text
doesn't anything about later versions... So is it version 3 only? The
binary package names should be: python-taglib, python3-taglib. See
Python Policy §2.2 for details.
Up to here It was easy ...
Please make sure that the .cpp file is rebuilt from source.
ok, thanks for this hint - because of that I noticed that actually the
pyx- and pxd-sources did not get included into the source tarball by
`setup.py sdist` for whatever reason. I fixed this and put a "rm
src/taglib.cpp" in debian/rules and an "extend-diff-ignore"-line for
taglib.cpp in debian/source/options.
The package FTBFS here:
| + python3.2 setup.py install --install-layout=deb --root=debian/tmp
| Traceback (most recent call last):
| File "setup.py", line 12, in
| from setuptools import setup
| ImportError: No module named setuptools
It still FTBFS even when I added python3-setuptools to Build-Depends:
| + python3.2 setup.py install --install-layout=deb --root=debian/tmp
| Traceback (most recent call last):
| File "setup.py", line 36, in
| long_description=readme(),
| File "setup.py", line 30, in readme
| return rm.read()
| File "/usr/lib/python3.2/encodings/ascii.py", line 26, in decode
| return codecs.ascii_decode(input, self.errors)[0]
| UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 9:
ordinal not in range(128)
After I worked around all the build problem, I installed
python-pytaglib and all its dependencies. Unfortunately, it didn't start:
| $ pyprinttags
| Traceback (most recent call last):
| File "/usr/bin/pyprinttags", line 5, in
| from pkg_resources import load_entry_point
| ImportError: No module named pkg_resources
So I installed python-pkg-resources, and then I got:
| $ pyprinttags
| Traceback (most recent call last):
| File "/usr/bin/pyprinttags", line 5, in
| from pkg_resources import load_entry_point
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2711, in
| parse_requirements(__requires__), Environment()
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 584, in
resolve
| raise DistributionNotFound(req)
| pkg_resources.DistributionNotFound: cython>=0.16
Wait, why is Cython needed at runtime at all?! But upgrading Cython to
0.17 didn't make it work either:
| $ pyprinttags
| Traceback (most recent call last):
| File "/usr/bin/pyprinttags", line 9, in
| load_entry_point('pytaglib==0.3.2', 'console_scripts', 'pyprinttags')()
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 337, in
load_entry_point
| return get_distribution(dist).load_entry_point(group, name)
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2279, in
load_entry_point
| return ep.load()
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 1989, in load
| entry = __import__(self.module_name, globals(),globals(), ['__name__'])
| ImportError: No module named pyprinttags
Now I'm at a loss. :)
Sorry, the pyprinttags module was also missing in the installed files.
This is fixed upstream now.
Additionally, I have renamed pyprinttags to pyprinttags3 for the python3
version. I hacked something into debian/rules to also rename the man
page for that package; please let me know if there's a better way to
achieve that.
I have uploaded the new version 0.3.3 to mentors, hopefully it will show
up there soon.
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50f71a7b.4080...@mathematik.uni-kl.de
Re: Re: Request for joining DPMT
Hi Jakub,
many thanks for your thorough review of the package.
Distribution in the changelog should be experimental, not unstable (as
the package cannot be currently built within unstable).
Missing ")" in the changelog.
Pet peeve: I'd use "debhelper (>= 8)" instead of "debhelper (>= 8.0.0)".
Typo in debian/control: Pytho2 -> "Python2".
What's up with debian/rules.working?
You declare "X-Python3-Version: >= 3.0", but this:
return "File('{}')".format(self.path)
requires Python 3.1 or later. (Admittedly it doesn't matter at all in
practice, because Python 3.0 has been never in Debian.)
debian/copyright says "License: GPL-3+", but the following text
doesn't anything about later versions... So is it version 3 only? The
binary package names should be: python-taglib, python3-taglib. See
Python Policy §2.2 for details.
Up to here It was easy ...
Please make sure that the .cpp file is rebuilt from source.
ok, thanks for this hint - because of that I noticed that actually the
pyx- and pxd-sources did not get included into the source tarball by
`setup.py sdist` for whatever reason. I fixed this and put a "rm
src/taglib.cpp" in debian/rules and an "extend-diff-ignore"-line for
taglib.cpp in debian/source/options.
The package FTBFS here:
| + python3.2 setup.py install --install-layout=deb --root=debian/tmp
| Traceback (most recent call last):
| File "setup.py", line 12, in
| from setuptools import setup
| ImportError: No module named setuptools
It still FTBFS even when I added python3-setuptools to Build-Depends:
| + python3.2 setup.py install --install-layout=deb --root=debian/tmp
| Traceback (most recent call last):
| File "setup.py", line 36, in
| long_description=readme(),
| File "setup.py", line 30, in readme
| return rm.read()
| File "/usr/lib/python3.2/encodings/ascii.py", line 26, in decode
| return codecs.ascii_decode(input, self.errors)[0]
| UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position
9: ordinal not in range(128)
After I worked around all the build problem, I installed
python-pytaglib and all its dependencies. Unfortunately, it didn't start:
| $ pyprinttags
| Traceback (most recent call last):
| File "/usr/bin/pyprinttags", line 5, in
| from pkg_resources import load_entry_point
| ImportError: No module named pkg_resources
So I installed python-pkg-resources, and then I got:
| $ pyprinttags
| Traceback (most recent call last):
| File "/usr/bin/pyprinttags", line 5, in
| from pkg_resources import load_entry_point
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line
2711, in
| parse_requirements(__requires__), Environment()
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line
584, in resolve
| raise DistributionNotFound(req)
| pkg_resources.DistributionNotFound: cython>=0.16
Wait, why is Cython needed at runtime at all?! But upgrading Cython to
0.17 didn't make it work either:
| $ pyprinttags
| Traceback (most recent call last):
| File "/usr/bin/pyprinttags", line 9, in
| load_entry_point('pytaglib==0.3.2', 'console_scripts',
'pyprinttags')()
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line
337, in load_entry_point
| return get_distribution(dist).load_entry_point(group, name)
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line
2279, in load_entry_point
| return ep.load()
| File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line
1989, in load
| entry = __import__(self.module_name, globals(),globals(),
['__name__'])
| ImportError: No module named pyprinttags
Now I'm at a loss.
Sorry, the pyprinttags module was also missing in the installed files.
This is fixed upstream now. I have also added dependencies for the
pkg-resources.
Additionally, I have renamed pyprinttags to pyprinttags3 for the python3
version. I hacked something into debian/rules to also rename the man
page for that package; please let me know if there's a better way to
achieve that.
I have uploaded the new version 0.3.4 to mentors, hopefully it will show
up there soon.
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50f71e8e.3060...@posteo.de
