Re: Code review for grammalecte

2021-05-25 Thread Louis-Philippe Véronneau
Hello!

This is quite a large package, so instead of continuing to spam the IRC
channel, here are my comments.

1. These files are licensed under the MPL2

* darg.py
* gc_core/py/oxt/Grammalecte.py
* gc_core/py/oxt/Options.py
* gc_lang/fr/build_data.py
* gc_lang/fr/dictionnaire/genfrdic.py
* gc_lang/fr/dictionnaire/_templates/ooo/DictionarySwitcher.py
* gc_lang/fr/oxt/AppLauncher.py
* gc_lang/fr/oxt/Graphspell.py
* gc_lang/fr/oxt/About/About.py
* gc_lang/fr/oxt/ChangeAuthor/Author.py
* gc_lang/fr/oxt/ContextMenu/ContextMenu.py
* gc_lang/fr/oxt/DictOptions/DictOptions.py
* gc_lang/fr/oxt/DictOptions/LexiconEditor.py
* gc_lang/fr/oxt/DictOptions/SearchWords.py
* gc_lang/fr/oxt/DictOptions/TagsInfo.py
* gc_lang/fr/oxt/GraphicOptions/GraphicOptions.py
* gc_lang/fr/oxt/Lexicographer/Enumerator.py
* gc_lang/fr/oxt/TextFormatter/TextFormatterEditor.py
* gc_lang/fr/oxt/TextFormatter/TextFormatter.py
* graphspell/dawg.py
* graphspell/progressbar.py
* graphspell-js/dawg.js

To me, this is a sign you haven't read the code

Although it can be long and tiresome (and trust me, I know, I've just
read the entire codebase :P), it's an important step in packaging
something in Debian. When updating a package, you should also go through
the diff.

2. There should be an entry in d/copyright for
gc_lang/fr/dictionnaire/metaphone2.py

3. gc_lang/fr/nodejs/cli/lib/minimist.js seems to be a vendored copy of
a version of node-minimist. If you need it, you should use the debian
package. If not, it should be excluded.

That's pretty much it! Fix those issues and I'll be happy to upload to
experimental.

Cheers,

-- 
  ⢀⣴⠾⠻⢶⣦⠀
  ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
  ⢿⡄⠘⠷⠚⠋   po...@debian.org / veronneau.org
  ⠈⠳⣄



OpenPGP_signature
Description: OpenPGP digital signature


Re: Joining the Python Team

2021-05-25 Thread Stefano Rivera
Hi Kyle (2021.05.25_09:11:25_+)
> I wish to join to the Python team to maintain openswitcher [1] and jack
> mixer [2].
> 
> [1] #988182
> [2] https://rdio.space/jackmixer/
> 
> My salsa login is paddatrapper.
> 
> I have read the Debian Team Policy and accept it.

Added, welcome.

SR

-- 
Stefano Rivera
  http://tumbleweed.org.za/
  +1 415 683 3272



Re: joining the team

2021-05-25 Thread Stefano Rivera
Hi Salman (2021.05.24_10:55:23_+)
> I would like to join the team and help maintaining *prospector* package
> which has been removed from Stable and Testing but is still in Sid in a
> broken state.

Added, welcome.

SR

-- 
Stefano Rivera
  http://tumbleweed.org.za/
  +1 415 683 3272



Joining the Python Team

2021-05-25 Thread Kyle Robbertze

Hi,

I wish to join to the Python team to maintain openswitcher [1] and jack 
mixer [2].


[1] #988182
[2] https://rdio.space/jackmixer/

My salsa login is paddatrapper.

I have read the Debian Team Policy and accept it.

Thanks
Kyle

--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄ https://wiki.debian.org/KyleRobbertze