Re: review for python-ssdpy
On 10/4/22 8:50 AM, Jeroen Ploemen wrote: Thanks, I didn't catch that since I use sbuild instead of pbuilder. I have set the environment variable CI = true which should disable those tests. Unfortunately, it doesn't. The change suggested below does make 'CI=true' take effect, but that still leaves a few failing tests not marked by upstream. Probably easiest to exclude those remaining troublemakers by instructing pybuild to set a pytest option, e.g. PYBUILD_TEST_ARGS = -k 'not ...'. I was going to, but it looks like practically all of the tests require network in some form, so I've just disabled tests altogether. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Re: review for python-ssdpy
Hello, On 10/3/22 08:12, Jeroen Ploemen wrote: * control: missing build-dep on python3-all? Needed to run the testsuite against all supported Python version rather than just the default one. Thanks, added. * watch: regex "(\d\.\d.\d)" is overly specific, could easily miss upstream versions such as a hypothetical "1.5" or "1.4.10". Fixed. Package ftbfs in pbuilder with errors in the testsuite; many of the failing tests are marked by upstream as incompatible with github ci, probably for similar reasons they fail in pbuilder, particularly assumptions regarding the availability and configuration of the network. See log at https://paste.debian.net/hidden/daadfbea/ Thanks, I didn't catch that since I use sbuild instead of pbuilder. I have set the environment variable CI = true which should disable those tests. This and above fixes are pushed to Salsa. -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Re: a review of your bumblebee-status package
Hello, I've read more into versioneer, and it turns out with the way it works you can't simply remove versioneer.py from the source, much less _version.py. Therefore, I'm excluding _version.py in d/copyright, then replacing it with the much smaller PyPI version in d/patches, and not touching versioneer.py at all, since with the way versioneer works it's technically not vendoring. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Re: a review of your bumblebee-status package
Here's another note: On 6/6/22 10:49 AM, Antoine Beaupré wrote: > * i'm really not sure I like that C binary to fetch the keyboard >layout... surely there must be a more pythonic way of doing this? i >guess there's another layout-xkb module that does the right thing, >but it seems odd to have both there.. This is apparently an issue that upstream already knows about (https://github.com/tobi-wan-kenobi/bumblebee-status/issues/790) but hasn't done anything about for a year. The fact that there shouldn't be a C binary here at all has just now been reported by me: https://github.com/tobi-wan-kenobi/bumblebee-status/issues/883 -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Re: a review of your bumblebee-status package
Hello Antoine, I am aware of this failure and have reported it upstream. For now, I'll disable the offending test. After doing that, I discovered that almost all of the tests are faulty (at least on Python 3.10), so I've disabled tests altogether for now. Does the package *work* at all in 3.10? We might not want to silence real errors here... Upstream says 3.4-3.9 is supported, but I don't know if that's because 3.10 doesn't work or because they haven't bothered to add it. Searching their bug tracker, I wasn't able to find any 3.10-related issues yet. I also haven't tried to use the program with Python 3.10, because I don't use it myself at all (packaging this for a friend). _version.py is not a copy of versioneer, it's *generated* by versioneer. However, there is versioneer.py in the root directory, which is. I'll exclude that from the source and repack. hmm... how about that generated file though? shouldn't it be ... well, generated at build time instead? :) As far as I understand it, this file is used by the author of the program, not end users. I don't understand it well, though, because I haven't put much time into researching what versioneer even does. If my hunch is correct, I may be able to just remove the file from the source altogether, but I haven't tried that yet. let me know when / if you need me to look at it again, and thanks again! It should be ready for review now, as long as I haven't messed anything up majorly in my attempts to fix the issues you brought to my attention. Thanks again, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Re: a review of your bumblebee-status package
Hello again,
Some corrections to my previous message:
As for how it's installed, I believe that's handled by the upstream setup.py:
data_files=[
("share/bumblebee-status/themes", glob.glob("themes/*.json")),
("share/bumblebee-status/themes/icons",
glob.glob("themes/icons/*.json")),
("share/bumblebee-status/utility", glob.glob("bin/*")),
]
Looks like it's put into /something/share/bumblebee-status/utility.
Confirmed that it's /usr/share/bumblebee-status/utility.
* the build fails here, in a fresh Debian unstable qemu image, with:
ERROR tests/core/test_output.py - RuntimeError: unable to find
theme default
I am aware of this failure and have reported it upstream. For now, I'll
disable the offending test.
After doing that, I discovered that almost all of the tests are faulty
(at least on Python 3.10), so I've disabled tests altogether for now.
As far as Debian is concerned, MIT and Expat are the same license > (although
in reality MIT is a term used to describe two slightly
different licenses).
I was corrected by pabs on IRC; Debian does in fact prefer the use of
the terms Expat and X11 to be separate and not to use the term MIT.
I was used to the way the Rust team does things, which uses MIT.
--
Ben Westover
OpenPGP_signature
Description: OpenPGP digital signature
Re: a review of your bumblebee-status package
Bonjour Antoine,
I already discussed this topic with you in IRC, but I'm documenting the
details here for the sake of the mailing list.
* i wonder if bumblebee-status/_version.py belongs there. it's a copy
of the python3-versioneer package that's already in the
archive... could you remove it from the source and make sure we use
the Debian copy instead? at the very least the debian/copyright file
should refer to it...
_version.py is not a copy of versioneer, it's *generated* by versioneer.
However, there is versioneer.py in the root directory, which is. I'll
exclude that from the source and repack.
* i also attach the output of `decopy` which finds a few more things
than you in debian/copyright
* i'm really not sure I like that C binary to fetch the keyboard
layout... surely there must be a more pythonic way of doing this? i
guess there's another layout-xkb module that does the right thing,
but it seems odd to have both there.. you also seem to rebuild it in
debian/rules, but i don't see where it gets installed
I'm just following what was done upstream (except removing a prebuilt
binary in the source that I then rebuild).
As for how it's installed, I believe that's handled by the upstream
setup.py:
data_files=[
("share/bumblebee-status/themes", glob.glob("themes/*.json")),
("share/bumblebee-status/themes/icons",
glob.glob("themes/icons/*.json")),
("share/bumblebee-status/utility", glob.glob("bin/*")),
]
Looks like it's put into /something/share/bumblebee-status/utility.
One flaw I did find is that my package is marked for architecture all,
while in reality it should be marked as any because of this C binary.
* i did a quick read of most of the code in commit
30853fd19110c6e53be35c4bb846ab3a133b51ac and it seems sane. i haven't
reviewed the contrib modules
* the build fails here, in a fresh Debian unstable qemu image, with:
ERROR tests/core/test_output.py - RuntimeError: unable to find theme
default
I am aware of this failure and have reported it upstream. For now, I'll
disable the offending test.
I attach a full build log.
Thanks for working on this package!
a.
anarcat@curie:bumblebee-status$ decopy
Building tree: 56dir [00:00, 2629.63dir/s]
Queueing: 739file [00:00, 1586.90file/s]
Processing: 100%|██| 683/683 [00:10<00:00,
63.52file/s]
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: bumblebee-status
Upstream-Contact: tobi-wan-kenobi
Source: https://github.com/tobi-wan-kenobi/bumblebee-status
Files-Excluded: bin/get-kbd-layout
Comment: Removed x86_64 Linux binary with source available in the same repo
Files: *
Copyright: 2015, Marc Herndon and GPL2
2017, Oscar Svensson
2017, Oscar Svensson (wogscpar) under MIT licence from upower-python
Public Domain
License: Expat or MIT
Files: LICENSE
Copyright: 2016, tobi-wan-kenobi
License: Expat
Files: bumblebee_status/_version.py
License: public-domain
Files: debian/*
Copyright: 2022, Ben Westover
License: MIT
License: Expat
Comment: Add the corresponding license text here
License: MIT
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
License: public-domain
Comment: Add the corresponding license text here
This autogenerated copyright file has some problems. First of all,
LICENSE shouldn't be considered separate from the rest of the source,
since it describes the entire source. Also, as far as Debian is
concerned, MIT and Expat are the same license (although in reality MIT
is a term used to describe two slightly different licenses). The
copyright holder for * is incorrect, I don't know where it got that info
from. It did catch _version.py, which I didn't, so I'll add that.
Merci d'avoir examiné mon paquet,
--
Ben Westover
OpenPGP_signature
Description: OpenPGP digital signature
Joining the team
I sent this message to the mailing list over a month ago and also asked about it on IRC, getting no response from either platform. The Wiki says this is how I join the team, so I'm just sending it again. On 4/23/22 12:32 AM, Ben Westover wrote: > Hello, > > I'd like to join the team, to package a couple modules I use in Debian > that aren't packaged yet. I have read and accept the policy. > > My salsa username is BenTheTechGuy, using this email. > > Thanks, > -- > Ben Westover -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
Joining the team
Hello, I'd like to join the team, to package a couple modules I use in Debian that aren't packaged yet. I have read and accept the policy. My salsa username is BenTheTechGuy, using this email. Thanks, -- Ben Westover OpenPGP_signature Description: OpenPGP digital signature
