Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
Hi Tai,
First of all thanks for the mail, and for the work in the poetry package.
Very
detailed mail, amazing :)
As mentioned Andrey, yes there's a test that failed with py3.10. The
package is
already in NEW, so we need to wait. In spite of this we can work to fix it.
I didn't investigate yet, So feel free to send a patch if you have one :).
For point [2] , call gbp with the b-depends are no longer needed, because
all of them
are already in Debian.
Cheers,
Emmanuel
On Fri, Nov 19, 2021 at 12:36 PM Taihsiang Ho (tai271828)
wrote:
> Hi Andrey,
>
> Thank you for your information. I will have a look at the failure. If
> anyone has been working on this error, it would be appreciated to let me
> know how I can help.
>
> Besides, I found this thread
> https://lists.debian.org/debian-python/2021/11/msg00025.html soon after I
> sent out my previous email. I believe I have followed up the latest process
> and status of poetry packaging for now. My apologies for not checking the
> email threads carefully enough.
>
> -tai
>
> On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin
> wrote:
>
>> On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:
>> > [5] Some of the error messages from latest package source:
>> >
>> > short test summary info
>> >
>> > FAILED
>> tests/inspection/test_info.py::test_info_setup_complex_pep517_error
>> > - ...
>> > 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
>> > -
>> >
>> > 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==
>> > ==
>> > dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
>> > "3.10 3.9" returned exit code 13
>> > make: *** [debian/rules:44: binary] Error 25
>> >
>> > dpkg-buildpackage: error: debian/rules binary subprocess returned exit
>> > status 2
>> Yes, one test fails with 3.10 which isn't unexpected because the package
>> wasn't tested with it.
>>
>> --
>> WBR, wRAR
>>
>
Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
Hi Andrey,
Thank you for your information. I will have a look at the failure. If
anyone has been working on this error, it would be appreciated to let me
know how I can help.
Besides, I found this thread
https://lists.debian.org/debian-python/2021/11/msg00025.html soon after I
sent out my previous email. I believe I have followed up the latest process
and status of poetry packaging for now. My apologies for not checking the
email threads carefully enough.
-tai
On Fri, Nov 19, 2021 at 4:19 PM Andrey Rahmatullin wrote:
> On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:
> > [5] Some of the error messages from latest package source:
> >
> > short test summary info
> >
> > FAILED
> tests/inspection/test_info.py::test_info_setup_complex_pep517_error
> > - ...
> > 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
> > -
> >
> > 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==
> > ==
> > dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
> > "3.10 3.9" returned exit code 13
> > make: *** [debian/rules:44: binary] Error 25
> >
> > dpkg-buildpackage: error: debian/rules binary subprocess returned exit
> > status 2
> Yes, one test fails with 3.10 which isn't unexpected because the package
> wasn't tested with it.
>
> --
> WBR, wRAR
>
Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
On Fri, Nov 19, 2021 at 03:54:48PM +0100, Taihsiang Ho (tai271828) wrote:
> [5] Some of the error messages from latest package source:
>
> short test summary info
>
> FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
> - ...
> 1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
> -
>
> 588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==
> ==
> dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
> "3.10 3.9" returned exit code 13
> make: *** [debian/rules:44: binary] Error 25
>
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit
> status 2
Yes, one test fails with 3.10 which isn't unexpected because the package
wasn't tested with it.
--
WBR, wRAR
signature.asc
Description: PGP signature
Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
Hi Emmanuel,
I failed to build the poetry deb with the latest package source[1] for some
pytest cases[4][5] since I was aware of this thread
https://lists.debian.org/debian-python/2021/06/msg00017.html . Do you
suggest where I should report or record the error messages I found?
By following my build steps[2] I could:
- successfully build the source with the commit "Initial review pass for
python-poetry package"[3]
- fail to build the source with the commit "ignore tests that use tar.gz
file instead of skip them"[4]
- fail to build the latest source[1][5]
Would you mind elaborating a bit more regarding the packaging steps or the
current packaging status? I walked through the mailing list and the latest
update I found is this email
https://lists.debian.org/debian-python/2021/08/msg00025.html thread. It
must be me not following the latest status and missing some necessary
information.
I will try to fix these pytest errors during package building. It would be
much appreciated that you could let me know if you are aware of anything
that I should know for fixing these errors or regarding the packaging
status. Thank you!
[1] git clone g...@salsa.debian.org:python-team/packages/poetry.git
[2] (build environment: ubuntu 20.04 on amd64)
1. Use this script to prepare the build environment
https://gitlab.com/tai271828/tool-box/-/blob/dev/scripts/prepare-deb-build-poetry.sh
2. gbp buildpackage --git-ignore-new --git-builder=sbuild
--extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-cleo_0.8.1-2_all.deb
--extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-httpretty_1.1.4-1_all.deb
--extra-package=/home/ubuntu/build-poetry-deb/DEPENDENCIES/python3-pkginfo_1.4.2-3_all.deb
[3] The source of the commit 92c24884d3d1a67fa5de490520d1baf83dc208bf .
Besides, I performed a quick test of the deb I built by installing it on
Sid and trying some basic commands like "poetry init" and "poetry shell".
The basic function behaviors expectedly.
[4] The source of the commit c20a910ab5ca679a362f762f5c317ca3af0e0989 and
some of the error messages:
short test summary info
===
FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert
['L...
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
- ...
FAILED
tests/masonry/builders/test_editable_builder.py::test_builder_installs_proper_files_for_standard_packages
### 3 failed, 576 passed, 5 skipped, 21 deselected, 15 warnings in 25.73s
short test summary info
FAILED tests/test_factory.py::test_create_poetry - AssertionError: assert
['L...
FAILED
tests/masonry/builders/test_editable_builder.py::test_builder_installs_proper_files_for_standard_packages
2 failed, 577 passed, 5 skipped, 21 deselected, 14 warnings in 24.09s
-
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
"3.10 3.9" returned exit code 13
make: *** [debian/rules:41: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2
[5] Some of the error messages from latest package source:
short test summary info
FAILED tests/inspection/test_info.py::test_info_setup_complex_pep517_error
- ...
1 failed, 587 passed, 5 skipped, 23 deselected, 15 warnings in 22.23s
-
588 passed, 5 skipped, 23 deselected, 14 warnings in 24.06s ==
==
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p
"3.10 3.9" returned exit code 13
make: *** [debian/rules:44: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit
status 2
Kind regards,
Tai
Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
Hello!!! I just push some updates to salsa Here are my comments: > > 1. d/control: > > You haven't set the Python Team either in Maintainer or Uploaders. > > Ready my bad! Also I note that some dependencies that I package for Poetry were uploaded and DPT was not the Maintainer, I'll change those. > - > > 2. d/control: > > If you require specific dependencies, you should make it clear in > d/control. It's the kind of thing that helps a lot if people decide to > backport it. > > Ready > - > > 3. tests/repositories/fixtures > > This directory contains a bunch of tarballs from other projects. I'm not > sure what should be done with this, as I guess they are used in the > testsuite > > My first reflex would be to exclude them from the imported tarball and > disable the tests that require them, but I don't know how much of the > testsuite depends on those tarballs. > > Maybe someone else from the team can chime-in? > > I will look at that these days. I can try to remove them and "turn off" the test that uses the tarballs. Some days ago, I started to look at the pypy package, and it has the suittest in another package (btw, that is new for me). Maybe poetry can have that approach? Also, I don't know if that makes sense. > - > > 4. d/tests > > There are no autopkgtests. This being a large project that's kinda hard > to package, I don't really mind for now. > > I think it's fair to wait to have at least 1 version in unstable before > working on that. > yes, that was my idea. > > - > > 5. d/rules > > Isn't the step in execute_after_dh_auto_install better suited in > execute_after_dh_clean instead? At least, it seems to me you're cleaning > the ./foo dir you patched in. > > yes you're right, that makes more sense, thanks! > - > > 6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry > > Again, not something that needs to be fixed, but each subcommand of > poetry should probably get a man page: > > https://python-poetry.org/docs/cli/ > > I looked at the code and I have no idea how this website is built (they > don't use sphinx). It seems like they do something manual? > > https://github.com/python-poetry/poetry/issues/3382 > > Anyway, here's an example of how I added man pages to a program with > multiple commands: > > https://github.com/spl0k/supysonic/tree/master/docs/man > > thanks for note it, I'll take a look these days. > - > > Overall it's very good! The trickiest part to fix will likely be #3 :S > > > I need to skip some tests because use a non versioned python, so that > > give me some troubles like "python don't exist". > > > > Also, there're some package (or package version) that aren't in Debian > > yet. So, to save your time looking which are them I tell you that I run > > the buildpackage in this way: > > > > ``` > > > > gbp buildpackage --git-ignore-new > > > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb > > > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb > > > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb > > This package has not been updated on Salsa, or at least, I couldn't find > version 1.7.0-1 anywhere. Maybe you forgot to push? > > Oh yes, I'm just psuh to salsa. Sorry! Cheers! Emmanuel
Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
On 2021-07-02 18 h 25, Louis-Philippe Véronneau wrote: > 2. d/control: > > If you require specific dependencies, you should make it clear in > d/control. It's the kind of thing that helps a lot if people decide to > backport it. Specific _versions_ of dependencies. Sorry, Friday afternoon :) -- Louis-Philippe Véronneau OpenPGP_signature Description: OpenPGP digital signature
Re: Request for review for Poetry(Was: Re: Asking for help Poetry)
On 2021-06-19 18 h 21, Emmanuel Arias wrote: > Hello everybody, > > I want to tell you that I push to salsa an advances of poetry packaging. > > Now, we have a complete package of poetry, so I'm requesting some more > experienced reviewers. Sorry, I said I would do this but it took me some time to actually do it :) Thanks for working on poetry, it's 100% going to make our lives easier. I have not read the upstream code, so I might be missing things... That's the kind of thing I only do when a package is ready to be sponsored. Here are my comments: 1. d/control: You haven't set the Python Team either in Maintainer or Uploaders. - 2. d/control: If you require specific dependencies, you should make it clear in d/control. It's the kind of thing that helps a lot if people decide to backport it. - 3. tests/repositories/fixtures This directory contains a bunch of tarballs from other projects. I'm not sure what should be done with this, as I guess they are used in the testsuite My first reflex would be to exclude them from the imported tarball and disable the tests that require them, but I don't know how much of the testsuite depends on those tarballs. Maybe someone else from the team can chime-in? - 4. d/tests There are no autopkgtests. This being a large project that's kinda hard to package, I don't really mind for now. I think it's fair to wait to have at least 1 version in unstable before working on that. - 5. d/rules Isn't the step in execute_after_dh_auto_install better suited in execute_after_dh_clean instead? At least, it seems to me you're cleaning the ./foo dir you patched in. - 6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry Again, not something that needs to be fixed, but each subcommand of poetry should probably get a man page: https://python-poetry.org/docs/cli/ I looked at the code and I have no idea how this website is built (they don't use sphinx). It seems like they do something manual? https://github.com/python-poetry/poetry/issues/3382 Anyway, here's an example of how I added man pages to a program with multiple commands: https://github.com/spl0k/supysonic/tree/master/docs/man - Overall it's very good! The trickiest part to fix will likely be #3 :S > I need to skip some tests because use a non versioned python, so that > give me some troubles like "python don't exist". > > Also, there're some package (or package version) that aren't in Debian > yet. So, to save your time looking which are them I tell you that I run > the buildpackage in this way: > > ``` > > gbp buildpackage --git-ignore-new > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb This package has not been updated on Salsa, or at least, I couldn't find version 1.7.0-1 anywhere. Maybe you forgot to push? I'm getting test failures on tests/inspection/test_info.py, but I'm taking for granted it's because I don't have the right version. -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ po...@debian.org / veronneau.org ⠈⠳⣄ OpenPGP_signature Description: OpenPGP digital signature
Request for review for Poetry(Was: Re: Asking for help Poetry)
Hello everybody, I want to tell you that I push to salsa an advances of poetry packaging. Now, we have a complete package of poetry, so I'm requesting some more experienced reviewers. I need to skip some tests because use a non versioned python, so that give me some troubles like "python don't exist". Also, there're some package (or package version) that aren't in Debian yet. So, to save your time looking which are them I tell you that I run the buildpackage in this way: ``` gbp buildpackage --git-ignore-new --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb ``` Thanks for your help :) Cheers, -- Emmanuel Arias @eamanu yaerobi.com OpenPGP_0xFA9DEC5DE11C63F1.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: Asking for help Poetry
Hello Everybody, I left some advances on poetry. Happily (from my point of view) we are near to having poetry packaged. I've just push some new commits to salsa [0]. After spend several times with the tests (see patches), we just have two test that still fail (I didn't looking it yet): tests/installation/test_pip_installer.py - fail one unit test tests/utils/test_env.py - fail several unit tests. To build poetry, you will also need to build locally python3-cleo still in NEW [1], python-httpretty 1.0.5: I prepare a new upstream release and a member of OpenStack sponsored its to experimental (thanks Michal Arbet) [2] and pkginfo 1.7.0, I ping @jandd on #debian-python for a new upstream release packaging, but if I haven't got news about it these days, I will push my work and I'll ask for sponsorship. [0] https://salsa.debian.org/python-team/packages/poetry [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958366 [2] https://tracker.debian.org/news/1241115/accepted-python-httpretty-105-01-source-into-experimental/ Cheers, Emmanuel On Tue, May 11, 2021 at 8:55 AM Emmanuel Arias wrote: > Hello! > > On 5/11/21 1:25 AM, Sandro Tosi wrote: > > On Sat, May 8, 2021 at 9:56 PM Emmanuel Arias > wrote: > >> On 5/8/21 10:37 PM, Sandro Tosi wrote: > >>> On Mon, Mar 15, 2021 at 10:29 AM Emmanuel Arias > wrote: > On Mon, Mar 15, 2021 at 4:22 AM Sandro Tosi wrote: > >> * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ > > are you handling this failure? > >>> looks like this is fixed in git: do you need a sponsor? > >> Yes, please. Thanks! > > sounds good, i'll have a look at this package soon and let you know > Thanks! > > > >> * python-cleo in review > https://salsa.debian.org/python-team/packages/cleo I hope finished this > week > >>> stefanor uploaded it a few days ago > >> Yes. > >> * poetry still in progress > https://salsa.debian.org/python-team/packages/poetry -> need help and > reviews > >>> for this one it looks like you imported a new upstream release a week > >>> ago: is there something we can help/check about poetry? > >> I've just push some advances. Currently, I'm working on tests, if you > >> want to take a look. > > maybe just ask here (or directly to me) if you have questions and > > what's failing/needs work, so we dont duplicate work > ok! > > > >> We need new upstream release for python-httpretty (for tests), that I > >> upload to mentors [0]. @zigo ask me about test that this new upstream > >> release doesn't break > >> cloud-init and python3-scciclient (I would like to take a look to ratt > >> for that). > > ratt is pretty great, and rather simple to use: > > > > - setup a sbuild schroot for unstable > > - build a binary package from the source you're working on > > - `ratt _amd64.changes` > > > > and then you'll get on screen the results for each package + a > > directory with the build results and logs > > > > https://github.com/Debian/ratt > > > > keep in mind it rebuilds packages sequentially, so it can take some > > time if the number of reverse deps is high. > > Thanks for the advice! > > > > >> Perhaps a good help from a more experienced person would be check if all > >> is ok with DFSG,that's my biggest concern. > > for which package specifically? while it's boring and long work, it's > > also rather trivial: look at every single file (yep, all of them) from > > the upstream source, and document their copyright and license in > > d/copyright -- happy to answer questions if you have something > > specific in mind about this > > Thanks, I hope have more news at the finish of the week > > Cheers! > > > > > > Regards, >
Re: Asking for help Poetry
Hello! On 5/11/21 1:25 AM, Sandro Tosi wrote: > On Sat, May 8, 2021 at 9:56 PM Emmanuel Arias wrote: >> On 5/8/21 10:37 PM, Sandro Tosi wrote: >>> On Mon, Mar 15, 2021 at 10:29 AM Emmanuel Arias wrote: On Mon, Mar 15, 2021 at 4:22 AM Sandro Tosi wrote: >> * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ > are you handling this failure? >>> looks like this is fixed in git: do you need a sponsor? >> Yes, please. Thanks! > sounds good, i'll have a look at this package soon and let you know Thanks! > >> * python-cleo in review >> https://salsa.debian.org/python-team/packages/cleo I hope finished this >> week >>> stefanor uploaded it a few days ago >> Yes. >> * poetry still in progress >> https://salsa.debian.org/python-team/packages/poetry -> need help and >> reviews >>> for this one it looks like you imported a new upstream release a week >>> ago: is there something we can help/check about poetry? >> I've just push some advances. Currently, I'm working on tests, if you >> want to take a look. > maybe just ask here (or directly to me) if you have questions and > what's failing/needs work, so we dont duplicate work ok! > >> We need new upstream release for python-httpretty (for tests), that I >> upload to mentors [0]. @zigo ask me about test that this new upstream >> release doesn't break >> cloud-init and python3-scciclient (I would like to take a look to ratt >> for that). > ratt is pretty great, and rather simple to use: > > - setup a sbuild schroot for unstable > - build a binary package from the source you're working on > - `ratt _amd64.changes` > > and then you'll get on screen the results for each package + a > directory with the build results and logs > > https://github.com/Debian/ratt > > keep in mind it rebuilds packages sequentially, so it can take some > time if the number of reverse deps is high. Thanks for the advice! > >> Perhaps a good help from a more experienced person would be check if all >> is ok with DFSG,that's my biggest concern. > for which package specifically? while it's boring and long work, it's > also rather trivial: look at every single file (yep, all of them) from > the upstream source, and document their copyright and license in > d/copyright -- happy to answer questions if you have something > specific in mind about this Thanks, I hope have more news at the finish of the week Cheers! > > Regards, OpenPGP_0xFA9DEC5DE11C63F1.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: Asking for help Poetry
On Sat, May 8, 2021 at 9:56 PM Emmanuel Arias wrote: > On 5/8/21 10:37 PM, Sandro Tosi wrote: > > On Mon, Mar 15, 2021 at 10:29 AM Emmanuel Arias wrote: > >> On Mon, Mar 15, 2021 at 4:22 AM Sandro Tosi wrote: > * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ > >>> are you handling this failure? > > looks like this is fixed in git: do you need a sponsor? > Yes, please. Thanks! sounds good, i'll have a look at this package soon and let you know > * python-cleo in review > https://salsa.debian.org/python-team/packages/cleo I hope finished this > week > > stefanor uploaded it a few days ago > Yes. > * poetry still in progress > https://salsa.debian.org/python-team/packages/poetry -> need help and > reviews > > for this one it looks like you imported a new upstream release a week > > ago: is there something we can help/check about poetry? > > I've just push some advances. Currently, I'm working on tests, if you > want to take a look. maybe just ask here (or directly to me) if you have questions and what's failing/needs work, so we dont duplicate work > We need new upstream release for python-httpretty (for tests), that I > upload to mentors [0]. @zigo ask me about test that this new upstream > release doesn't break > cloud-init and python3-scciclient (I would like to take a look to ratt > for that). ratt is pretty great, and rather simple to use: - setup a sbuild schroot for unstable - build a binary package from the source you're working on - `ratt _amd64.changes` and then you'll get on screen the results for each package + a directory with the build results and logs https://github.com/Debian/ratt keep in mind it rebuilds packages sequentially, so it can take some time if the number of reverse deps is high. > Perhaps a good help from a more experienced person would be check if all > is ok with DFSG,that's my biggest concern. for which package specifically? while it's boring and long work, it's also rather trivial: look at every single file (yep, all of them) from the upstream source, and document their copyright and license in d/copyright -- happy to answer questions if you have something specific in mind about this Regards, -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi Twitter: https://twitter.com/sandrotosi
Re: Asking for help Poetry
Hello Sandro, Thanks for write me. On 5/8/21 10:37 PM, Sandro Tosi wrote: > On Mon, Mar 15, 2021 at 10:29 AM Emmanuel Arias wrote: >> On Mon, Mar 15, 2021 at 4:22 AM Sandro Tosi wrote: * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ >>> are you handling this failure? > looks like this is fixed in git: do you need a sponsor? Yes, please. Thanks! * python-cleo in review https://salsa.debian.org/python-team/packages/cleo I hope finished this week > stefanor uploaded it a few days ago Yes. * poetry still in progress https://salsa.debian.org/python-team/packages/poetry -> need help and reviews > for this one it looks like you imported a new upstream release a week > ago: is there something we can help/check about poetry? I've just push some advances. Currently, I'm working on tests, if you want to take a look. We need new upstream release for python-httpretty (for tests), that I upload to mentors [0]. @zigo ask me about test that this new upstream release doesn't break cloud-init and python3-scciclient (I would like to take a look to ratt for that). Perhaps a good help from a more experienced person would be check if all is ok with DFSG,that's my biggest concern. [0] https://mentors.debian.net/package/python-httpretty/ Cheers! Emmanuel OpenPGP_0xFA9DEC5DE11C63F1.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: Asking for help Poetry
On Mon, Mar 15, 2021 at 10:29 AM Emmanuel Arias wrote: > On Mon, Mar 15, 2021 at 4:22 AM Sandro Tosi wrote: >> >> > * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ >> >> are you handling this failure? looks like this is fixed in git: do you need a sponsor? >> > * python-cleo in review https://salsa.debian.org/python-team/packages/cleo >> > I hope finished this week stefanor uploaded it a few days ago >> > * poetry still in progress >> > https://salsa.debian.org/python-team/packages/poetry -> need help and >> > reviews for this one it looks like you imported a new upstream release a week ago: is there something we can help/check about poetry? Regards, -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi Twitter: https://twitter.com/sandrotosi
Re: Asking for help Poetry
Hi, On Mon, Mar 15, 2021 at 4:22 AM Sandro Tosi wrote: > > * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ > > are you handling this failure? > > > * python-cleo in review > https://salsa.debian.org/python-team/packages/cleo I hope finished this > week > > * poetry still in progress > https://salsa.debian.org/python-team/packages/poetry -> need help and > reviews > > what kind of help do you need here? > Basically, with tests. There're so many setup.py on tests cases and we should identify if that test has some internet connections or not. Also, each setup.py has its Copyright and License so that should be added to d/copyright, or repack? Cheers, Emmanuel > > -- > Sandro "morph" Tosi > My website: http://sandrotosi.me/ > Me at Debian: http://wiki.debian.org/SandroTosi > Twitter: https://twitter.com/sandrotosi >
Re: Asking for help Poetry
On Mon, Mar 15, 2021 at 5:50 AM Bastian Venthur wrote: > Hi Emmanuel, > > I find it amazing that you went through all the hassle of un-bundeling > and actually packaging all the dependencies for poetry! > > > Good job and thank you very much for your efforts! > Thanks!! > > Bastian > > -- > Dr. Bastian Venthur https://venthur.de > Debian Developer venthur at debian org > >
Re: Asking for help Poetry
Hi Emmanuel, I find it amazing that you went through all the hassle of un-bundeling and actually packaging all the dependencies for poetry! Good job and thank you very much for your efforts! Bastian -- Dr. Bastian Venthur https://venthur.de Debian Developer venthur at debian org
Re: Asking for help Poetry
> * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ are you handling this failure? > * python-cleo in review https://salsa.debian.org/python-team/packages/cleo I > hope finished this week > * poetry still in progress > https://salsa.debian.org/python-team/packages/poetry -> need help and reviews what kind of help do you need here? -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi Twitter: https://twitter.com/sandrotosi
Re: Asking for help Poetry
Hi everyone, I leave an update about poetry packaging status. * poetry-core failing https://ci.debian.net/packages/p/poetry-core/ * pastel in testing https://tracker.debian.org/pkg/pastel * pylev in testing https://tracker.debian.org/pkg/pylev * crashtest in testing https://tracker.debian.org/pkg/crashtest * clikit in testing https://tracker.debian.org/pkg/clikit * shellingham in testing https://tracker.debian.org/pkg/shellingham * python-cleo in review https://salsa.debian.org/python-team/packages/cleo I hope finished this week * poetry still in progress https://salsa.debian.org/python-team/packages/poetry -> need help and reviews My goal is to finish poetry package before april. Cheers, Emmanuel On Fri, Mar 12, 2021 at 2:03 PM Sandro Tosi wrote: > Hello Emmanuel, > > > From the missing dependencies we have: > > * poetry-core in NEW [0] > > * pastel in NEW need for clikit [1] > > * pylev in NEW need for clikit [2] > > * crashtest has RFS need for clikit [3] > > * clikit is ready on salsa but waiting for crashtest before RFS [4] > > * cleo ready but waiting for clikit [5] > > * shellingham not ready nor ITP yet. > > * poetry some advances on salsa [6] > > > > For experience in the other packages (pylev, paste, etc) and for > recommendation of DDs, > > poetry package use upstream github repository where we have important > things like > > tests. I was looking and exist lot of setup.py that makes me think that > we will need > > repack the upstream package. > > > > I will continue working on it but after my reset week, I will be offline > until 9 january > > can you provide a status update on poetry packaging? more and more > upstreams are moving (or planning) to poetry, so having it available > asap is definitely important. > > Regards, > -- > Sandro "morph" Tosi > My website: http://sandrotosi.me/ > Me at Debian: http://wiki.debian.org/SandroTosi > Twitter: https://twitter.com/sandrotosi >
Re: Asking for help Poetry
Hello Emmanuel, > From the missing dependencies we have: > * poetry-core in NEW [0] > * pastel in NEW need for clikit [1] > * pylev in NEW need for clikit [2] > * crashtest has RFS need for clikit [3] > * clikit is ready on salsa but waiting for crashtest before RFS [4] > * cleo ready but waiting for clikit [5] > * shellingham not ready nor ITP yet. > * poetry some advances on salsa [6] > > For experience in the other packages (pylev, paste, etc) and for > recommendation of DDs, > poetry package use upstream github repository where we have important things > like > tests. I was looking and exist lot of setup.py that makes me think that we > will need > repack the upstream package. > > I will continue working on it but after my reset week, I will be offline > until 9 january can you provide a status update on poetry packaging? more and more upstreams are moving (or planning) to poetry, so having it available asap is definitely important. Regards, -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi Twitter: https://twitter.com/sandrotosi
Re: Asking for help Poetry
Hi everyone,
After read [0] and thinking about it, IMO the best solution is try to
package python-poetry,
and its dependencies. I make a very simple (and probably wrong) script [1]
to verify the
package that will be need package into Debian, before poetry package.
[{'name': 'cleo'}, {'name': 'clikit'}, {'name': 'crashtest'}, {'name':
'shellingham'}, {'name': 'pastel'}, {'name': 'pylev'}]
Please feel free to ITP them :)
[0] https://github.com/python-poetry/poetry/issues/2346
[1] https://github.com/eamanu/pydebdep
On Sun, Nov 22, 2020 at 11:03 AM Emmanuel Arias wrote:
> Hi everyone,
>
> In the last week I re-take this work.
>
> But, we need to discuss the poetry situation. First of all, poetry
> upstream doesn't consider
> adding vendor libs to the source. They have their reasons about this
> situation. I recommend
> you read this [0] [1].
>
> The problem here, is that poetry need some dependencies that are not in
> Debian yet,
> and that dependencies have more dependencies (not in Debian).
>
> Here there're some possibilities that from my point of view we can follow.
> If you read [0] @abn recommend use `sonnet` script to build poetry
> but is not maintained. In the other hand we can can try to package
> poetry-core
> that is a more pip similar case with the vendor libs.
>
> In this week I want to make some tests using `sonnet` and look poetry-core
> with the aim to package poetry before freezing Debian.
>
> I can send you (not today) the list of the dependencies that will be need
> package if we want poetry in Debian.
>
> This is my analysis about poetry (from a not so experienced DM) I will
> happy to listen to more experienced people about this, and if you consider
> correct that I mention, please.
>
> Thanks!
>
> [0] https://github.com/python-poetry/poetry/issues/2607
> [1] https://github.com/python-poetry/poetry/issues/2346
>
>
> Cheers,
> Arias Emmanuel
> @eamanu
> yaerobi.com
>
>
> On Thu, Nov 19, 2020 at 12:16 PM Bastian Venthur
> wrote:
>
>> Hi,
>>
>> I see some updates on the salsa repository, any chance we can get this
>> package ready before the next freeze so we'll have it in the next stable
>> release?
>>
>>
>> Cheers,
>>
>> Bastian
>>
>> On 29.06.20 06:04, Scott Kitterman wrote:
>> >
>> >
>> > On June 29, 2020 3:08:53 AM UTC, Emmanuel Arias
>> wrote:
>> >> Hi,
>> >>
>> >> I'm working on poetry packaging, I created on salsa de repository [0].
>> >>
>> >> Note that there are many packages that are not in Debian like cachy,
>> >> cleo,
>> >> etc.
>> >>
>> >> I RFS python-cachy [1] and now I'm working on cleo, which depends on
>> >> clikit
>> >> that is not on Debian (if I search correctly).
>> >>
>> >> Bastian Venthur note me that pienv, pip have vendors folder with the
>> >> dependencies
>> >> but looking on poetry that _vendor folder is empty.
>> >>
>> >> So, looking for I more experienced opinion, do you think that we would
>> >> try
>> >> convince
>> >> to upstream to make available vendors on the release (if that is
>> >> necessary)
>> >> or
>> >> we need to package all the missing dependencies?
>> >
>> > Definitely they should be packaged.
>> >
>> > At least for pip none of the vendored libs are used in Debian's
>> package. Fortunately upstream supports use of system libs with only minor
>> patching.
>> >
>> > Scott K
>> >
>> >
>>
>>
>> --
>> Dr. Bastian Venthur http://venthur.de
>> Debian Developer venthur at debian org
>>
>>
Re: Asking for help Poetry
Hi everyone, In the last week I re-take this work. But, we need to discuss the poetry situation. First of all, poetry upstream doesn't consider adding vendor libs to the source. They have their reasons about this situation. I recommend you read this [0] [1]. The problem here, is that poetry need some dependencies that are not in Debian yet, and that dependencies have more dependencies (not in Debian). Here there're some possibilities that from my point of view we can follow. If you read [0] @abn recommend use `sonnet` script to build poetry but is not maintained. In the other hand we can can try to package poetry-core that is a more pip similar case with the vendor libs. In this week I want to make some tests using `sonnet` and look poetry-core with the aim to package poetry before freezing Debian. I can send you (not today) the list of the dependencies that will be need package if we want poetry in Debian. This is my analysis about poetry (from a not so experienced DM) I will happy to listen to more experienced people about this, and if you consider correct that I mention, please. Thanks! [0] https://github.com/python-poetry/poetry/issues/2607 [1] https://github.com/python-poetry/poetry/issues/2346 Cheers, Arias Emmanuel @eamanu yaerobi.com On Thu, Nov 19, 2020 at 12:16 PM Bastian Venthur wrote: > Hi, > > I see some updates on the salsa repository, any chance we can get this > package ready before the next freeze so we'll have it in the next stable > release? > > > Cheers, > > Bastian > > On 29.06.20 06:04, Scott Kitterman wrote: > > > > > > On June 29, 2020 3:08:53 AM UTC, Emmanuel Arias > wrote: > >> Hi, > >> > >> I'm working on poetry packaging, I created on salsa de repository [0]. > >> > >> Note that there are many packages that are not in Debian like cachy, > >> cleo, > >> etc. > >> > >> I RFS python-cachy [1] and now I'm working on cleo, which depends on > >> clikit > >> that is not on Debian (if I search correctly). > >> > >> Bastian Venthur note me that pienv, pip have vendors folder with the > >> dependencies > >> but looking on poetry that _vendor folder is empty. > >> > >> So, looking for I more experienced opinion, do you think that we would > >> try > >> convince > >> to upstream to make available vendors on the release (if that is > >> necessary) > >> or > >> we need to package all the missing dependencies? > > > > Definitely they should be packaged. > > > > At least for pip none of the vendored libs are used in Debian's > package. Fortunately upstream supports use of system libs with only minor > patching. > > > > Scott K > > > > > > > -- > Dr. Bastian Venthur http://venthur.de > Debian Developer venthur at debian org > >
Re: Asking for help Poetry
Hi, I see some updates on the salsa repository, any chance we can get this package ready before the next freeze so we'll have it in the next stable release? Cheers, Bastian On 29.06.20 06:04, Scott Kitterman wrote: On June 29, 2020 3:08:53 AM UTC, Emmanuel Arias wrote: Hi, I'm working on poetry packaging, I created on salsa de repository [0]. Note that there are many packages that are not in Debian like cachy, cleo, etc. I RFS python-cachy [1] and now I'm working on cleo, which depends on clikit that is not on Debian (if I search correctly). Bastian Venthur note me that pienv, pip have vendors folder with the dependencies but looking on poetry that _vendor folder is empty. So, looking for I more experienced opinion, do you think that we would try convince to upstream to make available vendors on the release (if that is necessary) or we need to package all the missing dependencies? Definitely they should be packaged. At least for pip none of the vendored libs are used in Debian's package. Fortunately upstream supports use of system libs with only minor patching. Scott K -- Dr. Bastian Venthur http://venthur.de Debian Developer venthur at debian org
Re: Asking for help Poetry
On June 29, 2020 3:08:53 AM UTC, Emmanuel Arias wrote: >Hi, > >I'm working on poetry packaging, I created on salsa de repository [0]. > >Note that there are many packages that are not in Debian like cachy, >cleo, >etc. > >I RFS python-cachy [1] and now I'm working on cleo, which depends on >clikit >that is not on Debian (if I search correctly). > >Bastian Venthur note me that pienv, pip have vendors folder with the >dependencies >but looking on poetry that _vendor folder is empty. > >So, looking for I more experienced opinion, do you think that we would >try >convince >to upstream to make available vendors on the release (if that is >necessary) >or >we need to package all the missing dependencies? Definitely they should be packaged. At least for pip none of the vendored libs are used in Debian's package. Fortunately upstream supports use of system libs with only minor patching. Scott K
Asking for help Poetry
Hi, I'm working on poetry packaging, I created on salsa de repository [0]. Note that there are many packages that are not in Debian like cachy, cleo, etc. I RFS python-cachy [1] and now I'm working on cleo, which depends on clikit that is not on Debian (if I search correctly). Bastian Venthur note me that pienv, pip have vendors folder with the dependencies but looking on poetry that _vendor folder is empty. So, looking for I more experienced opinion, do you think that we would try convince to upstream to make available vendors on the release (if that is necessary) or we need to package all the missing dependencies? [0] https://salsa.debian.org/python-team/applications/poetry [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956819 Many thanks for your help Cheers, Arias Emmanuel @eamanu yaerobi.com
