Re: RFR: cairosvg -- SVG converter based on Cairo
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Taking this off mentors.
On 06/11/2012 12:12 PM, Jakub Wilk wrote:
The dependencies are generated by dh_python{2,3}, so it's a matter
of fixing shebangs before they are called, isn't it?
This may help:
https://lists.debian.org/debian-python/2011/03/msg00077.html
Thanks, that helped a lot. Now both the shebang lines and the
dependencies are correct.
One more thing: Vcs-* fields are broken:
$ svn ls -v $(grep-dctrl -ns Vcs-Svn '' debian/control) svn: URL
'svn://svn.debian.org/python-modules/packages/cairosvg/trunk'
non-existent in that revision
I used an incorrect directory in the repo. It has been renamed.
Cheers,
- --
Michael Fladischer mich...@fladi.at
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk/XPdgACgkQeJ3z1zFMUGajygCeMyIt27d7Nw1OE4dxP3K4K4bw
4KAAoJOvRVrs1hwbnrt599BD/N4tCMiE
=ZeTk
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4fd73dd9.1090...@fladi.at
Re: RFR: cairosvg -- SVG converter based on Cairo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Jakub, thanks for your input! On 06/08/2012 04:19 PM, Jakub Wilk wrote: No, it's not really correct. /usr/bin/cairosvg has currently #!/usr/bin/python2.7 (sic!) shebang, so it won't work out-of-the box if only python-ciarosvg is installed. I would recommend you to get rid of the -common package and use alternatives to manage /usr/bin/cairosvg symlink, that would point either to #!/usr/bin/python or #!/usr/bin/python3 script. I switched to alternatives. setuptools seem to be responsible for changing the shebang line in bin/cairosvg. I'm tempted to change it to #!/usr/bin/python instead of #!/usr/bin/python2.7 but this would require meddling with the dependencies. But now the binary package depends on python2.7 while it should also work with python2.6 alone. Same for python3.2. Re fix_setup.patch, what was wrong with the original code? Running setup.py clean with python3.2 fails: Traceback (most recent call last): File setup.py, line 24, in module VERSION = re.search(VERSION = '([^']+)', fd.read().strip()).group(1) File /usr/lib/python3.2/encodings/ascii.py, line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 68: ordinal not in range(128) Some dependencies are missing: I've added them and I'll issue the RFS soon. Cheers, - -- Michael Fladischer mich...@fladi.at -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/VuQAACgkQeJ3z1zFMUGZHygCdG6igy9a/VmxBetgF/JmBMHcG H7gAn1OWFj7EtNmjjxZxPfX78lry4C5E =D/2w -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4fd5b900.7000...@fladi.at
Re: RFR: cairosvg -- SVG converter based on Cairo
* Michael Fladischer mich...@fladi.at, 2012-06-11, 11:23:
No, it's not really correct. /usr/bin/cairosvg has currently
#!/usr/bin/python2.7 (sic!) shebang, so it won't work out-of-the box
if only python-ciarosvg is installed.
I would recommend you to get rid of the -common package and use
alternatives to manage /usr/bin/cairosvg symlink, that would point
either to #!/usr/bin/python or #!/usr/bin/python3 script.
I switched to alternatives. setuptools seem to be responsible for
changing the shebang line in bin/cairosvg.
s/setuptools/distutils/. This package doesn't use setuptools AFAICS
(which makes me wonder why it build-depends on it...).
I'm tempted to change it to #!/usr/bin/python instead of
#!/usr/bin/python2.7 but this would require meddling with the
dependencies.
The dependencies are generated by dh_python{2,3}, so it's a matter of
fixing shebangs before they are called, isn't it?
This may help:
https://lists.debian.org/debian-python/2011/03/msg00077.html
Re fix_setup.patch, what was wrong with the original code?
Running setup.py clean with python3.2 fails:
Traceback (most recent call last):
File setup.py, line 24, in module
VERSION = re.search(VERSION = '([^']+)', fd.read().strip()).group(1)
File /usr/lib/python3.2/encodings/ascii.py, line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position
68: ordinal not in range(128)
Fair enough. It would be nice if the patch header explained that.
One more thing: Vcs-* fields are broken:
$ svn ls -v $(grep-dctrl -ns Vcs-Svn '' debian/control)
svn: URL 'svn://svn.debian.org/python-modules/packages/cairosvg/trunk'
non-existent in that revision
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120611101256.ga6...@jwilk.net
Re: RFR: cairosvg -- SVG converter based on Cairo
On 7 June 2012 17:09, Michael Fladischer mich...@fladi.at wrote: SVG converter based on Cairo This description seems a bit ambiguous - does it convert from or to SVG? What's the format on the other end of the conversion? But perhaps this is obvious to anyone who'd want to install it. Clicking through to the website, I see it's from SVG to pdf/ps/png. Best wishes, Thomas -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caovn4qhz4xacjdsiu6czsams91faggd5e69rt8x18bx90ez...@mail.gmail.com
Re: RFR: cairosvg -- SVG converter based on Cairo
* Michael Fladischer mich...@fladi.at, 2012-06-07, 18:09: The CLI script /usr/bin/cairosvg works with both py2 and py3 versions of the cairosvg package, so I moved it to a separate -common package. Any comments on how to handle this in a saner/better way or if this is already the correct way are especially appreciated. No, it's not really correct. /usr/bin/cairosvg has currently #!/usr/bin/python2.7 (sic!) shebang, so it won't work out-of-the box if only python-ciarosvg is installed. I would recommend you to get rid of the -common package and use alternatives to manage /usr/bin/cairosvg symlink, that would point either to #!/usr/bin/python or #!/usr/bin/python3 script. http://mentors.debian.net/debian/pool/main/c/cairosvg/cairosvg_0.4.3-1.dsc Re fix_setup.patch, what was wrong with the original code? Some dependencies are missing: $ python -c 'import cairosvg' Traceback (most recent call last): File string, line 1, in module File /usr/lib/python2.7/dist-packages/cairosvg/__init__.py, line 27, in module from . import surface File /usr/lib/python2.7/dist-packages/cairosvg/surface/__init__.py, line 23, in module import cairo ImportError: No module named cairo -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120608141946.ga7...@jwilk.net
RFR: cairosvg -- SVG converter based on Cairo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I am looking for reviews of my package cairosvg. * Package name: cairosvg Version : 0.4.3-1 Upstream Author : Kozea guillaume.ay...@kozea.fr * URL : http://cairosvg.org/ * License : LGPL-3+ It builds those binary packages: python-cairosvg-common - SVG converter based on Cairo (CLI interface) python-cairosvg - SVG converter based on Cairo (Python2 library) python3-cairosvg - SVG converter based on Cairo (Python3 library) There is one issue which this package on which I'm not sure if I handled it correctly: The CLI script /usr/bin/cairosvg works with both py2 and py3 versions of the cairosvg package, so I moved it to a separate -common package. Any comments on how to handle this in a saner/better way or if this is already the correct way are especially appreciated. To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cairosvg Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cairosvg/cairosvg_0.4.3-1.dsc Kind regards, - -- Michael Fladischer -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEUEARECAAYFAk/Q0ioACgkQeJ3z1zFMUGYLCgCY591lkc1wZkKQFD/78SwW6tNN LACfdQmWbhlzFnD7tVIjxJ31xTXB0S0= =4knY -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4fd0d22d@fladi.at
