Re: py.test is not in debian anymore
Hi, On 4 April 2012 15:47, Simon Chopin wrote: > IMHO there is three alternatives: > * Provide the scripts for all Python versions available, py.test[-3] > pointing to the default Python version. It would mean that the > package would depend on python-all and python3-all because of the > shebang. I strongly dislike this one. I don't think this is so bad really. py.test is a development package, not a runtime dependency and I don't think it's unreasonable to ask a python developer to install python[3]-all. Regards, Floris -- Debian GNU/Linux -- The Power of Freedom www.debian.org | www.gnu.org | www.kernel.org -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAAWk_DyuZhXbNkFTijzFGYR=GVmNEkyQXv=z8otv1htak2q...@mail.gmail.com
Re: py.test is not in debian anymore
Hi Tiziano, On Mon, Apr 02, 2012 at 03:39:31PM +0200, Tiziano Zito wrote: > here a couple of short comments: > > - why do you build for all python versions and then only install > for the default versions? > > - in override_dh_auto_test, it would probably be better not to > introduce your own ENABLE_TESTS flag. you should rely on the > DEB_BUILD_OPTIONS variable. something like this should do: > ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) Well, actually it was to disable the tests by default for the first upload, since py.test isn't in the archive. Nonetheless, it is a good idea to add support for DEB_BUILD_OPTIONS, I suppose I can just comment out the whole section as well. > - why did you choose to rename the py.test script for python3 to > py3.test? I think the upstream convention of having > py.test-2.6, py.test-2.7, py.test-3.2, etc., seems > more sensible and also consistent with other packages (see for > example ipython: ipython2.6 ipython2.7 ...) > at the end one could have a py.test link to point to the > py.test-2.x where x is the default (probably 7 for wheezy), and > same thing for the python3 version, where py.test-3 may point to > py.test-3.2 on wheezy. I began to do so in my first attempts, but I didn't want the package to depend on non-default Python versions, which it would have if I provided every script because of the strict shebangs. Incidentally, the build for all version comes from this attempt, I've forgotten to clean it up. In any case, it doesn't cost much to build for every available version and prevents any syntax error. For the py3.test, I cannot remember why I used that name. The reason must not have been a good one if I've forgotten it, though ;-). py.test-3 is fine as well. IMHO there is three alternatives: * Provide the scripts for all Python versions available, py.test[-3] pointing to the default Python version. It would mean that the package would depend on python-all and python3-all because of the shebang. I strongly dislike this one. * Only provide the default Python version scripts. This is what I do now. If the users want to use different Python versions, they can always use "python$VERSION -m pytest" (since 2.0). * Do it the ipython way: use the python scripts for py.test and py.test-3, and use a shell script that detects the Python version to use based on the script name, and fails graciously if it isn't available. I hadn't thought about the third alternative until you mentioned ipython, but it seems a rather good approach. I'll take a shot at it shortly. Cheers, Simon signature.asc Description: Digital signature
Re: py.test is not in debian anymore
here a couple of short comments: - why do you build for all python versions and then only install for the default versions? - in override_dh_auto_test, it would probably be better not to introduce your own ENABLE_TESTS flag. you should rely on the DEB_BUILD_OPTIONS variable. something like this should do: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) - why did you choose to rename the py.test script for python3 to py3.test? I think the upstream convention of having py.test-2.6, py.test-2.7, py.test-3.2, etc., seems more sensible and also consistent with other packages (see for example ipython: ipython2.6 ipython2.7 ...) at the end one could have a py.test link to point to the py.test-2.x where x is the default (probably 7 for wheezy), and same thing for the python3 version, where py.test-3 may point to py.test-3.2 on wheezy. ciao, tiziano PS to the list: is this kind of conversation appropriate for debian-python or should it better stay private to keep the noise level low? On Wed 28 Mar, 18:28, Simon Chopin wrote: > debian-python@lists.debian.org Cc-ed. > On Wed, 28 Mar 2012 20:55:54 +0200, Tiziano Zito > wrote: > > hi simon, > Hi ! > > > > I am a user of py.test and maintainer of the python-mdp package, > > which used to suggest python-py and used py.test. > > now that py.test is not contained in python-py anymore, I was > > thinking about filing an RFP for pytest. > > you already filed an ITP for that, which is owesome :) > > yarik, a seasoned DD in Cc, would be willing to sponsor, but > > being really busy, asked me to help him review your package. > > if you agree I could send you my comments about your package, so > > that with the help of yarik you can make it fit for a speedy > > upload to debian. > > > > what do you think? > > Only good things :-). The more review the package gets, the better it > should become. Unfortunately, I have virtually no free time until next > week, which means I will not be able to address any comment you could > have ATM. As I intend to package pytest under the umbrella of the DPMT, the > packaging is in its SVN, and I added an RFS for it on the TODO wiki > page. > > Cheers, > > Simon > > > -- > To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: http://lists.debian.org/20120329012827.57487A0204@beltira > -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120402133931.ga14...@bio230.biologie.hu-berlin.de
Re: py.test is not in debian anymore
debian-python@lists.debian.org Cc-ed. On Wed, 28 Mar 2012 20:55:54 +0200, Tiziano Zito wrote: > hi simon, Hi ! > > I am a user of py.test and maintainer of the python-mdp package, > which used to suggest python-py and used py.test. > now that py.test is not contained in python-py anymore, I was > thinking about filing an RFP for pytest. > you already filed an ITP for that, which is owesome :) > yarik, a seasoned DD in Cc, would be willing to sponsor, but > being really busy, asked me to help him review your package. > if you agree I could send you my comments about your package, so > that with the help of yarik you can make it fit for a speedy > upload to debian. > > what do you think? Only good things :-). The more review the package gets, the better it should become. Unfortunately, I have virtually no free time until next week, which means I will not be able to address any comment you could have ATM. As I intend to package pytest under the umbrella of the DPMT, the packaging is in its SVN, and I added an RFS for it on the TODO wiki page. Cheers, Simon -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120329012827.57487A0204@beltira
