Processing of tcpspy_1.7d-10_amd64.changes
tcpspy_1.7d-10_amd64.changes uploaded successfully to localhost along with the files: tcpspy_1.7d-10.dsc tcpspy_1.7d-10.debian.tar.xz tcpspy_1.7d-10_amd64.deb Greetings, Your Debian queue daemon (running on host franck.debian.org) -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e1xm8kr-0006ij...@franck.debian.org
tcpspy_1.7d-10_amd64.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Wed, 29 Oct 2014 16:46:10 -0200 Source: tcpspy Binary: tcpspy Architecture: source amd64 Version: 1.7d-10 Distribution: unstable Urgency: medium Maintainer: Debian QA Group packa...@qa.debian.org Changed-By: Joao Eriberto Mota Filho eribe...@debian.org Description: tcpspy - Incoming and Outgoing TCP/IP connections logger Changes: tcpspy (1.7d-10) unstable; urgency=medium . * QA upload. * debian/patches/: added the patch 'fix-FTBFS-Hurd', that defines the PATH_MAX variable in Hurd systems. * debian/watch: updated. Checksums-Sha1: 1b09d71e47a14f633763eee592942dd69f191cd8 1650 tcpspy_1.7d-10.dsc 5d6bd48c5a088f0b9271780d7d8b9918e34aa221 12372 tcpspy_1.7d-10.debian.tar.xz 05a602b68397dabd67b67d6f3449b79bb591b206 31422 tcpspy_1.7d-10_amd64.deb Checksums-Sha256: 78b1ddb909bc31e3d1fbf790ffa8a32569ca0e21138e3bab8f84d709c29772a2 1650 tcpspy_1.7d-10.dsc 3038ef4193fd20173fdf8ab85c7578773465ee7a09ce06ded17e25ce7788414c 12372 tcpspy_1.7d-10.debian.tar.xz 4bc32f8ec5bc2957ca03c01569a42ae0aafc1d38d82e58599359f90aa8137418 31422 tcpspy_1.7d-10_amd64.deb Files: 8a5691d9817b2f09e30d8e7e7ea856c7 1650 net optional tcpspy_1.7d-10.dsc bdce890d8f127754ef91a52e85b70aac 12372 net optional tcpspy_1.7d-10.debian.tar.xz 896e6b9ab94093288bd798fc5db9f169 31422 net optional tcpspy_1.7d-10_amd64.deb -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBAgAGBQJUWpeBAAoJEN5juccE6+nvrKoP/itkPOHm34l6+7aQ3mKdVpT6 mso3uL/IMfcX12rN2IFpuBt8wyzxVOy8NeLqnr9D1F7hUGOZo0NIp7bcfxGWIhKr N1hEj+nMfNQvS3Y5tr+wk55VQBOE4z2S2ncmDybptXRI/HL8C3ULQ5OcF2QsrTJo sLR1ZBIMxoBTNNVGs033HA+G3xK2XlApfF8HOIfBOZo1izzpSoPkZ23q+0RH5NN1 4ca6SUjLYrS8doxdxejPnkENDIEzOuDGPa5GEND6XCM/gwFN9o/xkIKZnEm92uIK 33z2OMosQVfQaKHlZcO4/YDCHdIEJFLj+pAgb2b+rXeexXPsjHHC1txh1cGdf12+ 0NO1vn92nNRg9yXQV9ixPHtFEZrp5TQfYMSArH8QwVfktWKJr1/BCpaaFyw+iyQD u7z7CzT4zdUdQoYgxoqKuT9T4VkGt4qRy6qH4sz8m4FtTSm1jdPcSuEwCIr5wkqZ 9zvOzITem2GDsYFXERSqF5EW4k0FJAnVgmiu22d9LRT6+o7TD2lNvYKfSw4A0i9r au0K7noS11vsFbuokwfD2n3qPjrXKFO/RkrCtk72l4RABG3gRvdAP2Ks7js7kwlN v2jmWtIWAPh+x1ZuGiMRSrBCOyMd2AfCLBqQDrTpA2LQLG+k+ntxs0Cf8Eef6UlC tuO/03cJDfFTnrvmp4lO =wtMv -END PGP SIGNATURE- Thank you for your contribution to Debian. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e1xm8sq-0007fy...@franck.debian.org
Bug#764178: debsources: infobox CSS alignment problem with short files
On Tue, Nov 04, 2014 at 07:03:38PM -0500, Jason Pleau wrote: My commit adds a padding-right to make sure that even if the file has one short line, it's content will be left-aligned. Thanks Jason, your explanation makes a lot of sense to me now. And the description in the commit is now good enough to explain what's going on also to a CSS-illiterate like myself :) The 450px that I've written is a bit arbitrary. This is the only remaining aspect that concerns me. It is indeed arbitrary, and I'm pretty sure it will lead to nasty side effects on small screens. I've reviewed the rest of the current CSS files, and it seems to me that all other use cases for large px values are more safe (e.g. input field widths) than the one your patch is introducing. How about using a relative width instead? If CSS gurus are reading this, please advise on what you think is the best solution here. Cheers. -- Stefano Zacchiroli . . . . . . . z...@upsilon.cc . . . . o . . . o . o Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o Former Debian Project Leader . . @zack on identi.ca . . o o o . . . o . « the first rule of tautology club is the first rule of tautology club » -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141105091445.ga16...@upsilon.cc
Bug#764178: debsources: infobox CSS alignment problem with short files
Hi,
My commit adds a padding-right to make sure that even if the file has
one short line, it's content will be left-aligned.
We could instead limit the expansion of the first column, which contains
the line numbers, see attachment.
Cheers,
Christophe
From 2bab7e42849fb26333dc0962e7a43f530a290143 Mon Sep 17 00:00:00 2001
From: Christophe Siraut d...@tobald.eu.org
Date: Wed, 5 Nov 2014 13:43:28 +0100
Subject: [PATCH] css: limit the linenumbers column width, closes: #764178
---
debsources/app/static/css/source_file.css | 4
1 file changed, 4 insertions(+)
diff --git a/debsources/app/static/css/source_file.css b/debsources/app/static/css/source_file.css
index 58328bc..c0f3575 100644
--- a/debsources/app/static/css/source_file.css
+++ b/debsources/app/static/css/source_file.css
@@ -18,6 +18,10 @@ License: GNU Affero General Public License, version 3 or above.
padding: 0px;
}
+#codetable td:first-child {
+width: 80px;
+}
+
/* CAPTION */
#file_metadata {
--
2.1.1
Bug#764178: debsources: infobox CSS alignment problem with short files
Hey Christophe On 05/11/14 07:51 AM, Christophe Siraut wrote: Hi, My commit adds a padding-right to make sure that even if the file has one short line, it's content will be left-aligned. We could instead limit the expansion of the first column, which contains the line numbers, see attachment. Looks like that's a better solution ! I had tested with max-width, it didn't work for me. Should have tested with a simple width :) Thanks Cheers, Christophe -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/545a271b.1060...@jpleau.ca
Bug#764178: marked as done (debsources: infobox CSS alignment problem with short files)
Your message dated Wed, 5 Nov 2014 15:13:02 +0100 with message-id 20141105141302.ga5...@upsilon.cc and subject line Re: Bug#764178: debsources: infobox CSS alignment problem with short files has caused the Debian Bug report #764178, regarding debsources: infobox CSS alignment problem with short files to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 764178: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764178 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: qa.debian.org Severity: minor User: qa.debian@packages.debian.org Usertags: debsources On Mon, Oct 06, 2014 at 09:21:34AM +0200, Ferenc Wagner wrote: Your wonderful service seems to have alignment issues displaying short files. In the attached screenshot, the file contents (9) is pushed so far to the right that it overlaps with the info box. Please consider fixing this. Thanks Ferenc, I'm forwarding your message to the Debian bug tracking system, so that we don't lose track of your (very reasonable!) request. I suspect the reasonable behavior here would be to ensure that the CSS box showing the file content is always large enough to contain the package info box --- no matter if the infobox is expanded or not, and no matter the amount of lines in the file. Patches from CSS-skilled people that implement such a behavior would be very welcome! Cheers. -- Stefano Zacchiroli . . . . . . . z...@upsilon.cc . . . . o . . . o . o Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o Former Debian Project Leader . . @zack on identi.ca . . o o o . . . o . « the first rule of tautology club is the first rule of tautology club » ---End Message--- ---BeginMessage--- On Wed, Nov 05, 2014 at 08:33:15AM -0500, Jason Pleau wrote: On 05/11/14 07:51 AM, Christophe Siraut wrote: We could instead limit the expansion of the first column, which contains the line numbers, see attachment. Looks like that's a better solution ! I had tested with max-width, it didn't work for me. Should have tested with a simple width :) Thanks Christophe for your solution, and Jason for your help in debugging this matter. I've locally committed the attached patch and I'm going to push soon unless you've further comments. Please note that I've reduced the width to 60px, as that seems to be enough for line numbers in the 10k range, and doesn't look as bad as 80px on small line numbers. If you think that's a problem, please shout :-) Cheers. -- Stefano Zacchiroli . . . . . . . z...@upsilon.cc . . . . o . . . o . o Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o Former Debian Project Leader . . @zack on identi.ca . . o o o . . . o . « the first rule of tautology club is the first rule of tautology club »---End Message---
