Bug#457169: patch for qa.debian.org
On Fri, Dec 21, 2007 at 04:50:31PM +0100, Yves-Alexis Perez wrote: The simple patch attached fixes the problem on high dpi displays and looks good on a 96 dpi one. I guess removing all fonts: ##pt (and maybe replace them with a px one) would help but I don't know enough css/designing. No, sorry, this is not an acceptable patch (at least not by me), this is the removal of the current font size choices which, if it is one, is a different bug than that related to this bugreport. A patch for this bug would be changing the font sizes so that they use relative units instead of absolute ones (as you suggest in the end of your last message) preserving the current look and feel. The tricky part of doing that is that according to my tests em units are not cross-browsers compatible: I've tried with epiphany and firefox when the font size choices where in em and the pages looked remarkably different. It is possible that there were issues elsewhere though ... Cheers. -- Stefano Zacchiroli -*- PhD in Computer Science ... now what? [EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/ (15:56:48) Zack: e la demo dema ?/\All one has to do is hit the (15:57:15) Bac: no, la demo scema\/right keys at the right time signature.asc Description: Digital signature
Bug#457169: patch for qa.debian.org
On la, 2007-12-22 at 12:48 +0100, Stefano Zacchiroli wrote:
A patch for this bug would be changing the font sizes so that they use
relative units instead of absolute ones (as you suggest in the end of
your last message) preserving the current look and feel.
Attached is a patch that attempts to make all font sizes relative to the
browser's default base font size (which is what the user can be expected
to have chosen to suit their particular needs).
The tricky part
of doing that is that according to my tests em units are not
cross-browsers compatible
They are compatible, but they do not guarantee identical rendering in
different browsers. Neither do absolute font size units. It is almost
impossible to get exactly the same looks with every browser. Nor should
that be a goal for a functional site such as the PTS (as opposed to a
site that is a replacement for paper ads).
For example, different browsers might have different font configurations
(different base font size, different restrictions on minimum font size),
or they might be using different fonts, or different versions of the the
font libraries, or different widget libraries, all of which may result
in text being rendered differently.
--- revamp.css 2007-12-22 14:57:00.0 +0200
+++ revamp.css.new 2007-12-22 14:51:32.0 +0200
@@ -13,7 +13,7 @@
font-family: DejaVu Sans, Bitstream Vera Sans, sans-serif; /*Prefer Free Fonts*/
background: #fff url('debian.png') no-repeat 18px 7px;
color: #000;
-font-size: 11pt;
+font-size: 110%;
}
a:link{ color: #0755d7; text-decoration: underline; }
@@ -27,7 +27,7 @@
/* --- Header --- */
body form { /* Jump to package */
margin: 0.3em;
-font-size: 10pt;
+font-size: 100%;
padding: 0.5em;
border: 1px solid #aaa;
background-color: #dfdfdf;
@@ -36,7 +36,7 @@
h1 {
margin: 0 0 0 0;
padding: 20px 0 0 220px;
-font-size: 18pt;
+font-size: 180%;
min-height: 60px;
height: auto !important; /* Min-Height Fast Hack */
height: 60px;
@@ -73,7 +73,7 @@
td.titlecell {
padding: 0.2em 0.2em 0.1em 0.2em;
font-weight: bold;
-font-size: 12pt;
+font-size: 120%;
background: #d70751;
color: #fff;
border-top: 3px solid #999;
@@ -99,10 +99,10 @@
}
/* - Edge Tables - */
-tr#bugs_rc { font-size: 9pt; }
-tr#bugs_in { font-size: 9pt; }
-tr#bugs_mw { font-size: 9pt; }
-tr#bugs_fp { font-size: 9pt; }
+tr#bugs_rc { font-size: 90%; }
+tr#bugs_in { font-size: 90%; }
+tr#bugs_mw { font-size: 90%; }
+tr#bugs_fp { font-size: 90%; }
span.indented { padding-left: 1.5em; }
td form { margin: 0.4em 0 0.4em 0.4em; padding: 0; } /* PTS subscribe */
@@ -146,7 +146,7 @@
border-color: #fc9 #630 #330 #f96 !important;
padding: 0 3px!important;
font-weight: bold !important;
-font-size: 8pt!important;
+font-size: 80%!important;
text-decoration: none !important;
vertical-align: 0.2em !important;
/* Without !important, inherets from td.titlecell a:* */
Bug#457169: patch for qa.debian.org
Package: qa.debian.org
Followup-For: Bug #457169
The simple patch attached fixes the problem on high dpi displays and looks
good on a 96 dpi one. I guess removing all fonts: ##pt (and maybe replace them
with a px one) would help but I don't know enough css/designing.
Cheers,
--
Yves-Alexis Perez
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.24-rc6 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--- revamp2.css 2007-12-21 16:41:21.0 +0100
+++ revamp.css 2007-12-21 16:48:47.0 +0100
@@ -13,7 +13,6 @@
font-family: DejaVu Sans, Bitstream Vera Sans, sans-serif; /*Prefer Free Fonts*/
background: #fff url('debian.png') no-repeat 18px 7px;
color: #000;
-font-size: 11pt;
}
a:link{ color: #0755d7; text-decoration: underline; }
@@ -27,7 +26,6 @@
/* --- Header --- */
body form { /* Jump to package */
margin: 0.3em;
-font-size: 10pt;
padding: 0.5em;
border: 1px solid #aaa;
background-color: #dfdfdf;
Bug#457169: patch for qa.debian.org
On pe, 2007-12-21 at 16:50 +0100, Yves-Alexis Perez wrote: Package: qa.debian.org Followup-For: Bug #457169 The simple patch attached fixes the problem on high dpi displays and looks good on a 96 dpi one. I guess removing all fonts: ##pt (and maybe replace them with a px one) would help but I don't know enough css/designing. Both pt and px are, essentially, absolute sizes, and as such inappropriate for some (possibly most) people. Not specifying the base font size at all, and making all other font sizes relative to the base font size (font-size: 120% for example) should work fine for most people. Thanks for the patch. I meant to look at how big changes were needed and submit a similar patch, and you saved me the effort! Now let's hope it gets accepted. :) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
