Re: PTS: revamp style
On Mon, 27 May 2013, Paul Wise wrote: On Sun, May 26, 2013 at 10:06 PM, David Suárez wrote: I revamped a litle the main css theme of the PTS. Look preview at [1]. Unfortunately both of these URLs just give me some PHP errors. Could you attach a patch or new CSS file instead? I saw them before the error appeared: http://awesomescreenshot.com/01e1blyxfc http://awesomescreenshot.com/0dc1blz4e2 I do an alternate version with the subscription box at the page header, like bug #704102 suggests. Reach it at [2]. I asked about this on IRC a while ago since it is a fairly subjective thing. The majority of Debian contributors who responded were against moving it to the top. I think contributors who are already subscribed prefer to have it at the bottom, it's less distracting. On the other hand, I prefer to have it at the top because it means more people will subscribe to packages and the more eyes, the better. Even better would be to not have it so big and have only a Subscribe button that direct non-JS users to some external CGI while JS users have an embedded windown where they can complete the same form. But David, as you saw, your CSS for the form at the top has some problems with my Iceweasel (unless it's a cache issue, but I can't verify this now). Cheers, -- Raphaël Hertzog ◈ Debian Developer Get the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130527062605.gb10...@x230-buxy.home.ouaza.com
Re: PTS: revamp style
2013/5/27 Raphael Hertzog hert...@debian.org On Mon, 27 May 2013, Paul Wise wrote: On Sun, May 26, 2013 at 10:06 PM, David Suárez wrote: I revamped a litle the main css theme of the PTS. Look preview at [1]. Unfortunately both of these URLs just give me some PHP errors. Could you attach a patch or new CSS file instead? I saw them before the error appeared: http://awesomescreenshot.com/01e1blyxfc http://awesomescreenshot.com/0dc1blz4e2 Thanks Raphael, this is the price for free web hosting. I do an alternate version with the subscription box at the page header, like bug #704102 suggests. Reach it at [2]. I asked about this on IRC a while ago since it is a fairly subjective thing. The majority of Debian contributors who responded were against moving it to the top. I think contributors who are already subscribed prefer to have it at the bottom, it's less distracting. On the other hand, I prefer to have it at the top because it means more people will subscribe to packages and the more eyes, the better. Even better would be to not have it so big and have only a Subscribe button that direct non-JS users to some external CGI while JS users have an embedded windown where they can complete the same form. For me sounds good. But David, as you saw, your CSS for the form at the top has some problems with my Iceweasel (unless it's a cache issue, but I can't verify this now). Yes, its only a preview. I didn`t know if the change would be accepted or not and I didnt test it in other browsers. Sorry for that. So at the moment I prefer to wait, and if the changes looks good for people and i will work more on this later. Thanks, David
Re: PTS: revamp style
Hi,
On Lunes, 27 de mayo de 2013 06:57:59 Paul Wise escribió:
Unfortunately both of these URLs just give me some PHP errors. Could
you attach a patch or new CSS file instead?
Done.
Thanks,
David
Index: www/web/common/revamp.css
===
--- www/web/common/revamp.css (revisión: 3014)
+++ www/web/common/revamp.css (copia de trabajo)
@@ -16,10 +16,10 @@
font-size: 100%;
}
-a:link{ color: #0755d7; text-decoration: none; }
-a:visited { color: #0755d7; text-decoration: none; }
-a:hover { color: #0755d7; text-decoration: underline; }
-a:active { color: #f00;text-decoration: none; }
+a:link{ color: #005090; text-decoration: none; font-weight: bold; }
+a:visited { color: #005090; text-decoration: none; font-weight: bold; }
+a:hover { color: #D70767; text-decoration: none; font-weight: bold; }
+a:active { color: #f00;text-decoration: none; font-weight: bold; }
a img { border: none; }
.containertable { width: 100%; }
@@ -33,13 +33,21 @@
background-color: #dfdfdf;
}
.quickform { /* Jump to package */
-margin: 0.3em;
+margin: -0.3em 0.5em;
font-size: 80%;
padding: 0.5em;
border: 1px solid #aaa;
background-color: #dfdfdf;
}
+.quickformline {
+}
+
+.quickform:first-child input:first-child
+{
+margin-bottom: 0.2em;
+}
+
h1 {
margin: 10px 0 0 0;
padding: 20px 0 0 280px;
@@ -65,17 +73,18 @@
}
div.left { width: 26%; }
div.center {
-width: 56%;
+width: 52%;
padding-left: 2px;
padding-right: 2px;
}
-div.right { width: 16%; }
+div.right { width: 20%; }
div.block {
+background: none repeat scroll 0 0 #FF;
+border: 1px solid #99;
border-collapse: collapse;
-border: 1px solid #999;
-background: #fff;
-margin-bottom: 10px;
+margin-bottom: 0.2em;
+padding: 0.4em 0.6em 0.2em;
}
h1 {
@@ -89,15 +98,13 @@
}
h2 {
-padding: 0.2em 0.2em 0.1em 0.2em;
+background: none repeat scroll 0 0 #D70767;
+border-bottom: 1px solid #FF;
+color: #FF;
+font-size: 100%;
font-weight: bold;
-font-size: 100%;
-background: #d70751;
-color: #fff;
-border-top: 3px solid #999;
-border-bottom: 1px solid #999;
-margin-top: 0pt;
-margin-bottom: 0pt;
+margin: 0 -0.2em 0.2em;
+padding: 0.2em 0.4em;
}
dl {
@@ -117,17 +124,19 @@
}
div.binaries ul {
-max-height: 25em;
+max-height: 14.2em;
overflow: auto;
}
/* different margins are required for different dl's */
div.info dt { width: 5.5em; }
div.info dd { margin-left: 5.7em; }
-div.versions dt { width: 7.4em; }
-div.versions dd { margin-left: 7.6em; }
+div.versions dt { width: 6.4em; }
+div.versions dd { margin-left: 6.6em; }
div.bugs dt { width: 4em; }
div.bugs dd { margin-left: 4.2em; }
+div.patch-tracker dt { width: 6.4em; }
+div.patch-tracker dd { margin-left: 6.6em; }
/* - Edge Tables - */
tr#bugs_rc { font-size: 90%; }
@@ -155,7 +164,7 @@
background-color: #fff;
text-align: center;
border-top: 2px solid #d70751;
-margin: 0 0 0 0;
+margin: 1em 0 0 0;
border-bottom: 0;
font-size: small;
}
Re: PTS: revamp style
On Mon, May 27, 2013 at 06:12:04PM +0200, David Suárez wrote:
On Lunes, 27 de mayo de 2013 06:57:59 Paul Wise escribió:
Unfortunately both of these URLs just give me some PHP errors. Could
you attach a patch or new CSS file instead?
Done.
Hey David, thanks for your proposed changes.
-a:link{ color: #0755d7; text-decoration: none; }
-a:visited { color: #0755d7; text-decoration: none; }
-a:hover { color: #0755d7; text-decoration: underline; }
-a:active { color: #f00;text-decoration: none; }
+a:link{ color: #005090; text-decoration: none; font-weight: bold; }
+a:visited { color: #005090; text-decoration: none; font-weight: bold; }
+a:hover { color: #D70767; text-decoration: none; font-weight: bold; }
+a:active { color: #f00;text-decoration: none; font-weight: bold; }
I've some comments about this. Personally, I think your example uses
bold typefaces way too much. Bold typefaces should be used sparingly, to
highlight important stuff, not as a de facto default to typeset all the
informative content of a page. That is, in fact, the first thing that
caught my eye when looking at the page you posted here for comments.
Can you please reconsider the use of bold typefaces?
(I haven't yet looked much at the other changes you propose, so I can't
comment on them ATM.)
Cheers.
--
Stefano Zacchiroli . . . . . . . z...@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »
signature.asc
Description: Digital signature
Re: PTS: revamp style
Hi, Alternate version with the subscription box at the page header, like bug #704102 suggests: http://awesomescreenshot.com/0281bp59b6 Thanks, David -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201305271859.34539.david.sephi...@gmail.com
Re: PTS: revamp style
On Lunes, 27 de mayo de 2013 18:19:16 Stefano Zacchiroli escribió: I've some comments about this. Personally, I think your example uses bold typefaces way too much. Bold typefaces should be used sparingly, to highlight important stuff, not as a de facto default to typeset all the informative content of a page. That is, in fact, the first thing that caught my eye when looking at the page you posted here for comments. Can you please reconsider the use of bold typefaces? Yes, I upload a preview with the subscrition box at header and without bold typefaces. (I haven't yet looked much at the other changes you propose, so I can't comment on them ATM.) About the subscrition box I like the idea Raphael proposed later. I have to look at it (I never done cgi stuff). Thanks, David -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201305271911.19284.david.sephi...@gmail.com
Re: PTS: revamp style
On Tue, May 28, 2013 at 12:12 AM, David Suárez wrote: Done. Those of you who want to take a look at the result in your browser can compare it here: http://packages.qa.debian.org/~pabs/n/nsis.html http://packages.qa.debian.org/n/nsis.html My thoughts: You added a significant amount of whitespace. The PTS is fairly space-starved, I suggest not doing that. I agree with Stefano about the use of bold. I wonder if unifying the CSS/design with the main website would be good. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6EBU=xYd8+OKX-FDY72UkOUBZgUZDB46FrgBJQ8u=g...@mail.gmail.com
PTS: revamp style
Hi, I revamped a litle the main css theme of the PTS. Look preview at [1]. I do an alternate version with the subscription box at the page header, like bug #704102 suggests. Reach it at [2]. Let me know what do you think about. Thanks, David [1] http://deiv.site90.net/gcc-defaults.html [2] http://deiv.site90.net/driftnet.html -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201305261606.21260.david.sephi...@gmail.com
Re: PTS: revamp style
On Sun, May 26, 2013 at 10:06 PM, David Suárez wrote: I revamped a litle the main css theme of the PTS. Look preview at [1]. Unfortunately both of these URLs just give me some PHP errors. Could you attach a patch or new CSS file instead? I do an alternate version with the subscription box at the page header, like bug #704102 suggests. Reach it at [2]. I asked about this on IRC a while ago since it is a fairly subjective thing. The majority of Debian contributors who responded were against moving it to the top. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-qa-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6FgSi+Dqyq3aCj=znnHdrLE+JMdHXf=KvYr=qrlzwt...@mail.gmail.com
