Bug#170871: (no subject)
Quoting Colin Watson <[EMAIL PROTECTED]>:
> QA had nothing to do with it; I didn't touch this part of the code when
> I did the recent QA upload of xmms-nas, I just didn't notice that it was
> there.
Hmm, then it might have been an earlier update. Sorry for falsely accusing QA!
> > added else to otherwise just use the string inserted :)
>
> > --- xmms-nas-0.2/nasconf.c 2002-12-03 23:12:38.0 +
> > +++ xmms-new/nasconf.c 2002-12-03 23:06:00.0 +
> > @@ -43,6 +43,9 @@
> >
> > if (getenv("AUDIOHOST") &&
> g_strcasecmp(nas_cfg.server,getenv("AUDIOHOST")))
> > xmms_cfg_write_string(cfgfile, "NAS", "server", nas_cfg.server);
> > + else if (g_strcasecmp(nas_cfg.server,"") != 0)
> > + xmms_cfg_write_string(cfgfile, "NAS", "server", nas_cfg.server);
> > +
> > xmms_cfg_write_int(cfgfile, "NAS", "buffer_size", nas_cfg.bufsize);
> > xmms_cfg_write_file(cfgfile, filename);
> > xmms_cfg_free(cfgfile);
>
> Thanks for the patch. Wouldn't it be better to say something more like:
>
> if (g_strcasecmp(nas_cfg.server,
>getenv("AUDIOHOST") ? getenv("AUDIOHOST") : ""))
>
> (or a variant with less duplication)? That seems to be closer to the
> intent of the original code, i.e. don't save nas_cfg.server if it's
> equal to the value of $AUDIOHOST.
Sure, it was just a (very bad) example of how to fix it. Be my guest to
implement a more sane patch :)
Cheers, and thanks for looking into the bug,
Alex de Landgraaf
/'-'\
( o o )
oOO0--(_)--0OOo
Wouter Alexander de Landgraaf
Student AI & CS VU Amsterdam
Phone: 06-16844084
GPG: http://am.xs4all.nl/key_alex.asc
IRC: #debian/OPN, irc.xchat.org
.oooO
( ) Oooo.
--\ (( )--
\_)) /
(_/
Bug#170871: (no subject)
On Tue, Dec 03, 2002 at 11:34:13PM +0100, Alex de Landgraaf wrote:
> a patch for the recently uploaded xmms-nas package bug, hostname wasnt being
> saved.
> I guess QA wanted to use env settings to handle this?
QA had nothing to do with it; I didn't touch this part of the code when
I did the recent QA upload of xmms-nas, I just didn't notice that it was
there.
> added else to otherwise just use the string inserted :)
> --- xmms-nas-0.2/nasconf.c2002-12-03 23:12:38.0 +
> +++ xmms-new/nasconf.c2002-12-03 23:06:00.0 +
> @@ -43,6 +43,9 @@
>
> if (getenv("AUDIOHOST") &&
> g_strcasecmp(nas_cfg.server,getenv("AUDIOHOST")))
> xmms_cfg_write_string(cfgfile, "NAS", "server", nas_cfg.server);
> + else if (g_strcasecmp(nas_cfg.server,"") != 0)
> + xmms_cfg_write_string(cfgfile, "NAS", "server", nas_cfg.server);
> +
> xmms_cfg_write_int(cfgfile, "NAS", "buffer_size", nas_cfg.bufsize);
> xmms_cfg_write_file(cfgfile, filename);
> xmms_cfg_free(cfgfile);
Thanks for the patch. Wouldn't it be better to say something more like:
if (g_strcasecmp(nas_cfg.server,
getenv("AUDIOHOST") ? getenv("AUDIOHOST") : ""))
(or a variant with less duplication)? That seems to be closer to the
intent of the original code, i.e. don't save nas_cfg.server if it's
equal to the value of $AUDIOHOST.
Cheers,
--
Colin Watson [EMAIL PROTECTED]
Processed: feature request
Processing commands for [EMAIL PROTECTED]: > severity 167204 wishlist Bug#167204: Support other charsets (possibly Unicode) Severity set to `wishlist'. > thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Bug#166738: FTBFS with gcc 3.2
On Mon, Oct 28, 2002 at 07:42:15AM +0100, Gerhard Tonn wrote:
> Package: korelib
> Version: 0.0.1-9
> Severity: important
>
> Hi,
> the package get at least the following compile errors
>
> c++ -I. -I. -I.. -I../include -g -O2 -Wall -Wp,-MD,.deps/kernel.pp -c -fPIC
> -DPIC kernel.cpp -o .libs/kernel.lo
> In file included from kernel.cpp:4:
> ../include/kore/servicemanager.h:199: `hash' was not declared in this scope
> ../include/kore/servicemanager.h:199: parse error before `char'
> ../include/kore/servicemanager.h:212: 'srv_hash_type' is used as a type, but
> is not defined as a type.
A patch for this follows (lifted largely from the libstdc++
documentation on accessing extensions); with it, korelib builds cleanly
using g++ 3.2.
However, libkore0's only dependent is aethera, which is part of the qt2
dependency chain. As a result, this can't be uploaded until KDE3 is in
the archive and unless a KDE3 version of aethera is available.
--- korelib-0.0.1.orig/include/kore/servicemanager.h
+++ korelib-0.0.1/include/kore/servicemanager.h
@@ -7,9 +7,15 @@
#include
#else
#if (__GNUC__<3)
-#include
+# include
+ namespace Sgi { using ::hash_map; }; // inherit globals
#else
-#include
+# include
+# if __GNUC_MINOR__ == 0
+ namespace Sgi = std;// GCC 3.0
+# else
+ namespace Sgi = ::__gnu_cxx;// GCC 3.1 and later
+# endif
#endif
#endif
#include
@@ -196,7 +202,7 @@
return strcmp(s1,s2) == 0;
}
};
-typedef hash_multimap,
eqstr> srv_hash_type;
+typedef Sgi::hash_multimap, eqstr> srv_hash_type;
#endif
struct ltptr
{
Cheers,
--
Colin Watson [EMAIL PROTECTED]
Bug#176280: cxhextris: launching cxhextris crashes panel
Package: cxhextris Version: 1.0-22 Severity: normal Launching cxhextris from the gnome launcher panel crashes the panel. Other applications launched this way do not crash panel. -- System Information: Debian Release: testing/unstable Architecture: i386 Kernel: Linux synergy 2.4.18 #1 Wed Aug 7 06:05:11 CDT 2002 i686 Locale: LANG=C, LC_CTYPE= Versions of packages cxhextris depends on: ii debconf 1.2.20 Debian configuration management sy ii libc6 2.2.5-14.3 GNU C Library: Shared libraries an ii xlibs 4.2.1-3X Window System client libraries -- debconf information: cxhextris/move_scorefile: true
Bug#173558: marked as done (libcomprex_0.3.2-4(mipsel/unstable): out of date config.guess/config.sub)
Your message dated Sat, 11 Jan 2003 10:32:44 -0500 with message-id <[EMAIL PROTECTED]> and subject line Bug#173558: fixed in libcomprex 0.3.2-5 has caused the attached Bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database) -- Received: (at submit) by bugs.debian.org; 18 Dec 2002 13:45:12 + >From [EMAIL PROTECTED] Wed Dec 18 07:45:12 2002 Return-path: <[EMAIL PROTECTED]> Received: from h24-83-208-253.sbm.shawcable.net (straylight.cyberhqz.com) [24.83.208.253] (postfix) by master.debian.org with esmtp (Exim 3.12 1 (Debian)) id 18OeVb-0005Ls-00; Wed, 18 Dec 2002 07:45:11 -0600 Received: by straylight.cyberhqz.com (Postfix, from userid 1000) id A523F54004; Wed, 18 Dec 2002 05:45:10 -0800 (PST) Date: Wed, 18 Dec 2002 05:45:10 -0800 To: [EMAIL PROTECTED] Subject: libcomprex_0.3.2-4(mipsel/unstable): out of date config.guess/config.sub Message-ID: <[EMAIL PROTECTED]> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.28i From: [EMAIL PROTECTED] (Ryan Murray) Delivered-To: [EMAIL PROTECTED] X-Spam-Status: No, hits=-8.1 required=5.0 tests=QUOTED_EMAIL_TEXT,SPAM_PHRASE_00_01,USER_AGENT, USER_AGENT_MUTT version=2.41 X-Spam-Level: Package: libcomprex Version: 0.3.2-4 Severity: serious There was an error while trying to autobuild your package: > Automatic build of libcomprex_0.3.2-4 on repeat.rfc822.org by sbuild/mipsel > 1.169 > Build started at 20021218-0134 [...] > ** Using build dependencies supplied by package: > Build-Depends: gettext, libltdl3-dev, debhelper (>> 3.0.0), libbz2-dev (>> > 1.0), zlib1g-dev (>> 1.1.3), libcurl-dev (>> 7.9.8) [...] > The following central src deps are (probably) missing: > libcurl2-dev (>= 7.9.8-1) [...] > /bin/uname -X = > > hostinfo = > /bin/universe = > /usr/bin/arch -k = > /bin/arch = mips > /usr/bin/oslevel = > /usr/convex/getsysinfo = > > UNAME_MACHINE = mips > UNAME_RELEASE = 2.4.20-pre6 > UNAME_SYSTEM = Linux > UNAME_VERSION = #2 Tue Oct 22 12:27:33 CEST 2002 > configure: error: can not guess host type; you must specify one > make: *** [configure-stamp] Error 1 A full build log can be found at: http://buildd.debian.org/build.php?arch=mipsel&pkg=libcomprex&ver=0.3.2-4 The versions of config.guess and config.sub in this source package are too old to correctly support the Debian mips and mipsel architectures. A version is needed from this year, which is available in the autotools-dev packages that are in current woody, sarge, and sid. --- Received: (at 173558-close) by bugs.debian.org; 11 Jan 2003 15:36:10 + >From [EMAIL PROTECTED] Sat Jan 11 09:36:09 2003 Return-path: <[EMAIL PROTECTED]> Received: from auric.debian.org [206.246.226.45] (mail) by master.debian.org with esmtp (Exim 3.12 1 (Debian)) id 18XNg9-0005T6-00; Sat, 11 Jan 2003 09:36:09 -0600 Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian)) id 18XNcq-0007NM-00; Sat, 11 Jan 2003 10:32:44 -0500 From: Colin Watson <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] X-Katie: $Revision: 1.29 $ Subject: Bug#173558: fixed in libcomprex 0.3.2-5 Message-Id: <[EMAIL PROTECTED]> Sender: Archive Administrator <[EMAIL PROTECTED]> Date: Sat, 11 Jan 2003 10:32:44 -0500 Delivered-To: [EMAIL PROTECTED] We believe that the bug you reported is fixed in the latest version of libcomprex, which is due to be installed in the Debian FTP archive: libcomprex-dev_0.3.2-5_i386.deb to pool/main/libc/libcomprex/libcomprex-dev_0.3.2-5_i386.deb libcomprex3_0.3.2-5_i386.deb to pool/main/libc/libcomprex/libcomprex3_0.3.2-5_i386.deb libcomprex_0.3.2-5.diff.gz to pool/main/libc/libcomprex/libcomprex_0.3.2-5.diff.gz libcomprex_0.3.2-5.dsc to pool/main/libc/libcomprex/libcomprex_0.3.2-5.dsc A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Colin Watson <[EMAIL PROTECTED]> (supplier of updated libcomprex package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.
libcomprex_0.3.2-5_i386.changes ACCEPTED
Accepted: libcomprex-dev_0.3.2-5_i386.deb to pool/main/libc/libcomprex/libcomprex-dev_0.3.2-5_i386.deb libcomprex3_0.3.2-5_i386.deb to pool/main/libc/libcomprex/libcomprex3_0.3.2-5_i386.deb libcomprex_0.3.2-5.diff.gz to pool/main/libc/libcomprex/libcomprex_0.3.2-5.diff.gz libcomprex_0.3.2-5.dsc to pool/main/libc/libcomprex/libcomprex_0.3.2-5.dsc Announcing to debian-devel-changes@lists.debian.org Closing bugs: 173558 Thank you for your contribution to Debian.
peruser_4b33-11_i386.changes ACCEPTED
Accepted: peruser_4b33-11.diff.gz to pool/main/p/peruser/peruser_4b33-11.diff.gz peruser_4b33-11.dsc to pool/main/p/peruser/peruser_4b33-11.dsc peruser_4b33-11_i386.deb to pool/main/p/peruser/peruser_4b33-11_i386.deb Announcing to debian-devel-changes@lists.debian.org Thank you for your contribution to Debian.
