Processed: Bug#798249 marked as pending
Processing commands for cont...@bugs.debian.org: > tag 798249 pending Bug #798249 [mudita24] mudita24 - update for debian/* Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 798249: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798249 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug#816827 marked as pending
Processing commands for cont...@bugs.debian.org: > tag 816827 pending Bug #816827 [mudita24] Mudita24 - upstream location change Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 816827: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=816827 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#818907: live-build: Fails to integrate a binary package whose name contains an uppercase character
Package: live-build Version: 1:20151215 Severity: normal User: de...@kali.org Usertags: origin-kali If you download a Nessus deb from here: https://www.tenable.com/products/nessus/select-your-operating-system You get a Nessus-6.5.6-debian6_amd64.deb file for a "Nessus" package. Note the uppercase N in the package name... (both in the filename and in the .deb meta-data shown with dpkg -I) Put that file in config/packages.chroot/ and try a live-build, you will get an error like this: [2016-03-19 19:50:13] lb chroot_install-packages install P: Begin installing packages (install pass)... Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package Nessus P: Begin unmounting filesystems... P: Saving caches... Reading package lists... Building dependency tree... Reading state information... -- Package-specific info: -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages live-build depends on: ii debootstrap 1.0.79 Versions of packages live-build recommends: ii apt-utils 1.2.7 ii cpio2.11+dfsg-5 ii live-boot-doc 1:20151213 ii live-config-doc 5.20151121 ii live-manual-html [live-manual] 2:20151217 ii wget1.17.1-1+b1 Versions of packages live-build suggests: ii debian-keyring 2016.01.20 ii gpgv1.4.20-4 -- no debconf information
Bug#818907: live-build: Fails to integrate a binary package whose name contains an uppercase character
Hi, I am not involved in live-build, but: On Mon, Mar 21, 2016 at 04:41:18PM +0100, Raphaël Hertzog wrote: > If you download a Nessus deb from here: > https://www.tenable.com/products/nessus/select-your-operating-system > > You get a Nessus-6.5.6-debian6_amd64.deb file for a "Nessus" package. > Note the uppercase N in the package name... (both in the filename and > in the .deb meta-data shown with dpkg -I) Which is broken. https://www.debian.org/doc/debian-policy/ch-binary.html#s3.1 points to https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Package which points to https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Source which says "Package names (both source and binary, see Package, Section 5.6.7) must consist only of lower case letters (a-z), digits (0-9), plus (+) and minus (-) signs, and periods (.). They must be at least two characters long and must start with an alphanumeric character." I don't think it is a bug if one can't handle a broken package. > Put that file in config/packages.chroot/ and try a live-build, you will > get an error like this: > [2016-03-19 19:50:13] lb chroot_install-packages install > P: Begin installing packages (install pass)... > Reading package lists... > Building dependency tree... > Reading state information... > E: Unable to locate package Nessus And isn't this apt/aptitude here, anyways? So it would be apt/aptitude "bug"? Regards, Rene
Bug#818907: live-build: Fails to integrate a binary package whose name contains an uppercase character
On Mon, 21 Mar 2016, Rene Engelhard wrote: > Which is broken. It's not broken (the package works) but it doesn't conform to the Debian policy, certainly. > I don't think it is a bug if one can't handle a broken package. I think it's a bug, albeit a minor one. If there was a technical reason to not create such packages, dpkg would not allow to create such packages. > And isn't this apt/aptitude here, anyways? So it would be apt/aptitude "bug"? I have not investigated further so I don't know. It might be live-build which is not copying the files properly, it might be apt-ftparchive which is not generating the Packages file correctly or it might be apt-get not finding the package. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Bug#818916: live-build: Wrong version extracted from os-release in binary-syslinux
Package: live-build
Version: 5.0~a11-1
Severity: minor
Dear Maintainer,
* What led up to the situation?
I was trying to use @VERSION@ string in splash.svg.
* What exactly did you do (or not do) that was effective (or
ineffective)?
I used @VERSION@ string in splash.svg.
* What was the outcome of this action?
@VERSION@ was replaced by: 5.0~a11-1 which it's the live-build package
version.
* What outcome did you expect instead?
@VERSION@ should have been replaced by: 8 (The version read from
os-release for
my build) which it's the distro, in this case Debian, version.
Additional information. I attach a trivial patch which solves the problem.
-- System Information:
Debian Release: 8.2
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
>From b516d2defaeda72a03400dbd1a17b91d6bca7e31 Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 21 Mar 2016 18:44:38 +0100
Subject: [PATCH] @VERSION@ now its equal to VERSION_ID variable. Fixes a typo.
---
scripts/build/binary_syslinux | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/build/binary_syslinux b/scripts/build/binary_syslinux
index 024b563..66c14a0 100755
--- a/scripts/build/binary_syslinux
+++ b/scripts/build/binary_syslinux
@@ -248,7 +248,7 @@ then
_VERSION="$(. chroot/etc/os-release && echo ${VERSION_ID})"
fi
-_VERSION="${VERSION:-none}"
+_VERSION="${_VERSION:-none}"
_DISTRIBUTION="${LB_DISTRIBUTION}"
_ARCHITECTURE="${LB_ARCHITECTURES}"
--
2.1.4
Processing of piespy_0.4.0-4_source.changes
piespy_0.4.0-4_source.changes uploaded successfully to ftp-master.debian.org along with the files: piespy_0.4.0-4.dsc piespy_0.4.0-4.debian.tar.xz Greetings, Your Debian queue daemon (running on host coccia.debian.org)
Bug#814180: marked as done (piespy: (Build-)Depends on OpenJDK 7)
Your message dated Mon, 21 Mar 2016 19:20:19 + with message-id and subject line Bug#814180: fixed in piespy 0.4.0-4 has caused the Debian Bug report #814180, regarding piespy: (Build-)Depends on OpenJDK 7 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 814180: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=814180 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: src:piespy Version: 0.4.0-3 Severity: serious User: debian-j...@lists.debian.org Usertags: openjdk-8-transition The package build-depends or depends one an openjdk-7-* package, which is scheduled for removal for stretch. Please do not depend on a specific openjdk version, but on one of the default-java, default-java-headless or default-jdk packages instead. default-java defaulting to openjdk-8 on most architectures is now available in unstable. --- End Message --- --- Begin Message --- Source: piespy Source-Version: 0.4.0-4 We believe that the bug you reported is fixed in the latest version of piespy, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 814...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Markus Koschany (supplier of updated piespy package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Mon, 21 Mar 2016 19:24:47 +0100 Source: piespy Binary: piespy Architecture: source Version: 0.4.0-4 Distribution: unstable Urgency: medium Maintainer: Debian QA Group Changed-By: Markus Koschany Description: piespy - IRC bot to visualize social networks Closes: 814180 Changes: piespy (0.4.0-4) unstable; urgency=medium . * QA upload. * Declare compliance with Debian Policy 3.9.7. * Switch to source format 3.0 (quilt). * wrap-and-sort -sa. * Depend on default-jre | java7-runtime instead of openjdk-7-jre. Thanks to Matthias Klose for the report. (Closes: #814180) * debian/watch: Use version=4. * Remove trailing whitespace. Replace TABS with spaces and remove boilerplate comment in debian/rules. * debian/rules: Build for Java version 6 and for maximum compatibility. Checksums-Sha1: 8573fcb1956fd31404b4f0bf4ffe6df92856d925 1853 piespy_0.4.0-4.dsc e8047cd81f03a879bf75c700c94b3c8e0ca641dd 4372 piespy_0.4.0-4.debian.tar.xz Checksums-Sha256: 65773a153e131aac6052d5a3d336ad6988aa15556e93747cf8f2410abfaf7c30 1853 piespy_0.4.0-4.dsc c200e3796e5f8518d8fb6bbc5f8039db4ea71bb35a90be7a3b25f24deb3ea1dd 4372 piespy_0.4.0-4.debian.tar.xz Files: 4bb5ffe76a1f1320c7f036f6ed75fe8f 1853 net extra piespy_0.4.0-4.dsc b22fd44d6ade1ba2afbafea4efacc337 4372 net extra piespy_0.4.0-4.debian.tar.xz -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQJ8BAEBCgBmBQJW8D9HXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE OUFEMTRCOTUxM0I1MUU0AAoJENmtFLlRO1HkgX8P/A8pJWm+kBzcNhuAy7eBqHCe OwI9YhU1aPLZv4t+nhHXXJKqukMx7yF3rTPkM6iefENBrp5KGUyx19ngMl/Ne6zG xT6+grapiCZcI8OBTfKZBFK99+Tnpd91mCVBLnrBflQdAdvZPOpzNRvjdXldG5ll 2Z1JkN8bxs9KVAB7zfXGpeKwSiPREaaIC37s4VPojZe3RakNXRLOHW6G0qOcRmcM cNb/yrxuX8mRyjTOrbPjE/BXXv0vQNCui2xevZVlqakX6KOu52gHu0k4Wxa14WtB kOlEUGg2Y87mj8/6q8rwHUjtmAKJLKFx0CYkVTXCbstB6RW34esvC3G5PrAmg0wV pXSn0Ing9E6eU6nldaJ8JfsyLPAPWfLfS9JJN33QYfBG/9IJrGURDUUvF5VU012d 5C/pl4ShT3w5a5y9338X4mw1VckgcBvo8j0iv0OZ0LDNhu+NC+Xd8821Pt+h7k7d NEm4BQ2SEKEO9TQ3ajblDoSlzBB88gf7K4qD1TgwmZzDNsRDGCuJT8zU3wMhTxvo P7CYUs8fvKlo5mlom+WqD24im6xvbqENFQOAu1yntMKRR0ZI43IcU+GLYN6XMti9 qyal5aBebQz9+Wiq+plFOu4A8PrmS/649uahPUx8C82gDwfM9n21QHtEvjuPRtbw /qEQXNIh60Sxx1IN1+wj =Wyev -END PGP SIGNATURE End Message ---
Processing of piespy_0.4.0-4_source.changes
piespy_0.4.0-4_source.changes uploaded successfully to localhost along with the files: piespy_0.4.0-4.dsc piespy_0.4.0-4.debian.tar.xz Greetings, Your Debian queue daemon (running on host franck.debian.org)
piespy_0.4.0-4_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Mon, 21 Mar 2016 19:24:47 +0100 Source: piespy Binary: piespy Architecture: source Version: 0.4.0-4 Distribution: unstable Urgency: medium Maintainer: Debian QA Group Changed-By: Markus Koschany Description: piespy - IRC bot to visualize social networks Closes: 814180 Changes: piespy (0.4.0-4) unstable; urgency=medium . * QA upload. * Declare compliance with Debian Policy 3.9.7. * Switch to source format 3.0 (quilt). * wrap-and-sort -sa. * Depend on default-jre | java7-runtime instead of openjdk-7-jre. Thanks to Matthias Klose for the report. (Closes: #814180) * debian/watch: Use version=4. * Remove trailing whitespace. Replace TABS with spaces and remove boilerplate comment in debian/rules. * debian/rules: Build for Java version 6 and for maximum compatibility. Checksums-Sha1: 8573fcb1956fd31404b4f0bf4ffe6df92856d925 1853 piespy_0.4.0-4.dsc e8047cd81f03a879bf75c700c94b3c8e0ca641dd 4372 piespy_0.4.0-4.debian.tar.xz Checksums-Sha256: 65773a153e131aac6052d5a3d336ad6988aa15556e93747cf8f2410abfaf7c30 1853 piespy_0.4.0-4.dsc c200e3796e5f8518d8fb6bbc5f8039db4ea71bb35a90be7a3b25f24deb3ea1dd 4372 piespy_0.4.0-4.debian.tar.xz Files: 4bb5ffe76a1f1320c7f036f6ed75fe8f 1853 net extra piespy_0.4.0-4.dsc b22fd44d6ade1ba2afbafea4efacc337 4372 net extra piespy_0.4.0-4.debian.tar.xz -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQJ8BAEBCgBmBQJW8D9HXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE OUFEMTRCOTUxM0I1MUU0AAoJENmtFLlRO1HkgX8P/A8pJWm+kBzcNhuAy7eBqHCe OwI9YhU1aPLZv4t+nhHXXJKqukMx7yF3rTPkM6iefENBrp5KGUyx19ngMl/Ne6zG xT6+grapiCZcI8OBTfKZBFK99+Tnpd91mCVBLnrBflQdAdvZPOpzNRvjdXldG5ll 2Z1JkN8bxs9KVAB7zfXGpeKwSiPREaaIC37s4VPojZe3RakNXRLOHW6G0qOcRmcM cNb/yrxuX8mRyjTOrbPjE/BXXv0vQNCui2xevZVlqakX6KOu52gHu0k4Wxa14WtB kOlEUGg2Y87mj8/6q8rwHUjtmAKJLKFx0CYkVTXCbstB6RW34esvC3G5PrAmg0wV pXSn0Ing9E6eU6nldaJ8JfsyLPAPWfLfS9JJN33QYfBG/9IJrGURDUUvF5VU012d 5C/pl4ShT3w5a5y9338X4mw1VckgcBvo8j0iv0OZ0LDNhu+NC+Xd8821Pt+h7k7d NEm4BQ2SEKEO9TQ3ajblDoSlzBB88gf7K4qD1TgwmZzDNsRDGCuJT8zU3wMhTxvo P7CYUs8fvKlo5mlom+WqD24im6xvbqENFQOAu1yntMKRR0ZI43IcU+GLYN6XMti9 qyal5aBebQz9+Wiq+plFOu4A8PrmS/649uahPUx8C82gDwfM9n21QHtEvjuPRtbw /qEQXNIh60Sxx1IN1+wj =Wyev -END PGP SIGNATURE- Thank you for your contribution to Debian.
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
This is my updated set of patches.
Changes since last set of patches:
* Renamed primary and secondary to first and extra terms.
* Forced insmod all_video command in grub.cfg to avoid problems in UEFI
mode.
* Minor changes
Rescatux 0.40b6 which I will release soon will feature this branch which
include these changes:
https://github.com/rescatux/live-build/tree/rescatux-0.40b6
.
The branch which include specifically the commits I attach here as
patches is:
https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_5
.
About the variable names issue: I think the new terms: first and extra
are ok because they are not implying some sort of rank while explaining
what's the difference between them. Also, notice, that these are
internal variables which final user of live-build does not see. I think
we should focus on other aspects of my patch if there are more problems
for it.
If you think that the way bootloaders is currently managed by live-build
is wrong please file up a new bug and send there your patch with your
improvements so that it's get discussed.
Then, if it gets approved I can improve my patch over yours.
My patch tries to make the minimum improvements so that other live-build
functionality does not get affected by it.
Let's please focus on getting this set of patches accepted. Don't get me
wrong I'm not asking for a carte blanche but, let's focus on other
aspects from the patch. (E.g. please test it on actual hardware, in your
distro builds, even if you don't use UEFI does the ISO boot as always in
BIOS mode?) And give us feedback on it.
Thank you.
adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
>From ff8206aea1985760dfea9ec94b93686a242f137e Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 18 Jan 2016 03:04:00 +
Subject: [PATCH 01/10] functions/default.sh : Define LB_PRIMARY_BOOTLOADER at
the Set_defaults function which it's the right place where to do it
---
functions/defaults.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/functions/defaults.sh b/functions/defaults.sh
index ddf4b19..334984f 100755
--- a/functions/defaults.sh
+++ b/functions/defaults.sh
@@ -537,6 +537,8 @@ Set_defaults ()
esac
fi
+ LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
+
# Setting checksums
case "${LB_MODE}" in
progress-linux)
@@ -845,9 +847,6 @@ Check_defaults ()
fi
fi
-
- LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
if [ "${LB_PRIMARY_BOOTLOADER}" = "syslinux" ]
then
# syslinux + fat or ntfs, or extlinux + ext[234] or btrfs
--
2.1.4
>From f895f653dffb614639fa37a318e62c51104a4b2d Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Wed, 20 Jan 2016 00:53:53 +0100
Subject: [PATCH 02/10] Remove repeated LB_PRIMARY_BOOTLOADER definition
---
scripts/build/binary_hdd | 2 --
scripts/build/binary_iso | 2 --
2 files changed, 4 deletions(-)
diff --git a/scripts/build/binary_hdd b/scripts/build/binary_hdd
index d0db382..0c9c5af 100755
--- a/scripts/build/binary_hdd
+++ b/scripts/build/binary_hdd
@@ -67,8 +67,6 @@ do
esac
done
-LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
case ${LB_PRIMARY_BOOTLOADER} in
syslinux)
case ${LB_BINARY_FILESYSTEM} in
diff --git a/scripts/build/binary_iso b/scripts/build/binary_iso
index d8b1553..67dfc85 100755
--- a/scripts/build/binary_iso
+++ b/scripts/build/binary_iso
@@ -107,8 +107,6 @@ then
XORRISO_OPTIONS="${XORRISO_OPTIONS} -V \"${LB_ISO_VOLUME}\""
fi
-LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
# Handle xorriso architecture specific options
case "${LB_PRIMARY_BOOTLOADER}" in
grub)
--
2.1.4
>From 9175a624b7d88bfea80448a5a1e6ac1b11d651aa Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 18 Jan 2016 03:07:48 +
Subject: [PATCH 03/10] * Added: functions/bootloaders.sh . It has new
bootloader functions that are heavily used in efi scenarios where a
bootloader can act as a primary or a secondary bootloader.
Since the introduction of the new switch:
--bootloaders
you can setup it like this:
--bootloaders=syslinux,grub-efi
.
This means that syslinux is the primary bootloader and grub-efi is the secondary bootloader.
* Added new bootloader functions: Check_Non_Primary_Bootloader and Check_Non_Secondary_Bootloader.
These functions let each one of the bootloaders abort the build because
they cannot perform a role either as a primary bootloader or as a secondary bootloader.
* Added bootloader functions: Check_Primary_Bootloader_Role, Check_Secondary_Bootloader_Role and Check_Any_Bootloader_Role
These functions let bootloaders to force their default role in a single line.
---
functions/bootloaders.sh | 128 +++
1 file changed, 128 insertions(+
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
Hello, On 21 March 2016 at 21:09, adrian15 wrote: > > The branch which include specifically the commits I attach here as patches > is: > > https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_5 > > . > > About the variable names issue: I think the new terms: first and extra are > ok because they are not implying some sort of rank while explaining what's > the difference between them. Also, notice, that these are internal variables > which final user of live-build does not see. I think we should focus on > other aspects of my patch if there are more problems for it. The problem is not with the name of the variable. The problem is that you use it at all. In most places when you check for primary or secondary bootloader you should just loop all bootloaders and check each. In fact, in the previous batch of patches I found no place where checking for primary or secondary bootloader made any sense. > > If you think that the way bootloaders is currently managed by live-build is > wrong please file up a new bug and send there your patch with your > improvements so that it's get discussed. The bootloader support in live-build is limited. With your patches it becomes wrong. eg. compatibility of bootloader with selected filesystem and image type is only checked for first bootloader and EFI support is added only when grub-efi extra bootloader but not when it is the first bootloader. This is not fixed by renaming the variables. Thanks Michal
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
El 21/03/16 a las 22:19, Michal Suchanek escribió: Hello, On 21 March 2016 at 21:09, adrian15 wrote: The branch which include specifically the commits I attach here as patches is: https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_5 . About the variable names issue: I think the new terms: first and extra are ok because they are not implying some sort of rank while explaining what's the difference between them. Also, notice, that these are internal variables which final user of live-build does not see. I think we should focus on other aspects of my patch if there are more problems for it. The problem is not with the name of the variable. The problem is that you use it at all. In most places when you check for primary or secondary bootloader you should just loop all bootloaders and check each. In fact, in the previous batch of patches I found no place where checking for primary or secondary bootloader made any sense. If you think that the way bootloaders is currently managed by live-build is wrong please file up a new bug and send there your patch with your improvements so that it's get discussed. The bootloader support in live-build is limited. With your patches it becomes wrong. eg. compatibility of bootloader with selected filesystem and image type is only checked for first bootloader and EFI support is added only when grub-efi extra bootloader but not when it is the first bootloader. This is not fixed by renaming the variables. Ok. So I recognise that my patch: * Adds a limited support of UEFI only available when it's used as an extra bootloader * Does not check compatibility with selected filesystem in the extra bootloader because it blindly relies on selected filesystem selected in first bootloader being compatible with the extra bootloader too. * It does not work for hdd binaries (only iso binaries) and it does in addition to what live-build already did. I also think that my patch does not remove the current live-build functionality and if that happens I want to know about it. Yes, my patch does not bring UEFI complete support, but a minimal one. So according to you the many changes I make on the bootloader functions do not compensate the minimal UEFI support I add to live-build? Thank you. adrian15 -- Support free software. Donate to Super Grub Disk. Apoya el software libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
El 21/03/16 a las 22:19, Michal Suchanek escribió:
Hello,
On 21 March 2016 at 21:09, adrian15 wrote:
The branch which include specifically the commits I attach here as patches
is:
https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_5
.
About the variable names issue: I think the new terms: first and extra are
ok because they are not implying some sort of rank while explaining what's
the difference between them. Also, notice, that these are internal variables
which final user of live-build does not see. I think we should focus on
other aspects of my patch if there are more problems for it.
The problem is not with the name of the variable.
The problem is that you use it at all. In most places when you check
for primary or secondary bootloader you should just loop all
bootloaders and check each. In fact, in the previous batch of patches
I found no place where checking for primary or secondary bootloader
made any sense.
If you think that the way bootloaders is currently managed by live-build is
wrong please file up a new bug and send there your patch with your
improvements so that it's get discussed.
The bootloader support in live-build is limited. With your patches it
becomes wrong. eg. compatibility of bootloader with selected
filesystem and image type is only checked for first bootloader and EFI
support is added only when grub-efi extra bootloader but not when it
is the first bootloader.
This is not fixed by renaming the variables.
Thanks
Michal
Ok, what about now? Actually from my former email I only added one
additional patch (0011) with some sort of modular support for bootloaders.
There probably needs some work to be done on binary_hdd but I first
wanted to gather information on what to improve on this last patch.
https://github.com/rescatux/live-build/tree/efi_support_based_on_debian_cd_rebased_6
adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
>From ff8206aea1985760dfea9ec94b93686a242f137e Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 18 Jan 2016 03:04:00 +
Subject: [PATCH 01/11] functions/default.sh : Define LB_PRIMARY_BOOTLOADER at
the Set_defaults function which it's the right place where to do it
---
functions/defaults.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/functions/defaults.sh b/functions/defaults.sh
index ddf4b19..334984f 100755
--- a/functions/defaults.sh
+++ b/functions/defaults.sh
@@ -537,6 +537,8 @@ Set_defaults ()
esac
fi
+ LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
+
# Setting checksums
case "${LB_MODE}" in
progress-linux)
@@ -845,9 +847,6 @@ Check_defaults ()
fi
fi
-
- LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
if [ "${LB_PRIMARY_BOOTLOADER}" = "syslinux" ]
then
# syslinux + fat or ntfs, or extlinux + ext[234] or btrfs
--
2.1.4
>From f895f653dffb614639fa37a318e62c51104a4b2d Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Wed, 20 Jan 2016 00:53:53 +0100
Subject: [PATCH 02/11] Remove repeated LB_PRIMARY_BOOTLOADER definition
---
scripts/build/binary_hdd | 2 --
scripts/build/binary_iso | 2 --
2 files changed, 4 deletions(-)
diff --git a/scripts/build/binary_hdd b/scripts/build/binary_hdd
index d0db382..0c9c5af 100755
--- a/scripts/build/binary_hdd
+++ b/scripts/build/binary_hdd
@@ -67,8 +67,6 @@ do
esac
done
-LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
case ${LB_PRIMARY_BOOTLOADER} in
syslinux)
case ${LB_BINARY_FILESYSTEM} in
diff --git a/scripts/build/binary_iso b/scripts/build/binary_iso
index d8b1553..67dfc85 100755
--- a/scripts/build/binary_iso
+++ b/scripts/build/binary_iso
@@ -107,8 +107,6 @@ then
XORRISO_OPTIONS="${XORRISO_OPTIONS} -V \"${LB_ISO_VOLUME}\""
fi
-LB_PRIMARY_BOOTLOADER=$(echo "${LB_BOOTLOADERS}" | awk -F, '{ print $1 }')
-
# Handle xorriso architecture specific options
case "${LB_PRIMARY_BOOTLOADER}" in
grub)
--
2.1.4
>From 9175a624b7d88bfea80448a5a1e6ac1b11d651aa Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez
Date: Mon, 18 Jan 2016 03:07:48 +
Subject: [PATCH 03/11] * Added: functions/bootloaders.sh . It has new
bootloader functions that are heavily used in efi scenarios where a
bootloader can act as a primary or a secondary bootloader.
Since the introduction of the new switch:
--bootloaders
you can setup it like this:
--bootloaders=syslinux,grub-efi
.
This means that syslinux is the primary bootloader and grub-efi is the secondary bootloader.
* Added new bootloader functions: Check_Non_Primary_Bootloader and Check_Non_Secondary_Bootloader.
These functions let each one of the bootloaders abort the build because
they cannot perform a role either as a primary bootloader or as a secondary bootloader.
* Added bootloader functions: Check_Primary_Bootloader_Role, Check
Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
On 21 March 2016 at 23:06, adrian15 wrote: > El 21/03/16 a las 22:19, Michal Suchanek escribió: > >> The bootloader support in live-build is limited. With your patches it >> becomes wrong. eg. compatibility of bootloader with selected >> filesystem and image type is only checked for first bootloader and EFI >> support is added only when grub-efi extra bootloader but not when it >> is the first bootloader. >> >> This is not fixed by renaming the variables. > > > Ok. So I recognise that my patch: > > * Adds a limited support of UEFI only available when it's used as an extra > bootloader > * Does not check compatibility with selected filesystem in the extra > bootloader because it blindly relies on selected filesystem selected in > first bootloader being compatible with the extra bootloader too. > * It does not work for hdd binaries (only iso binaries) > > and it does in addition to what live-build already did. No, it does not. live-build only installed bootloader which was compatible with selected filesystem and image type which is no longer true with your patch. In fact, if I choose grub-efi as first bootloader the efi support is not added and compatibility of any extra bootloaders with the filesystem chosen is not checked so the image may be completely unbootable. So please consider either 1) fixing your current patch so there is no primary or first bootloader and all installed bootloaders are equal 2) don't pretend you add support for multiple bootloaders when you are not wiling to do so and just and some option like --bolt-on-grub-efi which installs grub-efi if image type and filesystem is compatible with grub-efi and fails the build otherwise BTW it has been pointed out already that -eltorito-alt-boot is just separator that starts new boot entry so there are no special secondary/extra bootloader options. Any bootloader can be first/second/third/whatever. Thanks Michal
