Processed: Re: Bug#756794: vsftpd: FTBFS on kfreebsd-*
Processing commands for cont...@bugs.debian.org: > tags 756794 + patch + pending Bug #756794 [src:vsftpd] vsftpd: FTBFS on kfreebsd-* Added tag(s) patch. Bug #756794 [src:vsftpd] vsftpd: FTBFS on kfreebsd-* Added tag(s) pending. > user debian-...@lists.debian.org Setting user to debian-...@lists.debian.org (was ste...@pyro.eu.org). > usertags 756794 + kfreebsd There were no usertags set. Usertags are now: kfreebsd. > thanks Stopping processing here. Please contact me if you need assistance. -- 756794: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756794 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.c.140900651212671.transcr...@bugs.debian.org
Bug#756794: vsftpd: FTBFS on kfreebsd-*
Hello Steven, Am Donnerstag, den 21.08.2014, 14:56 +0100 schrieb Steven Chamberlain: [...] > Hi, > > On 20/08/14 16:38, Jörg Frings-Fürst wrote: > > There are no changes at sysdeputil.c between vsftpd/3.0.2-14 and > > vsftpd/3.0.2-15. > > I see what happened: kfreebsd-kernel-headers introduced a new > sys/capability.h which we did not have before. vsftpd will use it in > preference to a dummyinc/sys/capability.h > > You can see in dummyinc/sys/capability.h that it would otherwise #undef > VSF_SYSDEP_HAVE_LIBCAP. > > vsftpd expects sys/capability.h will define cap_t, but only libcap has > that, our header does not. I'm not sure what's right/wrong here. > libcap is a linux-any package currently but would conflict with this > FreeBSD kernel header otherwise. (Why does libpcap put it in sys/?) > > Either way, we don't seem to have libcap on GNU/kFreeBSD, and quoting > Ben Kaduk: > > It seems [libpcap] is the provider of the cap_t; there is no such concept in > > the base freebsd system. > > I think it is appropriate to add the attached, along with the other > platform-specific configuration atop sysdeputil.c > > Regards, Many thanks for your work and the patch. I've added them into 3.0.2-16. CU Jörg -- pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E pgp Key: BE581B6E CAcert Key S/N: 0E:D4:56 Jörg Frings-Fürst D-54526 Niederkail Threema: SYR8SJXB IRC: j_...@freenode.net j_...@oftc.net signature.asc Description: This is a digitally signed message part
Bug#756794: vsftpd: FTBFS on kfreebsd-*
tags + patch user debian-...@lists.debian.org usertags + kfreebsd thanks Hi, On 20/08/14 16:38, Jörg Frings-Fürst wrote: > There are no changes at sysdeputil.c between vsftpd/3.0.2-14 and > vsftpd/3.0.2-15. I see what happened: kfreebsd-kernel-headers introduced a new sys/capability.h which we did not have before. vsftpd will use it in preference to a dummyinc/sys/capability.h You can see in dummyinc/sys/capability.h that it would otherwise #undef VSF_SYSDEP_HAVE_LIBCAP. vsftpd expects sys/capability.h will define cap_t, but only libcap has that, our header does not. I'm not sure what's right/wrong here. libcap is a linux-any package currently but would conflict with this FreeBSD kernel header otherwise. (Why does libpcap put it in sys/?) Either way, we don't seem to have libcap on GNU/kFreeBSD, and quoting Ben Kaduk: > It seems [libpcap] is the provider of the cap_t; there is no such concept in > the base freebsd system. I think it is appropriate to add the attached, along with the other platform-specific configuration atop sysdeputil.c Regards, -- Steven Chamberlain ste...@pyro.eu.org Description: Neither FreeBSD nor GNU/kFreeBSD have libpcap. Avoid confusing sys/capability.h kernel header with libpcap's Author: Steven Chamberlain Bug-Debian: http://bugs.debian.org/756794 Forwarded: no --- a/sysdeputil.c +++ b/sysdeputil.c @@ -113,6 +113,10 @@ #define VSF_SYSDEP_HAVE_SETPROCTITLE #endif +#if defined(__FreeBSD_kernel__) + #undef VSF_SYSDEP_HAVE_LIBCAP +#endif + #if defined(__NetBSD__) #include #define VSF_SYSDEP_HAVE_SETPROCTITLE signature.asc Description: OpenPGP digital signature
Bug#756794: vsftpd: FTBFS on kfreebsd-*
Source: vsftpd Version: 3.0.2-15 Severity: serious Justification: fails to build from source (but built successfully in the past) vsftpd failed to build on kfreebsd-* with: | gcc -c sysdeputil.c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -idirafter dummyinc | sysdeputil.c: In function 'do_checkcap': | sysdeputil.c:622:3: error: unknown type name 'cap_t' |cap_t current_caps = cap_get_proc(); |^ | sysdeputil.c:624:20: warning: comparison between pointer and integer |if (current_caps != NULL) | ^ | sysdeputil.c: In function 'vsf_sysdep_adopt_capabilities': | sysdeputil.c:635:3: error: unknown type name 'cap_value_t' |cap_value_t cap_value; |^ | sysdeputil.c:636:3: error: unknown type name 'cap_t' |cap_t adopt_caps = cap_init(); |^ | sysdeputil.c:639:17: error: 'CAP_CHOWN' undeclared (first use in this function) | cap_value = CAP_CHOWN; | ^ | sysdeputil.c:639:17: note: each undeclared identifier is reported only once for each function it appears in | sysdeputil.c:640:30: error: 'CAP_EFFECTIVE' undeclared (first use in this function) | cap_set_flag(adopt_caps, CAP_EFFECTIVE, 1, &cap_value, CAP_SET); | ^ | sysdeputil.c:640:60: error: 'CAP_SET' undeclared (first use in this function) | cap_set_flag(adopt_caps, CAP_EFFECTIVE, 1, &cap_value, CAP_SET); | ^ | sysdeputil.c:641:30: error: 'CAP_PERMITTED' undeclared (first use in this function) | cap_set_flag(adopt_caps, CAP_PERMITTED, 1, &cap_value, CAP_SET); | ^ | sysdeputil.c:645:17: error: 'CAP_NET_BIND_SERVICE' undeclared (first use in this function) | cap_value = CAP_NET_BIND_SERVICE; | ^ | make[2]: *** [sysdeputil.o] Error 1 Build logs are available from https://buildd.debian.org/status/package.php?p=vsftpd. Please take a look. Cheers -- Sebastian Ramacher signature.asc Description: Digital signature
