Bug#305481: Patch for knode brokenly forcing followups
I submitted the attached patch to fix this but to KDE bugzilla last night
https://bugs.kde.org/show_bug.cgi?id=68732
Summarising for debbug:
1. Followup-To was being populated from Newsgroups at start and every
time Newsgroups changed;
2. Followup-To widget was a single entry combo box with no default set, so
would always set followups to go to the first entry in Newsgroups.
Fix:
1. Don't automatically set Followup-To
2. Change Followup-To widget into a text box to permit user free form
editing without defaulting to any single group. This is no more lax than
previously, as user could type in an free form entry into the combo box.
This patch is still not fully GNKSA compliant, but is slightly more
so than before due to not forcing incorrect followups, and is far more
usable than the combo box.
Nick
--- kncomposer.h.orig 2006-02-02 12:35:43.0 +
+++ kncomposer.h2006-02-02 21:59:16.0 +
@@ -228,7 +228,7 @@
KNLineEdit *g_roups;
KNLineEdit *t_o;
-KComboBox *f_up2;
+KNLineEdit *f_up2;
QPushButton *g_roupsBtn,
*t_oBtn;
--- kncomposer.cpp.orig 2005-09-10 09:24:04.0 +0100
+++ kncomposer.cpp 2006-02-02 22:00:00.0 +
@@ -569,8 +569,8 @@
}
int groupCount = QStringList::split(',',v_iew-g_roups-text()).count();
-int fupCount = QStringList::split(',',v_iew-f_up2-currentText()).count();
-bool followUp = !v_iew-f_up2-currentText().isEmpty();
+int fupCount = QStringList::split(',',v_iew-f_up2-text()).count();
+bool followUp = !v_iew-f_up2-text().isEmpty();
if (groupCount12) {
KMessageBox::sorry(this, i18n(You are crossposting to more than 12
newsgroups.\nPlease remove all newsgroups in which your article is
off-topic.));
@@ -759,8 +759,8 @@
a_rticle-setDoMail(false);
//Followup-To
- if( a_rticle-doPost() !v_iew-f_up2-currentText().isEmpty())
-a_rticle-followUpTo()-fromUnicodeString(v_iew-f_up2-currentText(),
KMime::Headers::Latin1);
+ if( a_rticle-doPost() !v_iew-f_up2-text().isEmpty())
+a_rticle-followUpTo()-fromUnicodeString(v_iew-f_up2-text(),
KMime::Headers::Latin1);
else
a_rticle-removeHeader(Followup-To);
@@ -898,6 +898,7 @@
void KNComposer::initData(const QString text)
{
+ kdDebug(5003) KNComposer::initData endl;
//Subject
if(a_rticle-subject()-isEmpty())
slotSubjectChanged(QString::null);
@@ -912,8 +913,10 @@
//Followup-To
KMime::Headers::FollowUpTo *fup2=a_rticle-followUpTo(false);
+ kdDebug(5003) fup2 init as fup2 endl;
if(fup2 !fup2-isEmpty())
-v_iew-f_up2-lineEdit()-setText(fup2-asUnicodeString());
+v_iew-f_up2-setText(fup2-asUnicodeString());
+ kdDebug(5003) fup2 now fup2 endl;
KMime::Content *textContent=a_rticle-textContent();
QString s;
@@ -1435,25 +1438,37 @@
setCaption( i18n(No Subject) );
}
+// TODO for GNKSA: Write a function to check that Followup-To is a strict
+// subset of Newsgroups. Use that function before posting. Don't call
+// it while our user is still flipping between fields as it will only
+// annoy her. If followups are identical to newsgroups when posting,
+// then remove them as they're redundant.
+// TODO (gold plated): make Followup-To into a clever custom widget which
+// normally looks like a text box so the user can see the full entry
+// (i.e. is NOT a single entry combo or other cumbersome drop-down). This
+// widget will let user select multiple entries from Newsgroups, whilst
+// making sure not to set anything unless the user explicitly asks us to.
void KNComposer::slotGroupsChanged(const QString t)
{
- KQCStringSplitter split;
- bool splitOk;
- QString currText=v_iew-f_up2-currentText();
-
- v_iew-f_up2-clear();
-
- split.init(t.latin1(), ,);
- splitOk=split.first();
- while(splitOk) {
-v_iew-f_up2-insertItem(QString::fromLatin1(split.string()));
-splitOk=split.next();
- }
- v_iew-f_up2-insertItem();
+ // Leaving this call in, as it may be re-usable for the gold plated TODO.
+
+ // KQCStringSplitter split;
+ // bool splitOk;
+ // QString currText=v_iew-f_up2-currentText();
+
+ // v_iew-f_up2-clear();
+
+ // split.init(t.latin1(), ,);
+ // splitOk=split.first();
+ // while(splitOk) {
+// v_iew-f_up2-insertItem(QString::fromLatin1(split.string()));
+// splitOk=split.next();
+ // }
+ // v_iew-f_up2-insertItem();
- if ( !currText.isEmpty() || !mFirstEdit ) // user might have cleared fup2
intentionally during last edit
-v_iew-f_up2-lineEdit()-setText(currText);
+ // if ( !currText.isEmpty() || !mFirstEdit ) // user might have cleared fup2
intentionally during last edit
+// v_iew-f_up2-lineEdit()-setText(currText);
}
@@ -1760,7 +1775,9 @@
connect(g_roupsBtn, SIGNAL(clicked()), parent(),
SLOT(slotGroupsBtnClicked()));
//Followup-To
- f_up2=new KComboBox(true, hdrFrame);
+ f_up2=new KNLineEdit(this, false, hdrFrame);
+ mEdtList.append(f_up2);
+
l_fup2=new
Bug#351252: kicker crash for no obvious reason
Package: kicker Version: 4:3.5.1-1 Severity: important With KDE 3.5.0 and 3.5.1, kicker regularly crashes. Sometimes, it is properly restarted, sometimes, unfortunately not. If lucky enough, it can be restarted from a console. Otherwise, the desktop is unusable. That's what I got from the last crash: *** glibc detected *** free(): invalid pointer: 0xb7da3900 *** kicker: crashHa...(garbage from another application)...lled ^^^ supposedly crashHandler called I am not using APM, nor kpf (I see them in other similar reports). -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.15.2 Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Versions of packages kicker depends on: ii kdebase-data 4:3.5.1-1 shared data files for the KDE base ii kdelibs4c2a 4:3.5.1-1 core libraries for all KDE applica ii libacl1 2.2.34-1 Access control list shared library ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi ii libattr1 2.4.25-1 Extended attribute shared library ii libaudio2 1.7-3 The Network Audio System (NAS). (s ii libc6 2.3.5-12.1 GNU C Library: Shared libraries an ii libfam0 2.7.0-9Client library to control the FAM ii libfontconfig12.3.2-1.1 generic font configuration library ii libfreetype6 2.1.10-1 FreeType 2 font engine, shared lib ii libgcc1 1:4.0.2-8 GCC support library ii libice6 6.9.0.dfsg.1-4 Inter-Client Exchange library ii libidn11 0.5.18-1 GNU libidn library, implementation ii libjpeg62 6b-11 The Independent JPEG Group's JPEG ii libkonq4 4:3.5.1-1 core libraries for Konqueror ii libpng12-01.2.8rel-5 PNG library - runtime ii libqt3-mt 3:3.3.5-3 Qt GUI Library (Threaded runtime v ii libsm66.9.0.dfsg.1-4 X Window System Session Management ii libstdc++64.0.2-8The GNU Standard C++ Library v3 ii libx11-6 6.9.0.dfsg.1-4 X Window System protocol client li ii libxau6 6.9.0.dfsg.1-4 X Authentication library ii libxcomposite16.9.0.dfsg.1-4 X off-screen compositing library ii libxcursor1 1.1.3-1X cursor management library ii libxext6 6.9.0.dfsg.1-4 X Window System miscellaneous exte ii libxfixes36.9.0.dfsg.1-4 X Window System miscellaneous 'fix ii libxft2 2.1.8.2-2 FreeType-based font drawing librar ii libxi66.9.0.dfsg.1-4 X Window System Input extension li ii libxinerama1 6.9.0.dfsg.1-4 X Window System multi-head display ii libxrandr26.9.0.dfsg.1-4 X Window System Resize, Rotate and ii libxrender1 1:0.9.0.2-1X Rendering Extension client libra ii libxt66.9.0.dfsg.1-4 X Toolkit Intrinsics ii libxtst6 6.9.0.dfsg.1-4 X Window System event recording an ii zlib1g1:1.2.3-9 compression library - runtime kicker recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#348531: kdesktop: same problem, update didn't help
Package: kdesktop Version: 4:3.5.1-1 Followup-For: Bug #348531 I am having this problem still, despite the update of kdelibs4c2a. It seems to work about 1 in 20 icon moves. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.15-1-686 Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) Versions of packages kdesktop depends on: ii kdebase-bin 4:3.5.1-1 core binaries for the KDE base mod ii kdelibs4c2a 4:3.5.1-1 core libraries for all KDE applica ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi ii libaudio2 1.7-3 The Network Audio System (NAS). (s ii libc6 2.3.5-12.1 GNU C Library: Shared libraries an ii libfontconfig12.3.2-1.1 generic font configuration library ii libfreetype6 2.1.10-1 FreeType 2 font engine, shared lib ii libgcc1 1:4.0.2-8 GCC support library ii libglu1-xorg [libglu1 6.9.0.dfsg.1-4 Mesa OpenGL utility library [X.Org ii libice6 6.9.0.dfsg.1-4 Inter-Client Exchange library ii libidn11 0.5.18-1 GNU libidn library, implementation ii libjpeg62 6b-11 The Independent JPEG Group's JPEG ii libkonq4 4:3.5.1-1 core libraries for Konqueror ii libpng12-01.2.8rel-5 PNG library - runtime ii libqt3-mt 3:3.3.5-3+immodule Qt GUI Library (Threaded runtime v ii libsm66.9.0.dfsg.1-4 X Window System Session Management ii libstdc++64.0.2-8The GNU Standard C++ Library v3 ii libx11-6 6.9.0.dfsg.1-4 X Window System protocol client li ii libxau6 6.9.0.dfsg.1-4 X Authentication library ii libxcursor1 1.1.3-1X cursor management library ii libxext6 6.9.0.dfsg.1-4 X Window System miscellaneous exte ii libxft2 2.1.8.2-2 FreeType-based font drawing librar ii libxi66.9.0.dfsg.1-4 X Window System Input extension li ii libxinerama1 6.9.0.dfsg.1-4 X Window System multi-head display ii libxrandr26.9.0.dfsg.1-4 X Window System Resize, Rotate and ii libxrender1 1:0.9.0.2-1X Rendering Extension client libra ii libxss1 6.9.0.dfsg.1-4 X Screen Saver client-side library ii libxt66.9.0.dfsg.1-4 X Toolkit Intrinsics ii libxxf86misc1 6.9.0.dfsg.1-4 X miscellaneous extensions library ii xlibmesa-gl [libgl1] 6.9.0.dfsg.1-4 Mesa 3D graphics library [X.Org] ii zlib1g1:1.2.3-9 compression library - runtime Versions of packages kdesktop recommends: ii eject 2.1.4-1ejects CDs and operates CD-Changer -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#351292: Ctrl+D is a duplicated shortcut key by default installation
Package: Konqueror Version: 3.5.1 Currently in Konqueror, Ctrl+D has been assigned to two different function, Duplicate Window and Add bookmark after a fresh installation of KDE. By default the shortcut key for Add bookmark should be Ctrl+B. I understand somebody wants to change the shortcut key of Add bookmark to Ctrl+D because, in IE, Ctrl+D is for Add Bookmark. However, in Konqueror, this shortcut key is already assigned to Duplicate Window and it can't be changed. So plz change back to default shortcut key Ctrl+B. _ 与联机的朋友进行交流，请使用 MSN Messenger: http://messenger.msn.com/cn -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#287796: marked as done (kalzium: new version doesn't have molecular weight calculator (operations-calculate))
Your message dated Sat, 4 Feb 2006 00:07:46 +0100
with message-id [EMAIL PROTECTED]
and subject line Fixed in Kalzium 1.4.2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
---BeginMessage---
From [EMAIL PROTECTED] Wed Dec 29 21:08:16 2004
Return-path: [EMAIL PROTECTED]
Received: from dsl-202-72-174-244.wa.westnet.com.au
(euclid.patrick.wattle.id.au) [202.72.174.244]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CjsXm-0007Lk-00; Wed, 29 Dec 2004 21:08:15 -0800
Received: from localhost (unknown [IPv6:2002:ca48:aef4:1:240:f4ff:fe9d:4d16])
by euclid.patrick.wattle.id.au (Postfix) with ESMTP id 35F9553B15;
Thu, 30 Dec 2004 13:08:09 +0800 (WST)
Received: from vince by localhost with local (Exim 4.34)
id 1CjsXY-0004lT-CQ; Thu, 30 Dec 2004 13:08:00 +0800
Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Vincent A. Patrick [EMAIL PROTECTED]
To: Debian Bug Tracking System [EMAIL PROTECTED]
Subject: kalzium: new version doesn't have molecular weight calculator
(operations-calculate)
X-Mailer: reportbug 3.2
Date: Thu, 30 Dec 2004 13:08:00 +0800
Message-Id: [EMAIL PROTECTED]
Sender: Vincent A. Patrick [EMAIL PROTECTED]
X-BadReturnPath: [EMAIL PROTECTED] rewritten as [EMAIL PROTECTED]
using From header
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: kalzium
Version: 4:3.3.1-3
Severity: normal
Version 3.2.3-2 of Kalzium (0.93) has a nifty molecular weight calculator which
works fine: it is the
main reason I use Kalzium. Kalzium 3.3.1-3 has a new interface which lacks the
Operations-Calculate menu item, and no longer has a convenient way to
calculate molecular
weights. I have gone back to using the earlier version.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.6-2-k7
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Versions of packages kalzium depends on:
ii kdelibs4 4:3.3.1-1 KDE core libraries
ii libart-2.0-2 2.3.16-6 Library of functions for 2D graphi
ii libc6 2.3.2.ds1-18 GNU C Library: Shared libraries an
ii libfam0c102 2.7.0-6client library to control the FAM
ii libgcc1 1:3.4.3-2 GCC support library
ii libice6 4.3.0.dfsg.1-8 Inter-Client Exchange library
ii libjpeg62 6b-9 The Independent JPEG Group's JPEG
ii libkdeedu14:3.3.1-3 library for use with KDE education
ii libpcre3 4.5-1.1Perl 5 Compatible Regular Expressi
ii libpng12-01.2.8rel-1 PNG library - runtime
ii libqt3c102-mt 3:3.3.3-7 Qt GUI Library (Threaded runtime v
ii libsm64.3.0.dfsg.1-8 X Window System Session Management
ii libstdc++51:3.3.5-2 The GNU Standard C++ Library v3
ii libx11-6 4.3.0.dfsg.1-8 X Window System protocol client li
ii libxext6 4.3.0.dfsg.1-8 X Window System miscellaneous exte
ii libxrender1 0.8.3-7X Rendering Extension client libra
ii xlibs 4.3.0.dfsg.1-8 X Window System client libraries m
ii zlib1g1:1.2.2-3 compression library - runtime
-- no debconf information
---End Message---
---BeginMessage---
From [EMAIL PROTECTED] Fri Feb 03 15:08:20 2006
Return-path: [EMAIL PROTECTED]
Received: from mail-relay-1.tiscali.it ([213.205.33.41])
by spohr.debian.org with esmtp (Exim 4.50)
id 1F5A2O-0006UP-2v
for [EMAIL PROTECTED]; Fri, 03 Feb 2006 15:08:20 -0800
Received: from ulisse.toscano (84.220.49.104) by mail-relay-1.tiscali.it
(7.2.069.1)
id 43C7D795002E1FEF for [EMAIL PROTECTED]; Sat, 4 Feb 2006 00:07:48
+0100
From: Pino Toscano [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Fixed in Kalzium 1.4.2
Date: Sat, 4 Feb 2006 00:07:46 +0100
User-Agent: KMail/1.9
X-Face: 2{OL6n#o}As|AP]~j{^f$FhVLNXSMG=_D:KpHD\9dSG@:f3UD?Euh5^{F],P7K*Yet5
J+({@pnu*um[J`/I!A-ViZfZ[,g8vpZV_W=A[M}\yNRy4c'lp$'2$Umi,CR-zEy\U]
