Re: [RFR] templates://kde4libs/{kdelibs5.templates}

2009-10-17 Thread Christian Perrier
Quoting Sune Vuorela (deb...@pusling.com):

> Full NACK.  You are changing the message. We are not moving from .kde to 
> .kde4.

Interesting. That probably proves that the current message was very
hard to understand as even a longstanding KDE user read it
incorrectly.

Could you comment on Justin's new proposal?



signature.asc
Description: Digital signature


Re: [RFR] templates://kde4libs/{kdelibs5.templates}

2009-10-17 Thread Justin B Rye
Sune Vuorela wrote:
> Full NACK.  You are changing the message. We are not moving from .kde to 
> .kde4.

Oops, I missed that.  Revised patch with "from ~/.kde4 to ~/.kde"
attached.
-- 
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- kde4libs-4.3.2.pristine/debian/kdelibs5.templates   2009-10-08 
07:33:28.0 +0100
+++ kde4libs-4.3.2/debian/kdelibs5.templates2009-10-17 11:17:22.0 
+0100
@@ -6,27 +6,18 @@
 Type: boolean
 Default: true
 _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
- You are about to upgrade to the new version of the kdelibs5 package which
- introduces a major configuration change. Newly started KDE 4 applications
- will use ~/.kde directory to store user settings and data (also known as
- KDEHOME) by default while currently running KDE 4 applications use ~/.kde4.
- KDE 3 applications have always used (and will continue to use) ~/.kde. It
- seems that there are a few KDE 4 applications running on your system at the
- moment. To avoid potential setting/data loss, you should:
+ You are about to upgrade to the new version of the kdelibs5 package, which
+ introduces a major configuration change - details are given in
+ /usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
+ from ~/.kde4 to ~/.kde). However, some KDE 4 applications are currently
+ running: ${apps}
  .
- 1) Answer "Yes", terminate all KDE applications and KDE sessions and try
- upgrading again.
+ It is recommended to abort the upgrade of kdelibs5, terminate all KDE
+ applications and KDE sessions, and try upgrading again.
  .
- or 2) Answer "No" to continue upgrading. You should make sure that no new
- KDE 4 applications are started before you migrate your KDE 4 settings and
- data.  Beware, that clean termination of the old KDE 4 session might not be
- safe..
- .
- Once upgrade is complete, login to KDE as usual or you may use Kaboom wizard
- (package name: kaboom) to migrate your user settings and data before starting
- any KDE 4 application.
- .
- Currently running KDE 4 applications: ${apps}
+ If you choose to continue the upgrade, you should make sure that no new
+ KDE 4 applications are started before KDE 4 settings and data are migrated.
+ A clean termination of the old KDE 4 session might not be safe.
 
 Template: kdelibs5/upgrade_kdehome_info_title
 Type: title
@@ -35,12 +26,11 @@
 Template: kdelibs5/upgrade_kdehome_info
 Type: note
 _Description: New user settings directory (KDEHOME) for KDE 4 applications
- Once this package is upgraded, KDE 4 applications will use ~/.kde directory to
- store user settings and data (also known as KDEHOME) by default.  Currently,
- KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and will
+ Once this package is upgraded, KDE 4 applications will use ~/.kde as the 
default
+ directory to store user settings and data in (also known as KDEHOME). 
Currently,
+ KDE 4 applications use ~/.kde4. KDE 3 applications have always used (and will
  continue to use) ~/.kde.
  .
- When upgrade is complete, it is safe to login to KDE as usual or, if you are
- only using individual KDE 4 applications, you may use Kaboom (available in the
- package of the same name) wizard to migrate your user data before starting a
- KDE 4 application.
+ When the upgrade is complete, it is safe to log in to KDE as usual; or, if you
+ are only using individual KDE 4 applications, you may use the Kaboom wizard 
(in
+ the package kaboom) to migrate user data before starting a KDE 4 application.
Template: kdelibs5/upgrade_kdehome_running_title
Type: title
_Description: Upgrading kdelibs5 while KDE 4 is running

Template: kdelibs5/upgrade_kdehome_running
Type: boolean
Default: true
_Description: Stop possible unsafe upgrade of KDE4 with running sessions?
 You are about to upgrade to the new version of the kdelibs5 package, which
 introduces a major configuration change - details are given in
 /usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
 from ~/.kde4 to ~/.kde). However, some KDE 4 applications are currently
 running: ${apps}
 .
 It is recommended to abort the upgrade of kdelibs5, terminate all KDE
 applications and KDE sessions, and try upgrading again.
 .
 If you choose to continue the upgrade, you should make sure that no new
 KDE 4 applications are started before KDE 4 settings and data are migrated.
 A clean termination of the old KDE 4 session might not be safe.

Template: kdelibs5/upgrade_kdehome_info_title
Type: title
_Description: Upgrading kdelibs5

Template: kdelibs5/upgrade_kdehome_info
Type: note
_Description: New user settings directory (KDEHOME) for KDE 4 applications
 Once this package is upgraded, KDE 4 applications will use ~/.kde as the 
default
 directory to store user settings and data in (also known as KDEHOME). 
Currently,
 KDE 4 applications use ~/.kde4. KDE 3 applications have always used (and will
 con

Re: [RFR] templates://kde4libs/{kdelibs5.templates}

2009-10-17 Thread Sune Vuorela
On Saturday 17 October 2009 06:54:35 Christian Perrier wrote:
> Please find, for review, the debconf templates and packages descriptions
>  for the kde4libs source package.
>
> This review will last from Saturday, October 17, 2009 to Tuesday, October
>  27, 2009.

Full NACK.  You are changing the message. We are not moving from .kde to 
.kde4.

/Sune
 
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.
> 
> Your review should be sent as an answer to this mail.
> 
> When appropriate, I will send intermediate requests for review, with
> "[RFRn]" (n>=2) as a subject tag.
> 
> When we will reach a consensus, I send a "Last Chance For
> Comments" mail with "[LCFC]" as a subject tag.
> 
> Finally, the reviewed templates will be sent to the package maintainer
> as a bug report, and a mail will be sent to this list with "[BTS]" as
> a subject tag.
> 
> Rationale:
> --- kde4libs.old/debian/kdelibs5.templates2009-10-08 14:48:45.688656288
>  +0200 +++ kde4libs/debian/kdelibs5.templates 2009-10-12 22:25:35.766828119
>  +0200 @@ -7,26 +7,17 @@
>  Default: true
>  _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
>   You are about to upgrade to the new version of the kdelibs5 package which
> - introduces a major configuration change. Newly started KDE 4 applications
> - will use ~/.kde directory to store user settings and data (also known as
> - KDEHOME) by default while currently running KDE 4 applications use
>  ~/.kde4. - KDE 3 applications have always used (and will continue to use)
>  ~/.kde. It - seems that there are a few KDE 4 applications running on your
>  system at the - moment. To avoid potential setting/data loss, you should:
> + introduces a major configuration change. Details are given in
> + /usr/share/doc/kdelibs5/README.Debian: in short, user settings are moved
> + from ~/.kde to ~/.kde4.
>   .
> - 1) Answer "Yes", terminate all KDE applications and KDE sessions and try
> + Some KDE 4 applications are currently running (${apps}). It is
>  recommended + to abort the upgrade of kdelibs5, terminate all KDE
>  applications and KDE sessions and try upgrading again.
>   .
> - or 2) Answer "No" to continue upgrading. You should make sure that no new
> - KDE 4 applications are started before you migrate your KDE 4 settings and
> - data.  Beware, that clean termination of the old KDE 4 session might not
>  be - safe..
> - .
> - Once upgrade is complete, login to KDE as usual or you may use Kaboom
>  wizard - (package name: kaboom) to migrate your user settings and data
>  before starting - any KDE 4 application.
> - .
> - Currently running KDE 4 applications: ${apps}
> + If you choose to coontinue the upgrade, you should make sure that no new
> + KDE 4 applications are started before KDE 4 settings and data are
>  migrated. + A clean termination of the old KDE 4 session might not be
>  safe.
> 
> The original template was way too long and was trying to say too many
> things. It generally triggers more problems than it solves.
> 
> Also, the original template was making references to specific aspects
> of the interface ('Yes' and 'No' answers) that may vary depending on
> the debconf interface and locale settings.
> 
> So, I rewrote the template entirely, trying to say the same important
> information in a shorter way.
> 
> I indeed propose moving the gory details about ~/.kde and ~/.kde4 in a
> README.Debian file.
> 
>  Template: kdelibs5/upgrade_kdehome_info_title
>  Type: title
> @@ -40,7 +31,7 @@
>   KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and
>  will continue to use) ~/.kde.
>   .
> - When upgrade is complete, it is safe to login to KDE as usual or, if you
>  are + When the upgrade is complete, it is safe to login to KDE as usual
>  or, if you are only using individual KDE 4 applications, you may use
>  Kaboom (available in the - package of the same name) wizard to migrate
>  your user data before starting a + package of the same name) wizard to
>  migrate user data before starting a KDE 4 application.
> 
> Add missing article.
> 
> Drop "your": the user doing the upgrade is not necessarily owning the
> data.
> 
> PS: I did not review packages descriptions in debian/control.
> 

-- 
Do you know how to overclock a device from the control tools inside Photoshop?

You never have to cancel the editor and then from the folder menu within Excel 
you should install the RW gadget to uninstall on a level-6 LCD prompt on a 
virus over the attachment on a tool.


-- 
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Re: [RFR] templates://kde4libs/{kdelibs5.templates}

2009-10-17 Thread Justin B Rye
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Luckily enough I didn't see anything worth complaining about in the
control file, once I'd got my head round the fact that kdelibs5
provides libraries for KDE 4.

>  _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
[...]
> + Some KDE 4 applications are currently running (${apps}). It is recommended
> + to abort the upgrade of kdelibs5, terminate all KDE applications and KDE 
> sessions and try
>   upgrading again.
[...]

This phrasing all looks okay, but can you safely put ${apps} in the
middle like that, or is it liable to burst the paragraph?  How about
shuffling things like this:

  You are about to upgrade to the new version of the kdelibs5 package, which
  introduces a major configuration change - details are given in
  /usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
  from ~/.kde to ~/.kde4). However, some KDE 4 applications are currently
  running: ${apps}
  .
  It is recommended to abort the upgrade of kdelibs5, terminate all KDE
  applications and KDE sessions, and try upgrading again.
  .

> + If you choose to coontinue the upgrade, [...]
   ^typo

Oh, in fact there's stuff I'd change here:

>  Template: kdelibs5/upgrade_kdehome_info
>  Type: note
>  _Description: New user settings directory (KDEHOME) for KDE 4 applications
>   Once this package is upgraded, KDE 4 applications will use ~/.kde directory 
> to
>   store user settings and data (also known as KDEHOME) by default.  Currently,
>   KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and will
>   continue to use) ~/.kde.

Make that:
Once this package is upgraded, KDE 4 applications will use ~/.kde as the 
default
directory to store user settings and data in (also known as KDEHOME). 
Currently
KDE 4 applications use ~/.kde4. KDE 3 applications have always used (and 
will
continue to use) ~/.kde.

> + When the upgrade is complete, it is safe to login to KDE as usual or, if 
> you are
>   only using individual KDE 4 applications, you may use Kaboom (available in 
> the
> + package of the same name) wizard to migrate user data before starting a
>   KDE 4 application.

"To log in".  The "Kaboom (...) wizard" part is slightly awkward but
patching it up spoils the "same name" part.  (I hope nobody gets
confused by the package description for madbomber...)

When the upgrade is complete, it is safe to log in to KDE as usual; or, if 
you
are only using individual KDE 4 applications, you can use the Kaboom wizard 
(in
the package kaboom) to migrate user data before starting a KDE 4 
application.

-- 
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- kde4libs-4.3.2.pristine/debian/kdelibs5.templates   2009-10-08 
07:33:28.0 +0100
+++ kde4libs-4.3.2/debian/kdelibs5.templates2009-10-17 11:17:22.0 
+0100
@@ -6,27 +6,18 @@
 Type: boolean
 Default: true
 _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
- You are about to upgrade to the new version of the kdelibs5 package which
- introduces a major configuration change. Newly started KDE 4 applications
- will use ~/.kde directory to store user settings and data (also known as
- KDEHOME) by default while currently running KDE 4 applications use ~/.kde4.
- KDE 3 applications have always used (and will continue to use) ~/.kde. It
- seems that there are a few KDE 4 applications running on your system at the
- moment. To avoid potential setting/data loss, you should:
+ You are about to upgrade to the new version of the kdelibs5 package, which
+ introduces a major configuration change - details are given in
+ /usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
+ from ~/.kde to ~/.kde4). However, some KDE 4 applications are currently
+ running: ${apps}
  .
- 1) Answer "Yes", terminate all KDE applications and KDE sessions and try
- upgrading again.
+ It is recommended to abort the upgrade of kdelibs5, terminate all KDE
+ applications and KDE sessions, and try upgrading again.
  .
- or 2) Answer "No" to continue upgrading. You should make sure that no new
- KDE 4 applications are started before you migrate your KDE 4 settings and
- data.  Beware, that clean termination of the old KDE 4 session might not be
- safe..
- .
- Once upgrade is complete, login to KDE as usual or you may use Kaboom wizard
- (package name: kaboom) to migrate your user settings and data before starting
- any KDE 4 application.
- .
- Currently running KDE 4 applications: ${apps}
+ If you choose to continue the upgrade, you should make sure that no new
+ KDE 4 applications are started before KDE 4 settings and data are migrated.
+ A clean termination of the old KDE 4 session might not be safe.
 
 Template: kdelibs5/upgrade_kdehome_info_title
 Type: title
@@ -35,12 +26,11 @@
 Template: kdelibs5/upg

[RFR] templates://kde4libs/{kdelibs5.templates}

2009-10-16 Thread Christian Perrier
Please find, for review, the debconf templates and packages descriptions for 
the kde4libs source package.

This review will last from Saturday, October 17, 2009 to Tuesday, October 27, 
2009.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- kde4libs.old/debian/kdelibs5.templates  2009-10-08 14:48:45.688656288 
+0200
+++ kde4libs/debian/kdelibs5.templates  2009-10-12 22:25:35.766828119 +0200
@@ -7,26 +7,17 @@
 Default: true
 _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
  You are about to upgrade to the new version of the kdelibs5 package which
- introduces a major configuration change. Newly started KDE 4 applications
- will use ~/.kde directory to store user settings and data (also known as
- KDEHOME) by default while currently running KDE 4 applications use ~/.kde4.
- KDE 3 applications have always used (and will continue to use) ~/.kde. It
- seems that there are a few KDE 4 applications running on your system at the
- moment. To avoid potential setting/data loss, you should:
+ introduces a major configuration change. Details are given in 
+ /usr/share/doc/kdelibs5/README.Debian: in short, user settings are moved
+ from ~/.kde to ~/.kde4.
  .
- 1) Answer "Yes", terminate all KDE applications and KDE sessions and try
+ Some KDE 4 applications are currently running (${apps}). It is recommended
+ to abort the upgrade of kdelibs5, terminate all KDE applications and KDE 
sessions and try
  upgrading again.
  .
- or 2) Answer "No" to continue upgrading. You should make sure that no new
- KDE 4 applications are started before you migrate your KDE 4 settings and
- data.  Beware, that clean termination of the old KDE 4 session might not be
- safe..
- .
- Once upgrade is complete, login to KDE as usual or you may use Kaboom wizard
- (package name: kaboom) to migrate your user settings and data before starting
- any KDE 4 application.
- .
- Currently running KDE 4 applications: ${apps}
+ If you choose to coontinue the upgrade, you should make sure that no new
+ KDE 4 applications are started before KDE 4 settings and data are migrated.
+ A clean termination of the old KDE 4 session might not be safe.

The original template was way too long and was trying to say too many
things. It generally triggers more problems than it solves.

Also, the original template was making references to specific aspects
of the interface ('Yes' and 'No' answers) that may vary depending on
the debconf interface and locale settings.

So, I rewrote the template entirely, trying to say the same important
information in a shorter way.

I indeed propose moving the gory details about ~/.kde and ~/.kde4 in a
README.Debian file.
 
 Template: kdelibs5/upgrade_kdehome_info_title
 Type: title
@@ -40,7 +31,7 @@
  KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and will
  continue to use) ~/.kde.
  .
- When upgrade is complete, it is safe to login to KDE as usual or, if you are
+ When the upgrade is complete, it is safe to login to KDE as usual or, if you 
are
  only using individual KDE 4 applications, you may use Kaboom (available in the
- package of the same name) wizard to migrate your user data before starting a
+ package of the same name) wizard to migrate user data before starting a
  KDE 4 application.

Add missing article.

Drop "your": the user doing the upgrade is not necessarily owning the
data.

PS: I did not review packages descriptions in debian/control.

-- 


Template: kdelibs5/upgrade_kdehome_running_title
Type: title
_Description: Upgrading kdelibs5 while KDE 4 is running

Template: kdelibs5/upgrade_kdehome_running
Type: boolean
Default: true
_Description: Stop possible unsafe upgrade of KDE4 with running sessions?
 You are about to upgrade to the new version of the kdelibs5 package which
 introduces a major configuration change. Details are given in 
 /usr/share/doc/kdelibs5/README.Debian: in short, user settings are moved
 from ~/.kde to ~/.kde4.
 .
 Some KDE 4 applications are currently running (${apps}). It is recommended
 to abort the upgrade of kdelibs5, terminate all KDE applications and KDE 
sessions and try
 upgrading again.
 .
 If you choose to coontinue the upgrade, you should make sure that no new
 KDE 4 applications are started before KDE 4 settings and data are migrated.
 A clean termination of the old KDE 4 session might not be safe.

Template: kdelibs5/upgrade_kdehome_info_title
Type: title
_Description: Upgrading kdelibs5

Template: kdelibs5/upgrade_k