Bug#638813: qtcreator: FTBFS: error: no matching function for call to 'qMin(double, qreal)'

2011-08-22 Thread Adam Majer 
On Mon, Aug 22, 2011 at 02:03:19PM +0900, Nobuhiro Iwamatsu wrote:
 --- a/src/plugins/qmldesigner/components/formeditor/snapper.cpp   
 2011-07-07 11:14:10.0 +0900
 +++ b/src/plugins/qmldesigner/components/formeditor/snapper.cpp   
 2011-07-07 11:14:50.0 +0900
 @@ -495,10 +495,10 @@
  double minimumY =  std::numeric_limitsdouble::max();
  double maximumY =  std::numeric_limitsdouble::min();
  foreach(const QLineF line, lineList) {
 -minimumY = qMin(minimumY, line.y1());
 -minimumY = qMin(minimumY, line.y2());
 -maximumY = qMax(maximumY, line.y1());
 -maximumY = qMax(maximumY, line.y2());
 +minimumY = qMin(minimumY, static_castqreal(line.y1()));
 +minimumY = qMin(minimumY, static_castqreal(line.y2()));
 +maximumY = qMax(maximumY, static_castqreal(line.y1()));
 +maximumY = qMax(maximumY, static_castqreal(line.y2()));
  }
  
  double x(lineList.first().x1());


I'm assuming that the patch was to do static_castdouble(line.y1())
instead of qreal. As is, it should nothing. The definition of QLineF
is,

qreal QLineF::y1() const;


- Adam



-- 
Adam Majer
ad...@zombino.com



-- 
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20110822143059.ga9...@mira.lan.galacticasoftware.com

Bug#638813: qtcreator: FTBFS: error: no matching function for call to 'qMin(double, qreal)'

2011-08-22 Thread Sune Vuorela 
On Monday 22 August 2011 16:30:59 Adam Majer wrote:
 On Mon, Aug 22, 2011 at 02:03:19PM +0900, Nobuhiro Iwamatsu wrote:
  ---
  a/src/plugins/qmldesigner/components/formeditor/snapper.cpp 2011-07-07
  11:14:10.0 +0900 +++
  b/src/plugins/qmldesigner/components/formeditor/snapper.cpp 2011-07-07
  11:14:50.0 +0900 @@ -495,10 +495,10 @@
  
   double minimumY =  std::numeric_limitsdouble::max();
   double maximumY =  std::numeric_limitsdouble::min();
   foreach(const QLineF line, lineList) {
  
  -minimumY = qMin(minimumY, line.y1());
  -minimumY = qMin(minimumY, line.y2());
  -maximumY = qMax(maximumY, line.y1());
  -maximumY = qMax(maximumY, line.y2());
  +minimumY = qMin(minimumY, static_castqreal(line.y1()));
  +minimumY = qMin(minimumY, static_castqreal(line.y2()));
  +maximumY = qMax(maximumY, static_castqreal(line.y1()));
  +maximumY = qMax(maximumY, static_castqreal(line.y2()));
  
   }
   
   double x(lineList.first().x1());
 
 I'm assuming that the patch was to do static_castdouble(line.y1())
 instead of qreal. As is, it should nothing. The definition of QLineF
 is,
 
 qreal QLineF::y1() const;

event better would be to have 
  qreal minimumY =  std::numeric_limitsqreal::max();
  qreal maximumY =  std::numeric_limitsqreal::min();

/Sune



-- 
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/201108221705.39745.s...@debian.org

Bug#638813: qtcreator: FTBFS: error: no matching function for call to 'qMin(double, qreal)'

2011-08-22 Thread Adam Majer 
On Mon, Aug 22, 2011 at 05:05:39PM +0200, Sune Vuorela wrote:
 On Monday 22 August 2011 16:30:59 Adam Majer wrote:
  On Mon, Aug 22, 2011 at 02:03:19PM +0900, Nobuhiro Iwamatsu wrote:
   ---
   a/src/plugins/qmldesigner/components/formeditor/snapper.cpp   
   2011-07-07
   11:14:10.0 +0900 +++
   b/src/plugins/qmldesigner/components/formeditor/snapper.cpp   
   2011-07-07
   11:14:50.0 +0900 @@ -495,10 +495,10 @@
   
double minimumY =  std::numeric_limitsdouble::max();
double maximumY =  std::numeric_limitsdouble::min();
foreach(const QLineF line, lineList) {
   
   -minimumY = qMin(minimumY, line.y1());
   -minimumY = qMin(minimumY, line.y2());
   -maximumY = qMax(maximumY, line.y1());
   -maximumY = qMax(maximumY, line.y2());
   +minimumY = qMin(minimumY, static_castqreal(line.y1()));
   +minimumY = qMin(minimumY, static_castqreal(line.y2()));
   +maximumY = qMax(maximumY, static_castqreal(line.y1()));
   +maximumY = qMax(maximumY, static_castqreal(line.y2()));
   
}

double x(lineList.first().x1());
  
  I'm assuming that the patch was to do static_castdouble(line.y1())
  instead of qreal. As is, it should nothing. The definition of QLineF
  is,
  
  qreal QLineF::y1() const;
 
 event better would be to have 
   qreal minimumY =  std::numeric_limitsqreal::max();
   qreal maximumY =  std::numeric_limitsqreal::min();

Yes, but that may end up requiring other changes in the code. There
are going to be implicit conversions further down.

I'm just looking at the code and it seems that the problem was fixed
by casting to double in commit 30364a13. I've included it below,

commit 30364a130ea50380cadc90457e66e30f8d337bc0
Author: Marco Bubke marco.bu...@nokia.com
Date:   Thu Jul 21 13:26:39 2011 +0200

QmlDesigner: Fix qreal is not double

Task-number: QTCREATORBUG-5547

Change-Id: Id23737f292de00232deac792d3db2bd36bda0efe
Reviewed-on: http://codereview.qt.nokia.com/1947
Reviewed-by: Qt Sanity Bot qt_sanity_...@ovi.com
Reviewed-by: Thomas Hartmann thomas.hartm...@nokia.com

diff --git a/src/plugins/qmldesigner/components/formeditor/snapper.cpp 
b/src/plugins/qmldesigner/components/formeditor/snapper.cpp
index a0b816f..6f96747 100644
--- a/src/plugins/qmldesigner/components/formeditor/snapper.cpp
+++ b/src/plugins/qmldesigner/components/formeditor/snapper.cpp
@@ -292,12 +292,12 @@ QLineF Snapper::createSnapLine(Qt::Orientation 
orientation,
const QRectF itemRect) const
 {
 if (orientation == Qt::Horizontal) {
-double lowerX(qMin(lowerLimit, itemRect.left()));
-double upperX(qMax(upperLimit, itemRect.right()));
+double lowerX(qMin(lowerLimit, double(itemRect.left(;
+double upperX(qMax(upperLimit, double(itemRect.right(;
 return QLineF(lowerX, snapLine, upperX, snapLine);
 } else {
-double lowerY(qMin(lowerLimit, itemRect.top()));
-double upperY(qMax(upperLimit, itemRect.bottom()));
+double lowerY(qMin(lowerLimit, double(itemRect.top(;
+double upperY(qMax(upperLimit, double(itemRect.bottom(;
 return QLineF(snapLine, lowerY, snapLine, upperY);
 }
 }
@@ -477,10 +477,10 @@ static QLineF mergedHorizontalLine(const QListQLineF 
lineList)
 double minimumX =  std::numeric_limitsdouble::max();
 double maximumX =  std::numeric_limitsdouble::min();
 foreach(const QLineF line, lineList) {
-minimumX = qMin(minimumX, line.x1());
-minimumX = qMin(minimumX, line.x2());
-maximumX = qMax(maximumX, line.x1());
-maximumX = qMax(maximumX, line.x2());
+minimumX = qMin(minimumX, double(line.x1()));
+minimumX = qMin(minimumX, double(line.x2()));
+maximumX = qMax(maximumX, double(line.x1()));
+maximumX = qMax(maximumX, double(line.x2()));
 }
 
 double y(lineList.first().y1());
@@ -495,10 +495,10 @@ static QLineF mergedVerticalLine(const QListQLineF 
lineList)
 double minimumY =  std::numeric_limitsdouble::max();
 double maximumY =  std::numeric_limitsdouble::min();
 foreach(const QLineF line, lineList) {
-minimumY = qMin(minimumY, line.y1());
-minimumY = qMin(minimumY, line.y2());
-maximumY = qMax(maximumY, line.y1());
-maximumY = qMax(maximumY, line.y2());
+minimumY = qMin(minimumY, double(line.y1()));
+minimumY = qMin(minimumY, double(line.y2()));
+maximumY = qMax(maximumY, double(line.y1()));
+maximumY = qMax(maximumY, double(line.y2()));
 }
 
 double x(lineList.first().x1());


-- 
Adam Majer
ad...@zombino.com



-- 
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20110822171213.gb9...@mira.lan.galacticasoftware.com

Bug#638813: qtcreator: FTBFS: error: no matching function for call to 'qMin(double, qreal)'

2011-08-21 Thread Nobuhiro Iwamatsu 
Source: qtcreator
Version: 2.2.1-1
Severity: important
Tags: patch

Hi,

qtcreator FTBFS on armel and sh4.
  
https://buildd.debian.org/status/fetch.php?pkg=qtcreatorarch=armelver=2.2.1-1stamp=1309124335
  
http://buildd.debian-ports.org/status/fetch.php?pkg=qtcreatorarch=sh4ver=2.2.1-1stamp=1309530726

-
g++ -c -pipe -g -O2 -fvisibility=hidden -fvisibility-inlines-hidden
-Wall -W -D_REENTRANT -fPIC -DQT_WEBKIT -DIDE_LIBRARY_BASENAME=\lib\
-DQT_NO_CAST_TO_ASCII -DQT_USE_FAST_OPERATOR_PLUS
-DQT_USE_FAST_CONCATENATION -DQT_CREATOR -DQT_CREATOR -DQT_CREATOR
-DQT_CREATOR -DQT_CREATOR -DQT_NO_STYLE_S60 -DVIEWLOGGER
-DENABLE_TEXT_VIEW -DQWEAKPOINTER_ENABLE_ARROW -DQDEBUG_IN_TESTS
-DWARNINGS_IN_TESTS -DTEST_EXPORTS -DQT_NO_DEBUG -DQT_PLUGIN
-DQT_DECLARATIVE_LIB -DQT_WEBKIT_LIB -DQT_SCRIPT_LIB -DQT_GUI_LIB
-DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED
-I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore
-I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui
-I/usr/include/qt4/QtScript -I/usr/include/qt4/QtWebKit
-I/usr/include/qt4/QtDeclarative -I/usr/include/qt4 -I../../libs
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/tools
-I../../plugins -I../../libs/3rdparty/botan/build -I../../shared
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs/parser
-I../../libs/qmleditorwidgets -I../../libs/qmleditorwidgets/easingpane
-I../../shared 
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs/parser
-I../coreplugin -I../../shared/cplusplus -I../../libs/cplusplus
-I../../shared 
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs/parser
-I../../plugins -I../../libs/qmleditorwidgets
-I../../libs/qmleditorwidgets/easingpane -I../../shared
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs
-I/build/buildd-qtcreator_2.2.1-1-armel-lhlzQr/qtcreator-2.2.1/src/libs/qmljs/../../shared/qmljs/parser
-Idesignercore -Idesignercore/include -Icomponents/integration
-Icomponents/propertyeditor -Icomponents/formeditor
-Icomponents/navigator -Icomponents/itemlibrary -Icomponents/navigator
-Icomponents/pluginmanager -Icomponents/stateseditor
-Icomponents/resources -I.moc/release-shared -I.uic -o
.obj/release-shared/snapper.o components/formeditor/snapper.cpp
components/formeditor/snapper.cpp: In member function 'QLineF
QmlDesigner::Snapper::createSnapLine(Qt::Orientation, double, double,
double, const QRectF) const':
components/formeditor/snapper.cpp:295:55: error: no matching function
for call to 'qMin(double, qreal)'
components/formeditor/snapper.cpp:295:55: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1114:17: note: templateclass T
const T qMin(const T, const T)
components/formeditor/snapper.cpp:296:56: error: no matching function
for call to 'qMax(double, qreal)'
components/formeditor/snapper.cpp:296:56: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: templateclass T
const T qMax(const T, const T)
components/formeditor/snapper.cpp:299:54: error: no matching function
for call to 'qMin(double, qreal)'
components/formeditor/snapper.cpp:299:54: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1114:17: note: templateclass T
const T qMin(const T, const T)
components/formeditor/snapper.cpp:300:57: error: no matching function
for call to 'qMax(double, qreal)'
components/formeditor/snapper.cpp:300:57: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: templateclass T
const T qMax(const T, const T)
components/formeditor/snapper.cpp: In function 'QLineF
QmlDesigner::mergedHorizontalLine(const QListQLineF)':
components/formeditor/snapper.cpp:480:44: error: no matching function
for call to 'qMin(double, qreal)'
components/formeditor/snapper.cpp:480:44: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1114:17: note: templateclass T
const T qMin(const T, const T)
components/formeditor/snapper.cpp:481:44: error: no matching function
for call to 'qMin(double, qreal)'
components/formeditor/snapper.cpp:481:44: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1114:17: note: templateclass T
const T qMin(const T, const T)
components/formeditor/snapper.cpp:482:44: error: no matching function
for call to 'qMax(double, qreal)'
components/formeditor/snapper.cpp:482:44: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: templateclass T
const T qMax(const T, const T)
components/formeditor/snapper.cpp:483:44: error: no matching function
for call to 'qMax(double, qreal)'
components/formeditor/snapper.cpp:483:44: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: templateclass T