Bug#821802: [lokalize/Applications/16.04] cmake: support hunspell 1.4 in cmake
Hi, On Mon, Apr 25, 2016 at 10:59:58AM +0200, Rene Engelhard wrote: > On Mon, Apr 25, 2016 at 12:42:48AM +, Nick Shaforostoff wrote: > > Git commit 7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c by Nick Shaforostoff. > > Committed on 25/04/2016 at 00:42. > > Pushed by shaforo into branch 'Applications/16.04'. > > > > support hunspell 1.4 in cmake > > > > CCMAIL: 821...@bugs.debian.org > > > > M +1-1cmake/FindHUNSPELL.cmake > > > > http://commits.kde.org/lokalize/7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c > > > > diff --git a/cmake/FindHUNSPELL.cmake b/cmake/FindHUNSPELL.cmake > > index 26942b5..eca3cc1 100644 > > --- a/cmake/FindHUNSPELL.cmake > > +++ b/cmake/FindHUNSPELL.cmake > > @@ -14,7 +14,7 @@ ENDIF (HUNSPELL_INCLUDE_DIR AND HUNSPELL_LIBRARIES) > > > > FIND_PATH(HUNSPELL_INCLUDE_DIR hunspell/hunspell.hxx ) > > > > -FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-1.3 hunspell-1.2) > > +FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-2.0 hunspell-1.5 > > hunspell-1.4 hunspell-1.3 hunspell-1.2) > ^^ > > Where do you invent these? :) Ah, I see https://github.com/hunspell/hunspell/commit/ad5c19e3bab27167e9f7ecb0c05f61678e7e4930#diff-eb785e299ea6147029b02572abefea1d. That still doesn't explain hunspell-2.0, though :) Regards, Rene
Bug#821802: [lokalize/Applications/16.04] cmake: support hunspell 1.4 in cmake
Hi, On Mon, Apr 25, 2016 at 12:42:48AM +, Nick Shaforostoff wrote: > Git commit 7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c by Nick Shaforostoff. > Committed on 25/04/2016 at 00:42. > Pushed by shaforo into branch 'Applications/16.04'. > > support hunspell 1.4 in cmake > > CCMAIL: 821...@bugs.debian.org > > M +1-1cmake/FindHUNSPELL.cmake > > http://commits.kde.org/lokalize/7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c > > diff --git a/cmake/FindHUNSPELL.cmake b/cmake/FindHUNSPELL.cmake > index 26942b5..eca3cc1 100644 > --- a/cmake/FindHUNSPELL.cmake > +++ b/cmake/FindHUNSPELL.cmake > @@ -14,7 +14,7 @@ ENDIF (HUNSPELL_INCLUDE_DIR AND HUNSPELL_LIBRARIES) > > FIND_PATH(HUNSPELL_INCLUDE_DIR hunspell/hunspell.hxx ) > > -FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-1.3 hunspell-1.2) > +FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-2.0 hunspell-1.5 hunspell-1.4 > hunspell-1.3 hunspell-1.2) ^^ Where do you invent these? :) (And as I said in the bug: why is it not using pkg-config (hunspell.pc) which is version-agnostic and doesn't break if the SONAME is bumped without API breakage?) Regards, Rene
Bug#821802: [lokalize/Applications/16.04] cmake: support hunspell 1.4 in cmake
Git commit 7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c by Nick Shaforostoff. Committed on 25/04/2016 at 00:42. Pushed by shaforo into branch 'Applications/16.04'. support hunspell 1.4 in cmake CCMAIL: 821...@bugs.debian.org M +1-1cmake/FindHUNSPELL.cmake http://commits.kde.org/lokalize/7aa9dafeb457ca3bc48a61c5dfa2e69b0ecdad6c diff --git a/cmake/FindHUNSPELL.cmake b/cmake/FindHUNSPELL.cmake index 26942b5..eca3cc1 100644 --- a/cmake/FindHUNSPELL.cmake +++ b/cmake/FindHUNSPELL.cmake @@ -14,7 +14,7 @@ ENDIF (HUNSPELL_INCLUDE_DIR AND HUNSPELL_LIBRARIES) FIND_PATH(HUNSPELL_INCLUDE_DIR hunspell/hunspell.hxx ) -FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-1.3 hunspell-1.2) +FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-2.0 hunspell-1.5 hunspell-1.4 hunspell-1.3 hunspell-1.2) # handle the QUIETLY and REQUIRED arguments and set HUNSPELL_FOUND to TRUE if # all listed variables are TRUE
