Re: kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
Hi, > Let me suggest you a rule of thumb: if you are thinking in removing a > dependency version check first if the minimum required version is available in > stable. If it's not keep the relationship so backporters know from the start > that they also need to backport something else. Personally I use oldstable as bottom border for this. Best regards, Boris
Re: kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
Hi! El lunes, 24 de septiembre de 2018 12:25:15 -03 Maximiliano Curia escribió: [snip] > > This is not strictly a matter of principle, but just a question of common > > sense. > Ok, let's agree that common sense is subjective here, and we just want > something team acceptable, maintainable. > > Personally, I prefer adding the version dependency as a way of showing the > upstream package requirements. That way the source package ends up being > more independant of the current Debian archive, we don't need to review all > the packages when some release is no longer being supported and if somebody > wants to do some crazy thing with the package, well, we are not working > against them. Let me suggest you a rule of thumb: if you are thinking in removing a dependency version check first if the minimum required version is available in stable. If it's not keep the relationship so backporters know from the start that they also need to backport something else. Regards, Lisandro. -- Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ signature.asc Description: This is a digitally signed message part.
Re: kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
>> Yep, I remember. But there were no reason to not update this version >> together >> with package update. Also debdiff says that two lines were changed in file >> "po/zh_CN/kde-gtk-config.po". ;-) > > Oh, I missed that, currently I'm checking the diff between upstream tags in > minor versions, I guess I should probably also need to check the tarballs. :( Yeah, two reasons among others why I don't like current KDE infrastructure: 1) They do not store translations in the same git repo where sources are, so you cannot easily get git snapshot with up to date localization files. 2) Their tarballs with releases of programs differ from sources in git tags. As far as points above are closely related they might be merged into one... =) >>> Are you really that much against adding a version dependency is no longer >>> in >>> the archive? > >> This is not strictly a matter of principle, but just a question of common >> sense. > > Ok, let's agree that common sense is subjective here, and we just want > something > team acceptable, maintainable. > > Personally, I prefer adding the version dependency as a way of showing the > upstream package requirements. That way the source package ends up being more > independant of the current Debian archive, we don't need to review all the > packages when some release is no longer being supported and if somebody wants > to do some crazy thing with the package, well, we are not working against > them. Ok. Best regards, Boris
Re: kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
¡Hola Boris! El 2018-09-24 a las 17:57 +0300, Boris Pek escribió: Hi, First of all, thanks for working in improving kde-gtk-config. * New upstream release. As mentioned in a private mail, I try to avoid versions were the only change is the version bump. Yep, I remember. But there were no reason to not update this version together with package update. Also debdiff says that two lines were changed in file "po/zh_CN/kde-gtk-config.po". ;-) Oh, I missed that, currently I'm checking the diff between upstream tags in minor versions, I guess I should probably also need to check the tarballs. :( * Simplify debian/control: drop requirement of specific version of cmake (was >= 2.8.12), because even Debian Jessie has cmake version 3.0.2. The CMakeLists.txt states that it requires the version, why would the debian/control show this requirement? That was "why wouldn't/shouldn't ... also". :( I don't see a simplification here, also the version build dependency is added by a script that parses the CMakeLists.txt shipped in the package in particular: cmake_minimum_required(VERSION 2.8.12) Obviously we use different tools and rules during maintaining of packages. And I just was not aware of your script. So, the version dependency would be added in the next run of the script. I do not see a problem here. If you will add versioned dependency in a next upload, than let it be. Or you may manually edit file after automatic changes done by script. Or we may improve that magical script... The script is currently in: https://salsa.debian.org/qt-kde-team/pkg-kde-jenkins/blob/master/hooks/prepare/cmake_update_deps WARNING, it's an ugly piece of ... code. This is co-maintained package. We just have to come to common decision and I will add a point in my notes for this package. Are you really that much against adding a version dependency is no longer in the archive? This is not strictly a matter of principle, but just a question of common sense. Ok, let's agree that common sense is subjective here, and we just want something team acceptable, maintainable. Personally, I prefer adding the version dependency as a way of showing the upstream package requirements. That way the source package ends up being more independant of the current Debian archive, we don't need to review all the packages when some release is no longer being supported and if somebody wants to do some crazy thing with the package, well, we are not working against them. Happy hacking, -- "If you think your users are idiots, only idiots will use it." -- Linus Torvalds Saludos /\/\ /\ >< `/ signature.asc Description: PGP signature
Re: kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
Hi, > First of all, thanks for working in improving kde-gtk-config. > >>* New upstream release. > > As mentioned in a private mail, I try to avoid versions were the only change > is the version bump. Yep, I remember. But there were no reason to not update this version together with package update. Also debdiff says that two lines were changed in file "po/zh_CN/kde-gtk-config.po". ;-) >>* Bump Standards-Version to 4.2.1 (was 4.1.4): no changes required. > > Right, I haven't bumped any Standards-Version beyond 4.1.4, that's, a personal > decision based on a change introduced in 4.1.5. I'm not expecting anyone else > to follow suite. > > The Standards-Version 4.1.5 includes a change that I consider counter > productive, that is: > ... Ok, I see your point of view. Happily, this rule should not affect kde-gtk-config package because it is now among basic KDE applications. >>* Simplify debian/control: drop requirement of specific version of cmake >> (was >= 2.8.12), because even Debian Jessie has cmake version 3.0.2. > > The CMakeLists.txt states that it requires the version, why would the > debian/control show this requirement? > > I don't see a simplification here, also the version build dependency is added > by a script that parses the CMakeLists.txt shipped in the package in > particular: > cmake_minimum_required(VERSION 2.8.12) Obviously we use different tools and rules during maintaining of packages. And I just was not aware of your script. > So, the version dependency would be added in the next run of the script. I do not see a problem here. If you will add versioned dependency in a next upload, than let it be. Or you may manually edit file after automatic changes done by script. Or we may improve that magical script... This is co-maintained package. We just have to come to common decision and I will add a point in my notes for this package. > Are you really that much against adding a version dependency is no longer in > the archive? This is not strictly a matter of principle, but just a question of common sense. Best regards, Boris
Re: kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
¡Hola Boris! First of all, thanks for working in improving kde-gtk-config. * New upstream release. As mentioned in a private mail, I try to avoid versions were the only change is the version bump. * Bump Standards-Version to 4.2.1 (was 4.1.4): no changes required. Right, I haven't bumped any Standards-Version beyond 4.1.4, that's, a personal decision based on a change introduced in 4.1.5. I'm not expecting anyone else to follow suite. The Standards-Version 4.1.5 includes a change that I consider counter productive, that is: 5.6.12. "Version" "epoch" This is a single (generally small) unsigned integer. It may be omitted, in which case zero is assumed. If it is omitted then the "upstream_version" may not contain any colons. Epochs can help when the upstream version numbering scheme changes, but they must be used with care. You should not change the epoch, even in experimental, without getting consensus on debian-devel first. I consider this change paternalistic, as well as, unenforceable. Thus I haven't bumped the Standards-Version beyond 4.1.4. I'm not trying to raise this issue now, just trying to explain my point of view. * Simplify debian/control: drop requirement of specific version of cmake (was >= 2.8.12), because even Debian Jessie has cmake version 3.0.2. The CMakeLists.txt states that it requires the version, why would the debian/control show this requirement? I don't see a simplification here, also the version build dependency is added by a script that parses the CMakeLists.txt shipped in the package in particular: cmake_minimum_required(VERSION 2.8.12) So, the version dependency would be added in the next run of the script. Are you really that much against adding a version dependency is no longer in the archive? Happy hacking, -- "I decry the current tendency to seek patents on algorithms. There are better ways to earn a living than to prevent other people from making use of one's contributions to computer science." -- Donald Knuth Saludos /\/\ /\ >< `/ signature.asc Description: PGP signature
kde-gtk-config_5.13.5-1_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Sun, 23 Sep 2018 23:40:51 +0300 Source: kde-gtk-config Binary: kde-config-gtk-style kde-config-gtk-style-preview Architecture: source Version: 4:5.13.5-1 Distribution: unstable Urgency: medium Maintainer: Debian/Kubuntu Qt/KDE Maintainers Changed-By: Boris Pek Description: kde-config-gtk-style - KDE configuration module for GTK+ 2.x and GTK+ 3.x styles selecti kde-config-gtk-style-preview - KDE configuration module for GTK+ 2.x and GTK+ 3.x styles selecti Changes: kde-gtk-config (4:5.13.5-1) unstable; urgency=medium . * New upstream release. * Bump Standards-Version to 4.2.1 (was 4.1.4): no changes required. * Update long descriptions of binary packages for fixing errors found by lintian: description-contains-invalid-control-statement. * Simplify debian/control: drop requirement of specific version of cmake (was >= 2.8.12), because even Debian Jessie has cmake version 3.0.2. * Simplify debian/rules: stop adding of CPPFLAGS into CXXFLAGS using of DEB_CXXFLAGS_MAINT_APPEND as workaround for cmake because debhelper already does this since version 9.20120417. * Add patch 0001-Fix-spelling-errors. * Tiny cosmetic changes in debian/watch. * Update debian/copyright. Checksums-Sha1: af9ce7e0952f99ae5298a80acfdfaed2fbd50144 2805 kde-gtk-config_5.13.5-1.dsc 2ee13c5426c80788a683c18ba452888a9895bf7d 156428 kde-gtk-config_5.13.5.orig.tar.xz 3d96097cf7455d8c1dd379792c4ef27cb04ef9da 774 kde-gtk-config_5.13.5.orig.tar.xz.asc 89e01e42bbeddd8366e37b1f9781dc8e5129d2df 11804 kde-gtk-config_5.13.5-1.debian.tar.xz Checksums-Sha256: 10cf14d82e4d735a470df2a6e70fa10193f03b3e3e6870e01a51d471d460f0b8 2805 kde-gtk-config_5.13.5-1.dsc 46cee07a27dfa0659435bd8e2bb7444b0f981b50151e4006cbb6cf728f27461a 156428 kde-gtk-config_5.13.5.orig.tar.xz a639755fdd60b7844415f5d809ac7b89587e375f857197e5d5de63d73358f87b 774 kde-gtk-config_5.13.5.orig.tar.xz.asc 15d93805ec0f1d7db77fa9a06cb5500253a0c2f75b9a0317f6f4c16d5f5f65eb 11804 kde-gtk-config_5.13.5-1.debian.tar.xz Files: 853c8a699dbe1c9fa2a87486bd313634 2805 kde optional kde-gtk-config_5.13.5-1.dsc 40d35a0b01f67c1e7d8e7992c68f42de 156428 kde optional kde-gtk-config_5.13.5.orig.tar.xz e1437e4f0f4278566e8df857a7d6ba4a 774 kde optional kde-gtk-config_5.13.5.orig.tar.xz.asc 01464fbd838f115bc0487827fd237759 11804 kde optional kde-gtk-config_5.13.5-1.debian.tar.xz -BEGIN PGP SIGNATURE- iQJHBAEBCgAxFiEE74NZeBI5qRlNLX9Z0AFb0SjzkngFAlun+lwTHHRlaG5pY2tA ZGViaWFuLm9yZwAKCRDQAVvRKPOSeAinEACfrOc88vO1v2SZxMuGX9UoRbH4FDbo JTVnDJKlKWH+rltl6RZ+4IOIOrVnguZ5RgJS2JXSioX1xYVvqZ27MVeADpcR2ZAa foNhWz4WnXL7V4ibZnQ2py+yVMU5f6+d1BXlLpTaJ0UD6Ja1tK0lAkrXox8wC8qu aGDk+p9FBW8v+8k/9DoUkEug43udPlO2006VmzdtUnfazW6bjFVcX6jLWiBIj7C3 Y7VK5SgkrY77T5vPES0t4ZHw9jdhby814vHMoMAnBKFPH4YrFXZbsbSczVqKPljS VdELuRaL8je75a0s/cBmk32MEXa2VJN3D0U0lyf0euY/n7QbhncYn93FweLd5YGH 0LuvzOAkKPBIWYT+mF8LFi9n/BzvudMgFL55OipIamTEy/VXK3IUfdu6d6SvMMbk 6tjM0fsAHu+1dUs2pzps3hdgyhzzPuo34fIyWIFjKFf0X+Tb58GEgk3WnQdxt2Rn Ka8XFqFZSFC5iF/nlQsT9zng977h2YfQZy5jfaC6cNmRj4jz2xscY6dpN13pR0DU RIRBopanmfjrJ/Bt2O9DUqJUnLBBKUZg98MT+pRvgQMuzz7FRKvAZ5iMyX9cqRf2 wRwWEKr/5FGkCv6fXZmc3F6PQa+2FkechHSk34dmcd1WhORh6pfPqeqa4/uajANK ani5QBZvb68qNQ== =uxLJ -END PGP SIGNATURE- Thank you for your contribution to Debian.
