Re: [Pkg-javascript-devel] Help with fixing jekyll (wrt src:node-webpack)

2020-03-14 Thread Utkarsh Gupta
Hi Praveen,

On Sat, Mar 14, 2020 at 4:54 PM Pirate Praveen  wrote:
> I have patched webpack to use uglifyjs-webpack-plugin till
> terser-webpack-plugin is availabel in the archive. I confirmed jekyll
> is building fine, I'll upload it soon.

Thank you very much for your quick fix!
Very much appreciated! \o/


Best,
Utkarsh



Re: [Pkg-javascript-devel] Help with fixing jekyll (wrt src:node-webpack)

2020-03-14 Thread Pirate Praveen




On Sat, Mar 14, 2020 at 11:50 am, Pirate Praveen  
wrote:



On 2020, മാർച്ച് 14 7:32:59 AM IST, Daniel Leidert 
 wrote:

Hi there,


I reported the build issue against webpack and the bug was closed 
just

a few hours ago. Is this happening with the "fixed" webpack package?


This is a different bug, the bug you reported was for acorn 
dependency version.




Regards, Daniel



 Ursprüngliche Nachricht 
Von: Utkarsh Gupta 
Datum: Sa., 14. März 2020, 00:03
An: debian-ruby ,
pkg-javascript-de...@alioth-lists.debian.net
Cc: Pirate Praveen , Daniel Leidert

Betreff: Help with fixing jekyll (wrt src:node-webpack)

Hi there,

Currently, Jekyll doesn't build. Here's why:
This commit[1] introduced using webpack. However this command:

```
cd debian/node_modules/livereload-js; webpack --entry 
./lib/startup.js

\
--output
../../../lib/jekyll/commands/serve/livereload_assets/livereload.js; 
cd

-
```

fails to run with the following error:

```
/usr/share/nodejs/webpack/node_modules/webpack-cli/bin/cli.js:281
throw err;
^

Error: Cannot find module 'terser-webpack-plugin'
at Function.Module._resolveFilename
(internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require
(/usr/share/nodejs/webpack/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
at Object.apply
(/usr/share/nodejs/webpack/lib/WebpackOptionsDefaulter.js:302:27)
at WebpackOptionsApply.process
(/usr/share/nodejs/webpack/lib/WebpackOptionsApply.js:467:16)
at webpack (/usr/share/nodejs/webpack/lib/webpack.js:53:48)
at processOptions
(/usr/share/nodejs/webpack/node_modules/webpack-cli/bin/cli.js:272:16)
at yargs.parse
(/usr/share/nodejs/webpack/node_modules/webpack-cli/bin/cli.js:364:3)
at Object.parse (/usr/share/nodejs/yargs/yargs.js:611:18)
  at 
/usr/share/nodejs/webpack/node_modules/webpack-cli/bin/cli.js:49:8

at Object.
(/usr/share/nodejs/webpack/node_modules/webpack-cli/bin/cli.js:366:3)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js
(internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18)
 at Object. 
(/usr/share/nodejs/webpack/bin/webpack.js:156:2)

at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js
(internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain 
(internal/modules/cjs/loader.js:831:12)

at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
```

This maps to src:node-webpack. Whilst package.json (of node-webpack)
says to have a dependency on terser-webpack-plugin, however, it isn't
packaged and nor embedded. In fact, there's no mention of
terser-webpack-plugin at all.
This creates a problem with Jekyll (as shown above). I am not sure
what's the best way forward now? Is to embed terser-webpack-plugin
(with it's other dependencies packaged or embedded)? Or to embed
livereload-js into jekyll? Or what?

In any case, this is a bug with src:node-webpack which would be good
to have fixed.


Yes, this is a bug in webpack. As a work around try if --mode 
development to webpack command works. In production mode it minifies 
by default.


For actual fix terser-webpack-plugin needs packaging (someone is 
working on it already). It will have to clear new. In the short term, 
we can patch webpack to use uglifyjs-webpack-plugin which is already 
patched to use terser.


I have patched webpack to use uglifyjs-webpack-plugin till 
terser-webpack-plugin is availabel in the archive. I confirmed jekyll 
is building fine, I'll upload it soon.





Re: RFS: ruby-net-http-persistent

2020-03-14 Thread Pirate Praveen




On Sat, Mar 14, 2020 at 4:45 pm, Utkarsh Gupta  
wrote:

Hi,

On Sat, Mar 14, 2020 at 4:19 PM Pirate Praveen 
 wrote:
 How did you run the autopkgtest? I'm still seeing the failure. 
After bundle-bin-path there should be a testsuite which failed. Can 
anyone else confirm this?


I can confirm that the testsuite fails. There seems to be an 
ArguementError.


```
autopkgtest [16:39:02]: test bundle-bin-path: ---]
autopkgtest [16:39:02]: test bundle-bin-path:  - - - - - - - - - -
results - - - - - - - - - -
bundle-bin-path  PASS
autopkgtest [16:39:02]:  summary
testsuiteFAIL non-zero exit status 1
bundle-gem   PASS
smoke-test   PASS
bundle-bin-path  PASS
```



It is tracked here 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951879


Best,
Utkarsh






Re: RFS: ruby-net-http-persistent

2020-03-14 Thread Utkarsh Gupta
Hi,

On Sat, Mar 14, 2020 at 4:19 PM Pirate Praveen  wrote:
> How did you run the autopkgtest? I'm still seeing the failure. After 
> bundle-bin-path there should be a testsuite which failed. Can anyone else 
> confirm this?

I can confirm that the testsuite fails. There seems to be an ArguementError.

```
autopkgtest [16:39:02]: test bundle-bin-path: ---]
autopkgtest [16:39:02]: test bundle-bin-path:  - - - - - - - - - -
results - - - - - - - - - -
bundle-bin-path  PASS
autopkgtest [16:39:02]:  summary
testsuiteFAIL non-zero exit status 1
bundle-gem   PASS
smoke-test   PASS
bundle-bin-path  PASS
```


Best,
Utkarsh



Re: RFS: ruby-net-http-persistent

2020-03-14 Thread Pirate Praveen



On 2020, മാർച്ച് 14 11:53:08 AM IST, Pirate Praveen  
wrote:
>
>
>On 2020, മാർച്ച് 14 10:00:26 AM IST, Samyak Jain
> wrote:
>>Hey,
>>
>>For the ruby-faraday to be uploaded to unstable for v1.0.0. We need to
>>upload ruby-net-http-persistent to unstable.
>
>bundler autopkgtest was failing earlier. Happy to see it working now.
>I'll upload it.

How did you run the autopkgtest? I'm still seeing the failure. After 
bundle-bin-path there should be a testsuite which failed. Can anyone else 
confirm this?

>>The changelog entry has been pushed to the team[1].
>>The following dependencies and reverse dependencies;
>>
>>bundler
>>autopkgtest [09:12:46]: test bundle-bin-path:  - - - - - - - - - -
>>results
>>- - - - - - - - - -
>>autopkgtest [09:12:46]:  summary
>>bundle-gem  PASS
>>smoke-test   PASS
>>bundle-bin-path PASS
>>
>>ruby-mechanize
>>autopkgtest [09:15:29]: test run-test: ---]
>>autopkgtest [09:15:29]: test run-test:  - - - - - - - - - - results -
>-
>>- -
>>- - - - - -
>>run-test PASS
>>autopkgtest [09:15:29]:  summary
>>run-test PASS
>>
>>Both are the reverse dependency ruby-faraday and ruby-mechanize are
>>building fine.
>>Therefore, I request if anyone can sponsor for the same.
>>
>>Thanks and regards,
>>Samyak Jain
>>
>>[1] https://salsa.debian.org/ruby-team/ruby-net-http-persistent

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.



Re: RFS: ruby-net-http-persistent

2020-03-14 Thread Pirate Praveen



On 2020, മാർച്ച് 14 10:00:26 AM IST, Samyak Jain  wrote:
>Hey,
>
>For the ruby-faraday to be uploaded to unstable for v1.0.0. We need to
>upload ruby-net-http-persistent to unstable.

bundler autopkgtest was failing earlier. Happy to see it working now. I'll 
upload it.

>The changelog entry has been pushed to the team[1].
>The following dependencies and reverse dependencies;
>
>bundler
>autopkgtest [09:12:46]: test bundle-bin-path:  - - - - - - - - - -
>results
>- - - - - - - - - -
>autopkgtest [09:12:46]:  summary
>bundle-gem  PASS
>smoke-test   PASS
>bundle-bin-path PASS
>
>ruby-mechanize
>autopkgtest [09:15:29]: test run-test: ---]
>autopkgtest [09:15:29]: test run-test:  - - - - - - - - - - results - -
>- -
>- - - - - -
>run-test PASS
>autopkgtest [09:15:29]:  summary
>run-test PASS
>
>Both are the reverse dependency ruby-faraday and ruby-mechanize are
>building fine.
>Therefore, I request if anyone can sponsor for the same.
>
>Thanks and regards,
>Samyak Jain
>
>[1] https://salsa.debian.org/ruby-team/ruby-net-http-persistent

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.