Re: reducing volument of KGB notifications on IRC
Hiya, > As per discussion on IRC, this is now live: KGB notifications for > commits and CI pipeline stati are now send to #debian-ruby-changes. I just added the details about #debian-ruby-changes channel to our Ruby team wiki page :) Best, Utkarsh
Re: reducing volument of KGB notifications on IRC
Hi all, On 19-08-29 01:01:08, Georg Faerber wrote: > I'll follow-up to see if consensus can be formed within the Salsa CI > team to disable the pipeline for tags. Just for the record: this change was done upstream now [1]: By default, the pipeline is not run anymore if pushing tags. Cheers, Georg [1] https://salsa.debian.org/salsa-ci-team/pipeline/merge_requests/169
Re: reducing volument of KGB notifications on IRC
On 19-08-28 08:27:26, Georg Faerber wrote: > Still, we could at least disable notifications for the pipelines which > are triggered if tags are pushed. I didn't test this yet, but > disabling the hook for "Tag push events" should do the trick. This > way, the pipeline would still run two times, for the respective commit > and tag, but at least we would only get one notification, instead of > two, thus reducing noise. Any opinion on this? Scratch this -- this won't work, as we want to be notified of pushed tags, but we're not interested in the pipeline result of such a tag. However, there is currently no mechanism in place to distinguish if pipelines were triggered by commits or tags. I'll follow-up to see if consensus can be formed within the Salsa CI team to disable the pipeline for tags. Cheers, Georg
Re: reducing volument of KGB notifications on IRC
Hey, On 28/08/19 4:18 pm, rajudev wrote: > > On 28 August 2019 3:46:27 PM IST, Utkarsh Gupta > wrote: >> Hey, >> >> On 28/08/19 1:57 pm, Georg Faerber wrote: >>> Hi, >>> >>> This topic is two fold, in my opinion: >>> >>> On 19-08-28 08:25:06, Utkarsh Gupta wrote: It doesn't make much sense to run CI on the tags :/ >>> Yes, I agree. That's why I created [1] some time ago, more recently >> [2] >>> was created, both tickets asking to disable CI by default for tags. >>> However, so far, it seems there is no consensus regarding this. >>> If that's not already done, could you please do that as well? >>> Still, we could at least disable notifications for the pipelines >> which >>> are triggered if tags are pushed. I didn't test this yet, but >> disabling >>> the hook for "Tag push events" should do the trick. This way, the >>> pipeline would still run two times, for the respective commit and >> tag, >>> but at least we would only get one notification, instead of two, thus >>> reducing noise. Any opinion on this? >> Sounds good; though it doesn't matter much since we have a different >> channel now. >> But sure, until it is officially resolved, I won't mind doing that :D > > Can we all who do not wish to trigger a CI build when tags or any changes are > pushed, start using the CI skipping mechanism/feature provided by Gitlab CI. > > You can include [skip ci] or [ci skip] > in your commit message to skip a CI build. No, we don't want to skip CI for any commits per se. However, we do want to skip CI when pushing a tag. And it is just extra work if we use git for skipping CI pipelines on the tags for individual packages. Disabling them for all at once makes more sense here. Best, Utkarsh signature.asc Description: OpenPGP digital signature
Re: reducing volument of KGB notifications on IRC
On 28 August 2019 3:46:27 PM IST, Utkarsh Gupta wrote: >Hey, > >On 28/08/19 1:57 pm, Georg Faerber wrote: >> Hi, >> >> This topic is two fold, in my opinion: >> >> On 19-08-28 08:25:06, Utkarsh Gupta wrote: >>> It doesn't make much sense to run CI on the tags :/ >> Yes, I agree. That's why I created [1] some time ago, more recently >[2] >> was created, both tickets asking to disable CI by default for tags. >> However, so far, it seems there is no consensus regarding this. >> >>> If that's not already done, could you please do that as well? >> Still, we could at least disable notifications for the pipelines >which >> are triggered if tags are pushed. I didn't test this yet, but >disabling >> the hook for "Tag push events" should do the trick. This way, the >> pipeline would still run two times, for the respective commit and >tag, >> but at least we would only get one notification, instead of two, thus >> reducing noise. Any opinion on this? > >Sounds good; though it doesn't matter much since we have a different >channel now. >But sure, until it is officially resolved, I won't mind doing that :D Can we all who do not wish to trigger a CI build when tags or any changes are pushed, start using the CI skipping mechanism/feature provided by Gitlab CI. You can include [skip ci] or [ci skip] in your commit message to skip a CI build. More details here https://docs.gitlab.com/ce/ci/yaml/#skipping-jobs > > >Best, >Utkarsh -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Re: reducing volument of KGB notifications on IRC
Hey, On 28/08/19 1:57 pm, Georg Faerber wrote: > Hi, > > This topic is two fold, in my opinion: > > On 19-08-28 08:25:06, Utkarsh Gupta wrote: >> It doesn't make much sense to run CI on the tags :/ > Yes, I agree. That's why I created [1] some time ago, more recently [2] > was created, both tickets asking to disable CI by default for tags. > However, so far, it seems there is no consensus regarding this. > >> If that's not already done, could you please do that as well? > Still, we could at least disable notifications for the pipelines which > are triggered if tags are pushed. I didn't test this yet, but disabling > the hook for "Tag push events" should do the trick. This way, the > pipeline would still run two times, for the respective commit and tag, > but at least we would only get one notification, instead of two, thus > reducing noise. Any opinion on this? Sounds good; though it doesn't matter much since we have a different channel now. But sure, until it is officially resolved, I won't mind doing that :D Best, Utkarsh signature.asc Description: OpenPGP digital signature
Re: reducing volument of KGB notifications on IRC
Hi, This topic is two fold, in my opinion: On 19-08-28 08:25:06, Utkarsh Gupta wrote: > It doesn't make much sense to run CI on the tags :/ Yes, I agree. That's why I created [1] some time ago, more recently [2] was created, both tickets asking to disable CI by default for tags. However, so far, it seems there is no consensus regarding this. > If that's not already done, could you please do that as well? Still, we could at least disable notifications for the pipelines which are triggered if tags are pushed. I didn't test this yet, but disabling the hook for "Tag push events" should do the trick. This way, the pipeline would still run two times, for the respective commit and tag, but at least we would only get one notification, instead of two, thus reducing noise. Any opinion on this? Cheers, Georg [1] https://salsa.debian.org/salsa-ci-team/pipeline/issues/39 [2] https://salsa.debian.org/salsa-ci-team/pipeline/issues/77
Re: reducing volument of KGB notifications on IRC
Hey, On 27/08/19 2:25 pm, Georg Faerber wrote: > On 19-08-27 08:44:47, Georg Faerber wrote: >> Also, Antonio, I think consensus is reached regarding your initial >> proposal, minus squashing the commits, so I think you're good to go >> ahead. > If possible, I would like to not receive build notifications for tags, > but just for commits. In the huge majority of cases both will have the > same result, as the tagged commit is the one which is tested as well, so > the information is quite redundant. Oh yes, please! It doesn't make much sense to run CI on the tags :/ If that's not already done, could you please do that as well? Best, Utkarsh signature.asc Description: OpenPGP digital signature
Re: reducing volument of KGB notifications on IRC
Hey, On 27/08/19 7:04 pm, Georg Faerber wrote: > On 19-08-27 08:44:47, Georg Faerber wrote: >> Also, Antonio, I think consensus is reached regarding your initial >> proposal, minus squashing the commits, so I think you're good to go >> ahead. > As per discussion on IRC, this is now live: KGB notifications for > commits and CI pipeline stati are now send to #debian-ruby-changes. Thanks for all the work, Georg. Best, Utkarsh signature.asc Description: OpenPGP digital signature
Re: reducing volument of KGB notifications on IRC
On 19-08-27 08:44:47, Georg Faerber wrote: > Also, Antonio, I think consensus is reached regarding your initial > proposal, minus squashing the commits, so I think you're good to go > ahead. As per discussion on IRC, this is now live: KGB notifications for commits and CI pipeline stati are now send to #debian-ruby-changes. Cheers, Georg
Re: reducing volument of KGB notifications on IRC
On 19-08-27 08:44:47, Georg Faerber wrote: > Also, Antonio, I think consensus is reached regarding your initial > proposal, minus squashing the commits, so I think you're good to go > ahead. If possible, I would like to not receive build notifications for tags, but just for commits. In the huge majority of cases both will have the same result, as the tagged commit is the one which is tested as well, so the information is quite redundant. Cheers, Georg
Re: reducing volument of KGB notifications on IRC
Hi all, On 19-08-17 13:02:44, Antonio Terceiro wrote: > fair enough. I noticed that the python team has two channels: > #debian-python for humans, and #debian-python-changes for > notifications. maybe we could do something similar? This seems like the way to go given all the mails in response, so I registered #debian-ruby-changes. Feel free to join! Also, Antonio, I think consensus is reached regarding your initial proposal, minus squashing the commits, so I think you're good to go ahead. Cheers, Georg
Re: reducing volument of KGB notifications on IRC
On 19-08-18 22:57:29, Cédric Boutillier wrote: > Having a dedicated channel for notifications would be a nice solution > to get all the information we want and keep a sane place for human > interactions. +1
Re: reducing volument of KGB notifications on IRC
Hi! On Sat, Aug 17, 2019 at 01:02:44PM -0300, Antonio Terceiro wrote: > fair enough. I noticed that the python team has two channels: > #debian-python for humans, and #debian-python-changes for notifications. > maybe we could do something similar? Having a dedicated channel for notifications would be a nice solution to get all the information we want and keep a sane place for human interactions. Cheers, Cédric signature.asc Description: PGP signature
Re: reducing volument of KGB notifications on IRC
Hey, On 17/08/19 9:32 pm, Antonio Terceiro wrote: > On Sat, Aug 17, 2019 at 01:05:52PM +0530, Utkarsh Gupta wrote: >> I'd always say that it is a good idea to see who's doing what under the >> Ruby team. >> At least, I'd like to see other's commit; helps me explore the different >> ways. For instance, the other day, Daniel's commit of setting and >> exporting LANG/LC_ALL to C.UTF-8 for tests did help me with something I >> was stuck on. >> I am not sure if I'd want to see KGB "squashing" the commits :/ >> But of course, it is a team decision :D >> >> OTOH, I am fine by the CI thingy. Not an ardent fan of viewing CI logs. > fair enough. I noticed that the python team has two channels: > #debian-python for humans, and #debian-python-changes for notifications. > maybe we could do something similar? That'd be lovely. Please do that :) Best, Utkarsh signature.asc Description: OpenPGP digital signature
Re: reducing volument of KGB notifications on IRC
Hi Em 17 de agosto de 2019 13:02:44 BRT, Antonio Terceiro escreveu: >On Sat, Aug 17, 2019 at 01:05:52PM +0530, Utkarsh Gupta wrote: >> Hey, >> >> On 16/08/19 7:09 pm, Antonio Terceiro wrote: >> > Hi, >> > >> > To reduce the volume of KGB notifications on IRC, I intend to run >the >> > following: >> > >> > $ salsa --group ruby-team update_repo --all --kgb --irc >'debian-ruby_only_status=failed_threshold=1' >> > >> > - squash_threshold=1 will make KGB notify only once each time >multiple >> > commits are pushed >> > - pipeline_only_status=failed makes KGB notify only when pipelines >fail >> > (i.e. no new is good news). >> > >> > This is an attempt to reduce the wall of notifications on >#debian-ruby >> > and leave more space for us humans to chat. >> > >> > Thoughts? >> >> I'd always say that it is a good idea to see who's doing what under >the >> Ruby team. >> At least, I'd like to see other's commit; helps me explore the >different >> ways. For instance, the other day, Daniel's commit of setting and >> exporting LANG/LC_ALL to C.UTF-8 for tests did help me with something >I >> was stuck on. >> I am not sure if I'd want to see KGB "squashing" the commits :/ >> But of course, it is a team decision :D >> >> OTOH, I am fine by the CI thingy. Not an ardent fan of viewing CI >logs. > >fair enough. I noticed that the python team has two channels: >#debian-python for humans, and #debian-python-changes for >notifications. >maybe we could do something similar? Sounds a good solution for me. Cheers! -- Enviado de meu dispositivo Android com K-9 mail. Desculpe-me pela brevidade.
Re: reducing volument of KGB notifications on IRC
On Sat, Aug 17, 2019 at 01:05:52PM +0530, Utkarsh Gupta wrote: > Hey, > > On 16/08/19 7:09 pm, Antonio Terceiro wrote: > > Hi, > > > > To reduce the volume of KGB notifications on IRC, I intend to run the > > following: > > > > $ salsa --group ruby-team update_repo --all --kgb --irc > > 'debian-ruby_only_status=failed_threshold=1' > > > > - squash_threshold=1 will make KGB notify only once each time multiple > > commits are pushed > > - pipeline_only_status=failed makes KGB notify only when pipelines fail > > (i.e. no new is good news). > > > > This is an attempt to reduce the wall of notifications on #debian-ruby > > and leave more space for us humans to chat. > > > > Thoughts? > > I'd always say that it is a good idea to see who's doing what under the > Ruby team. > At least, I'd like to see other's commit; helps me explore the different > ways. For instance, the other day, Daniel's commit of setting and > exporting LANG/LC_ALL to C.UTF-8 for tests did help me with something I > was stuck on. > I am not sure if I'd want to see KGB "squashing" the commits :/ > But of course, it is a team decision :D > > OTOH, I am fine by the CI thingy. Not an ardent fan of viewing CI logs. fair enough. I noticed that the python team has two channels: #debian-python for humans, and #debian-python-changes for notifications. maybe we could do something similar? signature.asc Description: PGP signature
Re: reducing volument of KGB notifications on IRC
Hey, On 16/08/19 7:09 pm, Antonio Terceiro wrote: > Hi, > > To reduce the volume of KGB notifications on IRC, I intend to run the > following: > > $ salsa --group ruby-team update_repo --all --kgb --irc > 'debian-ruby_only_status=failed_threshold=1' > > - squash_threshold=1 will make KGB notify only once each time multiple > commits are pushed > - pipeline_only_status=failed makes KGB notify only when pipelines fail > (i.e. no new is good news). > > This is an attempt to reduce the wall of notifications on #debian-ruby > and leave more space for us humans to chat. > > Thoughts? I'd always say that it is a good idea to see who's doing what under the Ruby team. At least, I'd like to see other's commit; helps me explore the different ways. For instance, the other day, Daniel's commit of setting and exporting LANG/LC_ALL to C.UTF-8 for tests did help me with something I was stuck on. I am not sure if I'd want to see KGB "squashing" the commits :/ But of course, it is a team decision :D OTOH, I am fine by the CI thingy. Not an ardent fan of viewing CI logs. Also, if the team thinks that it is a good idea to disable both to reduce the noise, then that is fine as well. Best, Utkarsh signature.asc Description: OpenPGP digital signature
