Re: OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
Hi Nilesh, Am Mon, Nov 28, 2022 at 01:44:16PM +0530 schrieb Nilesh Patra: > > I'm in favour of droping the OCaml patch. > > I guess the Ocaml patch was needed for pplacer. Now pplacer FTBFS due to > removed > ocaml patch/binpkg. See Bug#1024889 Ah, yes, sure, I'm blaming my very bad memory. :-( > We need to fix this before the cruft removal happens. Unfortunately I have no idea how to fix old, unmaintained OCaml code. Thus I include debian-ocaml-ma...@lists.debian.org for potential helpers. For its readers I shortly the situation: Shayan Doust took the challenge and successfully ported an unmaintained patch for mcl which provides OCaml support which is needed for the package pplacer. I decided to deactivate the patch[1] since its not maintained upstream any more. It would be really great if you could lend some helping hand to upgrade the patch to mcl version 22-282. Unfortunately Salsa CI does not contain the log of the failures any more but if it helps I could easily create the errors in the build process. Kind regards Andreas. > [1] > https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch > [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- http://fam-tille.de
Re: OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
On Fri, Oct 28, 2022 at 10:47:01PM +0200, Andreas Tille wrote: > Am Sat, Oct 29, 2022 at 01:32:59AM +0530 schrieb Nilesh Patra: > > > > > On Wed, Oct 26, 2022 at 11:17:38AM +0200, Andreas Tille wrote: > > > Shayan, do you think you can fix this patch you once obtained from some > > > project that seems to have stalled since 9 years? Otherwise I'd tend to > > > remove the patch and thus the OCaml support again. > > > > I am interested in knowing as to why are we keeping ocaml support in the > > first place? > > In other words, what is the purpose of the patch? > > (Upstream project seems to be written in C) > > I'm in favour of droping the OCaml patch. I guess the Ocaml patch was needed for pplacer. Now pplacer FTBFS due to removed ocaml patch/binpkg. See Bug#1024889 We need to fix this before the cruft removal happens. > > > [1] > > > https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch > > > [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- Best, Nilesh signature.asc Description: PGP signature
Re: OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
Hi, Am Sat, Oct 29, 2022 at 01:32:59AM +0530 schrieb Nilesh Patra: > > On Wed, Oct 26, 2022 at 11:17:38AM +0200, Andreas Tille wrote: > > Shayan, do you think you can fix this patch you once obtained from some > > project that seems to have stalled since 9 years? Otherwise I'd tend to > > remove the patch and thus the OCaml support again. > > I am interested in knowing as to why are we keeping ocaml support in the > first place? > In other words, what is the purpose of the patch? > (Upstream project seems to be written in C) I'm in favour of droping the OCaml patch. Kind regards Andreas. > > [1] > > https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch > > [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- http://fam-tille.de
Re: OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
Shayan, do you think you can fix this patch you once obtained from some > project that seems to have stalled since 9 years? Otherwise I'd tend to > remove the patch and thus the OCaml support again. I am interested in knowing as to why are we keeping ocaml support in the first place? In other words, what is the purpose of the patch? (Upstream project seems to be written in C) > [1] > https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch > [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- Best, Nilesh signature.asc Description: PGP signature
OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
Hi Joost, Am Tue, Oct 25, 2022 at 03:41:57PM +0200 schrieb Joost van Baal-Ilić: > > > Do you have any idea where to obtain util/rand.h? > > > > It came with cimfomfa-18-238/util/rand.h > > > > does current cimfomfa no longer ship it? > > I think you have to patch it: replace > > #include "util/rand.h" > > with > > #include Hmmm, I think the problem is the OCaml patch[1] which leads to build issues now. It was also the place where rand.h was included. Shayan, do you think you can fix this patch you once obtained from some project that seems to have stalled since 9 years? Otherwise I'd tend to remove the patch and thus the OCaml support again. Kind regards Andreas. [1] https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- http://fam-tille.de
