Bug#942609: pspp: build with -O2 to avoid misbuild with CFLAGS=-O3

2019-10-18 Thread Ben Pfaff 
On Fri, Oct 18, 2019 at 4:27 PM Steve Langasek
 wrote:
>
> Package: pspp
> Version: 1.2.0-3
> Severity: minor
> Tags: patch
> User: ubuntu-de...@lists.ubuntu.com
> Usertags: origin-ubuntu focal ubuntu-patch
>
> Dear maintainers,
>
> In Ubuntu, pspp was failing to build on ppc64el because the Ubuntu ppc64el
> port, unlike Debian's, uses -O3 as the default optimization level; and when
> built this way, at least on ppc64el the package fails one of its tests:
>
> [...]
> ##  ##
> Failed tests:
> GNU PSPP 1.2.0 test suite test groups:
>
>  NUM: FILE-NAME:LINE TEST-GROUP-NAME
>   KEYWORDS
>
>  126: sys-file-reader.at:2951 zero or one variable in mrset
>   sack synthetic system file negative multiple response
>
> ## -- ##
> ## Detailed failed tests. ##
> ## -- ##
>
> # -*- compilation -*-
> 126. sys-file-reader.at:2951: testing zero or one variable in mrset ...
> ./sys-file-reader.at:2970: sack --$variant sys-file.sack > sys-file.sav
> ./sys-file-reader.at:2973: pspp -O format=csv sys-file.sps
> --- -   2019-01-16 11:24:48.338741568 +
> +++ /<>/tests/testsuite.dir/at-groups/126/stdout   2019-01-16 
> 11:24:48.335475863 +
> @@ -1,3 +1,5 @@
> +warning: `sys-file.sav' near offset 0xd8: Missing new-line parsing variable 
> names at offset 22 in MRSETS record.

Thank you very much for the note and the patch.

Do you have any idea whether this is likely to be a previously unknown bug
in PSPP (as opposed to a bug somewhere else, such as in GCC)? I feel like
I ought to invest some time into trying to find a PSPP bug here, but on the
other hand I don't want to chase a ghost.

-- 
debian-science-maintainers mailing list
debian-science-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#942609: pspp: build with -O2 to avoid misbuild with CFLAGS=-O3

2019-10-18 Thread Steve Langasek 
Package: pspp
Version: 1.2.0-3
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, pspp was failing to build on ppc64el because the Ubuntu ppc64el
port, unlike Debian's, uses -O3 as the default optimization level; and when
built this way, at least on ppc64el the package fails one of its tests:

[...]
##  ##
Failed tests:
GNU PSPP 1.2.0 test suite test groups:

 NUM: FILE-NAME:LINE TEST-GROUP-NAME
  KEYWORDS

 126: sys-file-reader.at:2951 zero or one variable in mrset
  sack synthetic system file negative multiple response

## -- ##
## Detailed failed tests. ##
## -- ##

# -*- compilation -*-
126. sys-file-reader.at:2951: testing zero or one variable in mrset ...
./sys-file-reader.at:2970: sack --$variant sys-file.sack > sys-file.sav
./sys-file-reader.at:2973: pspp -O format=csv sys-file.sps
--- -   2019-01-16 11:24:48.338741568 +
+++ /<>/tests/testsuite.dir/at-groups/126/stdout   2019-01-16 
11:24:48.335475863 +
@@ -1,3 +1,5 @@
+warning: `sys-file.sav' near offset 0xd8: Missing new-line parsing variable 
names at offset 22 in MRSETS record.
+
 warning: `sys-file.sav': MRSET $a has only one variable.
 
 warning: `sys-file.sav': MRSET $b has no variables.
126. sys-file-reader.at:2951: 126. zero or one variable in mrset 
(sys-file-reader.at:2951): FAILED (sys-file-reader.at:2973)
[...]

  (https://launchpad.net/ubuntu/+source/pspp/1.2.0-2build1/+build/16278288)

We've therefore uploaded the attached patch to Ubuntu to get the package
building on all architectures.

While this issue doesn't affect Debian in its default configuration, this
patch or one like it would help make the package more resilient to
downstreams that use other build flags.

Thanks for considering,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru pspp-1.2.0/debian/rules pspp-1.2.0/debian/rules
--- pspp-1.2.0/debian/rules 2019-04-23 04:59:03.0 -0700
+++ pspp-1.2.0/debian/rules 2019-10-01 16:45:29.0 -0700
@@ -29,6 +29,11 @@
 #CONFIGUREFLAGS =
 #endif
 
+ifeq ($(DEB_HOST_ARCH),ppc64el)
+  export DEB_CFLAGS_MAINT_APPEND += -O2
+  export DEB_CFLAGS_MAINT_STRIP += -O3
+endif
+
 %:
dh $@ --with autoreconf,elpa
 
-- 
debian-science-maintainers mailing list
debian-science-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers