Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED
Am Montag, den 02.04.2018, 19:53 +0100 schrieb Chris Lamb: > Hi Gert, > > > > The comments were listed as being "for" version 7.1.1+dfsg1- > > > 1~exp1 — > > > did you upload with the same version number? That would explain > > > why I > > > thought they remained unaddressed. > > > > Yes, I did upload with the same version. The policy is not clear > > about > > this > > Oh, this has nothing to do with any policy, more that it this time I > got > confused. > > > Regarding the reported problems: > > Thank you for sharing these, but please could you add such things to > your debian/copyright instead of here? Well, the corrected copyright notices and the Files-Excluded obviously now contain the according information - apart from the md5 sum related thing, but this does not really belong into the d/copyright. I just replicated here what I did, kind of to acknowledge the review and the changes it required (a habit from scinetific paper reviews, nothing more) Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED
Hello Chris, Am Freitag, den 30.03.2018, 15:56 +0100 schrieb Chris Lamb: > Hi all, > > > these are the comments I got last year > > The comments were listed as being "for" version 7.1.1+dfsg1-1~exp1 — > did you upload with the same version number? That would explain why I > thought they remained unaddressed. Yes, I did upload with the same version. The policy is not clear about this, and since the first changelog entry must remain for the ITP, I thought that was the usual approach. > > If so, please re-upload and ping me and I will happily take a look. > :) I just did the new upload, this time I changed the name to ~exp2. Regarding the reported problems: * Accelerators/Dax/* have different copyright terms .. corrected * Please mention license of the font under Charts/Core/Testing/Data/Fonts This is only a md5 sum. * Common/Core/CaseFolding.txt is licensed under http://www.unicode.org/ copyright.html Added * Examples/GUI/QT/* are copyright Sandia Corp. and have different licensing terms * Same as above applies for ... Corrected accordingly: However, there is really a mess of slightly variying copyright texts and I don't know to which detail this should be copied into d/copyright. * Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright University of Utah Files removed via d/copyright many thanks for taking another look, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#894462: paraview: edges are blotted [regression]
Am Freitag, den 30.03.2018, 18:01 +0200 schrieb Francesco Poli (wintermute): > Package: paraview > Version: 5.4.1+dfsg4-2 > Severity: grave > Justification: renders package unusable > > Hello paraview Debian package maintainers, > thanks for uploading a Debian revision that uses Qt5 rather than Qt4! > > I've just upgraded to it on my Debian testing box, but I found a bad > regression that renders the package unusable to create beautiful and > clear visualizations (this may be considered as basically the main > purpose of paraview!). Since I did this upload as a team upload I can give you one comment (I don't used the program myself, and I have no idea how to use it, I am only somewhat familiar with VTK, but also only from the "get it to compile" side and not so much from the "how to use it properly"). With this upload I switched the package from using the deprecated "OpenGL" redering interface (based on OpenGL 1.1) to the new "OpenGL2" rendering interface (based on openGL 3.2), which means that his might be a fallout from this rather big upstream change. These two upstream bugs might also be related: https://gitlab.kitware.com/paraview/paraview/issues/17202 https://gitlab.kitware.com/paraview/paraview/issues/16882 Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED
Am 29.03.2018 18:00 schrieb "Chris Lamb": > > > Forwarding notes, please include Luca in any reply. See, also: > > Thu 29 16:38 < mapreri> lamby: can I ask you to either *) forward me the > comments and I'll see what to do next *) accept and open a bunch of RC bugs > as needed *) plain reject with those comments. Whatever feels more sensible > for you in this case (guess it depends on what the comments say…) > > -- Chris Lamb Thu, 29 Mar 2018 15:40:20 + > > > Author: Luca Falavigna > Version: 7.1.1+dfsg1-1~exp1 > Timestamp: 2017-09-01 21:05:53.165364+00:00 > > * Accelerators/Dax/* have different copyright terms than the one mentioned in d/copyright > * Please mention license of the font under Charts/Core/Testing/Data/Fonts > * Common/Core/CaseFolding.txt is licensed under http://www.unicode.org/copyright.html > * Examples/GUI/QT/* are copyright Sandia Corp. and have different licensing terms > * Same as above applies for Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView} > * Same as above applies for Examples/Statistics/* > * Same as above applies for Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrategy.h} > * Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright University of Utah > > > > === > > Please feel free to respond to this email if you don't understand why > your files were rejected, or if you upload new files which address our > concerns. I'm completely baffled, these are the comments I got last year, and unless I've accidently uploaded the old tarball again, these problems should all have been resolved with the upload I did the second time. Currently, I'm travelling and can not check whether I did upload the wrong tarball, but since also Nico did review the package I highly doubt it. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Accepted paraview 5.4.1+dfsg4-2 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Fri, 23 Mar 2018 22:47:21 + Source: paraview Binary: paraview paraview-dev paraview-doc paraview-python Architecture: source Version: 5.4.1+dfsg4-2 Distribution: unstable Urgency: medium Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org> Changed-By: Gert Wollny <g...@debian.org> Description: paraview - Parallel Visualization Application paraview-dev - Parallel Visualization Application. Development header files paraview-doc - Parallel Visualization Application. Comprehensive documentation paraview-python - Parallel Visualization Application. python-support Closes: 893735 Changes: paraview (5.4.1+dfsg4-2) unstable; urgency=medium . * Team upload. * [bd12fc4] d/p/fix_opengl_arm: use Extra OpenGL functions Closes: #893735 Checksums-Sha1: e84895ea9ed4760940a1dc7e94dbc8941fbafce6 2643 paraview_5.4.1+dfsg4-2.dsc 301a5380136e3f6a6024726e028ce832e7c4a4dc 34928 paraview_5.4.1+dfsg4-2.debian.tar.xz eba147d2014986dd1cb5f621b445c6de36066a6d 24585 paraview_5.4.1+dfsg4-2_source.buildinfo Checksums-Sha256: 438ad5b41223aea0db18931e1d0c0b3a876dfa380153c7e5f57c57d10f059da1 2643 paraview_5.4.1+dfsg4-2.dsc 1d0f84fb67796f43bcd043983efdb108f4ee1e824c2f197c44af1e65b02f1264 34928 paraview_5.4.1+dfsg4-2.debian.tar.xz b364188f442f06338c464853d985ef14758bd22d32bc857591a7ab8349ba4729 24585 paraview_5.4.1+dfsg4-2_source.buildinfo Files: e19a746a186aa9fdd0cbae01471fb1f1 2643 science optional paraview_5.4.1+dfsg4-2.dsc 1935d325f22c9e1d4a581561a2467ac6 34928 science optional paraview_5.4.1+dfsg4-2.debian.tar.xz 85a8165b33228bfc491d64030a24c224 24585 science optional paraview_5.4.1+dfsg4-2_source.buildinfo -BEGIN PGP SIGNATURE- iQEzBAEBCAAdFiEENGr+2YOvnEff6Rr7+B42i5smq5gFAlq3cUoACgkQ+B42i5sm q5gqtwf7BdIMhKGluUO9HTteBApdQFK3VCK/aUQUfL8m1BAaTmrFytfdeikzNgnl Ce5Vj9DK7vs+uSXMMnYNia6PkvT7vm8iqAHqHHVBvHeofAqamqzvwy6Glqlt5f7v VrU5O5PfDuEr1TO02b5WHqgtw6kgyOje3mT2KmSaY3a5sDtj34x92UHsWLtGmizq vN+yFz0l2wpF2aGn9VCAP2sLxYbKT8HT+XC1faAEgOT/dVRqXxgptIA/qu2nKy1D izJI0XT2HU84qiRZPjpshe0WE45py8jCOHazQsMvizVWt9ckZT+hllEzAGy8MMos 8H8LNV4NeMQwiqFDLJEOKVVXagX6qA== =Itjg -END PGP SIGNATURE- -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Accepted vtk6 6.3.0+dfsg2-2 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Fri, 23 Mar 2018 22:34:02 +0100 Source: vtk6 Binary: libvtk6-dev libvtk6-qt-dev libvtk6.3 libvtk6.3-qt libvtk6-jni libvtk6-java python-vtk6 tcl-vtk6 vtk6 vtk6-doc vtk6-examples Architecture: source Version: 6.3.0+dfsg2-2 Distribution: unstable Urgency: medium Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org> Changed-By: Gert Wollny <g...@debian.org> Description: libvtk6-dev - VTK header files libvtk6-java - Visualization Toolkit - A high level 3D visualization library - j libvtk6-jni - Visualization Toolkit - A high level 3D visualization library - j libvtk6-qt-dev - VTK header files, containing Qt files libvtk6.3 - VTK libraries libvtk6.3-qt - VTK libraries, Qt files python-vtk6 - Python bindings for VTK tcl-vtk6 - Tcl bindings for VTK vtk6 - Binaries for VTK6 vtk6-doc - VTK class reference documentation vtk6-examples - VTK examples Closes: 893789 Changes: vtk6 (6.3.0+dfsg2-2) unstable; urgency=medium . * [20d58f6] d/rules: Set java src/trgt version Closes: #893789 Checksums-Sha1: 38fb6baa8f61a7fa7097562c01ddc6216a79dfeb 3311 vtk6_6.3.0+dfsg2-2.dsc 77aa54f70295c5c03dac914d4eef9f0c78244eac 32308 vtk6_6.3.0+dfsg2-2.debian.tar.xz 87890e376b011e3bf30bc96af9dd1a940bf4a393 29559 vtk6_6.3.0+dfsg2-2_source.buildinfo Checksums-Sha256: 0886bd4ed88185335b35d35669d41ea673e4ed18f0fe06313448ece36b7cacfb 3311 vtk6_6.3.0+dfsg2-2.dsc 5770adb4f283d5100a92ea3447eaa9f7dd1500daffa0a3e86701f4f455a2a9fe 32308 vtk6_6.3.0+dfsg2-2.debian.tar.xz eda7d150ec047d855bc74ef4f6652b164898a127443121db3876d01c2fd78ec0 29559 vtk6_6.3.0+dfsg2-2_source.buildinfo Files: f1ebdabecdcbe6113a3a49d2d8ea5989 3311 graphics optional vtk6_6.3.0+dfsg2-2.dsc 10e2622b50de1211ff525227220d0a9e 32308 graphics optional vtk6_6.3.0+dfsg2-2.debian.tar.xz 81a509e26b6699ae48e4376b76ccde76 29559 graphics optional vtk6_6.3.0+dfsg2-2_source.buildinfo -BEGIN PGP SIGNATURE- iQEzBAEBCAAdFiEENGr+2YOvnEff6Rr7+B42i5smq5gFAlq1qlIACgkQ+B42i5sm q5jMVAgAh7dppxBf5TOpZkS81CwzicRRdK+TsMp/ccyBcWQRO65X44uhP/DuWaSG gNUWGnMHOn4sEV36fsivMnpdbcIMarJUnCeJZt1TDugSdRq4ZhV/gXfiCJj3pJ1k toMOAG5HSpj28Boe9g6wTYIpp3H1wTO0cDpTusA2PuQWQ7xoxGbUszp/JU7+jmlN kdPnHul77He5aoAH4jhORxl+QLmPrkj4RiiawsGqeynmKirbTRs9qEDQAY/X0qxC EhPFR6ZsHdeobMn6lSsPsCvNJCUwOIkxTbPa1OAoQYr+fvI7yVB+dr1W3bbXhSqy 9dstZflVH1Y5K6fcWpI2mh14jynsZQ== =9jjT -END PGP SIGNATURE- -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Accepted paraview 5.4.1+dfsg4-1 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Thu, 15 Mar 2018 19:02:28 +0100 Source: paraview Binary: paraview paraview-dev paraview-doc paraview-python Architecture: source Version: 5.4.1+dfsg4-1 Distribution: unstable Urgency: medium Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org> Changed-By: Gert Wollny <g...@debian.org> Description: paraview - Parallel Visualization Application paraview-dev - Parallel Visualization Application. Development header files paraview-doc - Parallel Visualization Application. Comprehensive documentation paraview-python - Parallel Visualization Application. python-support Changes: paraview (5.4.1+dfsg4-1) unstable; urgency=medium . * Team upload. * [a7b9430] New upstream version 5.4.1+dfsg4 * [117a771] Use backend OpenGL2 * [c5d2240] d/p/fix_gl2ps Update OpenGL2 backend * [145a06f] d/rules: Switch to qt5 * [a7aaa49] d/control: Switch to qt5 * [fa81501] d/copyright: remove duplicate BSD-3-clause section * [033db76] d/source: Add some overrides for the package Checksums-Sha1: c96151112f867f653a6160cf086b25cf5ddf4ca9 2643 paraview_5.4.1+dfsg4-1.dsc d0470a7d7127beaeeebfc08267efe2ddafc8a654 23231272 paraview_5.4.1+dfsg4.orig.tar.xz 42de63a3c5a99c5be2f506acfe298fd11723da91 34368 paraview_5.4.1+dfsg4-1.debian.tar.xz dcff65c1b2e92be189fe612aff297b4a9462fa0c 24496 paraview_5.4.1+dfsg4-1_source.buildinfo Checksums-Sha256: ce2136e66b5a12c491efee6b6db92a5ce55b75934c83ad4ca33e4d72ca622ce8 2643 paraview_5.4.1+dfsg4-1.dsc aa29c185a913f830621844b46d1a5bdd603d9e7f62ef46f73c50d9c83e51f0eb 23231272 paraview_5.4.1+dfsg4.orig.tar.xz 3975f8441b8b905b8d32b94091459243d7c0206648a72ca6ff0fc3dd65c12426 34368 paraview_5.4.1+dfsg4-1.debian.tar.xz 6c12b4cd16fc129d19a40e5425b85783721c82ad133ff348e11e1773ccb3ed36 24496 paraview_5.4.1+dfsg4-1_source.buildinfo Files: 7ee6d5de7dc1ebd16a538c7ac7e5c289 2643 science optional paraview_5.4.1+dfsg4-1.dsc 549daafefa608a740b68e2971af78029 23231272 science optional paraview_5.4.1+dfsg4.orig.tar.xz af9abf1116e44183ccf7f028e5b5be84 34368 science optional paraview_5.4.1+dfsg4-1.debian.tar.xz 8931c8a31bf8dfebb8716813bfadc79b 24496 science optional paraview_5.4.1+dfsg4-1_source.buildinfo -BEGIN PGP SIGNATURE- iQEzBAEBCAAdFiEENGr+2YOvnEff6Rr7+B42i5smq5gFAlqq1FIACgkQ+B42i5sm q5gIRAf/bsaYspKJbXdu6ZUHSZ4WfM8X7yumeTV//1Sloo3BtkofDABxZwiSJN1x X4/JkmD0BaFAw4rfVReucYOGp7zJ1/VfAoYUklyvKjghCAvtTBgCNMYj3uaesGX5 /71rkSJqSc3Cz+lKBmOSYeVGrf74bu5BYj23Hv+OI9ghldGuCy3K99HtlRDq5NNV e8CG2tEH4L9mUQQwRRK7ml/Rk6smyEBbkZNANL0GGirUPOluJhObqL2QWS+fSkib BnZxHgYCMMEqmPe9gUTnnZ4dnalG30OmLIjTwT7wBmf/2asHXr0qYdDuuNKEZ9xV o3ERqyQJkjOdcBFy+8ptlc9+H5Vd/g== =nkoE -END PGP SIGNATURE- -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED
Am Dienstag, den 06.03.2018, 21:37 + schrieb Nico Schlömer: > Perhaps it's time to bring this up again. At six months in the queue, > VTK7 has been the leader in the NEW queue for a while now. It'd be > great if we could work on this again, particularly since VTK8 is > already out there. I guess we will just skip vtk8 and move to vtk9 when it comes out :/ Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Accepted vtk6 6.3.0+dfsg2-1 (source) into unstable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Sat, 03 Mar 2018 23:58:09 +0100 Source: vtk6 Binary: libvtk6-dev libvtk6-qt-dev libvtk6.3 libvtk6.3-qt libvtk6-jni libvtk6-java python-vtk6 tcl-vtk6 vtk6 vtk6-doc vtk6-examples Architecture: source Version: 6.3.0+dfsg2-1 Distribution: unstable Urgency: medium Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org> Changed-By: Gert Wollny <g...@debian.org> Description: libvtk6-dev - VTK header files libvtk6-java - Visualization Toolkit - A high level 3D visualization library - j libvtk6-jni - Visualization Toolkit - A high level 3D visualization library - j libvtk6-qt-dev - VTK header files, containing Qt files libvtk6.3 - VTK libraries libvtk6.3-qt - VTK libraries, Qt files python-vtk6 - Python bindings for VTK tcl-vtk6 - Tcl bindings for VTK vtk6 - Binaries for VTK6 vtk6-doc - VTK class reference documentation vtk6-examples - VTK examples Changes: vtk6 (6.3.0+dfsg2-1) unstable; urgency=medium . * d/copyright: update and remove some more files * d/watch update to old listing * repackage to remove some files with invalid copyright * d/source/lintian-override: override python3 warning Checksums-Sha1: 18147a642a59772d2ab21259adbddf6a62b8fb8e 3311 vtk6_6.3.0+dfsg2-1.dsc 7ea0cdf21fe32118c613774eb9a056b2e408a4fc 18165661 vtk6_6.3.0+dfsg2.orig.tar.gz 18ad63861d9d7acfe00c36b35b734f74243a82a2 32164 vtk6_6.3.0+dfsg2-1.debian.tar.xz a98aa5491136c1962d5406a86c1fad6f9bc9ace4 28895 vtk6_6.3.0+dfsg2-1_source.buildinfo Checksums-Sha256: b9370335e9a7dc5d07c0d7e71c47ae27488672a570ece28c7eb149852269adb2 3311 vtk6_6.3.0+dfsg2-1.dsc 0c823748d66d36678a59c534ec9c919c9188d1176bbf31a511d6f53d503bc4f0 18165661 vtk6_6.3.0+dfsg2.orig.tar.gz 2878895e460567426d6e614520af0e1528b2f55c79a89509b76aa33ed4b603a2 32164 vtk6_6.3.0+dfsg2-1.debian.tar.xz 1a86d8b8d4e32946bd37ba0aff3f5713ce51555d3f2bca331142e42ceb669f22 28895 vtk6_6.3.0+dfsg2-1_source.buildinfo Files: eda0dffb4502fab177468f7d82b2a79d 3311 graphics optional vtk6_6.3.0+dfsg2-1.dsc bf1d5d653ec438d0aa9b2841fdf9fc3e 18165661 graphics optional vtk6_6.3.0+dfsg2.orig.tar.gz b0ca109db7aaf1676d0e588f281d46c4 32164 graphics optional vtk6_6.3.0+dfsg2-1.debian.tar.xz bacd822fb7c3757de9ee5902a3a80b7d 28895 graphics optional vtk6_6.3.0+dfsg2-1_source.buildinfo -BEGIN PGP SIGNATURE- iQEzBAEBCAAdFiEENGr+2YOvnEff6Rr7+B42i5smq5gFAlqdZ7kACgkQ+B42i5sm q5hKmwgAg8Ybp4KyfzAe2bKlxTH/z8thIxYhbNZvEeFIf3Re/z1L80doSlS4t0wY pQhQfwYQy8/53+MofBr1tbgzVGgAGQzk4oC/FxG3SRzhLhdQ4wAQwWAPSYRMq56F dYrq8sZ5wFnef5aHH6tz8qZRW+S7yhoxDxGbzYPwTZqVrA2QdntztaQmUnak79v9 LIx6nCTeNPDed1RsYH6BANxVVV2UdZEqTMeI0GuIff/hWeTXeZ11jnNRe6rDi9Kp MJpVn70Sb5DHiUFCWXgtaxvSoKThWhN1xUxpyEV9OnwG4EhNVQQcd40qkHM/CLI1 RKFNvI0IfLKaIm8r7P/J4Z3d+GmwEA== =x6GT -END PGP SIGNATURE- -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED
Hello Luca, since you did the initial review of the VTK7 package (and it is a really big one), would you consider to have another look at the updated version soon, I ask because we would like to start porting dependent packages. All the issuses you raised should be addressed by now (although what upstream provides there is really a mess). Specifially the for last one with no clear copyright (not even upstream knows) we removed the files since they are not needed anyway. many thanks, Gert Am Freitag, den 01.09.2017, 23:00 + schrieb Luca Falavigna: > Hi, > > * Accelerators/Dax/* have different copyright terms than the one > mentioned in d/copyright > * Please mention license of the font under > Charts/Core/Testing/Data/Fonts > * Common/Core/CaseFolding.txt is licensed under http://www.unicode.or > g/copyright.html > * Examples/GUI/QT/* are copyright Sandia Corp. and have different > licensing terms > * Same as above applies for > Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView} > * Same as above applies for Examples/Statistics/* > * Same as above applies for > Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrat > egy.h} > * Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright > University of Utah > > Cheers, > Luca > > > > === > > Please feel free to respond to this email if you don't understand why > your files were rejected, or if you upload new files which address > our > concerns. > -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED
Hello Luca, thanks for your work on this. One comment though: Am Freitag, den 01.09.2017, 23:00 + schrieb Luca Falavigna: > * Please mention license of the font under > Charts/Core/Testing/Data/Fonts I don't see a font file in this directory, only a md5 hash sum file. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#834493: Bogus value for vtkWrappingJava_RUNTIME_LIBRARY_DIRS
Control: tags -1 wontfix Hello Mathieu, It is true that vtk originally installs the vtk6.jar files into the system library path that is indicated by vtkWrappingJava_RUNTIME_LIBRARY_DIRS, but since this does not conform to Debian policy, vtk6.jar is installed in /usr/share/java/ via d/libvtk6-java.install. However, the value for vtkWrappingJava_RUNTIME_LIBRARY_DIRS is created as part of the general macros for modules in /CMake/vtkModuleAPI.cmake which is somehow indirectly called by vtk_module_library. Since both are generic macros used throughout the VTK build system I don't think it is feasible to change the value from withing the build system. The value could be corrected in d/rules, but since VTK6 is EOL upstream the java module will probably be dropped after the stretch release (or even all of vtk6), and for stretch itself the problem is not grave enough to try to fix it now. I will keep the bug open though and we may later reassign it to vtk7, once that is packaged. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: conflicts between VTK/XDMF and libloki
Hello Alastair, Am Montag, den 05.12.2016, 13:56 + schrieb Alastair McKinstry: > I'm the maintainer of xdmf, which I packaged to work with VisIT and > related code (in particular CDAT, which uses VISIT). > > I originally packaged xdmf, recently moving up to xdmf3 as required > by VTK 7+. (I plan to submit a patch to VTK later to use the external > xdmf rather than its internal copy.) The current version of VTK in Debian is 6.3 (which is EOL upstream), and the internal xdmf version there does not contain a copy of libloki, so there is no problem with libvtk6-dev in stretch. > However it appears that xdmf3 ships its own version of libloki, which > conflicts, especially /usr/include/loki/* > > The xdmf version is similar except it applies its own patch to > /usr/include/loki/Visitor.h, where it passes Xdmf shared pointers, > thus breaking the API/ABI: > > (Compare > https://sources.debian.net/src/libloki/0.1.7-3/include/loki/Visitor.h > / > and > https://sources.debian.net/src/xdmf/3.0%2Bgit20160803-1/core/loki/Vis > itor.h/ > ) > I'm at a loss what to do at this point - can the libloki and VTK > packagers give an opinion? One of libloki-dev and libxdmf-dev should declare a conflict with th eother. Luckily xmdf doesn't ship the loki-library (I assume for that reason it is smaller), so that there are no conflicts when installing the libraries. Of course I would also suggest to file a bug against xdmf upstream and ask them to change the file name, namespace, and include guards of their embedded loki version to avoid conflicts with the original loki library. hope that helps, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#846372: vtk6: FTBFS: /< ...
Hello Iain, thanks for the patch and please go ahead with the upload. I will take care of adding it to the packaging git. There is no use in forwarding this to upstream, because for them vtk-6 is EOL, they are now at vtk-7 which will only be packaged after stretch is released. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#811682: Updated patch
Hi, I've updated the patch according to my last comment and also tested it with g++-5 (i.e. without -std=c++11) and it builds successfully. Note however that their are lintian errors: E: libgtkmathview-dev: pkg-config-multi-arch-wrong-dir usr/lib/pkgconfig/gtkmathview-gmetadom.pc full text contains architecture specific dir x86_64-linux-gnu E: libgtkmathview-dev: pkg-config-multi-arch-wrong-dir usr/lib/pkgconfig/mathview-frontend-gmetadom.pc full text contains architecture specific dir x86_64-linux-gnu Best, Gert From: Gert Wollny <gw.foss...@gmail.com> Date: Sun, 26 Jun 2016 13:25:00 +0200 Description: gcc 6.0 build fixes Bug: https://bugs.debian.org/811682 --- a/src/engine/common/View.cc +++ b/src/engine/common/View.cc @@ -291,7 +291,7 @@ } } - return false; + return SmartPtr(); } bool --- a/src/backend/common/tfm/TFM.hh +++ b/src/backend/common/tfm/TFM.hh @@ -37,7 +37,7 @@ unsigned char face; const char* codingScheme; int designSize; -int checksum; +unsigned int checksum; unsigned int nDimensions; unsigned int nCharacters; }; @@ -52,7 +52,7 @@ struct Kerning { UChar8 index; -int value; +unsigned int value; }; struct Ligature @@ -67,7 +67,7 @@ UChar8 index; int width; int height; -int depth; +unsigned int depth; int italicCorrection; unsigned char nKernings; const Kerning* kerning; --- a/src/backend/common/ComputerModernShaper.cc +++ b/src/backend/common/ComputerModernShaper.cc @@ -578,7 +578,7 @@ }; #endif -static ComputerModernShaper::PlainChar cmsMap[] = +static ComputerModernShaper::PlainChar32 cmsMap[] = { { 0x007B, 0x66 }, // LEFT CURLY BRACKET { 0x007D, 0x67 }, // RIGHT CURLY BRACKET --- a/src/backend/common/StandardSymbolsShaper.hh +++ b/src/backend/common/StandardSymbolsShaper.hh @@ -32,20 +32,20 @@ struct HStretchyChar { Char16 ch; -Char8 normal; -Char8 left; -Char8 glue; -Char8 right; +UChar8 normal; +UChar8 left; +UChar8 glue; +UChar8 right; }; struct VStretchyChar { Char16 ch; -Char8 normal; -Char8 top; -Char8 glue; -Char8 middle; -Char8 bottom; +UChar8 normal; +UChar8 top; +UChar8 glue; +UChar8 middle; +UChar8 bottom; }; protected: --- a/src/backend/common/StandardSymbolsShaper.cc +++ b/src/backend/common/StandardSymbolsShaper.cc @@ -29,7 +29,7 @@ #include "ShapingContext.hh" struct GlyphMap { - Char8 index; + UChar8 index; Char16 ch; }; -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#811682: FTBFS with GCC 6: could not convert a from x to y
Are you sure? > It fails to build from source in unstable. > > View.cc: In member function 'SmartPtr View::getCharAt(const > scaled&, const scaled&, CharIndex&, Point*, BoundingBox*) const': > View.cc:294:10: error: 'nullptr' was not declared in this scope > return nullptr; Arrg, "nullptr" is a c++11 construct, and since g++-5 defaults to c++03, it doesn't compile like this. Instead return SmartPtr(); should work in both cases (if this SmartPtr template defines a sensible default constructor). Otherwise "return NULL" should be the (ugly) solution. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#811682: FTBFS with GCC 6: could not convert a from x to y
Control: tags -1 patch Hello, the attached patch fixes the reported compile error and also fixes the "narrowing conversion" errors that came up with g++-6. The package now builds with g++-6 (but it is not lintian-clean). Best, Gert From: Gert Wollny <gw.foss...@gmail.com> Date: Sun, 26 Jun 2016 13:25:00 +0200 Description: gcc 6.0 build fixes Bug: https://bugs.debian.org/811682 --- a/src/engine/common/View.cc +++ b/src/engine/common/View.cc @@ -291,7 +291,7 @@ } } - return false; + return nullptr; } bool --- a/src/backend/common/tfm/TFM.hh +++ b/src/backend/common/tfm/TFM.hh @@ -37,7 +37,7 @@ unsigned char face; const char* codingScheme; int designSize; -int checksum; +unsigned int checksum; unsigned int nDimensions; unsigned int nCharacters; }; @@ -52,7 +52,7 @@ struct Kerning { UChar8 index; -int value; +unsigned int value; }; struct Ligature @@ -67,7 +67,7 @@ UChar8 index; int width; int height; -int depth; +unsigned int depth; int italicCorrection; unsigned char nKernings; const Kerning* kerning; --- a/src/backend/common/ComputerModernShaper.cc +++ b/src/backend/common/ComputerModernShaper.cc @@ -578,7 +578,7 @@ }; #endif -static ComputerModernShaper::PlainChar cmsMap[] = +static ComputerModernShaper::PlainChar32 cmsMap[] = { { 0x007B, 0x66 }, // LEFT CURLY BRACKET { 0x007D, 0x67 }, // RIGHT CURLY BRACKET --- a/src/backend/common/StandardSymbolsShaper.hh +++ b/src/backend/common/StandardSymbolsShaper.hh @@ -32,20 +32,20 @@ struct HStretchyChar { Char16 ch; -Char8 normal; -Char8 left; -Char8 glue; -Char8 right; +UChar8 normal; +UChar8 left; +UChar8 glue; +UChar8 right; }; struct VStretchyChar { Char16 ch; -Char8 normal; -Char8 top; -Char8 glue; -Char8 middle; -Char8 bottom; +UChar8 normal; +UChar8 top; +UChar8 glue; +UChar8 middle; +UChar8 bottom; }; protected: --- a/src/backend/common/StandardSymbolsShaper.cc +++ b/src/backend/common/StandardSymbolsShaper.cc @@ -29,7 +29,7 @@ #include "ShapingContext.hh" struct GlyphMap { - Char8 index; + UChar8 index; Char16 ch; }; -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#826050: Faulty CMake file impairs compiling against VTK
Control: tags -1 wontfix Control: severity -1 wishlist Hello Peter, with the same reasoning as in #826048 I mark this as wontfix. I also downgrade it to wishlist, because I think that the changes needed to fix this are rather grave and offer little gain. As for the listing of packages from 6.2 on the sid page of src:vtk6, I think there all packages are listed that are in sid and are created by some version of vtk6 regardless of the latest version number that is listed, and since there are still packages in sid that are compiled against vtk-6.2 these libvtk*6.2 packages are (still) listed there. best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#820450: yade: FTBFS with glibc 2.23: 'isnan' was not declared in this scope
Hi, I've updated the patch to use the std:: namespace prefix instead of "using std::xxx" - in the header files this is a cleaner approach. Best, Gert --- a/gui/qt4/GLViewer.cpp +++ b/gui/qt4/GLViewer.cpp @@ -350,7 +350,7 @@ if(not(rb->bound)){ rb->updateBound();} min=rb->bound->min; max=rb->bound->max; - bool hasNan=(isnan(min[0])||isnan(min[1])||isnan(min[2])||isnan(max[0])||isnan(max[1])||isnan(max[2])); + bool hasNan=(std::isnan(min[0])||std::isnan(min[1])||std::isnan(min[2])||std::isnan(max[0])||std::isnan(max[1])||std::isnan(max[2])); Real minDim=std::min(max[0]-min[0],std::min(max[1]-min[1],max[2]-min[2])); if(minDim<=0 || hasNan){ // Aabb is not yet calculated... @@ -362,7 +362,7 @@ max=max.cwiseMax(b->state->pos); min=min.cwiseMin(b->state->pos); } - if(isinf(min[0])||isinf(min[1])||isinf(min[2])||isinf(max[0])||isinf(max[1])||isinf(max[2])){ LOG_DEBUG("No min/max computed from bodies either, setting cube (-1,-1,-1)×(1,1,1)"); min=-Vector3r::Ones(); max=Vector3r::Ones(); } + if(std::isinf(min[0])||std::isinf(min[1])||std::isinf(min[2])||std::isinf(max[0])||std::isinf(max[1])||std::isinf(max[2])){ LOG_DEBUG("No min/max computed from bodies either, setting cube (-1,-1,-1)×(1,1,1)"); min=-Vector3r::Ones(); max=Vector3r::Ones(); } } else {LOG_DEBUG("Using scene's Aabb");} LOG_DEBUG("Got scene box min="<
Bug#818817: woo: FTBFS with libc 2.23: 'isnan' was not declared in this scope (patch)
Control: tags -1 patch Hi, the attached patch adds std:: to all instances of isnan and isinf in the c++ code, and this fixes the bug. Best, Gert --- a/core/Cell.cpp +++ b/core/Cell.cpp @@ -62,7 +62,7 @@ // spin tensor W=.5*(gradV-gradV.transpose()); spinVec=.5*leviCivita(W); - // if(!isnan(nnextGradV(0,0))){ nextGradV=nnextGradV; nnextGradV<=0){ - if(isnan(val)){ LOG_WARN("Ignoring attempt to add NaN to energy '"< pyStr()+": "< setNextGradV(); step++; time+=dt; /* gives -1 along with the increment afterwards */ subStep=-2; -if(!isnan(nextDt)){ dt=nextDt; nextDt=NaN; } +if(!std::isnan(nextDt)){ dt=nextDt; nextDt=NaN; } } // (?!) else { /* never reached */ assert(false); } --- a/gui/qt4/GLViewer.cpp +++ b/gui/qt4/GLViewer.cpp @@ -887,7 +887,7 @@ Vector3r p3v(p3[0],p3[1],p3[2]); p3v[diri]=NaN; for(short ax:{0,1,2}){ std::ostringstream oss; - oss<<(isnan(p3v[ax])?"*":to_string(p3v[ax])); + oss<<(std::isnan(p3v[ax])?"*":to_string(p3v[ax])); glColor3v(Renderer::axisColor(ax)); QGLViewer::drawText(p.x()+20,p.y()+14*(ax+1),oss.str().c_str()); } --- a/gui/qt4/OpenGLManager.cpp +++ b/gui/qt4/OpenGLManager.cpp @@ -41,7 +41,7 @@ frameMeasureTime=0; t=1e-9*(woo::TimingInfo::getNow(/*evenIfDisabled*/true)-t); // in seconds Real& dt(Renderer::fastDraw?Renderer::fastRenderTime:Renderer::renderTime); - if(isnan(dt)) dt=t; + if(std::isnan(dt)) dt=t; dt=.6*dt+.4*(t); } else { frameMeasureTime++; --- a/lib/base/CompUtils.cpp +++ b/lib/base/CompUtils.cpp @@ -133,7 +133,7 @@ // return sample for cylindrical coordinate "box" uniformly-distributed in cartesian space; returned point is in cylindrical coordinates Vector3r CompUtils::cylCoordBox_sample_cylindrical(const AlignedBox3r& box, const Vector3r& unitRand){ // three random numbers; can be user-provided (for biased sampling), otherwise computed - Vector3r rand=isnan(unitRand.maxCoeff())?Vector3r(Mathr::UnitRandom(),Mathr::UnitRandom(),Mathr::UnitRandom()):unitRand; + Vector3r rand=std::isnan(unitRand.maxCoeff())?Vector3r(Mathr::UnitRandom(),Mathr::UnitRandom(),Mathr::UnitRandom()):unitRand; // explanation at http://www.anderswallin.net/2009/05/uniform-random-points-in-a-circle-using-polar-coordinates/ const Real& r0(box.min()[0]); const Real& r1(box.max()[0]); Real r=sqrt(pow(r0,2)+rand.x()*(pow(r1,2)-pow(r0,2))); --- a/lib/opengl/GLUtils.cpp +++ b/lib/opengl/GLUtils.cpp @@ -34,7 +34,7 @@ void GLUtils::AlignedBox(const
Bug#820450: FTBFS with glibc 2.23: 'isnan' was not declared in this scope
Hi Anton, the attached patch fixes all instances of isnan/isinf compilation errors. I did a test build against libvtk6.3 (which passes), therefore I came across this problem). best, Gert --- a/gui/qt4/GLViewer.cpp +++ b/gui/qt4/GLViewer.cpp @@ -28,6 +28,8 @@ #include #endif +using std::isnan; + static unsigned initBlocked(State::DOF_NONE); CREATE_LOGGER(GLViewer); --- a/home/gerddie/vtk63-transition/yade-1.20.0/gui/qt5/GLViewer.cpp +++ /dev/null @@ -1,488 +0,0 @@ -/* -* Copyright (C) 2004 by Olivier Galizzi * -* olivier.gali...@imag.fr * -* Copyright (C) 2005 by Janek Kozicki * -* cosu...@berlios.de* -** -* This program is free software; it is licensed under the terms of the * -* GNU General Public License v2 or later. See file LICENSE for details. * -*/ - -#include"GLViewer.hpp" -#include"OpenGLManager.hpp" - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#ifdef YADE_GL2PS - #include -#endif - -static unsigned initBlocked(State::DOF_NONE); - -CREATE_LOGGER(GLViewer); - -GLLock::GLLock(GLViewer* _glv): boost::try_mutex::scoped_lock(Omega::instance().renderMutex), glv(_glv){ - glv->makeCurrent(); -} -GLLock::~GLLock(){ glv->doneCurrent(); } - - -#define _W3 setw(3)<emitCloseView(viewId); - e->accept(); -} - -GLViewer::GLViewer(int _viewId, const shared_ptr& _renderer, QGLWidget* shareWidget): QGLViewer(/*parent*/(QWidget*)NULL,shareWidget), renderer(_renderer), viewId(_viewId) { - isMoving=false; - drawGrid=0; - drawScale=true; - timeDispMask=TIME_REAL|TIME_VIRT|TIME_ITER; - cut_plane = 0; - cut_plane_delta = -2; - gridSubdivide = false; - resize(550,550); - last=-1; - if(viewId==0) setWindowTitle("Primary view"); - else setWindowTitle(("Secondary view #"+boost::lexical_cast(viewId)).c_str()); - - show(); - - mouseMovesCamera(); - manipulatedClipPlane=-1; - - if(manipulatedFrame()==0) setManipulatedFrame(new qglviewer::ManipulatedFrame()); - - xyPlaneConstraint=shared_ptr(new qglviewer::LocalConstraint()); - manipulatedFrame()->setConstraint(NULL); - - setKeyDescription(Qt::Key_Return,"Run simulation."); - setKeyDescription(Qt::Key_A,"Toggle visibility of global axes."); - setKeyDescription(Qt::Key_C,"Set scene center so that all bodies are visible; if a body is selected, center around this body."); - setKeyDescription(Qt::Key_C & Qt::AltModifier,"Set scene center to median body position (same as space)"); - setKeyDescription(Qt::Key_D,"Toggle time display mask"); - setKeyDescription(Qt::Key_G,"Toggle grid visibility; g turns on and cycles"); - setKeyDescription(Qt::Key_G & Qt::ShiftModifier ,"Hide grid."); - setKeyDescription(Qt::Key_M, "Move selected object."); - setKeyDescription(Qt::Key_X,"Show the xz [shift: xy] (up-right) plane (clip plane: align normal with +x)"); - setKeyDescription(Qt::Key_Y,"Show the yx [shift: yz] (up-right) plane (clip plane: align normal with +y)"); - setKeyDescription(Qt::Key_Z,"Show the zy [shift: zx] (up-right) plane (clip plane: align normal with +z)"); - setKeyDescription(Qt::Key_Period,"Toggle grid subdivision by 10"); - setKeyDescription(Qt::Key_S,"Save QGLViewer state to /tmp/qglviewerState.xml"); - setKeyDescription(Qt::Key_T,"Switch orthographic / perspective camera"); - setKeyDescription(Qt::Key_O,"Set narrower field of view"); - setKeyDescription(Qt::Key_P,"Set wider field of view"); - setKeyDescription(Qt::Key_R,"Revolve around scene center"); - setKeyDescription(Qt::Key_V,"Save PDF of the current view to /tmp/yade-snapshot-0001.pdf (whichever number is available first). (Must be compiled with the gl2ps feature.)"); - setPathKey(-Qt::Key_F1); - setPathKey(-Qt::Key_F2); - setKeyDescription(Qt::Key_Escape,"Manipulate scene (default)"); - setKeyDescription(Qt::Key_F1,"Manipulate clipping plane #1"); - setKeyDescription(Qt::Key_F2,"Manipulate clipping plane #2"); - setKeyDescription(Qt::Key_F3,"Manipulate clipping plane #3"); - setKeyDescription(Qt::Key_1,"Make the manipulated clipping plane parallel with plane #1"); - setKeyDescription(Qt::Key_2,"Make the manipulated clipping plane parallel with plane #2"); - setKeyDescription(Qt::Key_2,"Make the manipulated clipping plane parallel with plane #3"); - setKeyDescription(Qt::Key_1 & Qt::AltModifier,"Add/remove plane #1 to/from the bound group"); -
Bug#750184: Reopen this for now
Control: reopen -1 The next upload will revert this change since the use of the system provided proj4 introduced an ABI-incompatibility. I'll deal with this when uploading 6.3.0. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#819741: libvtk6-dev: No rule to make target libproj.so / cannot find -lvtkproj4
Control: tag -1 pending thanks Hello Jochen, thanks for reporting this. With version -10 I switched to the use of the system libproj4. Unfortunately, VTK exposes the libproj4 in te cmake files (which it shouldn't), and also libpcl exposes the vtkprok4 library via its own cmake file. In other words, this change would have to be handled like an ABI change. Hence I will upload a version that reverts to the use of the internal version for now to keep ABI compatibility. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#750197: Please enable VTK6 test suite
On Tue, 2016-03-29 at 11:19 +0200, Mathieu Malaterre wrote: > There is a vtkdata package. Do you need a vtk6data package ? vtkdata is used for the examples, and not for the tests. The test data set consists of files that have their md5sums as file names - just like with ITK, only that VTK-upstream doesn't provide an according tarball. With that in mind I wouldn't want to create an extra package for just the test data since it is useless after the package has been build. Another problem is that VTK will need an OpenGL enabled test environment. xvfb doesn't cut it, and with Xdummy I don't have any experience yet (i.e. it doesn't provide such a nice script like xvfb-run. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Re: [vtk6] 12/12: Update changelog for release
Hello Anton, On Thu, 2016-02-18 at 12:40 +0100, Anton Gladky wrote: > I think, git was not pulled before creating a changelog > entries. Please, do not forget to do it next time. Sorry for that, moving around the java and python modules made the preparation quite complex, so I somehow overlooked these changes when pulling. I have to admit, that I also need to get a hang on creating the changelog entries last. For the other packages I maintain so far I added them as I go, especially when so many changes are to be made. BTW: There is one open task related to java I didn't do yet: As of java policy [1] the java modules (*Java.so) should go into a package libvtk6 -jni. But since this would have meant NEW, and I since I need the qt libraries in the libvtk6-qt* packages for vtk-dicom and would like to do an upload soon, I left this open for a future upload and only moved these files to the libvtk6-java package. Best, Gert [1] https://www.debian.org/doc/packaging-manuals/java-policy/x110.html -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#805010: ping: VTK 6.3.0 released
On Mon, 2016-02-01 at 13:52 +0100, Anton Gladky wrote: > 2016-02-01 13:49 GMT+01:00 Andreas Tille: > I have pushed your commit to git and will integrate it into the next > upload. Thanks, do you have any additional changes lined up? Otherwise I could take care of this today or tomorrow. > > If you have more experience with VTK with me, do you think, we should > update current packaged VTK to 6.2.1 due to bugfixes? Well, 6.2.1 was mentioned in the according bug report, but there is no corresponding tarball, which means the next would be 6.3 and this comes with an ABI and API changesthat will require some packages to be corrected (at least itksnap), since they dropped some legacy code. My experience with VTK is on the level of "I have some packages that I'm interested to see in Debian, and they depend on VTK". I myself don't write code that uses anything beyond the file IO. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#805010: ping: VTK 6.3.0 released
Hi, it would be nice if this got packaged, because if fixed a bug that manifests itself for instance in ginkgocadx: http://www.vtk.org/Bug/view.php?id=15365 Many thanks, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#805010: ping: VTK 6.3.0 released
Hello Anton, in that case I'll prepare an upload for 6.2.1, since this already fixes the bug, could be uploaded without passing through NEW, and shouldn't need much work. With this we would at least get this fix into testing without a vtk-7 transition. Since 6.3.0 breaks some things, i.e. legacy code was removed and with this itksnap required some fixes, directly moving to vtk-7 later on really makes more sense, but I wonder whether vtk 6 and 7 should co -exist in Stretch, whether we should push for updating all to vtk-7, As for co-maintaining - I'll see what I can do, but so far I'm only DM, which means I will need at least sponsoring. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#805010: ping: VTK 6.3.0 released
Hello Anton, well, it turns out that there is no version 6.2.1, so I've added only the upstream patch to the package. > OK, just push into git. Since I'm not (yet) in the debian-science group I don't have write access to the vtk6 packaging git. Therefore, I've attached the change set as a patch against the package source tree: > diffstat vtk6-6.2.0-dfsg1-6-fix-racecondition.patch changelog | 7 patches/96_concurrent_vtkLookupTableMapData_fix.patch | 198++ patches/series| 1 3 files changed, 206 insertions(+) -- The 96_ patch applies cleanly, and I'm test building now (right now at 50% well within the Tcl bindings). Best, Gert commit 88349595a1410bbb8670fbd31550c38297f15b68 Author: Gert Wollny <gw.foss...@gmail.com> Date: Sun Jan 31 17:40:33 2016 +0100 Add patch to fix race condition diff --git a/debian/changelog b/debian/changelog index f8003d3..e2927d0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +vtk6 (6.2.0+dfsg1-6.1) UNRELEASED; urgency=medium + + * Non-maintainer upload + * d/patched/96 Fix race condition in vtkLookupTableMapdata + + -- Gert Wollny <gw.foss...@gmail.com> Sun, 31 Jan 2016 17:37:41 +0100 + vtk6 (6.2.0+dfsg1-6) unstable; urgency=medium * [18cd92a] Add missing libaec-dev to build-depends. diff --git a/debian/patches/96_concurrent_vtkLookupTableMapData_fix.patch b/debian/patches/96_concurrent_vtkLookupTableMapData_fix.patch new file mode 100644 index 000..242b2f3 --- /dev/null +++ b/debian/patches/96_concurrent_vtkLookupTableMapData_fix.patch @@ -0,0 +1,198 @@ +Description: Fix crash in function called from multiple threads + vtkLookupTableMapData() was not thread safe and could lead to + crashes when accessed from multiple threads. Added a mutex around + the logic to determine if the color table size needed to be + increased. + . + Added a multi-threaded test that crashes on occasion prior + to this patch, but does not crash with this patch applied. +Author: Cory Quammen <cory.quam...@kitware.com> +Last-Update: 2016-01-31 +Bug: http://www.vtk.org/Bug/view.php?id=15365 + +diff --git a/Common/Core/Testing/Cxx/CMakeLists.txt b/Common/Core/Testing/Cxx/CMakeLists.txt +--- a/Common/Core/Testing/Cxx/CMakeLists.txt b/Common/Core/Testing/Cxx/CMakeLists.txt +@@ -32,6 +32,7 @@ vtk_add_test_cxx(${vtk-module}CxxTests tests + TestGarbageCollector.cxx + # TestInstantiator.cxx # Have not enabled instantiators. + TestLookupTable.cxx ++ TestLookupTableThreaded.cxx + TestMath.cxx + TestMinimalStandardRandomSequence.cxx + TestNew.cxx +diff --git a/Common/Core/Testing/Cxx/TestLookupTableThreaded.cxx b/Common/Core/Testing/Cxx/TestLookupTableThreaded.cxx +new file mode 100644 +index 000..4330609 +--- /dev/null b/Common/Core/Testing/Cxx/TestLookupTableThreaded.cxx +@@ -0,0 +1,57 @@ ++/*= ++ ++ Program: Visualization Toolkit ++ Module:TestLookupTableThreaded.cxx ++ ++ Copyright (c) Ken Martin, Will Schroeder, Bill Lorensen ++ All rights reserved. ++ See Copyright.txt or http://www.kitware.com/Copyright.htm for details. ++ ++ This software is distributed WITHOUT ANY WARRANTY; without even ++ the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR ++ PURPOSE. See the above copyright notice for more information. ++ ++=*/ ++ ++#include "vtkLookupTable.h" ++#include "vtkMultiThreader.h" ++#include "vtkNew.h" ++ ++namespace { ++ ++vtkLookupTable * lut; ++ ++VTK_THREAD_RETURN_TYPE ThreadedMethod(void *) ++{ ++ int numberOfValues = 25; ++ double* input = new double[numberOfValues]; ++ unsigned char* output = new unsigned char[4*numberOfValues]; ++ int inputType = VTK_DOUBLE; ++ int inputIncrement = 1; ++ int outputFormat = VTK_RGBA; ++ ++ lut->MapScalarsThroughTable2(input, output, inputType, numberOfValues, ++ inputIncrement, outputFormat); ++ ++ delete[] input; ++ delete[] output; ++ ++ return VTK_THREAD_RETURN_VALUE; ++} ++ ++} // end anonymous namespace ++ ++int TestLookupTableThreaded(int, char* []) ++{ ++ lut = vtkLookupTable::New(); ++ lut->SetNumberOfTableValues( 1024 ); ++ ++ vtkNew threader; ++ threader->SetSingleMethod( ThreadedMethod, NULL ); ++ threader->SetNumberOfThreads( 4 ); ++ threader->SingleMethodExecute(); ++ ++ lut->Delete(); ++ ++ return EXIT_SUCCESS; ++} +diff --git a/Common/Core/vtkLookupTable.cxx b/Common/Core/vtkLookupTable.cxx +index 53d9663..2d90054 100644 +--- a/Common/Core/vtkLookupTable.cxx b/Common/Core/vtkLookupTable.cxx +@@ -18,6 +18,7 @@ + #include "vtkBitArray.h" + #include "vtkMath.h" + #include "vtkMathConfigure.h" ++#include "vtkMutexLock.h" + #include &qu
Bug#756480: fix no longer needed
The reason I filed this bug is no longer relevant, because I added a patch to fix #733629 that doesn't require a cmake file. Hence it would probably be okay to tag this patch as wontfix. Best, Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#751395: approach to fix "vtk6: Do not compress perl scripts"
Hi, I've prepared a GDCM-2.6 upload that uses the compressed scripts, but since depending on files from /usr/share/doc is a policy violation, I'd suggest the following 2-step procedure to get rid of the problem: 1. Apply the attached patch to the vtk6 debian scripts to install the perl scripts uncompressed in the libvtk6-dev package, but also keep the compressed versions where they were before. This way the current GDCM-2.6 version that is in NEW can be build even if you get around to do a new vtk6 upload before GDCM passes through NEW. 2. When this new vtk6-dev package is available from the repo, I'll fix GDCM to use the these uncompressed scripts, and I'll notify you that you can adjust the -doc package to no longer include the (then duplicate) perl scripts. Opinions? Best, Gert --- vtk6-6.2.0+dfsg1/debian/libvtk6-dev.install 2015-05-19 23:38:22.0 +0200 +++ vtk6-6.2.0+dfsg1.new/debian/libvtk6-dev.install 2015-10-19 10:30:51.148564320 +0200 @@ -23,3 +23,4 @@ usr/include/vtk-6.2usr/include usr/lib/*/*.so usr/lib/cmake/vtk-6.2 +usr/share/doc/vtk-6.2/doxygen/* /usr/share/vtk-6.2/doxygen/ -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
vtk6 and #773424
Hi all, since #773424 was an RC bug that would result in the removal of vtk6 and various other packages from jessie, shouldn't someone request an unblock of the latest upload that closed this bug so that it can migrate? many thanks, Gert signature.asc Description: This is a digitally signed message part -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#773379: Python specifics in libvtk6-dev
The problem with these files is that they are listed in one of the cmake files installed by vtk6 into /usr/lib/cmake/vtk-6.1, e.g., VTKTargets-none.cmake: IMPORTED_LOCATION_NONE /usr/lib/x86_64-linux-gnu/python2.7/site-packages/vtk/vtkCommonExecutionModelPython.so IMPORTED_SONAME_NONE vtkCommonExecutionModelPython.so list(APPEND _IMPORT_CHECK_FILES_FOR_vtkCommonExecutionModelPython /usr/lib/x86_64-linux-gnu/python2.7/site-packages/vtk/vtkCommonExecutionModelPython.so and I remember with earlier packages that cmake complained about missing these libraries when one wanted to import VTK to build against it and they were not installed. best, Gert signature.asc Description: This is a digitally signed message part -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#767138: fftw3: runtime detection of NEON is perhaps broken
A few comments. I'm not sure if the disassembly is the right one. Supposedly it is in a function called fftwf_guru64_kosherp, but it should be in really_have_neon. There I would expect that the actual disassembly results in the the signal SIGILL not being reset and return 1 always being executed. Then the error pattern would make sense. I will check this tonight when I have access to my ARM hardware. Regarding the use of intrinsics: AFAICS in configure.ac --with-neon always sets HAVE_NEON as define and adds the flag -mfpu=neon. In addition the gcc manpage says: If the selected floating-point hardware includes the NEON extension (e.g. -mfpu=neon), note that floating-point operations are not generated by GCC's auto-vectorization pass unless -funsafe-math-optimizations is also specified. With this in mind I would suggest the attached patch. Best Gert --- simd-support/neon.c.old 2014-10-29 12:57:25.627329195 +0100 +++ simd-support/neon.c 2014-10-29 13:02:34.465717330 +0100 @@ -23,8 +23,23 @@ #if HAVE_NEON -/* check for an environment where signals are known to work */ -#if defined(unix) || defined(linux) + +/* check for an environment where getauxval exists */ +#if defined(linux) + #include sys/auxv.h + + int X(have_simd_neon)(void) + { + static int init = 0, res; + if (!init) { + res = !!(getauxval(AT_HWCAP) HWCAP_ARM_NEON); + init = 1; + } + return res; + } + +/* otherwise check for signals */ +#elif defined(unix) # include signal.h # include setjmp.h @@ -44,10 +59,9 @@ signal(SIGILL, oldsig); return 0; } else { - /* paranoia: encode the instruction in binary because the - assembler may not recognize it without -mfpu=neon */ - /*asm volatile (vand q0, q0, q0);*/ - asm volatile (.long 0xf2000150); +/* --with-neon sets HAVE_NEON and -mfpu=neon, so we are save */ + asm volatile (vand q0, q0, q0); + signal(SIGILL, oldsig); return 1; } signature.asc Description: This is a digitally signed message part -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#767138: fftw3: runtime detection of NEON is perhaps broken
On Wed, 2014-10-29 at 18:36 +0100, Julian Taylor wrote: the flags are only added to files which do the computations, the rest of the program should not have this flag, this should include the file that has the neon runtime check. Makes sense, but then adding an intrinsic should be okay. Regarding the actual disassembly: really_have_neon is probably inlined into fftwf_have_simd_neon, because strings /usr/lib/arm-linux-gnueabihf/libfftw3f.so| \ grep really_have_neon returns nothing. (gdb) Dump of assembler code for function fftwf_have_simd_neon: 0x000a9fdc +00:10 b5 push{r4, lr} 0x000a9fde +02:08 4c ldr r4, [pc, #32] ; (0xaa000 fftwf_have_simd_neon+36) 0x000a9fe0 +04:7c 44 add r4, pc 0x000a9fe2 +06:d4 f8 88 31 ldr.w r3, [r4, #392] ; 0x188 0x000a9fe6 +10:13 b1 cbz r3, 0xa9fee fftwf_have_simd_neon+18 0x000a9fe8 +12:d4 f8 8c 01 ldr.w r0, [r4, #396] ; 0x18c 0x000a9fec +16:10 bd pop {r4, pc} 0x000a9fee +18:ff f7 c9 ff bl 0xa9f84 0x000a9ff2 +22:01 23 movsr3, #1 0x000a9ff4 +24:c4 f8 88 31 str.w r3, [r4, #392] ; 0x188 0x000a9ff8 +28:c4 f8 8c 01 str.w r0, [r4, #396] ; 0x18c 0x000a9ffc +32:10 bd pop {r4, pc} 0x000a9ffe +34:00 bf nop 0x000aa000 +36:34 46 mov r4, r6 0x000aa002 +38:0b 00 movsr3, r1 No f2 00 01 50 to be seen ...Now I have to admit that I don't really read arm assembler, so I can't tell what this code actually does. Considering [1] it seems that one can not just put some asm statement into the code and assume that this assembler code will really be inserted at that very spot, and given the dump, I can only assume that the compiler might even decide to optimize the assembler code away, since it doesn't reference any variable. [1] https://stackoverflow.com/questions/6517860/arm-gcc-inline-assembler-optimization-problem Best Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
Bug#756480: double-conversion: the package should create and install the *.cmake files
Source: double-conversion Version: Package should generate and install *.cmake files Severity: normal Dear Maintainer, the package is prepared to provide various *.cmake files that can be used by third party libraries using cmake to find the required information about the location of library files etc. E.g. the Insighttoolkit requires these files. As far as I can see the package supports two build systems: cmake and scons, and to build the package scons is used which doesn't create the *.cmake files. The cmake based build system would create these files but doesn't create and run the tests. (One should probably ask upstream to completely move to cmake). Many thanks, Gert -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.14-1-amd64 (SMP w/6 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash signature.asc Description: This is a digitally signed message part -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
nlopt backport to wheezy via NeuroDebian
Dear maintainers, I'm in the course of submitting some packages for backporting to wheezy through NeuroDebian - which currently resides outside the official Debian backports. nlopt is one of the requirements of one of my packages (mia), and since you are the maintainers I wanted to check back if you have any intentions to provide backports yourself before I ask the NeuroDebian to initiate the builds. many thanks Gert -- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers