Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Nico Schlömer]

Whoop whoop! Thanks everyone!

[1] https://packages.debian.org/experimental/libvtk7-dev

On Tue, Apr 3, 2018 at 11:55 PM Chris Lamb  wrote:

> Hi Gert et al.,
>
> Thanks again for re-uploading; I have just ACCEPTed it.
>
> > [I] replicated here what I did, kind of to acknowledge the review and
> > the changes it required (a habit from scinetific paper reviews, nothing
> > more)
>
> Thanks! I was mostly making sure for next time; it is a good habit
> to be applauded.
>
>
> Best wishes,
>
> --
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-
>
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Chris Lamb]

Hi Gert et al.,

Thanks again for re-uploading; I have just ACCEPTed it.

> [I] replicated here what I did, kind of to acknowledge the review and 
> the changes it required (a habit from scinetific paper reviews, nothing
> more)

Thanks! I was mostly making sure for next time; it is a good habit
to be applauded.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Gert Wollny]

Am Montag, den 02.04.2018, 19:53 +0100 schrieb Chris Lamb:
> Hi Gert,
> 
> > > The comments were listed as being "for" version 7.1.1+dfsg1-
> > > 1~exp1 —
> > > did you upload with the same version number? That would explain
> > > why I
> > > thought they remained unaddressed.
> > 
> > Yes, I did upload with the same version. The policy is not clear
> > about
> > this
> 
> Oh, this has nothing to do with any policy, more that it this time I
> got
> confused.
> 
> > Regarding the reported problems: 
> 
> Thank you for sharing these, but please could you add such things to
> your debian/copyright instead of here? 
Well, the corrected copyright notices and the Files-Excluded obviously
now contain the according information - apart from the md5 sum related
thing, but this does not really belong into the d/copyright. I just
replicated here what I did, kind of to acknowledge the review and the
changes it required (a habit from scinetific paper reviews, nothing
more) 

Best, 
Gert

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Chris Lamb]

Hi Gert,

> > The comments were listed as being "for" version 7.1.1+dfsg1-1~exp1 —
> > did you upload with the same version number? That would explain why I
> > thought they remained unaddressed.
>
> Yes, I did upload with the same version. The policy is not clear about
> this

Oh, this has nothing to do with any policy, more that it this time I got
confused.

> Regarding the reported problems: 

Thank you for sharing these, but please could you add such things to
your debian/copyright instead of here? The ftpmaster mailbox is a poor
place for them to be recorded as they are not only entire hidden
from the rest of the Project, they cannot be seen by our downstream
distributions nor anyone doing an entirely separate audit. :)

Thanks for re-uploading.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Gert Wollny]

Hello Chris,  

Am Freitag, den 30.03.2018, 15:56 +0100 schrieb Chris Lamb:
> Hi all,
> 
> > these are the comments I got last year
> 
> The comments were listed as being "for" version 7.1.1+dfsg1-1~exp1 —
> did you upload with the same version number? That would explain why I
> thought they remained unaddressed.
Yes, I did upload with the same version. The policy is not clear about
this, and since the first changelog entry must remain for the ITP, I
thought that was the usual approach.

> 
> If so, please re-upload and ping me and I will happily take a look.
> :)

I just did the new upload, this time I changed the name to ~exp2. 

Regarding the reported problems: 

* Accelerators/Dax/* have different copyright terms ..
corrected 

* Please mention license of the font under 
 Charts/Core/Testing/Data/Fonts
This is only a md5 sum.  

* Common/Core/CaseFolding.txt is licensed under http://www.unicode.org/
copyright.html
Added

* Examples/GUI/QT/* are copyright Sandia Corp. and have different
licensing terms
* Same as above applies for ...

Corrected accordingly: However, there is really a mess of slightly
variying copyright texts and I don't know to which detail this should
be copied into d/copyright.

* Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* 
  are copyright University of Utah

Files removed via d/copyright

many thanks for taking another look, 
Gert





-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Chris Lamb]

Hi all,

> these are the comments I got last year

The comments were listed as being "for" version 7.1.1+dfsg1-1~exp1 — did
you upload with the same version number? That would explain why I thought
they remained unaddressed.

If so, please re-upload and ping me and I will happily take a look. :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Gert Wollny]

Am 29.03.2018 18:00 schrieb "Chris Lamb" :
>
>
> Forwarding notes, please include Luca in any reply. See, also:
>
>   Thu 29 16:38 < mapreri> lamby: can I ask you to either *) forward me the
>   comments and I'll see what to do next *) accept and open a bunch of RC
bugs
>   as needed *) plain reject with those comments.  Whatever feels more
sensible
>   for you in this case (guess it depends on what the comments say…)
>
>  -- Chris Lamb   Thu, 29 Mar 2018 15:40:20 +
>
>
> Author: Luca Falavigna
> Version: 7.1.1+dfsg1-1~exp1
> Timestamp: 2017-09-01 21:05:53.165364+00:00
>
> * Accelerators/Dax/* have different copyright terms than the one
mentioned in d/copyright
> * Please mention license of the font under Charts/Core/Testing/Data/Fonts
> * Common/Core/CaseFolding.txt is licensed under
http://www.unicode.org/copyright.html
> * Examples/GUI/QT/* are copyright Sandia Corp. and have different
licensing terms
> * Same as above applies for
Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView}
> * Same as above applies for Examples/Statistics/*
> * Same as above applies for
Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrategy.h}
> * Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright University of
Utah
>
>
>
> ===
>
> Please feel free to respond to this email if you don't understand why
> your files were rejected, or if you upload new files which address our
> concerns.
I'm completely baffled, these are the comments I got last year, and unless
I've accidently uploaded the old tarball again, these problems should all
have been resolved with the upload I did the second time. Currently, I'm
travelling and can not check whether I did  upload the wrong tarball, but
since also Nico did review the package I highly doubt it.

Best, Gert
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Nico Schlömer]

Wait, VTK7 is no longer in NEW [1]. Does anyone know what happened?

Cheers,
Nico

[1] https://ftp-master.debian.org/new.html

On Wed, Mar 7, 2018 at 1:28 PM Gert Wollny  wrote:

> Am Dienstag, den 06.03.2018, 21:37 + schrieb Nico Schlömer:
> > Perhaps it's time to bring this up again. At six months in the queue,
> > VTK7 has been the leader in the NEW queue for a while now. It'd be
> > great if we could work on this again, particularly since VTK8 is
> > already out there.
>
> I guess we will just skip vtk8 and move to vtk9 when it comes out :/
>
> Best,
> Gert
>
>
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Chris Lamb]

Forwarding notes, please include Luca in any reply. See, also:

  Thu 29 16:38 < mapreri> lamby: can I ask you to either *) forward me the
  comments and I'll see what to do next *) accept and open a bunch of RC bugs
  as needed *) plain reject with those comments.  Whatever feels more sensible
  for you in this case (guess it depends on what the comments say…)

 -- Chris Lamb   Thu, 29 Mar 2018 15:40:20 +


Author: Luca Falavigna
Version: 7.1.1+dfsg1-1~exp1
Timestamp: 2017-09-01 21:05:53.165364+00:00

* Accelerators/Dax/* have different copyright terms than the one mentioned in 
d/copyright
* Please mention license of the font under Charts/Core/Testing/Data/Fonts
* Common/Core/CaseFolding.txt is licensed under 
http://www.unicode.org/copyright.html
* Examples/GUI/QT/* are copyright Sandia Corp. and have different licensing 
terms
* Same as above applies for 
Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView}
* Same as above applies for Examples/Statistics/*
* Same as above applies for 
Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrategy.h}
* Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright University of Utah



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.


-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Gert Wollny]

Am Dienstag, den 06.03.2018, 21:37 + schrieb Nico Schlömer:
> Perhaps it's time to bring this up again. At six months in the queue,
> VTK7 has been the leader in the NEW queue for a while now. It'd be
> great if we could work on this again, particularly since VTK8 is
> already out there.

I guess we will just skip vtk8 and move to vtk9 when it comes out :/

Best, 
Gert


-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Nico Schlömer]

Perhaps it's time to bring this up again. At six months in the queue, VTK7
has been the leader in the NEW queue for a while now. It'd be great if we
could work on this again, particularly since VTK8 is already out there.

Cheers,
Nico

On Thu, Nov 9, 2017 at 10:56 AM Gert Wollny  wrote:

> Hello Luca,
>
> since you did the initial review of the VTK7 package (and it is a
> really big one), would you consider to have another look at the updated
> version soon, I ask because we would like to start porting dependent
> packages.
>
> All the issuses you raised should be addressed by now (although what
> upstream provides there is really a mess). Specifially the for last one
> with no clear copyright (not even upstream knows) we removed the files
> since they are not needed anyway.
>
> many thanks,
> Gert
>
> Am Freitag, den 01.09.2017, 23:00 + schrieb Luca Falavigna:
> > Hi,
> >
> > * Accelerators/Dax/* have different copyright terms than the one
> > mentioned in d/copyright
> > * Please mention license of the font under
> > Charts/Core/Testing/Data/Fonts
> > * Common/Core/CaseFolding.txt is licensed under http://www.unicode.or
> > g/copyright.html
> > * Examples/GUI/QT/* are copyright Sandia Corp. and have different
> > licensing terms
> > * Same as above applies for
> > Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView}
> > * Same as above applies for Examples/Statistics/*
> > * Same as above applies for
> > Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrat
> > egy.h}
> > * Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright
> > University of Utah
> >
> > Cheers,
> > Luca
> >
> >
> >
> > ===
> >
> > Please feel free to respond to this email if you don't understand why
> > your files were rejected, or if you upload new files which address
> > our
> > concerns.
> >
>
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Gert Wollny]

Hello Luca, 

since you did the initial review of the VTK7 package (and it is a
really big one), would you consider to have another look at the updated
version soon, I ask because we would like to start porting dependent
packages.  

All the issuses you raised should be addressed by now (although what
upstream provides there is really a mess). Specifially the for last one
with no clear copyright (not even upstream knows) we removed the files
since they are not needed anyway. 

many thanks, 
Gert 

Am Freitag, den 01.09.2017, 23:00 + schrieb Luca Falavigna:
> Hi,
> 
> * Accelerators/Dax/* have different copyright terms than the one
> mentioned in d/copyright
> * Please mention license of the font under
> Charts/Core/Testing/Data/Fonts
> * Common/Core/CaseFolding.txt is licensed under http://www.unicode.or
> g/copyright.html
> * Examples/GUI/QT/* are copyright Sandia Corp. and have different
> licensing terms
> * Same as above applies for
> Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView}
> * Same as above applies for Examples/Statistics/*
> * Same as above applies for
> Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrat
> egy.h}
> * Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright
> University of Utah
> 
> Cheers,
> Luca
> 
> 
> 
> ===
> 
> Please feel free to respond to this email if you don't understand why
> your files were rejected, or if you upload new files which address
> our
> concerns.
> 

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Re: vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Gert Wollny]

Hello Luca, 

thanks for your work on this. One comment though: 


Am Freitag, den 01.09.2017, 23:00 + schrieb Luca Falavigna:
> * Please mention license of the font under
> Charts/Core/Testing/Data/Fonts
I don't see a font file in this directory, only a md5 hash sum file. 


Best, 
Gert 


-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

vtk7_7.1.1+dfsg1-1~exp1_amd64.changes REJECTED

[Luca Falavigna]

Hi,

* Accelerators/Dax/* have different copyright terms than the one mentioned in 
d/copyright
* Please mention license of the font under Charts/Core/Testing/Data/Fonts
* Common/Core/CaseFolding.txt is licensed under 
http://www.unicode.org/copyright.html
* Examples/GUI/QT/* are copyright Sandia Corp. and have different licensing 
terms
* Same as above applies for 
Examples/Infovis/Cxx/{CustomLinkView,EasyView,StatsView}
* Same as above applies for Examples/Statistics/*
* Same as above applies for 
Infovis/Layout/{vtkCosmicTreeLayoutStrategy.h,vtkTreeOrbitLayoutStrategy.h}
* Rendering/VolumeOpenGL/vtkHAVSVolumeMapper* are copyright University of Utah

Cheers,
Luca



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.


-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers