Re: radare2-cutter initial upload; possible radare2 update?
Hi, On Sat, Jan 26, 2019 at 12:32:28AM +0100, Hilko Bengen wrote: > * Sebastian Reichel: > > > Thanks, for taking care of this. I'm currently a bit short on time. > > I noticed, that you enabled OpenSSL, which is not ok. > > Right. Will revert that right away, now that my upload has been accepted > into unstable. > > > Also I think we should switch to upstream soname (3.2.1), which plains > > the way to use meson instead of their own build system. > > As long as upstream keeps their ABI stable across patchlevel releases, > I see no reason for doing that. upstream does not guarantee any ABI stability. This needs to be checked downstream (i.e. the maintainer importing the updated release). > Couldn't we also override the soname picked by the meson > buildsystem? I think that requires patching the build system. FWIW I rebased my meson patch on top of your changes and pushed it into an extra branch: https://salsa.debian.org/pkg-security-team/radare2/tree/meson It works, but uses upstream's soname. -- Sebastian signature.asc Description: PGP signature
Re: radare2-cutter initial upload; possible radare2 update?
Hi, On Thu, Jan 24, 2019 at 12:04:29AM +0100, Hilko Bengen wrote: > * Samuel Henrique: > > > I know that you're asking for objections, but I'd say please go ahead, > > especially because this new release of radare2 ships lots of > > improvements and somebody sent an email to our team's list requesting > > for 3.2.1 already (at least one person will be happy with it). > > Thank you. I'll upload radare/3.2.1+dfsg-1 right now. It will have to go > through NEW because of a SONAME bump, of course. After it has been > accepted, I'll follow up with radare2-cutter, hoping to get it into the > archive before the soft-freeze. > > Unless there are objections, of course. :-) Thanks, for taking care of this. I'm currently a bit short on time. I noticed, that you enabled OpenSSL, which is not ok. Most of R2 is LGPL, but there is some GPL code in it. Also I think we should switch to upstream soname (3.2.1), which plains the way to use meson instead of their own build system. -- Sebastian signature.asc Description: PGP signature