Re: Request for review/upload of galleta 1.0+20040505-10
Hello Aleksey, On Fri, Jan 18, 2019 at 10:55 PM Samuel Henrique > wrote: > >> Regarding the smoke tests you added, I think it would be better to >> declare them as "Restriction: superficial"[0]: >> > Done. > Sponsored :) > This simplifies backporting of packages. > > For example, stretch-backports has *debhelper 12~bpo9+1*. > This version will match "debhelper (>= 12~)" condition > and will not match "debhelper (>= 12)". > > From debian-policy 5.6.12. Version [2] : > >> The lexical comparison is a comparison of ASCII values modified so that >> all the letters sort earlier than all the non-letters and so that a tilde >> sorts before anything, even the end of a part. For example, the following >> parts are in sorted order from earliest to latest: ~~, ~~a, ~, the empty >> part, a. > > > [1] https://manpages.debian.org/unstable/debhelper/debhelper.7.en.html > [2] https://www.debian.org/doc/debian-policy/ch-controlfields.html#version > A, makes sense, thanks for pointing that out. Regards, -- Samuel Henrique
Re: Request for review/upload of galleta 1.0+20040505-10
Hello, On Fri, Jan 18, 2019 at 10:55 PM Samuel Henrique wrote: > Regarding the smoke tests you added, I think it would be better to declare > them as "Restriction: superficial"[0]: > Done. > And on a side note, I'm not sure I know the difference between: > >> debhelper (>= 12~) >> > and > >> debhelper (>= 12) >> > > If anybody could give me a light here, I appreciate :) > Debhelper manual [1] requires to write > Build-Depends: debhelper (>= 12~) This simplifies backporting of packages. For example, stretch-backports has *debhelper 12~bpo9+1*. This version will match "debhelper (>= 12~)" condition and will not match "debhelper (>= 12)". >From debian-policy 5.6.12. Version [2] : > The lexical comparison is a comparison of ASCII values modified so that > all the letters sort earlier than all the non-letters and so that a tilde > sorts before anything, even the end of a part. For example, the following > parts are in sorted order from earliest to latest: ~~, ~~a, ~, the empty > part, a. [1] https://manpages.debian.org/unstable/debhelper/debhelper.7.en.html [2] https://www.debian.org/doc/debian-policy/ch-controlfields.html#version Best wishes, Aleksey.
Re: Request for review/upload of galleta 1.0+20040505-10
Hello Aleksey, Argh, this one had gcc hardcoded on the Makefile, Helmut is always saving us from this kind of things :) There's only one thing that I ask you before sponsoring, just like recoverdm: Regarding the smoke tests you added, I think it would be better to declare > them as "Restriction: superficial"[0]: > >> superficial >> The test does not provide significant test coverage, so if it >> passes, that does not necessarily mean that the package under test >> is actually functional. If a ``superficial`` test fails, it will be >> treated like any other failing test, but if it succeeds, this is >> only a weak indication of success. Continuous integration systems >> should treat a package where all non-superficial tests are skipped as >> equivalent to a package where all tests are skipped. >> >> For example, a C library might have a superficial test that simply >> compiles, links and executes a "hello world" program against the >> library under test but does not attempt to make use of the library's >> functionality, while a Python or Perl library might have a >> superficial test that runs ``import foo`` or ``require Foo;`` but >> does not attempt to use the library beyond that. >> >> [0] > https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst > And on a side note, I'm not sure I know the difference between: > debhelper (>= 12~) > and > debhelper (>= 12) > If anybody could give me a light here, I appreciate :) Thanks for your work Aleksey, I will upload as soon as you add the tests restriction. -- Samuel Henrique
Request for review/upload of galleta 1.0+20040505-10
Hello team, I've prepared galleta 1.0+20040505-10 - imported BTS patch, added tests, lintian-cleaned. Please review it and upload [1]. [1] https://salsa.debian.org/pkg-security-team/galleta Best wishes, Aleksey.
