Re: Request to review and upload librtr 0.6.3-2
On Sat, 16 Jan 2021, Francisco Vilmar Cardoso Ruviaro wrote: > That's right Peter, pkg-config was missing, thanks! > > I think librtr[1] is now ready for review and upload. Uploaded. Thank you! -- ⢀⣴⠾⠻⢶⣦⠀ Raphaël Hertzog ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/ ⠈⠳⣄ Debian Long Term Support: https://deb.li/LTS signature.asc Description: PGP signature
Re: Request to review and upload librtr 0.6.3-2
Hi, Sorry my late. Peter Wienemann: > Dear Francisco, > > On 08.01.21 17:56, Francisco Vilmar Cardoso Ruviaro wrote: >> On 1/8/21 9:23 AM, Raphael Hertzog wrote: >>> He also pointed towards a possible upstream fix. Do you want to look into >>> backporting this? >>> >> I tried to get the latest version (0.7.0+git20201012.93724e4), applied >> the patch >> https://github.com/rtrlib/rtrlib/pull/260/commits/f81b70bf03a52b2e25f7154062c538dc050b3571 >> >> >> yet the bug continues. >> Unfortunately I was not successful. > > along with the mentioned patch you also have to add "pkg-config" to the > build deps. Have you considered this for your test? > That's right Peter, pkg-config was missing, thanks! I think librtr[1] is now ready for review and upload. [1] https://salsa.debian.org/pkg-security-team/librtr Best regards. -- Francisco Vilmar Cardoso Ruviaro 4096R: 1B8C F656 EF3B 8447 2F48 F0E7 82FB F706 0B2F 7D00 OpenPGP_signature Description: OpenPGP digital signature
Re: Request to review and upload librtr 0.6.3-2
Dear Francisco, On 08.01.21 17:56, Francisco Vilmar Cardoso Ruviaro wrote: On 1/8/21 9:23 AM, Raphael Hertzog wrote: He also pointed towards a possible upstream fix. Do you want to look into backporting this? I tried to get the latest version (0.7.0+git20201012.93724e4), applied the patch https://github.com/rtrlib/rtrlib/pull/260/commits/f81b70bf03a52b2e25f7154062c538dc050b3571 yet the bug continues. Unfortunately I was not successful. along with the mentioned patch you also have to add "pkg-config" to the build deps. Have you considered this for your test? Best regards, Peter
Re: Request to review and upload librtr 0.6.3-2
Hello Raphael, On 1/8/21 9:23 AM, Raphael Hertzog wrote: Hi, On Thu, 24 Dec 2020, Francisco Vilmar Cardoso Ruviaro wrote: I fixed an RC bug [0] in librtr [1]. Please, review and upload. Adrian Bunk pointed out that your fix is clearly incorrect. Can you at least revert your change please ?It would be nice if you tried to Sure, it's done. understand your changes before you are doing them. A symbol that disappears is a big deal because it breaks users of the library that are using this symbol. So it was relatively evident that the correct fix was not to acknowledge the disparition of the symbol (at least not without an explanation of why it's not important). Thanks Raphael, I need to be more careful and pay attention before any change, you're right, I need to understand better. He also pointed towards a possible upstream fix. Do you want to look into backporting this? I tried to get the latest version (0.7.0+git20201012.93724e4), applied the patch https://github.com/rtrlib/rtrlib/pull/260/commits/f81b70bf03a52b2e25f7154062c538dc050b3571 yet the bug continues. Unfortunately I was not successful. Regards, -- Francisco Vilmar Cardoso Ruviaro 4096R: 1B8C F656 EF3B 8447 2F48 F0E7 82FB F706 0B2F 7D00 OpenPGP_signature Description: OpenPGP digital signature
Re: Request to review and upload librtr 0.6.3-2
Hi, On Thu, 24 Dec 2020, Francisco Vilmar Cardoso Ruviaro wrote: > I fixed an RC bug [0] in librtr [1]. > > Please, review and upload. Adrian Bunk pointed out that your fix is clearly incorrect. Can you at least revert your change please ? It would be nice if you tried to understand your changes before you are doing them. A symbol that disappears is a big deal because it breaks users of the library that are using this symbol. So it was relatively evident that the correct fix was not to acknowledge the disparition of the symbol (at least not without an explanation of why it's not important). He also pointed towards a possible upstream fix. Do you want to look into backporting this? Cheers, -- ⢀⣴⠾⠻⢶⣦⠀ Raphaël Hertzog ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/ ⠈⠳⣄ Debian Long Term Support: https://deb.li/LTS signature.asc Description: PGP signature
Request to review and upload librtr 0.6.3-2
Hello Team, I fixed an RC bug [0] in librtr [1]. Please, review and upload. [0] https://bugs.debian.org/975174 [1] https://salsa.debian.org/pkg-security-team/librtr Regards, -- Francisco Vilmar Cardoso Ruviaro 4096R: 1B8C F656 EF3B 8447 2F48 F0E7 82FB F706 0B2F 7D00 OpenPGP_signature Description: OpenPGP digital signature
