Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Hello SZ Lin and Peter, On Sun, 3 May 2020 at 16:09, SZ Lin (林上智) wrote: > Thanks for taking this, I'm on the national holidays. Enjoy your holidays :) > According to the team wiki [1], it elaborates to submit merge requests to > submit the result of the work in most cases. > > Therefore, generally, I review the MR which includes three branches in > Salsa once the repository exists in the team. (talking about this scenario in general, as in this specific case Peter should have permissions to push to the repo and wouldn't need to deal with MR/forking) hmm, we may have to rethink this approach and document that is okay to ask for a review on the person's own fork. Unless Salsa does support multiple branches as source and dest in an MR, but... > IIRC, the MR function in Salsa will handle three different branches > and act accordingly. > (please correct me if I'm wrong) I had tried this in the past and it wasn't a feature, searching online also didn't gave me any results of people managing to do this. Thus I believe it's not possible to do so, if you happen to confirm that it works, please correct me. Peter, the package is good and I uploaded it with a small change in the changelog to put the "new release" statement at the first line. Since this is the first time I sponsor an upload of yours, I will not give you DM permission now, unfortunately, but will happily do so in the next 1/2 uploads. I wasn't aware of the existence of this package, it's very interesting and I will try it out myself for some domains I own, the autopkgtest also leads to some interesting results, hahaha. Thanks for your work -- Samuel Henrique
Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Hi Samuel, Samuel Henrique 於 2020年5月3日 週日 下午9:35寫道： > > Hello Peter and SZ Lin, > > > > Can you send the MR to the team repository[1]? > > > > > > [1] https://salsa.debian.org/pkg-security-team/dnstwist > > > > what precisely do you want me to do? Usually a MR relates one source > > branch to one destination branch. But the mentioned changes affect three > > branches and a tag. How am I supposed to map this to a normal MR? > > Peter, I noticed you are the maintainer of the package and is also a > DM, so I gave you permission to the repository, maintainers should be > able to push to their packages' repos. > I also pushed all your changes to the team's repo, so from now on > please feel free to commit there directly. I hope this reduces the > overhead of contributing for you. > > SZ Lin, one thing I usually do when reviewing things like this is, I > review the changes on the person's fork and then push them to the > official repo when done. an MR might help, but as Peter mentioned, is > only doable when only one branch has changes. Thanks for taking this, I'm on the national holidays. According to the team wiki [1], it elaborates to submit merge requests to submit the result of the work in most cases. Therefore, generally, I review the MR which includes three branches in Salsa once the repository exists in the team. IIRC, the MR function in Salsa will handle three different branches and act accordingly. (please correct me if I'm wrong) [1] https://wiki.debian.org/Teams/pkg-security SZ > > We are already 7 days after Peter's initial request for review, so if > nobody beats me to it, I will do it tomorrow. > > Regards, > > -- > Samuel Henrique
Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
> Peter, I noticed you are the maintainer of the package and is also a > DM, so I gave you permission to the repository, maintainers should be > able to push to their packages' repos. I forgot to mention, this permissions will expire at the end of 2021, so if you're not a DD by that time just ask someone to bump the expiration for you. -- Samuel Henrique
Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Hello Peter and SZ Lin, > > Can you send the MR to the team repository[1]? > > > > [1] https://salsa.debian.org/pkg-security-team/dnstwist > > what precisely do you want me to do? Usually a MR relates one source > branch to one destination branch. But the mentioned changes affect three > branches and a tag. How am I supposed to map this to a normal MR? Peter, I noticed you are the maintainer of the package and is also a DM, so I gave you permission to the repository, maintainers should be able to push to their packages' repos. I also pushed all your changes to the team's repo, so from now on please feel free to commit there directly. I hope this reduces the overhead of contributing for you. SZ Lin, one thing I usually do when reviewing things like this is, I review the changes on the person's fork and then push them to the official repo when done. an MR might help, but as Peter mentioned, is only doable when only one branch has changes. We are already 7 days after Peter's initial request for review, so if nobody beats me to it, I will do it tomorrow. Regards, -- Samuel Henrique
Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Hi SZ, On 27.04.20 08:09, SZ Lin (林上智) wrote: > Can you send the MR to the team repository[1]? > > [1] https://salsa.debian.org/pkg-security-team/dnstwist what precisely do you want me to do? Usually a MR relates one source branch to one destination branch. But the mentioned changes affect three branches and a tag. How am I supposed to map this to a normal MR? Peter
Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Hi Peter, Peter Wienemann 於 2020年4月27日 週一 上午3:52寫道： > > Dear security tools team, > > On 11.04.20 15:11, Peter Wienemann wrote: > > could someone please review the changes in > > > > https://salsa.debian.org/wiene-guest/dnstwist > > > > and - provided they look OK - push the changes to the corresponding > > repository in the team area and upload. > > > > This fixes an issue in the test suite which blocks migration to testing. > > in the meantime upstream released a new version. I added the new > upstream version and some entailed modifications as well as a fix for > #958735. > > I am looking forward to a review/upload. Can you send the MR to the team repository[1]? [1] https://salsa.debian.org/pkg-security-team/dnstwist SZ > > Peter >
RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Dear security tools team, On 11.04.20 15:11, Peter Wienemann wrote: > could someone please review the changes in > > https://salsa.debian.org/wiene-guest/dnstwist > > and - provided they look OK - push the changes to the corresponding > repository in the team area and upload. > > This fixes an issue in the test suite which blocks migration to testing. in the meantime upstream released a new version. I added the new upstream version and some entailed modifications as well as a fix for #958735. I am looking forward to a review/upload. Peter
Test suite issue fixed for dnstwist
Hi, could someone please review the changes in https://salsa.debian.org/wiene-guest/dnstwist and - provided they look OK - push the changes to the corresponding repository in the team area and upload. This fixes an issue in the test suite which blocks migration to testing. Thanks, Peter
