RE: Fix for bridge-utils for Sparc64

[Small, Jim]

> -Original Message-
> 
> You reversed the diff and your email client mangled it, too...
> 

You're right about the reversed diff...oops.

Looks like my client sent the message OK, not sure why it got wrapped
later...

> >
> 
> Just adding or removing some magic constants isn't good. If there's
> something missing on the kernel side, just fix it there.
> 

Agreed.  If I knew enough to fix it I would!  As 64bit architectures get
more popular, I'm hoping many of these 32-64bit issues will disappear.  In
the mean time though, this lets those of us with an UltraSPARC and a qfe
card do bridging.

<> Jim

Re: Fix for bridge-utils for Sparc64

[Jan-Benedict Glaw]

On Thu, 2004-04-08 09:48:19 -0400, Small, Jim <[EMAIL PROTECTED]>
wrote in message <[EMAIL PROTECTED]>:
> Here is a diff too:
> # diff -Nru bridge-utils/libbridge/libbridge_devif.c
> bridge-utils/libbridge/libbridge_devif.c.orig 
> --- bridge-utils/libbridge/libbridge_devif.c2004-04-01
> 21:10:55.0 -0500
> +++ bridge-utils/libbridge/libbridge_devif.c.orig   2002-01-16
> 07:04:45.0 -0500

You reversed the diff and your email client mangled it, too...

> @@ -56,7 +56,7 @@
> memcpy(ifr.ifr_name, br->ifname, IFNAMSIZ);
> ((unsigned long long *)(&ifr.ifr_data))[0] = (unsigned long
> long)(unsigned long)args;
>  
> -   return ioctl(br_socket_fd, SIOCDEVPRIVATE, &ifr);
> +   return ioctl(br_socket_fd, SIOCDEVPRIVATE + 3, &ifr);
>  }
>  #endif
> 

Just adding or removing some magic constants isn't good. If there's
something missing on the kernel side, just fix it there.

MfG, JBG

-- 
   Jan-Benedict Glaw   [EMAIL PROTECTED]. +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf| Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));


signature.asc
Description: Digital signature