Re: qscintilla2: FTBFS on hppa - LD_LIBRARY_PATH incorrectly set

2023-11-28 Thread John Paul Adrian Glaubitz
Control: retitle -1 'FTBFS on multiple architectures due to incorrect 
LD_LIBRARY_PATH'
Control: tags -1 +patch

Hi!

On Tue, 2023-11-28 at 10:13 +0100, John Paul Adrian Glaubitz wrote:
> --- qscintilla2-2.14.1+dfsg/debian/rules.orig   2023-07-22 20:17:16.0 
> +0200
> +++ qscintilla2-2.14.1+dfsg/debian/rules2023-11-28 10:12:29.317757619 
> +0100
> @@ -46,7 +46,7 @@
>  Python/build-%/configure-stamp: build-library-stamp
> dh_testdir
> cp -f Python/pyproject-qt5.toml Python/pyproject.toml
> -   cd Python && python$* /usr/bin/sip-build \
> +   cd Python && LD_LIBRARY_PATH=$(CURDIR)/QSciQt5 python$* 
> /usr/bin/sip-build \
> --verbose --no-make --pep484-pyi \
> --qmake /usr/bin/$(DEB_HOST_GNU_TYPE)-qmake \
> --qmake-setting 'QMAKE_CXXFLAGS += "$(CXXFLAGS) $(CPPFLAGS)"' 
> \
> @@ -59,7 +59,7 @@
> --qsci-library-dir $(CURDIR)/QSciQt5
>  ifeq ($(qt6), "yes")
> cp -f Python/pyproject-qt6.toml Python/pyproject.toml
> -   cd Python && python$* /usr/bin/sip-build \
> +   cd Python && LD_LIBRARY_PATH=$(CURDIR)/QSciQt6 python$* 
> /usr/bin/sip-build \
> --verbose --no-make --pep484-pyi \
> --qmake /usr/bin/qmake6 \
> --qmake-setting 'QMAKE_CXXFLAGS += "$(CXXFLAGS) $(CPPFLAGS)"' 
> \

I can confirm that this patch fixes the problem for me. Attaching it as a file.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
--- qscintilla2-2.14.1+dfsg/debian/rules.orig	2023-07-22 20:17:16.0 +0200
+++ qscintilla2-2.14.1+dfsg/debian/rules	2023-11-28 10:12:29.317757619 +0100
@@ -46,7 +46,7 @@
 Python/build-%/configure-stamp: build-library-stamp
 	dh_testdir
 	cp -f Python/pyproject-qt5.toml Python/pyproject.toml
-	cd Python && python$* /usr/bin/sip-build \
+	cd Python && LD_LIBRARY_PATH=$(CURDIR)/QSciQt5 python$* /usr/bin/sip-build \
 		--verbose --no-make --pep484-pyi \
 		--qmake /usr/bin/$(DEB_HOST_GNU_TYPE)-qmake \
 		--qmake-setting 'QMAKE_CXXFLAGS += "$(CXXFLAGS) $(CPPFLAGS)"' \
@@ -59,7 +59,7 @@
 		--qsci-library-dir $(CURDIR)/QSciQt5
 ifeq ($(qt6), "yes")
 	cp -f Python/pyproject-qt6.toml Python/pyproject.toml
-	cd Python && python$* /usr/bin/sip-build \
+	cd Python && LD_LIBRARY_PATH=$(CURDIR)/QSciQt6 python$* /usr/bin/sip-build \
 		--verbose --no-make --pep484-pyi \
 		--qmake /usr/bin/qmake6 \
 		--qmake-setting 'QMAKE_CXXFLAGS += "$(CXXFLAGS) $(CPPFLAGS)"' \


Re: qscintilla2: FTBFS on hppa - LD_LIBRARY_PATH incorrectly set

2023-11-28 Thread John Paul Adrian Glaubitz
Hi!

Testing the following patch now which seems to work:

--- qscintilla2-2.14.1+dfsg/debian/rules.orig   2023-07-22 20:17:16.0 
+0200
+++ qscintilla2-2.14.1+dfsg/debian/rules2023-11-28 10:12:29.317757619 
+0100
@@ -46,7 +46,7 @@
 Python/build-%/configure-stamp: build-library-stamp
dh_testdir
cp -f Python/pyproject-qt5.toml Python/pyproject.toml
-   cd Python && python$* /usr/bin/sip-build \
+   cd Python && LD_LIBRARY_PATH=$(CURDIR)/QSciQt5 python$* 
/usr/bin/sip-build \
--verbose --no-make --pep484-pyi \
--qmake /usr/bin/$(DEB_HOST_GNU_TYPE)-qmake \
--qmake-setting 'QMAKE_CXXFLAGS += "$(CXXFLAGS) $(CPPFLAGS)"' \
@@ -59,7 +59,7 @@
--qsci-library-dir $(CURDIR)/QSciQt5
 ifeq ($(qt6), "yes")
cp -f Python/pyproject-qt6.toml Python/pyproject.toml
-   cd Python && python$* /usr/bin/sip-build \
+   cd Python && LD_LIBRARY_PATH=$(CURDIR)/QSciQt6 python$* 
/usr/bin/sip-build \
--verbose --no-make --pep484-pyi \
--qmake /usr/bin/qmake6 \
--qmake-setting 'QMAKE_CXXFLAGS += "$(CXXFLAGS) $(CPPFLAGS)"' \

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Re: qscintilla2: FTBFS on hppa - LD_LIBRARY_PATH incorrectly set

2023-11-28 Thread John Paul Adrian Glaubitz
Hi David!

The issue exists on sparc64 as well [1] and I'm not quite sure why it does not
seem to affect the release architectures:

make[2]: Entering directory '/<>/Python/build-3.11/cfgtest_Qsci'
sparc64-linux-gnu-g++ -c -pipe -g -O2 -ffile-prefix-map=/<>=. \
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time \
-D_FORTIFY_SOURCE=2 -O2 -Wall -Wextra -D_REENTRANT -fPIC -DQSCINTILLA_DLL \
-DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB 
\
-I. -I../../../QSciQt5 -I/usr/include/sparc64-linux-gnu/qt5 \
-I/usr/include/sparc64-linux-gnu/qt5/QtPrintSupport 
-I/usr/include/sparc64-linux-gnu/qt5/QtWidgets \
-I/usr/include/sparc64-linux-gnu/qt5/QtGui 
-I/usr/include/sparc64-linux-gnu/qt5/QtCore -I. \
-I/usr/lib/sparc64-linux-gnu/qt5/mkspecs/linux-g++ -o cfgtest_Qsci.o 
../../config-tests/cfgtest_Qsci.cpp
sparc64-linux-gnu-g++ -Wl,-z,relro -Wl,-O1 -o Qsci cfgtest_Qsci.o   \
-L../../../QSciQt5 -L/usr/lib/sparc64-linux-gnu -lqscintilla2_qt5 
/usr/lib/sparc64-linux-gnu/libQt5PrintSupport.so \
/usr/lib/sparc64-linux-gnu/libQt5Widgets.so 
/usr/lib/sparc64-linux-gnu/libQt5Gui.so \
/usr/lib/sparc64-linux-gnu/libQt5Core.so -lGL -lpthread   
make[2]: Leaving directory '/<>/Python/build-3.11/cfgtest_Qsci'
/<>/Python/build-3.11/cfgtest_Qsci/./Qsci 
/<>/Python/build-3.11/cfgtest_Qsci/cfgtest_Qsci.out
sip-build: '/<>/Python/build-3.11/cfgtest_Qsci/./Qsci' didn't 
create any output
/<>/Python/build-3.11/cfgtest_Qsci/./Qsci: error while loading 
shared libraries: libqscintilla2_qt5.so.15: \
cannot open shared object file: No such file or directory

Might be a race condition.

Adrian

> [1] 
> https://buildd.debian.org/status/fetch.php?pkg=qscintilla2&arch=sparc64&ver=2.14.1%2Bdfsg-1&stamp=1701131767&raw=0

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913