Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-06 Thread Paul Wise
gregor herrmann wrote:

> But this forked PPI seems like a blocker, at least I have no good
> idea how to handle it right now. [1]

It seems like the best option would be to talk to upstream about
depending on its dependencies instead of embedding/forking them.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part


Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-06 Thread Felix Lechner
Hi,

On Mon, Dec 6, 2021 at 12:44 PM gregor herrmann  wrote:
>
> It's already in NEW (and the other requested package as well).

Thank you for your prompt assistance!

Lintian provides backports to stable (and some users run it in even
more adventurous ways). Is it acceptable for the Lintian maintainers
to upload backports of the new packages, or would the Perl team rather
handle them via bug reports?

I would prefer if the Perl team handled backports as well, but it
would be an extra burden. Please just let me know one way or the
other. Thanks!

Kind regards
Felix Lechner



Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-06 Thread gregor herrmann
On Mon, 06 Dec 2021 11:26:22 -0800, Felix Lechner wrote:

> On Mon, Dec 6, 2021 at 10:48 AM gregor herrmann  wrote:
> > I have no good idea how to handle it right now.
> Thank you for having a look!
> For Lintian, the functionality of Sub::StrictDecl is probably enough.

Alright, thanks.

Then I propose that we put perlimports on the backburner until
someone both has good ideas and the necessary time to
implement them.

> I requested it separately (and you already assumed ownership). [1]

It's already in NEW (and the other requested package as well).


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Koko Taylor: Wang Dang Doodle


signature.asc
Description: Digital Signature


Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-06 Thread Felix Lechner
Hi,

On Mon, Dec 6, 2021 at 10:48 AM gregor herrmann  wrote:
>
> I have no good idea how to handle it right now.

Thank you for having a look!

For Lintian, the functionality of Sub::StrictDecl is probably enough.
I requested it separately (and you already assumed ownership). [1]
Thank you!

Kind regards,
Felix Lechner

[1] https://bugs.debian.org/1001175



Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-06 Thread Jonas Smedegaard
Quoting gregor herrmann (2021-12-06 19:48:39)
> I looked a bit further, and this is not as trivial as most CPAN 
> distributions:
> 
> - perlimports in the CPAN tarball is a fat-packed script:
>   https://metacpan.org/dist/App-perlimports/source/script/perlimports
>   i.e. it embeds a couple of Perl modules;
>   now we could just live it but that's neither elegant nor clever
>   seurity-wise nor simple copyright-wise;
> - we could try to rip out the fat-packed parts (which still leaves
>   the copyright question for the source package); [0] but:
> - the fat-packing works with an author script:
>   https://github.com/oalders/App-perlimports/tree/main/author
>   which already says that it uses a forked PPI module (cf. also
>   .gitmodules in the upstream git repo)
> 
> With cpanminus we have a similar situation, there we take the tarball
> from GitHub and not from CPAN, and create the actual script without
> fatpacking. (Before that we removed the fatpacked modules from the
> script.)
> 
> But this forked PPI seems like a blocker, at least I have no good
> idea how to handle it right now. [1]

If the forked PPI is specific for building this module, I would find it 
sensible to embed that fork with this source package - e.g. using the 
"component" feature of uscan.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature


Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-06 Thread gregor herrmann
On Sun, 05 Dec 2021 12:16:30 -0800, Felix Lechner wrote:

> On Sun, Dec 5, 2021 at 12:08 PM gregor herrmann  wrote:
> > (Just as a note, and that means I won't upload this tonight :))
> Thank you for looking into it!

You're welcome.

I looked a bit further, and this is not as trivial as most CPAN
distributions:

- perlimports in the CPAN tarball is a fat-packed script:
  https://metacpan.org/dist/App-perlimports/source/script/perlimports
  i.e. it embeds a couple of Perl modules;
  now we could just live it but that's neither elegant nor clever
  seurity-wise nor simple copyright-wise;
- we could try to rip out the fat-packed parts (which still leaves
  the copyright question for the source package); [0] but:
- the fat-packing works with an author script:
  https://github.com/oalders/App-perlimports/tree/main/author
  which already says that it uses a forked PPI module (cf. also
  .gitmodules in the upstream git repo)

With cpanminus we have a similar situation, there we take the tarball
from GitHub and not from CPAN, and create the actual script without
fatpacking. (Before that we removed the fatpacked modules from the
script.)

But this forked PPI seems like a blocker, at least I have no good
idea how to handle it right now. [1]

Cc'ing my friendly fellow perl team members …


Cheers,
gregor


[0] Cf. also 
https://github.com/oalders/App-perlimports/commit/7de596d7a607693ca298027bc63127e2a565f597
[1] I won't mention Monkey::Patch here.

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Joe Cocker: Rivers Rising


signature.asc
Description: Digital Signature


Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-05 Thread Felix Lechner
Hi,

On Sun, Dec 5, 2021 at 12:08 PM gregor herrmann  wrote:
>
> (Just as a note, and that means I won't upload this tonight :))

Thank you for looking into it!

Kind regards,
Felix Lechner



Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-05 Thread gregor herrmann
On Sun, 05 Dec 2021 10:06:31 -0800, Felix Lechner wrote:

> * Package name: perlimports
>   Version : 0.27
>   Upstream Author : Olaf Alders 
> * URL : https://metacpan.org/pod/App::perlimports
> * License : Artistic
>   Programming Lang: Perl
>   Description : Automate maintenance of Perl import statements
> 
> This distribution provides the perlimports command line interface
> (CLI), which automates the cleanup and maintenance of Perl use and
> require statements. Loosely inspired by goimports, this tool aims to
> be part of your linting and tidying workflow, in much the same way you
> might use perltidy or perlcritic.

This needs Symbol::Get, which needs Call::Context.

(Just as a note, and that means I won't upload this tonight :))


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Leonard Cohen: You Know Who I Am


signature.asc
Description: Digital Signature


Bug#1001176: RFP: perlimports -- Automate maintenance of Perl import statements

2021-12-05 Thread Felix Lechner
Package: wnpp
Severity: wishlist
X-Debbugs-CC: debian-p...@lists.debian.org

* Package name: perlimports
  Version : 0.27
  Upstream Author : Olaf Alders 
* URL : https://metacpan.org/pod/App::perlimports
* License : Artistic
  Programming Lang: Perl
  Description : Automate maintenance of Perl import statements

This distribution provides the perlimports command line interface
(CLI), which automates the cleanup and maintenance of Perl use and
require statements. Loosely inspired by goimports, this tool aims to
be part of your linting and tidying workflow, in much the same way you
might use perltidy or perlcritic.

For a detailed discussion of the problems this tool attempts to solve,
see this "Conference in the Cloud" talk from June 2021: Where did that
Symbol Come From? [1]

Lintian would like to use the functionality to protect against missing
imports in rarely used code paths during parallel execution. [2]
Thanks!

Kind regards,
Felix Lechner

[1] https://www.youtube.com/watch?v=fKqxdTbGxYY
[2] https://lists.debian.org/debian-perl/2021/11/msg00011.html