Bug#350391: glest package - an analysis

2006-08-13 Thread Eddy Petrişor

Hello Giuseppe,

I have seen your comments on REVU, how would you feel about
comaintaining glest insde the Debian Games Team, thus we could have
both the Ubuntu and the Debian version in sync and we could reduce the
packaing effort?

Now, about the package... I have made a modified Jamfile which adds a
clean target (see bug #350391 in debian BTS:
http://bugs.debian.org/350391), but there are some problems related to
dpatch and the way the editor target is removed. Why did you disable
it? I think it would be a good thing to have the editor, too, so I
don't see a reason to remove it. Still I think the clean target is not
complete, but I didn't had time to fully follow this and inverstigate.

On 11/08/06, Eddy Petrişor [EMAIL PROTECTED] wrote:

On 11/08/06, Eddy Petrişor [EMAIL PROTECTED] wrote:
 On 11/08/06, Eddy Petrişor [EMAIL PROTECTED] wrote:
   http://revu.tauware.de/details.py?upid=2849
- !!! the build process does *not* stop at any of these errors !!!
  
   Oh, crap, just saw it:
   -cd mk/linux  jam
  
   Please note that it won't stop compiling the targets if one fails due to 
jam's
   nature. IIRC jam -q could do that trick, but not sure though.
 
  the package has just compiled, I'll look into the ignoring thingies

 That leaves us also with the clean target not really doing the right
 job (did this after a build and running by hand debian/rules clean):

I worked a little on fixing the clean target, but is not yet there,
because there is another patch which affects the Jamfile, which
disables the editor. This is how the file should look like after the
clean target is added.


I have also a modified debian/rules but because of the editor target
patch issue I haven't published it yet.

--
Regards,
EddyP
=
Imagination is more important than knowledge A.Einstein


Bug#350391: glest package - an analysis

2006-08-11 Thread Eddy Petrişor

On 11/08/06, Stefan Potyra [EMAIL PROTECTED] wrote:

Hi Eddy,

thanks for stepping in here, I'm just -EOUTOFTIME right now :(.

NP



Am Donnerstag 10 August 2006 15:29 schrieb Eddy Petrişor:
 #I'll take this, in the name of the Debian Games Team
 owner 350391 !
 thanks

 Hello,

 I have looked over the glest package in REVU and tried to compile the
 package. I don't know what happens with this package, but it FTBFS for
 me.

Seems like you didn't look at the latest uploaded version to revu... it's

http://revu.tauware.de/details.py?upid=2849



*This* is weird! I specifically remember REVU pointing to a package
older than the one that should have been, judjing from the REVU page.
I have deleted from the dsc url the trailing part and looked by hand
the most recent upload of glest, then using that link to get the
package via dget. Maybe I have mixed middle click paste and
shift+insert paste.


(if you follow that link, and a newer version has been uploaded to revu,
you'll need to click on the latest date to switch to this upload. I know,
it's a little bit annoying that revu doesn't highlight what exact version
s.o. is looking at.)



 - not gcc 4.1 ready (lots of extraqualification erros)

This is fixed in the latter upload.

 - !!! the build process does *not* stop at any of these errors !!!

Oh, crap, just saw it:
-cd mk/linux  jam

Please note that it won't stop compiling the targets if one fails due to jam's
nature. IIRC jam -q could do that trick, but not sure though.


the package has just compiled, I'll look into the ignoring thingies


 - the glest binary is, of course, not created because many object
 files are broken, thus the dh_install rule fails when looking for that
 file
 - I think there are some places where the result of a rule in a target
 is ignored, which might be problematic

 I'll try to package this game after I test it some more ;-)

The version I built for ubuntu works quite well, but I didn't test it on
unstable yet. Also I didn't come around testing multiplayer. (And the AI
always beats me *g*).

As a side note: the glest script will link the binary and the game data to
~/.glest, which I think is not the very best approach to do so. However that
way it's possible to dump custom maps to ~/.glest, which otherwise doesn't
seem possible. I didn't look at any code bits yet, maybe glest could be
customized to honour both DATADIR and ~/.glest.


Hmm, yes, that would be nice, but we will see.

--
Regards,
EddyP
=
Imagination is more important than knowledge A.Einstein


Bug#350391: glest package - an analysis

2006-08-11 Thread Eddy Petrişor

On 11/08/06, Eddy Petrişor [EMAIL PROTECTED] wrote:

 http://revu.tauware.de/details.py?upid=2849
  - !!! the build process does *not* stop at any of these errors !!!

 Oh, crap, just saw it:
 -cd mk/linux  jam

 Please note that it won't stop compiling the targets if one fails due to jam's
 nature. IIRC jam -q could do that trick, but not sure though.

the package has just compiled, I'll look into the ignoring thingies


That leaves us also with the clean target not really doing the right
job (did this after a build and running by hand debian/rules clean):

# dpkg-buildpackage -uc -us
dpkg-buildpackage: source package is glest
dpkg-buildpackage: source version is 2.0.0-0ubuntu1
dpkg-buildpackage: source changed by Giuseppe Borzi [EMAIL PROTECTED]
dpkg-buildpackage: host architecture i386
dpkg-buildpackage: source version without epoch 2.0.0-0ubuntu1
debian/rules clean
dh_testdir
dh_testroot
rm -f build-stamp configure-stamp
# Add here commands to clean up after the build process.
/usr/bin/make clean
make[1]: Entering directory `/build/glest-2.0.0'
make[1]: *** No rule to make target `clean'.  Stop.
make[1]: Leaving directory `/build/glest-2.0.0'
make: [clean-patched] Error 2 (ignored)
dh_clean
dpatch  deapply-all
10_fix_gcc-4.1_particle.h not applied to ./ .
01_nomapeditor not applied to ./ .
rm -rf patch-stamp patch-stampT debian/patched
dpkg-source -b glest-2.0.0
dpkg-source: building glest using existing glest_2.0.0.orig.tar.gz
dpkg-source: building glest in glest_2.0.0-0ubuntu1.diff.gz
dpkg-source: cannot represent change to mk/linux/shared_lib:
dpkg-source:  new version is symlink
dpkg-source:  old version is nonexistent
dpkg-source: warning: executable mode 0755 of `mk/linux/configure'
will not be represented in diff
dpkg-source: cannot represent change to mk/linux/glest_game:
dpkg-source:  new version is symlink
dpkg-source:  old version is nonexistent
dpkg-source: cannot represent change to mk/linux/glest_map_editor:
dpkg-source:  new version is symlink
dpkg-source:  old version is nonexistent
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/shared_lib/sources/libglestlib.a:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/ai/ai.o: binary
file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/ai/ai_interface.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/ai/path_finder.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/ai/ai_rule.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/facilities/game_util.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/facilities/logger.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/facilities/components.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/game/console.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/game/game_camera.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/game/stats.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/game/commander.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/game/game.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/global/metrics.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/global/core_data.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/global/lang.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/global/config.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/graphics/renderer.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/graphics/particle_type.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/gui/selection.o:
binary file contents changed
dpkg-source: cannot represent change to
mk/linux/build/i486-pc-linux-gnu/optimize/glest_game/gui/display.o:
binary file contents changed
dpkg-source: 

Bug#350391: glest package - an analysis

2006-08-11 Thread Eddy Petrişor

On 11/08/06, Eddy Petrişor [EMAIL PROTECTED] wrote:

On 11/08/06, Eddy Petrişor [EMAIL PROTECTED] wrote:
  http://revu.tauware.de/details.py?upid=2849
   - !!! the build process does *not* stop at any of these errors !!!
 
  Oh, crap, just saw it:
  -cd mk/linux  jam
 
  Please note that it won't stop compiling the targets if one fails due to 
jam's
  nature. IIRC jam -q could do that trick, but not sure though.

 the package has just compiled, I'll look into the ignoring thingies

That leaves us also with the clean target not really doing the right
job (did this after a build and running by hand debian/rules clean):


I worked a little on fixing the clean target, but is not yet there,
because there is another patch which affects the Jamfile, which
disables the editor. This is how the file should look like after the
clean target is added.

--
Regards,
EddyP
=
Imagination is more important than knowledge A.Einstein


Jamfile
Description: Binary data


Bug#350391: glest package - an analysis

2006-08-10 Thread Eddy Petrişor

#I'll take this, in the name of the Debian Games Team
owner 350391 !
thanks

Hello,

I have looked over the glest package in REVU and tried to compile the
package. I don't know what happens with this package, but it FTBFS for
me.

These are the issues I have seen:
- build depends on libxerces26-dev (debian has 27)
- not gcc 4.1 ready (lots of extraqualification erros)
- !!! the build process does *not* stop at any of these errors !!!
- the glest binary is, of course, not created because many object
files are broken, thus the dh_install rule fails when looking for that
file
- I think there are some places where the result of a rule in a target
is ignored, which might be problematic

I'll try to package this game after I test it some more ;-)

--
Regards,
EddyP
=
Imagination is more important than knowledge A.Einstein


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]