Bug#360092: kmplayer package review

2006-04-05 Thread Mark Purcell
On Wednesday 05 April 2006 05:35, Christian Marillat wrote:
 Fathi BOUDRA [EMAIL PROTECTED] writes:

 [...]

  Christian, Jonathan, The Debian KDE-Extras team has uploaded kmplayer
  to http://svn.debian.org/wsvn/pkg-kde/kde-extras/ and we shall upload
  to the debian unstable archive shortly. If you have any suggestions
  for packaging please let us know and/or would like to work with us,
  please follow the README in svn.
 
  so a comment from peoples concerned will be appreciated :)

 Yes, this package should go in contrib due to the mplayer dependency.

Thanks Christian,

kmplayer despite the name no longer solely depends on mplayer to provide a 
functional media player.  In fact the way it has been packaged for Debian in 
svn.debian is that it only depends on the free xine to provide media player 
functionality and this should go in main and not contrib. It also can use a 
gstreamer backend, which, whilst also free, has been disabled for the Debian 
package.

Mark


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#360092: kmplayer package review

2006-04-05 Thread Christian Marillat
Mark Purcell [EMAIL PROTECTED] writes:

 On Wednesday 05 April 2006 05:35, Christian Marillat wrote:

[...]

 Yes, this package should go in contrib due to the mplayer dependency.

 Thanks Christian,

 kmplayer despite the name no longer solely depends on mplayer to provide a 
 functional media player.  In fact the way it has been packaged for Debian in 
 svn.debian is that it only depends on the free xine to provide media player 
 functionality and this should go in main and not contrib. It also can use a 
 gstreamer backend, which, whilst also free, has been disabled for the Debian 
 package.

Of course mplayer is needed. See in src/kmplayerprocess.cpp

In the same source, mencoder is also called which is definitely not
free.

The README file isn't ambiguous :

,
| KMPlayer needs KDE3.1 and a working mplayer/mencoder somewhere in you PATH.
`

So kmplayer should go in contrib or all the code related to
mplayer/mencoder need to be removed and then kmplayer can go in main.

Christian


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#360092: kmplayer package review

2006-04-04 Thread Mark Purcell
On Tuesday 04 April 2006 17:20, Fathi Boudra wrote:
 i've added kmplayer to kde-extras. The package lacks of 2 manpages that
 i'll write as soon as possible. If you've got some time, can you please
 review it ?

Fathi,

Even though you have filed the first ITP, you might like to check with 
Christian Marillat as he has kmplayer in his archives and your changelog 
should at least follow on from his..  Especially since his last version 
number is 1:0.9.1c-0.0 which is greater then your proposal.

Ubuntu also have a package so it might be good to sync changes with them.

Christian, Jonathan, The Debian KDE-Extras team has uploaded kmplayer to 
http://svn.debian.org/wsvn/pkg-kde/kde-extras/ and we shall upload to the 
debian unstable archive shortly. If you have any suggestions for packaging 
please let us know and/or would like to work with us, please follow the 
README in svn.

Mark


pgpOuBL3M1Ptq.pgp
Description: PGP signature