Bug#497200: ITP: rt2860-source -- source for RT2860 wireless adapter kernel module

2008-09-01 Thread Damyan Ivanov
-=| Ben Hutchings, Sat, Aug 30, 2008 at 11:16:27PM +0100 |=-
 On Sat, 2008-08-30 at 22:08 +0300, Damyan Ivanov wrote:
  Package: wnpp
  Severity: wishlist
  Owner: Damyan Ivanov [EMAIL PROTECTED]
  
  * Package name: rt2860-source
Version : 1.7.0.0
Upstream Author : Ralink Tech Inc
  * URL : http://www.ralinktech.com/
  * License : GPL-2+  some binary non-free firmware
Programming Lang: C
Description : source for RT2860 wireless adapter kernel module
  
  RT2860 is a wireless adapter found particularly in the ASUS EeePC model
  901 and above. The package contains the source of a Linux kernel module
  for it.
 
 Would you like to include this in the pkg-ralink project on Alioth?

It is currently under debian-eeepc Git[1], but I find what you say 
very attractive, especially if it is extended a bit:

[1] http://git.debian.org/?p=debian-eeepc/rt2860.git;a=summary

Would you like to take over the package? I'd gladly put it in the 
hands of people having experience dealing with ralink-based cards.

What do the rest of Debian EeePC Team thinks?

The package is as ready for 2.6.26 as I can get it without digging 
deep about moving the firmware into a separate package.

  There may be some licensing problems and this is why I CC 
  debian-legal.
  All the sources are licensed under GPL-2+, except one file,
  include/firmware.h, which is generated from a binary blob and contains
  the following notice:
 snip
  I did not yet check if this code is actually linked in the GPL-2+
  module, but have a bad feeling it it does. Would a compiled GPL source,
  including firmware.h be even distributable?
 
 Possibly not.  The module source code should go in contrib with the blob
 and firmware.h removed.  The blob should go in the firmware-ralink
 binary package built from the firmware-nonfree source package.

Or, the madwifi way - put only -source package in non-free and let 
users build the module with module-assistant.

  Perhaps the module can be changed to load its firmware from 
  external
  file or even not need that nasty firmware.h (there are traces of
  support to other hardware and that firmware may be for them).
 
 This should not be too hard.  Look at rt73 for an example of how
 this has been done in an existing Ralink driver.

Moving the firmware away would also make it possible for a -modules 
package to be made part of linux-modules-extra, right? That would be a 
good thing.

-- 
damJabberID: [EMAIL PROTECTED]


signature.asc
Description: Digital signature


Bug#497200: ITP: rt2860-source -- source for RT2860 wireless adapter kernel module

2008-09-01 Thread Sven Joachim
On 2008-09-01 09:07 +0200, Damyan Ivanov wrote:

 -=| Ben Hutchings, Sat, Aug 30, 2008 at 11:16:27PM +0100 |=-
 Possibly not.  The module source code should go in contrib with the blob
 and firmware.h removed.  The blob should go in the firmware-ralink
 binary package built from the firmware-nonfree source package.

 Or, the madwifi way - put only -source package in non-free and let 
 users build the module with module-assistant.

Please not.  Unlike madwifi, the ralink drivers are actually free, only
the device needs the non-free firmware.

 Moving the firmware away would also make it possible for a -modules 
 package to be made part of linux-modules-extra, right? That would be a 
 good thing.

As long as all devices that the driver supports need non-free firmware,
the -source and -modules packages should go to contrib, because the user
has to install the firmware (and if Debian can distribute it in
non-free, the driver should recommend the firmware package).

Regards,
Sven



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#497200: ITP: rt2860-source -- source for RT2860 wireless adapter kernel module

2008-09-01 Thread Ben Hutchings
On Mon, Sep 01, 2008 at 10:07:10AM +0300, Damyan Ivanov wrote:
 -=| Ben Hutchings, Sat, Aug 30, 2008 at 11:16:27PM +0100 |=-
  On Sat, 2008-08-30 at 22:08 +0300, Damyan Ivanov wrote:
   Package: wnpp
   Severity: wishlist
   Owner: Damyan Ivanov [EMAIL PROTECTED]
   
   * Package name: rt2860-source
 Version : 1.7.0.0
 Upstream Author : Ralink Tech Inc
   * URL : http://www.ralinktech.com/
   * License : GPL-2+  some binary non-free firmware
 Programming Lang: C
 Description : source for RT2860 wireless adapter kernel module
   
   RT2860 is a wireless adapter found particularly in the ASUS EeePC model
   901 and above. The package contains the source of a Linux kernel module
   for it.
  
  Would you like to include this in the pkg-ralink project on Alioth?
 
 It is currently under debian-eeepc Git[1], but I find what you say 
 very attractive, especially if it is extended a bit:
 
 [1] http://git.debian.org/?p=debian-eeepc/rt2860.git;a=summary
 
 Would you like to take over the package? I'd gladly put it in the 
 hands of people having experience dealing with ralink-based cards.

I don't have any of the hardware this supports, or any 802.11n access
point I could test against (though maybe other maintainers do).  There
would need to be someone in the team to take responsibility for that.
But the Ralink drivers have a lot in common (bugs, terrible coding
style...) so I should at least have some familiarity with the code.

snip
   Perhaps the module can be changed to load its firmware from 
   external
   file or even not need that nasty firmware.h (there are traces of
   support to other hardware and that firmware may be for them).
  
  This should not be too hard.  Look at rt73 for an example of how
  this has been done in an existing Ralink driver.
 
 Moving the firmware away would also make it possible for a -modules 
 package to be made part of linux-modules-extra, right? That would be a 
 good thing.

As it is, it could be built by linux-modules-nonfree-2.6.  Separate
the firmware and the module can be built by linux-modules-contrib-2.6.

Ben.

-- 
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison


signature.asc
Description: Digital signature


Bug#497200: ITP: rt2860-source -- source for RT2860 wireless adapter kernel module

2008-08-30 Thread Damyan Ivanov
Package: wnpp
Severity: wishlist
Owner: Damyan Ivanov [EMAIL PROTECTED]

* Package name: rt2860-source
  Version : 1.7.0.0
  Upstream Author : Ralink Tech Inc
* URL : http://www.ralinktech.com/
* License : GPL-2+  some binary non-free firmware
  Programming Lang: C
  Description : source for RT2860 wireless adapter kernel module

RT2860 is a wireless adapter found particularly in the ASUS EeePC model
901 and above. The package contains the source of a Linux kernel module
for it.


There may be some licensing problems and this is why I CC debian-legal.
All the sources are licensed under GPL-2+, except one file,
include/firmware.h, which is generated from a binary blob and contains
the following notice:

/*
 Copyright (c) 2007, Ralink Technology Corporation 
 All rights reserved. 

 Redistribution.  Redistribution and use in binary form, without 
 modification, are permitted provided that the following conditions are 
 met: 

* Redistributions must reproduce the above copyright notice and the 
following disclaimer in the documentation and/or other materials 
provided with the distribution. 
* Neither the name of Ralink Technology Corporation nor the names of 
its 
suppliers may be used to endorse or promote products derived from this 
software without specific prior written permission. 
* No reverse engineering, decompilation, or disassembly of this 
software 
is permitted. 

 Limited patent license. Ralink Technology Corporation grants a world-wide, 
 royalty-free, non-exclusive license under patents it now or hereafter 
 owns or controls to make, have made, use, import, offer to sell and 
 sell (Utilize) this software, but solely to the extent that any 
 such patent is necessary to Utilize the software alone, or in 
 combination with an operating system licensed under an approved Open 
 Source license as listed by the Open Source Initiative at 
 http://opensource.org/licenses.  The patent license shall not apply to 
 any other combinations which include this software.  No hardware per 
 se is licensed hereunder. 

 DISCLAIMER.  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND 
 CONTRIBUTORS AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, 
 BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND 
 FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE 
 COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, 
 INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, 
 BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS 
 OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 
 ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 
 TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE 
 USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH 
 DAMAGE. 
*/ 
/* AUTO GEN PLEASE DO NOT MODIFY IT */ 
/* AUTO GEN PLEASE DO NOT MODIFY IT */ 


UCHAR FirmwareImage [] = { 
0x02, 0x03, 0x5e, 0x02, 0x02, 0xb1, 0x22, 0x22, 0xff, 0xff, 0xff, 0x02, 0x01, 
0x82, 0xff, 0xff, 
.

I did not yet check if this code is actually linked in the GPL-2+
module, but have a bad feeling it it does. Would a compiled GPL source,
including firmware.h be even distributable?

Perhaps the module can be changed to load its firmware from external
file or even not need that nasty firmware.h (there are traces of
support to other hardware and that firmware may be for them).


-- 
dam



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#497200: [Debian-eeepc-devel] Bug#497200: ITP: rt2860-source -- source for RT2860 wireless adapter kernel module

2008-08-30 Thread Phil Endecott

Damyan Ivanov wrote:

There may be some licensing problems and this is why I CC debian-legal.
All the sources are licensed under GPL-2+, except one file,
include/firmware.h, which is generated from a binary blob and contains
the following notice:


[snip]

Looks bad to me.


I did not yet check if this code is actually linked in the GPL-2+
module, but have a bad feeling it it does. Would a compiled GPL source,
including firmware.h be even distributable?

Perhaps the module can be changed to load its firmware from external
file or even not need that nasty firmware.h (there are traces of
support to other hardware and that firmware may be for them).


There's some code in common/rtmp_init.c that's inside #ifdef 
BIN_IN_FILE that tries to get the firmware from a file, and falls back 
to the contents of firmware.h.  BIN_IN_FILE is not defined, and so it 
unconditionally uses firmware.h.  I have had a quick try at enabling 
BIN_IN_FILE, and defining RTMP_FIRMWARE_FILE_NAME to point to 
common/rt2860.bin, and according to the debug output it worked.  I 
can't be certain though, as it still has firmware.h compiled in as a 
fallback and unless you power-cycle you can't be sure that the previous 
download has been lost.


Someone keen could probably convert it to use the proper kernel 
firmware loading infrastructure.  The code that does this seems to be 
quite localised in common/rtmp_init.c.



Phil.







--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#497200: ITP: rt2860-source -- source for RT2860 wireless adapter kernel module

2008-08-30 Thread Ben Hutchings
On Sat, 2008-08-30 at 22:08 +0300, Damyan Ivanov wrote:
 Package: wnpp
 Severity: wishlist
 Owner: Damyan Ivanov [EMAIL PROTECTED]
 
 * Package name: rt2860-source
   Version : 1.7.0.0
   Upstream Author : Ralink Tech Inc
 * URL : http://www.ralinktech.com/
 * License : GPL-2+  some binary non-free firmware
   Programming Lang: C
   Description : source for RT2860 wireless adapter kernel module
 
 RT2860 is a wireless adapter found particularly in the ASUS EeePC model
 901 and above. The package contains the source of a Linux kernel module
 for it.

Would you like to include this in the pkg-ralink project on Alioth?

 There may be some licensing problems and this is why I CC debian-legal.
 All the sources are licensed under GPL-2+, except one file,
 include/firmware.h, which is generated from a binary blob and contains
 the following notice:
snip
 I did not yet check if this code is actually linked in the GPL-2+
 module, but have a bad feeling it it does. Would a compiled GPL source,
 including firmware.h be even distributable?

Possibly not.  The module source code should go in contrib with the blob
and firmware.h removed.  The blob should go in the firmware-ralink
binary package built from the firmware-nonfree source package.

 Perhaps the module can be changed to load its firmware from external
 file or even not need that nasty firmware.h (there are traces of
 support to other hardware and that firmware may be for them).

This should not be too hard.  Look at rt73 for an example of how
this has been done in an existing Ralink driver.

Ben.





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]