Bug#610676: My version of php-codecoverage

[Thomas Goirand]

On 04/20/2012 04:37 AM, Luis Uribe wrote:
 Hi,
 
 For some strange reason i can't push my changes to alioth, i'm sending a
 patch then.
 
 Cheers,

Thanks. Uploaded with your changes.

Thomas




-- 
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f913f80.9030...@goirand.fr

Bug#610676: My version of php-codecoverage

[Thomas Goirand]

Hi!

I have uploaded to Alioth a new version of the php-codecoverage package.
Please checkout the Git and let me know what you think. I hope you will
not take it as a take-over of the packaging, but more as a team work.
There was issues in the package from Arthur, and I believe that my
package is better. Of course, I'm open to any suggestion and improvement.

If you guys agree with the package and don't see any issue, I'll upload
once the dependencies are accepted in SID by ftp-masters.

Luis, do you plan on making more phpunit packages? It'd be really great
if you do! Arthur, do are you going to make more phpunit packages as well?

Once we get all these into SID, I think it'd be a good idea to start
having unit tests for the PEAR packages that support it. I'm currently
unsure how to do it, but that's certainly a very good quality insurance.

Cheers,

Thomas Goirand (zigo)



-- 
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f8fcaaf.3090...@goirand.fr

Bug#610676: My version of php-codecoverage

[Luis Uribe]

Hi,

On Thu, Apr 19, 2012 at 04:19:59PM +0800, Thomas Goirand wrote:
 Hi!
 
 I have uploaded to Alioth a new version of the php-codecoverage package.
 Please checkout the Git and let me know what you think. I hope you will
 not take it as a take-over of the packaging, but more as a team work.
 There was issues in the package from Arthur, and I believe that my
 package is better. Of course, I'm open to any suggestion and improvement.

I agree with the package, mine is almost similar (but you upload it first).

 If you guys agree with the package and don't see any issue, I'll upload
 once the dependencies are accepted in SID by ftp-masters.

I check the package at my laptop and upload some changes to Alioth:

+ Fixed copyright file (There was a lintian warning)
+ Add a patch for php-token-stream PATH
+ Adding php5-xdebug to Depends:

I try to run a simple example:

acme@volatile /tmp $ cat foo.php 
?php
require 'PHP/CodeCoverage/Autoload.php';

$coverage = new PHP_CodeCoverage;
//$coverage-start('name of test');

// ...

$coverage-stop();

?

But i've got this error:

acme@volatile /tmp $ php -f foo.php 
PHP Fatal error:  Uncaught exception 'PHP_CodeCoverage_Exception' with message 
'Xdebug is not loaded.' in /usr/share/php/PHP/CodeCoverage/Driver/Xdebug.php:67
Stack trace:
#0 /usr/share/php/PHP/CodeCoverage.php(119): 
PHP_CodeCoverage_Driver_Xdebug-__construct()
#1 /tmp/foo.php(4): PHP_CodeCoverage-__construct()
#2 {main}
  thrown in /usr/share/php/PHP/CodeCoverage/Driver/Xdebug.php on line 67

However i can't install php5-xdebug at this machine:

root@volatile:~# apt-get install php5-xdebug
Reading package lists... Done
Building dependency tree   
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 php5-xdebug : Depends: phpapi-20100525+lfs
E: Broken packages

I will try it on a clean sid machine and let you know the results. Don't know 
if xdebug is broken or is just my machine.

 Luis, do you plan on making more phpunit packages? It'd be really great
 if you do! Arthur, do are you going to make more phpunit packages as well?

Sure! I don't have much time this month but i will help as much as i can.

 Once we get all these into SID, I think it'd be a good idea to start
 having unit tests for the PEAR packages that support it. I'm currently
 unsure how to do it, but that's certainly a very good quality insurance.

Like running phpunit tests on a clean sid installation? Sounds good to me.

Thanks,

-- 
Luis Uribe
http://eviled.org


signature.asc
Description: Digital signature

Bug#610676: My version of php-codecoverage

[Luis Uribe]

Hi,

For some strange reason i can't push my changes to alioth, i'm sending a
patch then.

Cheers,

-- 
Luis Uribe
http://eviled.org
diff --git a/debian/control b/debian/control
index d2ea893..5366de2 100644
--- a/debian/control
+++ b/debian/control
@@ -11,7 +11,7 @@ Homepage: http://pear.phpunit.de/
 
 Package: php-codecoverage
 Architecture: all
-Depends: ${misc:Depends}, pear-phpunit-channel, php-text-template, php-file-iterator, php-token-stream, libjs-jquery, libjs-yui
+Depends: ${misc:Depends}, pear-phpunit-channel, php-text-template, php-file-iterator, php-token-stream, libjs-jquery, libjs-yui, php5-xdebug
 Description: provides collection, processing and rendering for PHP code coverage information
  This PEAR package provides collection, processing, and rendering functionality
  for PHP code coverage information. It is part of a collection of PEAR packages
diff --git a/debian/copyright b/debian/copyright
index 44f28d3..a54ce4a 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -15,26 +15,23 @@ License: BSD
 
 License: BSD
  Redistribution and use in source and binary forms, with or without
- modification, are permitted provided that the following conditions are met:
+ modification, are permitted provided that the following conditions
+ are met:
+ 1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ 2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+ 3. The name of the author may not be used to endorse or promote products
+ derived from this software without specific prior written permission.
  .
- Redistributions of source code must retain the above copyright notice, this
- list of conditions and the following disclaimer.
- .
- Redistributions in binary form must reproduce the above copyright notice,
- this list of conditions and the following disclaimer in the documentation
- and/or other materials provided with the distribution.
- .
- Neither the name of Sebastian Bergmann nor the names of his contributors may
- be used to endorse or promote products derived from this software without
- specific prior written permission.
-
- THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS AS IS
- AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
- FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
- CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
- OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/debian/patches/02_php-tokenstream.patch b/debian/patches/02_php-tokenstream.patch
new file mode 100644
index 000..cb95d89
--- /dev/null
+++ b/debian/patches/02_php-tokenstream.patch
@@ -0,0 +1,16 @@
+Description: Patch to fix php-token-stream path
+Author: Luis Uribe a...@eviled.org
+
+Index: php-codecoverage/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Autoload.php
+===
+--- php-codecoverage.orig/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Autoload.php	2012-04-19 15:05:17.0 -0500
 php-codecoverage/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Autoload.php	2012-04-19 15:05:56.0 -0500
+@@ -44,7 +44,7 @@
+  */
+ 
+ require_once 'File/Iterator/Autoload.php';
+-require_once 'PHP/Token/Stream/Autoload.php';
++require_once 'Token/Token/Stream/Autoload.php';
+ require_once 'Text/Template/Autoload.php';
+ 
+ function php_codecoverage_autoload($class = NULL) {
diff --git a/debian/patches/series b/debian/patches/series
index 53c2e6a..b215665 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 01_channel.patch
+02_php-tokenstream.patch


signature.asc
Description: