Bug#612341: libjpeg-turbo, getting it into wheezy

2012-06-16 Thread Osamu Aoki
Hi,

(I had email problem resending ...)

On Wed, Jun 06, 2012 at 08:18:14AM +0200, Mike Gabriel wrote:
> Hi all,
> 
> it seems the discussion has come to an intermediary still point... I
> will pick up the thread then...
> 
> On So 03 Jun 2012 11:32:47 CEST Bill Allombert wrote:
> 
> >>Not getting what you mean exactly here. Can anything be done about
> >>it? Anything that we can do?
> >
> >I assume that Osamu refer to this line of the IJG license:
> >
> >(1) If any part of the source code for this software is
> >distributed, then this
> >README file must be included, with this copyright and no-warranty notice
> >unaltered; and any additions, deletions, or changes to the original files
> >must be clearly indicated in accompanying documentation.
> >
> >For example, when I released libjpeg 6b1, I added a file README.6b1
> >with the complete list of modified files (in attachment).
> >
> >(I am not especially fond of this requirement, but it is not really onerous).

Yes.  And also, some source codes are modified in the way which may look
like they were released by IJG while including libjpeg-turbo copyright
and names included.  For example: jpegtran.c

| /*
|  * jpegtran.c
|  *
|  * Copyright (C) 1995-2010, Thomas G. Lane, Guido Vollbeding.
|  * Copyright (C) 2010, D. R. Commander.
|  * This file is part of the Independent JPEG Group's software.
|  * For conditions of distribution and use, see the accompanying README file.
|  *
|  * This file contains a command-line user interface for JPEG transcoding.
|  * It is very similar to cjpeg.c, and partly to djpeg.c, but provides
|  * lossless transcoding between different JPEG file formats.  It also
|  * provides some lossless and sort-of-lossless transformations of JPEG data.
|  */

As I understand, D. R. Commander is not Independent JPEG Group.  This is a bit
ambiguous. (Since README is modified, this is not totally wrong but still
misleading.) I would add one line.

|  * This file ws part of the Independent JPEG Group's software.
|  * This file is adoped and modified for libjpeg-turbo.
|  * For conditions of distribution and use, see the accompanying README file.


> @Bill: Thanks for this extra info, this should be provided by
> libjpeg-turbo upstream and be re-modified by the Debian maintainers
> of libjpeg-turbo.

True to some extent.  Basically, when we package, we need to check all
licenses.  Especially for this type of software, its careful review is
strongly recommended for debian/copyright.  I think it is prudent send a
patch to upstream, if we can.

> Most important questions currently are:
> 
> 1. Is team maintenance wanted and ok (pkg-tigervnc team context).
> Fathi in the role of ITP holder, we need your statement here.

Please.  (Within few days since we are close to freeze.)
 
> 2. Is it ok to start working with:
> http://anonscm.debian.org/gitweb/?p=users/osamu/libjpeg-turbo.git;a=summary
> http://code.das-netzwerkteam.de/gitweb?p=debian/libjpeg-turbo.git;a=summary

I merged your changes.   Fathi, will you reset your collab-maint
archive.  So we can make better history and work together.

> 3. Who does what?

I can help routine simple works.  But one of you have to be the
maintainer. I can sponsor.

> 4. Communication channels (IRC, pkg-tigervnc-devel@l.a.d.o, Jabber?)

For now, good enough.  I do not do Jabber.
 
> 5. Who does review, sponsor, upload the work?

First, we still need to fix few things. Quick build and lintian found
some bugs and i fixed in my repo.  Please check.

I did not revert your change for debian/copyright.  But changing from
LGPL to GPL is not wise thing to do.  Did you consult previous
maintainer to get consent?  Also, I do not understand why debian/* was
marked as LGPL to start with while it contains patch to BSD upstream.
Cosidering situation, this may not cause much real problem but unusual.

I have not addressed following warnings.

W: libturbojpeg: shlib-without-versioned-soname 
usr/lib/x86_64-linux-gnu/libturbojpeg.so libturbojpeg.so
N: 
N:The listed shared library in a public library directory has an SONAME
N:that does not contain any versioning information, either after the .so
N:or before it and set off by a hyphen. It cannot therefore be represented
N:in the shlibs system, and if linked by binaries its interface cannot
N:safely change. There is no backward-compatible way to migrate programs
N:linked against it to a new ABI.
N:
N:Normally, this means the shared library is a private library for a
N:particular application and is not meant for general use. Policy
N:recommends that such libraries be installed in a subdirectory of
N:/usr/lib rather than in a public shared library directory.
N:
N:To view the SONAME of a shared library, run readelf -d on the shared
N:library and look for the tag of type SONAME.
N:
N:There are some special stub libraries or special-purpose shared objects
N:for which an ABI version is not meaningful. If this is one of

Bug#612341: libjpeg-turbo, getting it into wheezy

2012-06-05 Thread Mike Gabriel

Hi all,

it seems the discussion has come to an intermediary still point... I  
will pick up the thread then...


On So 03 Jun 2012 11:32:47 CEST Bill Allombert wrote:


Not getting what you mean exactly here. Can anything be done about
it? Anything that we can do?


I assume that Osamu refer to this line of the IJG license:

(1) If any part of the source code for this software is distributed,  
then this

README file must be included, with this copyright and no-warranty notice
unaltered; and any additions, deletions, or changes to the original files
must be clearly indicated in accompanying documentation.

For example, when I released libjpeg 6b1, I added a file README.6b1
with the complete list of modified files (in attachment).

(I am not especially fond of this requirement, but it is not really onerous).


@Bill: Thanks for this extra info, this should be provided by  
libjpeg-turbo upstream and be re-modified by the Debian maintainers of  
libjpeg-turbo.


Most important questions currently are:

1. Is team maintenance wanted and ok (pkg-tigervnc team context).  
Fathi in the role of ITP holder, we need your statement here.


2. Is it ok to start working with:
http://anonscm.debian.org/gitweb/?p=users/osamu/libjpeg-turbo.git;a=summary
http://code.das-netzwerkteam.de/gitweb?p=debian/libjpeg-turbo.git;a=summary

3. Who does what?

4. Communication channels (IRC, pkg-tigervnc-devel@l.a.d.o, Jabber?)

5. Who does review, sponsor, upload the work?

Let us get moving...

Greets,
Mike


--

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0xB588399B
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb


pgpOVZ5mB2S4W.pgp
Description: Digitale PGP-Unterschrift