Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Mon, 2014-05-12 at 11:15 +0200, Roland Mas wrote: > Daniel Beyer, 2014-05-12 07:54:43 +0200 : > > [...] > > > I pushed everything I've done last week to anonscm.d.o [1] and > > uploaded the package again to mentors [2]. > > > > Roland, can you have an other look onto the package, especially the > > new parts [3] regarding the newly added php-twig-doc package? > > I just did. The package looks fine, and I uploaded it. Thanks! > > Since I plan on using it for FusionForge, you may hear from me as a > user in the not-too-distant future if I find bugs :-) > That's just great. Really thanks a lot for the upload. signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Daniel Beyer, 2014-05-12 07:54:43 +0200 : [...] > I pushed everything I've done last week to anonscm.d.o [1] and > uploaded the package again to mentors [2]. > > Roland, can you have an other look onto the package, especially the > new parts [3] regarding the newly added php-twig-doc package? I just did. The package looks fine, and I uploaded it. Thanks! Since I plan on using it for FusionForge, you may hear from me as a user in the not-too-distant future if I find bugs :-) Roland. -- Roland Mas A lesson for you all: never fall in love during a total eclipse. -- Senex, in A Funny Thing Happened on the Way to the Forum -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/87r43ztl19@polymir.placard.fr.eu.org
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Mon, 2014-05-05 at 13:31 +0200, Daniel Beyer wrote:
> On Mon, 2014-05-05 at 12:12 +0200, Roland Mas wrote:
> >
> > The main nit I have is that the testsuite doesn't pass. When I run
> > pdebuild, the override_dh_auto_test target in debian/rules runs phpunit,
> > and phpunit fails one test with the following error:
> >
> > ,
> > | There was 1 failure:
> > |
> > | 1) Twig_Tests_IntegrationTest::testIntegration with data set #23
> > ('expressions/ends_with.test', 'Twig supports the "ends with" operator',
> > '', array('
> > | {{ \'foo\' ends with \'o\' ? \'OK\' : \'KO\' }}
> > | {{ not (\'foo\' ends with \'f\') ? \'OK\' : \'KO\' }}
> > | {{ not (\'foo\' ends with \'foowaytoolong\') ? \'OK\' : \'KO\' }}'),
> > false, array(array('--DATA--
> > | return array()
> > | --EXPECT--
> > | OK
> > | OK
> > | OK', '
> > | return array()
> > | ', '', '
> > | OK
> > | OK
> > | OK')))
> > | Twig supports the "ends with" operator (in expressions/ends_with.test)
> > | Failed asserting that two strings are equal.
> > | --- Expected
> > | +++ Actual
> > | @@ @@
> > | 'OK
> > | -OK
> > | -OK'
> > | +KO
> > | +KO'
> > |
> > | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:140
> > | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:28
> > `
> >
> > I'm not sure exactly what that means, but since the source package
> > generates an arch-specific binary package it's quite possible that the
> > autobuilders will fail on that. And regardless of the biuldds, it's
> > better if the testsuite passes.
> >
>
> Funny, the tests do not fail under wheezy(-backports), but they do fail
> under jessie and sid (both with the error above). I'll try to take a
> look at this in the evening.
>
It looks like this is related to php 5.5.11. With php 5.5.12 which now
can be found in jessie and sid the problem is gone. I'll try to check
what's wrong with Twig and php 5.5.11. But for now this no longer should
block this package, since tests passes with the versions of php
currently found in wheezy, jessie and sid.
>
> > Also, I found out that https://github.com/fabpot/Twig/issues/1118 is
> > now closed. It might make sense so update the packaging accordingly
> > (maybe add a new php-twig-doc binary package?).
> >
> > Thanks for your efforts, this package is almost in shape!
> >
>
> Great, I guess I should go and thank some people like my colleague at
> work for finally getting this resolved. I already have a variant laying
> around that builds a -doc from the source, so this should not delay the
> packing much.
>
The doc no longer gets removed from upstream's tarball, the '+dfsg' is
removed from the Debian version and a new binary package 'php-twig-doc'
is build.
I pushed everything I've done last week to anonscm.d.o [1] and uploaded
the package again to mentors [2].
Roland, can you have an other look onto the package, especially the new
parts [3] regarding the newly added php-twig-doc package?
Thanks
Daniel
[1] http://anonscm.debian.org/gitweb/?p=pkg-php/twig.git;a=summary
[2] https://mentors.debian.net/package/twig
[3]
http://anonscm.debian.org/gitweb/?p=pkg-php/twig.git;a=commit;h=ad3dc1376111f8351f8e905b9799d687b64713d1
signature.asc
Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Mon, 2014-05-05 at 12:12 +0200, Roland Mas wrote:
> Daniel Beyer, 2014-05-04 23:44:03 +0200 :
>
> > Roland, can you have a look onto the package? Yann and I think it is
> > ready. You can find it on anonscm.d.o [1] or mentors [2]. Thanks a
> > lot!
>
> I just did. The package looks almost ready, congrats :-)
>
> The main nit I have is that the testsuite doesn't pass. When I run
> pdebuild, the override_dh_auto_test target in debian/rules runs phpunit,
> and phpunit fails one test with the following error:
>
> ,
> | There was 1 failure:
> |
> | 1) Twig_Tests_IntegrationTest::testIntegration with data set #23
> ('expressions/ends_with.test', 'Twig supports the "ends with" operator', '',
> array('
> | {{ \'foo\' ends with \'o\' ? \'OK\' : \'KO\' }}
> | {{ not (\'foo\' ends with \'f\') ? \'OK\' : \'KO\' }}
> | {{ not (\'foo\' ends with \'foowaytoolong\') ? \'OK\' : \'KO\' }}'), false,
> array(array('--DATA--
> | return array()
> | --EXPECT--
> | OK
> | OK
> | OK', '
> | return array()
> | ', '', '
> | OK
> | OK
> | OK')))
> | Twig supports the "ends with" operator (in expressions/ends_with.test)
> | Failed asserting that two strings are equal.
> | --- Expected
> | +++ Actual
> | @@ @@
> | 'OK
> | -OK
> | -OK'
> | +KO
> | +KO'
> |
> | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:140
> | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:28
> `
>
> I'm not sure exactly what that means, but since the source package
> generates an arch-specific binary package it's quite possible that the
> autobuilders will fail on that. And regardless of the biuldds, it's
> better if the testsuite passes.
>
Funny, the tests do not fail under wheezy(-backports), but they do fail
under jessie and sid (both with the error above). I'll try to take a
look at this in the evening.
> Also, I found out that https://github.com/fabpot/Twig/issues/1118 is
> now closed. It might make sense so update the packaging accordingly
> (maybe add a new php-twig-doc binary package?).
>
> Thanks for your efforts, this package is almost in shape!
>
Great, I guess I should go and thank some people like my colleague at
work for finally getting this resolved. I already have a variant laying
around that builds a -doc from the source, so this should not delay the
packing much.
Thanks a lot for you fast and valuable feedback.
--
Daniel
Swiss
signature.asc
Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Daniel Beyer, 2014-05-04 23:44:03 +0200 :
> Roland, can you have a look onto the package? Yann and I think it is
> ready. You can find it on anonscm.d.o [1] or mentors [2]. Thanks a
> lot!
I just did. The package looks almost ready, congrats :-)
The main nit I have is that the testsuite doesn't pass. When I run
pdebuild, the override_dh_auto_test target in debian/rules runs phpunit,
and phpunit fails one test with the following error:
,
| There was 1 failure:
|
| 1) Twig_Tests_IntegrationTest::testIntegration with data set #23
('expressions/ends_with.test', 'Twig supports the "ends with" operator', '',
array('
| {{ \'foo\' ends with \'o\' ? \'OK\' : \'KO\' }}
| {{ not (\'foo\' ends with \'f\') ? \'OK\' : \'KO\' }}
| {{ not (\'foo\' ends with \'foowaytoolong\') ? \'OK\' : \'KO\' }}'), false,
array(array('--DATA--
| return array()
| --EXPECT--
| OK
| OK
| OK', '
| return array()
| ', '', '
| OK
| OK
| OK')))
| Twig supports the "ends with" operator (in expressions/ends_with.test)
| Failed asserting that two strings are equal.
| --- Expected
| +++ Actual
| @@ @@
| 'OK
| -OK
| -OK'
| +KO
| +KO'
|
| /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:140
| /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:28
`
I'm not sure exactly what that means, but since the source package
generates an arch-specific binary package it's quite possible that the
autobuilders will fail on that. And regardless of the biuldds, it's
better if the testsuite passes.
Also, I found out that https://github.com/fabpot/Twig/issues/1118 is
now closed. It might make sense so update the packaging accordingly
(maybe add a new php-twig-doc binary package?).
Thanks for your efforts, this package is almost in shape!
Roland.
--
Roland Mas
Reincarnation likes a joke as much as the next philosophical hypothesis.
-- in The Truth (Terry Pratchett)
--
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/87eh084jpz@polymir.placard.fr.eu.org
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Roland, can you have a look onto the package? Yann and I think it is ready. You can find it on anonscm.d.o [1] or mentors [2]. Thanks a lot! Yann, please find my replies inline. On Sat, 2014-05-03 at 12:13 +0200, Yann Autissier wrote: > Hi Daniel, > > I pushed two modifications to github : > - rename the C extension package to php5-twig > - update dependencies between packages as you mentionned > Perfect and thanks a lot for updating the two README.Debian files. > The packaging is quite complete and compiles properly. > > All seems fine to me. Great, so it does to me. Please note that I put the git repository onto anonscm.d.o [1], since this should makes it easier to group-maintain Twig within the Debian PHP PEAR Maintainers. I updated the vcs-fields in d/control to reflect the new location of the packaging repository. You may in future want to push directly to the repository there. [1] http://anonscm.debian.org/gitweb/?p=pkg-php/twig.git;a=summary [2] https://mentors.debian.net/package/twig signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Le 28/04/2014 23:43, Daniel Beyer a écrit : > On Wed, 2014-04-23 at 23:28 +0200, Daniel Beyer wrote: > > Hi Yann, hi Laurent, > > what do you think about the way Twig currently is packaged? Should we > proceed with the current packaging or are there reasons to re-think > about or even abandon it? > Hi Daniel, I pushed two modifications to github : - rename the C extension package to php5-twig - update dependencies between packages as you mentionned The packaging is quite complete and compiles properly. All seems fine to me. Regards, Yann signature.asc Description: OpenPGP digital signature
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Wed, 2014-04-29 at 09:24 +0200, Yann Autissier wrote: > Here it is : https://github.com/aya Thanks, just added it. signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Le 2014-04-29 08:57, Daniel Beyer a écrit : On Tue, 2014-04-29 at 00:57 +0200, Yann Autissier wrote: Hi Daniel, I agree that twig should be provided as two separate packages for the C module and the PEAR extension, with a dependance between both. Currently php-twig only suggests the C module, while the C module recommends php-twig. Thinking about it, I guess more tight dependencies would be better, e.g: Let the C module depend on php-twig and have php-twig recommend the C module. I would rather have named the C module 'php5-twig', like other C modules. I agree. Do you have an account on github? I would happily add you to the current repo there, so you can directly push changes to it. But maybe the repo should be put onto alioth? Here it is : https://github.com/aya -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/e8c2ae00fcf3eb1e8f9a3f507c299...@autissier.net
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Tue, 2014-04-29 at 00:57 +0200, Yann Autissier wrote: > > Hi Daniel, > > I agree that twig should be provided as two separate packages for the C module > and the PEAR extension, with a dependance between both. > Currently php-twig only suggests the C module, while the C module recommends php-twig. Thinking about it, I guess more tight dependencies would be better, e.g: Let the C module depend on php-twig and have php-twig recommend the C module. > I would rather have named the C module 'php5-twig', like other C modules. > I agree. Do you have an account on github? I would happily add you to the current repo there, so you can directly push changes to it. But maybe the repo should be put onto alioth? @Roland, David: The instructions on php.debian.net how to upload a repo mentions a shell script alioth-new-git [1], which no longer seems to be around there. Btw.: My alioth account is dabe-guest. > I will shortly test your packaging and give you some feedback. > Great! In the meantime I recalled Twig from mentors.debian.net, since it obviously needs some more work. [1] http://php.debian.net/alioth-new-git.txt -- Daniel Swiss signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Le 28/04/2014 23:43, Daniel Beyer a écrit : > On Wed, 2014-04-23 at 23:28 +0200, Daniel Beyer wrote: >> On Wed, 2014-04-23 at 19:14 +0200, Daniel Beyer wrote: >> >> I just pushed that to the repo on github [1] and dropped some no longer >> useful old branches. Additionally I locally build and uploaded the >> current status (as of 039273f) to mentors.debian.net [2]. >> >> Any feedback/review/improvements/suggestions/testing is always welcome. >> >> [1] https://github.com/ymc/twig-debian >> [2] https://mentors.debian.net/package/twig > > Hi Yann, hi Laurent, > > what do you think about the way Twig currently is packaged? Should we > proceed with the current packaging or are there reasons to re-think > about or even abandon it? > Hi Daniel, I agree that twig should be provided as two separate packages for the C module and the PEAR extension, with a dependance between both. I would rather have named the C module 'php5-twig', like other C modules. I will shortly test your packaging and give you some feedback. Regards, Yann signature.asc Description: OpenPGP digital signature
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Wed, 2014-04-23 at 23:28 +0200, Daniel Beyer wrote: > On Wed, 2014-04-23 at 19:14 +0200, Daniel Beyer wrote: > > > > (...) > > > > * I'm almost done with switching the packing to git-buildpackage and > > will push this to github in the next few hours. > > > > I just pushed that to the repo on github [1] and dropped some no longer > useful old branches. Additionally I locally build and uploaded the > current status (as of 039273f) to mentors.debian.net [2]. > > Any feedback/review/improvements/suggestions/testing is always welcome. > > > (...) > > [1] https://github.com/ymc/twig-debian > [2] https://mentors.debian.net/package/twig > > Hi Yann, hi Laurent, what do you think about the way Twig currently is packaged? Should we proceed with the current packaging or are there reasons to re-think about or even abandon it? Sorry for pushing this, which might seems a bit strange after I cold-shouldered this ITP for quite some time. But now that David brought this up again and Roland pointed to a quite promising way for getting Twig into and maintaining it in Debian, I simply can't let loose of it. Btw: In recent commit 79878c9 [1] I dropped the dependency to devscript 2.13.5~ in favor of a newly added override_dh_testdir target in d/rules. The commit message explains my motivation for this, but I'm unsure if this really is something that should be done there. [1]https://github.com/ymc/twig-debian/commit/79878c9d3a48ffafb39d1aaeee588a88f8027eb7 Thanks Daniel signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Wed, 2014-04-23 at 19:14 +0200, Daniel Beyer wrote: > > (...) > > * I'm almost done with switching the packing to git-buildpackage and > will push this to github in the next few hours. > I just pushed that to the repo on github [1] and dropped some no longer useful old branches. Additionally I locally build and uploaded the current status (as of 039273f) to mentors.debian.net [2]. Any feedback/review/improvements/suggestions/testing is always welcome. > (...) > [1] https://github.com/ymc/twig-debian [2] https://mentors.debian.net/package/twig -- Daniel Swiss signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
On Wed, 2014-04-23 at 18:23 +0200, Roland Mas wrote: > Hi all, > > As part of > https://wiki.debian.org/DebianFrance/NewContributorGame#Twig_packaging > I'd like to introduce you guys to one another. Yann and Laurent > expressed interest in packaging Twig; from a cursory read of the bug > log, Daniel seems to have preliminary packages; David is curious ; > #645883 is where the discussion happens (and pkg-php-pear would like to > be kept in touch); and yours truly is interested in seeing the package > enter Debian and would gladly provide testing and sponsoring. Let's > work together :-) > > Roland. That's totally great news for me and I'm really would enjoy working on that with all of you. To prevent you from digging through #645883 here is its current status: * There is a packaging on github [1], which I think is in a pretty good shape. * I'm almost done with switching the packing to git-buildpackage and will push this to github in the next few hours. * I (double) replaced the way the dfsg source is generated. In the current (just pushed) version it uses uscan's "debian/copyright::Files-Excluded" feature (first found in devscripts v2.13.5). * The licensing issue of Twig's documentation: This is now open for about 10 month. Short version is, that SensioLabs mentions two different licenses for Twig's documentation (see [2]). A co-worker of mine at YMC will meet with Andreas from SensioLabs Germany tomorrow and promised me to talk with him about that licensing thing. Therefore I have reason to believe this might get resolved soon. Btw: I have a version of the packaging, that additionally builds a -doc package from the source. But that one would need some more work to get it in a final shape. The last days I had time to play around with pkg-php-tools. The way of creating Debian packages from pear repositories is cool. Sadly, in my opinion, this can't be used for Twig, since we would end up with multiple source packages for Twig (one for Twig, one for Twig's PHP5 extension and probably an other one for the documentation). Reason for this is, that Twigs pear package [3] only provides the PHP code of Twig. The PHP5 extension is in a separate pear package and the documentation is not found on the pear channel at all (at least I did not see any traces of it). @David: I have a modified version of package pear-channels, that adds Twigs's pear channel - if you are interested in it. [1] https://github.com/ymc/twig-debian [2] https://github.com/fabpot/Twig/issues/1118 [3] http://pear.twig-project.org/ Sorry for the pretty longish summary, didn't intended to write that much... Greetings Daniel signature.asc Description: This is a digitally signed message part
Bug#645883: [pkg-php-pear] Bug#645883: Current status of twig
Hi all, As part of https://wiki.debian.org/DebianFrance/NewContributorGame#Twig_packaging I'd like to introduce you guys to one another. Yann and Laurent expressed interest in packaging Twig; from a cursory read of the bug log, Daniel seems to have preliminary packages; David is curious ; #645883 is where the discussion happens (and pkg-php-pear would like to be kept in touch); and yours truly is interested in seeing the package enter Debian and would gladly provide testing and sponsoring. Let's work together :-) Roland. -- Roland Mas Je suis un anti-virus de signature. Copiez-moi dans la vôtre pour éliminer les virus de signature ! -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/87lhuwovzn@polymir.placard.fr.eu.org
