Bug#777671: firejail packaging
Hi Reiner, How the firejail packaging goes? I've a working package, ready to upload. But you own the ITP and I step back if all you need is more time to finish your work. Otherwise I'd be happy to take over. Regards, Laszlo/GCS -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cakjshr3+9q52o_l8n-ukknmog3z5o0gxhyb7cp+12fqi5t8...@mail.gmail.com
Bug#777671: firejail packaging
Hi Laszlo, On 03/14/2015 05:30 PM, László Böszörményi (GCS) wrote: > How the firejail packaging goes? I've a working package, ready to > upload. But you own the ITP and I step back if all you need is more > time to finish your work. Otherwise I'd be happy to take over. I also already have a working package, which I just uploaded to mentors: https://mentors.debian.net/package/firejail While packaging it, I sent a few patches upstream, which is the reason why I intended to wait for a new upstream release before submitting it, so that those patches can be dropped. But since you are interested in the package, I uploaded my current state. Woule you be interested in reviewing it and sponsoring an upload? You can get it with the following command: dget -x http://mentors.debian.net/debian/pool/main/f/firejail/firejail_0.9.22-1.dsc Regards, Reiner signature.asc Description: OpenPGP digital signature
Bug#777671: firejail packaging
Hi Reiner, On Sat, Mar 14, 2015 at 9:24 PM, Reiner Herrmann wrote: > While packaging it, I sent a few patches upstream, which is the reason > why I intended to wait for a new upstream release before submitting it, so > that those patches can be dropped. But there's no problem only later removing it from the package when upstream releases a new version. The package needs to go through our NEW queue anyway which needs time. Newer versions can be uploaded meanwhile. > But since you are interested in the package, I uploaded my current state. > Woule you be interested in reviewing it and sponsoring an upload? Sure. Generally it's good. Only a few nitpicks: - extra line at the end of copyright, - also an extra line at the end of rules, - rules file format may be noted on the second line with '# -*- makefile -*-', - you may add DH_VERBOSE option (uncommented ATM) to rules, - it's a small package and probably not worth it, but you may add '--parallel' to 'dh $@' in rules, - in control, I'd not start the long description with the package name as it's already known, - I don't see why you install README, the description part is already in control, plus the download, build and install part is not relevant for the users (they can do and maybe already did it with apt-get install), - patches needs to be updated with newer releases, that's why I prefer removing extra files in rules and no patching / while nothing wrong with your way, - the use of GPL 2.0 (dot+zero) in copyright, as it's noted 2 or 3 everywhere including the second line of the package COPYING file, in its Wiki[1] or on the GNU license page[2]; only the filenames may contain that ending. If you change any of these, I can wait or if you want, upload it as is. Regards, Laszlo/GCS [1] http://en.wikipedia.org/wiki/GNU_General_Public_License [2] http://www.gnu.org/licenses/gpl-2.0.html -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAKjSHr0DU4Em=oj-v58fdajr9fsvgffgkgszfknxzjmu86r...@mail.gmail.com
Bug#777671: firejail packaging
Hi Laszlo, thank you for your review. I just reworked most of your suggestions into the package. On 03/15/2015 10:25 AM, László Böszörményi (GCS) wrote: > - extra line at the end of copyright, Done > - also an extra line at the end of rules, Done > - rules file format may be noted on the second line with '# -*- makefile -*-', I left this still out, because I think it should be clear that it is a Makefile (especially with #!/usr/bin/make at the top). > - you may add DH_VERBOSE option (uncommented ATM) to rules, Done > - it's a small package and probably not worth it, but you may add > '--parallel' to 'dh $@' in rules, Done > - in control, I'd not start the long description with the package name > as it's already known, I also left the long description as it is. I checked several other packages, and starting it with the package name seems to be the normal case? > - I don't see why you install README, the description part is already > in control, plus the download, build and install part is not relevant > for the users (they can do and maybe already did it with apt-get > install), You're right, the README doesn't make much sense now. I've removed it from the package. > - patches needs to be updated with newer releases, that's why I prefer > removing extra files in rules and no patching / while nothing wrong > with your way, I didn't think of it at first, but I also agree that it's better to remove them in rules than to keep updating patches. > - the use of GPL 2.0 (dot+zero) in copyright, as it's noted 2 or 3 > everywhere including the second line of the package COPYING file, in > its Wiki[1] or on the GNU license page[2]; only the filenames may > contain that ending. Done I also now let the bash-completion script be installed by debhelper instead of the upstream Makefile. > If you change any of these, I can wait or if you want, upload it as is. Can you please redownload it again (same place), review and then upload it? Thank you! Regards, Reiner signature.asc Description: OpenPGP digital signature
Bug#777671: firejail packaging
Hi Reiner, On Sun, Mar 15, 2015 at 1:13 PM, Reiner Herrmann wrote: > Can you please redownload it again (same place), review and then upload it? Now it's fine. May I comment out DH_VERBOSE before uploading? Laszlo/GCS -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/cakjshr3cyqwotmhe2dokbdkrejgkshntmrtpzrqw6adoyny...@mail.gmail.com
Bug#777671: firejail packaging
Hi Laszlo, yes, you can comment it out or remove it, if you want. Thank you! Kind regards, Reiner Am 21. März 2015 17:03:41 MEZ, schrieb "László Böszörményi (GCS)" : >Hi Reiner, > >On Sun, Mar 15, 2015 at 1:13 PM, Reiner Herrmann >wrote: >> Can you please redownload it again (same place), review and then >upload it? > Now it's fine. May I comment out DH_VERBOSE before uploading? > >Laszlo/GCS
