Bug#886404: [Pkg-javascript-devel] node-rollup-plugin-babel: build error unrepro but babelHelpers missing error in autopkgtest

[Pirate Praveen]

On ബുധന്‍ 17 ജനുവരി 2018 07:15 വൈകു, Paolo Greppi wrote:
> But back to our issue, I follow you on 887500, but I am unsure whether 887497 
> really blocks 886404 ?
> 
> I mean, only one of the 4 Critical dependency warnings seems related to 
> /usr/lib/nodejs/base/utils.js (node-base)

Well, it is not sufficient, but necessary. So it is indeed a blocker,
but there are more blockers as you identified below :)

> The other 3 are related to:
> /usr/lib/nodejs/babel-core/lib/transformation/file/options/option-manager.js
> /usr/lib/nodejs/babel-core/lib/transformation/file/index.js
> 
> Pravi, are you sure that all the webpack "Critical dependency" warnings would 
> go away with the latest version of base ?

You are correct, I missed these warning related to babel-core.

WARNING in
/usr/lib/nodejs/babel-core/lib/transformation/file/options/option-manager.js
190:19-37 Critical dependency: the request of a dependency is an expression

WARNING in
/usr/lib/nodejs/babel-core/lib/transformation/file/options/option-manager.js
307:16-34 Critical dependency: the request of a dependency is an expression

WARNING in /usr/lib/nodejs/babel-core/lib/transformation/file/index.js
511:24-39 Critical dependency: the request of a dependency is an expression

WARNING in /usr/lib/nodejs/babel-core/lib/transformation/file/index.js
710:16-34 Critical dependency: the request of a dependency is an expression

The code below fixes babelhelpers error.

babeljs-external-helpers > dist/external-helpers.js
cat dist/external-helpers.js dist/rollup-plugin-babel.cjs.js > dist/tmp.js
mv dist/tmp.js dist/rollup-plugin-babel.cjs.js
rm dist/external-helpers.js



signature.asc
Description: OpenPGP digital signature

Bug#886404: [Pkg-javascript-devel] node-rollup-plugin-babel: build error unrepro but babelHelpers missing error in autopkgtest

[Paolo Greppi]

Il 17/01/2018 12:47, Pirate Praveen ha scritto:
> On 2018, ജനുവരി 17 4:54:11 PM IST, Pirate Praveen  
> wrote:
>> These warnings are gone with latest versions of base but it will break
>> snapdragon. New version of snapdragon does not depend on base, but it
>> will break braces. But braces upstream is not interested to update to
>> newer snapdragon, but he is open to pull requests.
>>
>> So the solution is to update braces to use snapdragon 0.11.
> 
> https://github.com/micromatch/braces/issues/13

OK so the developer of braces (jonschlinkert) refused to update one of braces 
dependencies (snapdragon) to a version that in turn drops a dependency on 
another one of his 1397 packages (base) ?
Ah the delights of the JS ecosystem !

But back to our issue, I follow you on 887500, but I am unsure whether 887497 
really blocks 886404 ?

I mean, only one of the 4 Critical dependency warnings seems related to 
/usr/lib/nodejs/base/utils.js (node-base)

The other 3 are related to:
/usr/lib/nodejs/babel-core/lib/transformation/file/options/option-manager.js
/usr/lib/nodejs/babel-core/lib/transformation/file/index.js

Pravi, are you sure that all the webpack "Critical dependency" warnings would 
go away with the latest version of base ?

Paolo

Bug#886404: [Pkg-javascript-devel] node-rollup-plugin-babel: build error unrepro but babelHelpers missing error in autopkgtest

[Pirate Praveen]

On 2018, ജനുവരി 17 4:54:11 PM IST, Pirate Praveen  
wrote:
>These warnings are gone with latest versions of base but it will break
>snapdragon. New version of snapdragon does not depend on base, but it
>will break braces. But braces upstream is not interested to update to
>newer snapdragon, but he is open to pull requests.
>
>So the solution is to update braces to use snapdragon 0.11.

https://github.com/micromatch/braces/issues/13

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Bug#886404: [Pkg-javascript-devel] node-rollup-plugin-babel: build error unrepro but babelHelpers missing error in autopkgtest

[Pirate Praveen]

On 2018, ജനുവരി 17 3:35:44 PM IST, Paolo Greppi  wrote:
>First the good news: I dont' get the build error on sid today. Maybe
>that problem has solved by itself ;-)

I think the build error was fixed by adding external-helpers plugin.

>But the autopkgtest fails with the babelHelpers missing error as rollup
>and node-react:

This can be fixed by adding babeljs-external-helpers output at the top of the 
umd file.

>/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:6544
>var isSymbol = USE_NATIVE && babelHelpers.typeof($Symbol.iterator) ==
>'symbol' ? function (it) {
> ^
>ReferenceError: babelHelpers is not defined
>at Object.
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:6544:30)
>at __webpack_require__
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:20:30)
>at Object.
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:18563:1)
>at __webpack_require__
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:20:30)
>at Object.
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:6470:31)
>at __webpack_require__
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:20:30)
>at Object.
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:1418:15)
>at __webpack_require__
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:20:30)
>at Object.
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:2983:16)
>at __webpack_require__
>(/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js:20:30)
>
>It seems the rollup-plugin-babel cjs build with webpack has something
>wrong.
>It is much larger than the one built by upstream with rollup:
>
>npm install rollup-plugin-babel
>ls -l node_modules/rollup-plugin-babel/dist/*
>/usr/lib/nodejs/rollup-plugin-babel/dist/*
>ls -l node_modules/rollup-plugin-babel/dist/*
>/usr/lib/nodejs/rollup-plugin-babel/dist/*
>-rw-r--r-- 1 root root5533 Dec 18 12:22
>node_modules/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js
>-rw-r--r-- 1 root root5486 Dec 18 12:22
>node_modules/rollup-plugin-babel/dist/rollup-plugin-babel.es.js
>-rw-r--r-- 1 root root 1526968 Jan  5 14:35
>/usr/lib/nodejs/rollup-plugin-babel/dist/rollup-plugin-babel.cjs.js
>
>I noticed that these messages come up during the
>node-rollup-plugin-babel build with webpack (sorted and compacted):
>
>WARNING in
>/usr/lib/nodejs/babel-core/lib/transformation/file/options/option-manager.js
>190:19-37 Critical dependency: the request of a dependency is an
>expression
>307:16-34 Critical dependency: the request of a dependency is an
>expression
>WARNING in /usr/lib/nodejs/babel-core/lib/transformation/file/index.js
>511:24-39 Critical dependency: the request of a dependency is an
>expression
>WARNING in /usr/lib/nodejs/base/utils.js
>3:34-41 Critical dependency: require function is used in a way in which
>dependencies cannot be statically extracted
>
>It looks like this is by design in webpack:
>https://github.com/webpack/webpack-dev-server/issues/212
>
>SO apparently this can not be built with webpack after all ...

These warnings are gone with latest versions of base but it will break 
snapdragon. New version of snapdragon does not depend on base, but it will 
break braces. And braces upstream is not interested to update to newer 
snapdragon, but he is open to pull requests.

So the solution is to update braces to use snapdragon 0.11.

>Paolo

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.