Bug#887565: Please package python3-vlc

2018-01-25 Thread Sebastian Ramacher
Hi

On 2018-01-18 16:00:18, Olivier Aubert wrote:
> Hi 
> 
> > As long as the module is imported with "import vlc", the proper Debian 
> > package
> > name is python-vlc for the Python 2 version and python3-vlc for the Python 3
> > version. So that definitely needs to be fixed.
> 
> The easy fix would be for me to update the module name from python-vlc
> to vlc in the setup.py file. Then the stdeb generated packages will be
> correct. What prevented me from doing this before is the confusion it
> may introduce (old names references in forums), but it is feasible [1].
> 
> Another issue I have with this is that some users do not understand
> that python-vlc only installs bindings, not vlc itself. This will be
> even worse if the name is vlc, but I guess that at some point, there is
>  not much that can be done.
> 
> [1] http://legacy.python.org/dev/peps/pep-0423/#how-to-rename-a-project

So I wouldn't bother renaming the module on pypi. Run stdeb once, fix the
package numbes once and that's it.

> I can fix the package name, add the copyright info and put the
> resulting packaged file in some git repo. What is the preferred
> approach: a repository distinct from the upstream repo, or a repo
> integrated in the upstream repo?

Depends(TM). If you want to maintain it as part of the multimedia team, we'd
expect the packaging repo to be hosted on salsa.debian.org. If not, I'll just
need a dsc to look at and the repo does not matter to me.

Cheers
-- 
Sebastian Ramacher


signature.asc
Description: PGP signature


Bug#887565: Please package python3-vlc

2018-01-18 Thread Olivier Aubert
Hi 

> As long as the module is imported with "import vlc", the proper Debian package
> name is python-vlc for the Python 2 version and python3-vlc for the Python 3
> version. So that definitely needs to be fixed.

The easy fix would be for me to update the module name from python-vlc
to vlc in the setup.py file. Then the stdeb generated packages will be
correct. What prevented me from doing this before is the confusion it
may introduce (old names references in forums), but it is feasible [1].

Another issue I have with this is that some users do not understand
that python-vlc only installs bindings, not vlc itself. This will be
even worse if the name is vlc, but I guess that at some point, there is
 not much that can be done.

[1] http://legacy.python.org/dev/peps/pep-0423/#how-to-rename-a-project

I can fix the package name, add the copyright info and put the
resulting packaged file in some git repo. What is the preferred
approach: a repository distinct from the upstream repo, or a repo
integrated in the upstream repo?

Olivier

signature.asc
Description: This is a digitally signed message part


Bug#887565: Please package python3-vlc

2018-01-18 Thread Sebastian Ramacher
Hi,

On 2018-01-18 10:47:27, Olivier Aubert wrote:
> Hello
> 
> From my point of view, the Debian packaging is ready as I mentioned
> last october.  
> 
> Note that the project principles make it a bit unusual to package: the
> main setup.py file is for the python-vlc-generator project, which is
> used to generate the actual bindings from the include files. I update
> the generated bindings when I either make a change in the generator or
> a new VLC version is available, and the result, proper VLC bindings, is
> located in generated/3.0 directory, with a full package structure,
> proper setup.py, etc. So this directory should be the reference for
> building from source, or it could also be built from PyPI.
> 
> Building the debian package, using the setup.py from PyPI or
> generated/3.0 - which are the same -, can then be achieved with:
> 
> python setup.py --command-packages=stdeb.command sdist_dsc 
> --with-python2=true --with-python3=true bdist_deb
> 
> The only issue I see is the naming: since my package is named python-
> vlc (in pypi) and stdeb prepends a python-  prefix, it produces a 
> python-python-vlc package (and there seems to be no option to fix
> this).

As long as the module is imported with "import vlc", the proper Debian package
name is python-vlc for the Python 2 version and python3-vlc for the Python 3
version. So that definitely needs to be fixed.

Note that stdeb can be a starting point starting point for packaging from PyPI,
but source packages produced by it need some manual work before being uploaded
to the archive. For example, fixing the package names is one such thing. Also
debian/copyright needs to be checked, etc. And after the first upload to the
Debian archive, stdeb is no longer relevant.

> I was waiting for some feedback from Sebastian. If the
> stdeb road is ok, and the naming issue is not blocking, it will be
> simpler to maintain. Else we could have to duplicate the packaging
> work.

Sorry, I must have missed that mail. Feel free to ping me if I forget to answer.

Cheers

> 
> Cheers,
> Olivier
> 
> 
> 
> On Thu, 2018-01-18 at 10:17 +0100, Sebastian Ramacher wrote:
> > Control: reassign -1 wnpp
> > Control: title -1 RFP: python-vlc -- Python bindings for VLC
> > 
> > On 2018-01-18 13:27:32, Mike Abrahall wrote:
> > > Package: src:vlc
> > > Version: 3.0.0~rc5-1
> > > Severity: wishlist
> > > 
> > > I have a Python app that uses VLC via the standard bindings.
> > > This is already upstream 
> > > https://git.videolan.org/?p=vlc/bindings/python.git;a=tree
> > > I can ship that file myself, but when VLC updates my app breaks.
> > > It would be much easier if this was just packaged alongside the VLC 
> > > packages.
> > 
> > The Python bindings for VLC will require a new source package. Thus I am
> > reassigning this bug to wnpp. I am also adding Olivier to CC. He was 
> > interested
> > in packaging it.
> > 
> > Olivier, did you make any progress since our last conversation?
> > 
> > Cheers



-- 
Sebastian Ramacher


signature.asc
Description: PGP signature


Bug#887565: Please package python3-vlc

2018-01-18 Thread Olivier Aubert
Hello

From my point of view, the Debian packaging is ready as I mentioned
last october.  

Note that the project principles make it a bit unusual to package: the
main setup.py file is for the python-vlc-generator project, which is
used to generate the actual bindings from the include files. I update
the generated bindings when I either make a change in the generator or
a new VLC version is available, and the result, proper VLC bindings, is
located in generated/3.0 directory, with a full package structure,
proper setup.py, etc. So this directory should be the reference for
building from source, or it could also be built from PyPI.

Building the debian package, using the setup.py from PyPI or
generated/3.0 - which are the same -, can then be achieved with:

python setup.py --command-packages=stdeb.command sdist_dsc --with-python2=true 
--with-python3=true bdist_deb

The only issue I see is the naming: since my package is named python-
vlc (in pypi) and stdeb prepends a python-  prefix, it produces a 
python-python-vlc package (and there seems to be no option to fix
this).

I was waiting for some feedback from Sebastian. If the
stdeb road is ok, and the naming issue is not blocking, it will be
simpler to maintain. Else we could have to duplicate the packaging
work.

Cheers,
Olivier



On Thu, 2018-01-18 at 10:17 +0100, Sebastian Ramacher wrote:
> Control: reassign -1 wnpp
> Control: title -1 RFP: python-vlc -- Python bindings for VLC
> 
> On 2018-01-18 13:27:32, Mike Abrahall wrote:
> > Package: src:vlc
> > Version: 3.0.0~rc5-1
> > Severity: wishlist
> > 
> > I have a Python app that uses VLC via the standard bindings.
> > This is already upstream 
> > https://git.videolan.org/?p=vlc/bindings/python.git;a=tree
> > I can ship that file myself, but when VLC updates my app breaks.
> > It would be much easier if this was just packaged alongside the VLC 
> > packages.
> 
> The Python bindings for VLC will require a new source package. Thus I am
> reassigning this bug to wnpp. I am also adding Olivier to CC. He was 
> interested
> in packaging it.
> 
> Olivier, did you make any progress since our last conversation?
> 
> Cheers

signature.asc
Description: This is a digitally signed message part


Processed (with 1 error): Re: Bug#887565: Please package python3-vlc

2018-01-18 Thread Debian Bug Tracking System
Processing control commands:

> reassign -1 wnpp
Bug #887565 [src:vlc] Please package python3-vlc
Bug reassigned from package 'src:vlc' to 'wnpp'.
No longer marked as found in versions vlc/3.0.0~rc5-1.
Ignoring request to alter fixed versions of bug #887565 to the same values 
previously set
> title -1 RFP: python-vlc -- Python bindings for VLC
Unknown command or malformed arguments to command.


-- 
887565: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887565
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems