Bug#959412: Puppeteer status?

2022-01-04 Thread Andrius Merkys
On 2022-01-04 19:11, Martina Ferrari wrote:
> One more thing: I see the salsa repos do not have the upstream sources..
> Is there a reason for that? What commands/tools do you use to get the
> source and build the pacakge?

For Javascript packages I usually keep only debian/ directory in the
VCS. This prevents prebuilt/large/non-free stuff from appearing on Salsa
until I figure out what to exclude via repacking.

In such repos the source could be acquired by using uscan:

$ uscan --download-current-version

And built by git-buildpackage:

$ gbp buildpackage -uc -us --git-overlay --git-export-dir=..
--git-no-pristine-tar

Hope this helps. If debian/-only layout becomes too cumbersome, we may
push upstream sources as well.

Andrius



Bug#959412: Puppeteer status?

2022-01-04 Thread Andrius Merkys
Hi,

On 2022-01-04 19:10, Martina Ferrari wrote:
> On 03/01/2022 08:13, Andrius Merkys wrote:
> 
>> I have revisited puppeteer packaging. I have collected missing
>> dependencies, packaged a missing one, node-devtools-protocol, and
>> attempted to update to the newest upstream release. However, both old
>> and new puppeteer versions FTBFS with tsc failures, most likely rising
>> from incompatibilities of node packages.
>>
>> The least problematic seems the failure of puppeteer/13.0.1 with
>> devtools-protocol/0.0.953906:
>>
>> src/common/Coverage.ts(277,7): error TS2558: Expected 1 type arguments,
>> but got 4.
>> src/common/Page.ts(1798,38): error TS2558: Expected 1 type arguments,
>> but got 2.
>>
>> However, I have no idea about how to fix or debug that. I have pushed
>> packagings of newer package versions to salsa, to package-v* branches,
>> should you wish to give them a look.
> 
> Thanks for the update!
> I will take a look. Do you prefer that I send you merge requests or to
> commit directly?

Please feel free to commit directly.

>> Another blocker is chromium, which is currently not installable (see [1]
>> for reference). Firefox-based backend for puppeteer is also available,
>> albeit deprecated. I have not tried it yet, though.
> 
> 
> I am not too worried about chromium being uninstallable, surely
> *somebody* will fix that! Firefox support seems to still be
> experimental, and in any case, the puppeteer package will not care no?

I am not sure, though. Puppeteer is prepared to download browsers by
itself, but puppeteer-core would rely on system/user-installed browsers.
I am particularly interested in the latter case as some packages use
puppeteer to execute test suites.

Best,
Andrius



Bug#959412: Puppeteer status?

2022-01-04 Thread Martina Ferrari
One more thing: I see the salsa repos do not have the upstream sources.. 
Is there a reason for that? What commands/tools do you use to get the 
source and build the pacakge?


On 04/01/2022 17:10, Martina Ferrari wrote:

Hi,


On 03/01/2022 08:13, Andrius Merkys wrote:


I have revisited puppeteer packaging. I have collected missing
dependencies, packaged a missing one, node-devtools-protocol, and
attempted to update to the newest upstream release. However, both old
and new puppeteer versions FTBFS with tsc failures, most likely rising
from incompatibilities of node packages.

The least problematic seems the failure of puppeteer/13.0.1 with
devtools-protocol/0.0.953906:

src/common/Coverage.ts(277,7): error TS2558: Expected 1 type arguments,
but got 4.
src/common/Page.ts(1798,38): error TS2558: Expected 1 type arguments,
but got 2.

However, I have no idea about how to fix or debug that. I have pushed
packagings of newer package versions to salsa, to package-v* branches,
should you wish to give them a look.


Thanks for the update!
I will take a look. Do you prefer that I send you merge requests or to 
commit directly?



Another blocker is chromium, which is currently not installable (see [1]
for reference). Firefox-based backend for puppeteer is also available,
albeit deprecated. I have not tried it yet, though.



I am not too worried about chromium being uninstallable, surely 
*somebody* will fix that! Firefox support seems to still be 
experimental, and in any case, the puppeteer package will not care no?




--
Martina Ferrari (Tina)



Bug#959412: Puppeteer status?

2022-01-04 Thread Martina Ferrari

Hi,


On 03/01/2022 08:13, Andrius Merkys wrote:


I have revisited puppeteer packaging. I have collected missing
dependencies, packaged a missing one, node-devtools-protocol, and
attempted to update to the newest upstream release. However, both old
and new puppeteer versions FTBFS with tsc failures, most likely rising
from incompatibilities of node packages.

The least problematic seems the failure of puppeteer/13.0.1 with
devtools-protocol/0.0.953906:

src/common/Coverage.ts(277,7): error TS2558: Expected 1 type arguments,
but got 4.
src/common/Page.ts(1798,38): error TS2558: Expected 1 type arguments,
but got 2.

However, I have no idea about how to fix or debug that. I have pushed
packagings of newer package versions to salsa, to package-v* branches,
should you wish to give them a look.


Thanks for the update!
I will take a look. Do you prefer that I send you merge requests or to 
commit directly?



Another blocker is chromium, which is currently not installable (see [1]
for reference). Firefox-based backend for puppeteer is also available,
albeit deprecated. I have not tried it yet, though.



I am not too worried about chromium being uninstallable, surely 
*somebody* will fix that! Firefox support seems to still be 
experimental, and in any case, the puppeteer package will not care no?


--
Martina Ferrari (Tina)



Bug#959412: Puppeteer status?

2022-01-03 Thread Andrius Merkys
Hi again,

On 2021-12-31 02:47, Martina Ferrari wrote:
> I was wondering what is the status of this ITP? I need puppeteer for
> $DAYJOB, and I would prefer to use a proper Debian package.
> 
> It seems not much has happened in the last year in the salsa repo, is
> there much left to be done? I would be happy to give it a go if you are
> not currently working on it..

I have revisited puppeteer packaging. I have collected missing
dependencies, packaged a missing one, node-devtools-protocol, and
attempted to update to the newest upstream release. However, both old
and new puppeteer versions FTBFS with tsc failures, most likely rising
from incompatibilities of node packages.

The least problematic seems the failure of puppeteer/13.0.1 with
devtools-protocol/0.0.953906:

src/common/Coverage.ts(277,7): error TS2558: Expected 1 type arguments,
but got 4.
src/common/Page.ts(1798,38): error TS2558: Expected 1 type arguments,
but got 2.

However, I have no idea about how to fix or debug that. I have pushed
packagings of newer package versions to salsa, to package-v* branches,
should you wish to give them a look.

Another blocker is chromium, which is currently not installable (see [1]
for reference). Firefox-based backend for puppeteer is also available,
albeit deprecated. I have not tried it yet, though.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995212#23

Best,
Andrius



Bug#959412: Puppeteer status?

2021-12-31 Thread Andrius Merkys
Hi Martina,

On 2021-12-31 02:47, Martina Ferrari wrote:
> I was wondering what is the status of this ITP? I need puppeteer for
> $DAYJOB, and I would prefer to use a proper Debian package.
> 
> It seems not much has happened in the last year in the salsa repo, is
> there much left to be done? I would be happy to give it a go if you are
> not currently working on it..

Thanks for your interest. AFAIR, I got stuck in packaging the JS
dependencies needed by puppeteer. Nevertheless I recall the package was
building mostly successfully and passing its upstream-provided test suite.

Please give me a couple of days to dig a bit deeper into this. If I do
not return in a week with more precise status report, please ping.

Best wishes,
Andrius



Bug#959412: Puppeteer status?

2021-12-30 Thread Martina Ferrari

Hi Andrius,

I was wondering what is the status of this ITP? I need puppeteer for 
$DAYJOB, and I would prefer to use a proper Debian package.


It seems not much has happened in the last year in the salsa repo, is 
there much left to be done? I would be happy to give it a go if you are 
not currently working on it..


Thanks.

--
Martina Ferrari (Tina)