Re: New security/audit pages not translatable
On Sun, Dec 02, 2007 at 10:24:09PM +, Steve Kemp wrote: > On Thu Nov 29, 2007 at 14:36:12 +0100, Frans Pop wrote: > > Looking at the Makefile in the english directory, the problem is probably > > that it refers to the data dir in the current directory. But of course the > > translations do not have a data dir in _their_ current directory. > > Perhaps we could use something such as $(ENGLISHSRCDIR) / $(LANGUAGE) > to make it conditional? I've just committed a fix for this. Those variables are right, although they weren't working at all out over there, because they preceded the Make.lang inclusion, which defines them. It would've helped if you had written these makefiles based on existing simple examples elsewhere in the webwml tree - but looking at security/Makefile and all its convoluted logic to build up the RSS feed files, I can see how you'd get instantly confused and misled... (Sorry for not tracking this stuff more actively...) -- 2. That which causes joy or happiness. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
Steve Kemp wrote: > On Thu Nov 29, 2007 at 14:46:12 +0100, Frans Pop wrote: > > On Thursday 29 November 2007, Steve Kemp wrote: > > > They shouldn't have anything to be translated in them (though right now > > > there are about three small strings that are there). > > > > Are you perhaps referring to strings like > > $credit discovered that $package contained a $type > > vulnerability. > > and > > No advisories found. > > in make-advisories? > > Precisely. > > > In that case it would be very nice if those were gettexted. The only > > problem > > I see is that some languages would need different declinations for > > male/female $credit (probably not a problem in practise :-) and maybe how > > to get $type and maybe even $date translated. > > Yes, I will endeavor to get these switched to gettext as soon as > possible, unless somebody beats me to it. (I will just need to look > over the rest of the site to get a good example to copy from!) Has there been any improvement so far? Currently, the Makefile contains statements that cause make wanting to run make-advisories for each language. I assume that this is only needed for English? Regards, Joey -- All language designers are arrogant. Goes with the territory... -- Larry Wall Please always Cc to me when replying to me on the lists. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
On Thu Nov 29, 2007 at 14:46:12 +0100, Frans Pop wrote: > On Thursday 29 November 2007, Steve Kemp wrote: > > They shouldn't have anything to be translated in them (though right now > > there are about three small strings that are there). > > Are you perhaps referring to strings like > $credit discovered that $package contained a $type > vulnerability. > and > No advisories found. > in make-advisories? Precisely. > In that case it would be very nice if those were gettexted. The only problem > I see is that some languages would need different declinations for > male/female $credit (probably not a problem in practise :-) and maybe how > to get $type and maybe even $date translated. Yes, I will endeavor to get these switched to gettext as soon as possible, unless somebody beats me to it. (I will just need to look over the rest of the site to get a good example to copy from!) Steve -- Debian GNU/Linux System Administration http://www.debian-administration.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
On Thu Nov 29, 2007 at 14:12:36 +0100, Frans Pop wrote: > Ah, 'cvs up -d' fixes that. /me blames cvs for being incomprehensible. I know that feeling :) > Yes, with a completely different starting position that is fully > understandable :-) Sorry for the confusion due to my broken checkout and > thanks for giving me the push that was needed to find the real problem. No problem. Steve -- http://www.steve.org.uk/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
On Thu Nov 29, 2007 at 14:36:12 +0100, Frans Pop wrote: > Looking at the Makefile in the english directory, the problem is probably > that it refers to the data dir in the current directory. But of course the > translations do not have a data dir in _their_ current directory. Perhaps we could use something such as $(ENGLISHSRCDIR) / $(LANGUAGE) to make it conditional? Steve -- # The Debian Security Audit Project. http://www.debian.org/security/audit -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 29-11-2007 11:46, Frans Pop wrote: > On Thursday 29 November 2007, Steve Kemp wrote: >> They shouldn't have anything to be translated in them (though right now >> there are about three small strings that are there). > > Are you perhaps referring to strings like > $credit discovered that $package contained a $type > vulnerability. > and > No advisories found. > in make-advisories? > > In that case it would be very nice if those were gettexted. The only problem > I see is that some languages would need different declinations for > male/female $credit (probably not a problem in practise :-) and maybe how > to get $type and maybe even $date translated. Ok, so let's try to integrate another team player so we can together improve it. :-) * english/po/Makefile Contains the list of files that will be gettexted, you can simply add the files in the right tag. security_FILES = $(TEMPLDIR)/security.wml \ [...] You need to use Lorem Ipsum on the target file to allow xwmlgettext to get it. :-) This will make things appear in security.pot and, of course, when translators run 'make update-po' they will find the new unstranslated strings. * english/template/debian/ctime.wml It contains several time formats that you can use to define what you want, please, take a quick look at News and security, it pretty much does what you want, specially DSAs, with regards to data files and automatic updates. I'm during the final exams week at University, so I'm without much time, I can implement what is needed during the weekend or next week. But I would gladly accept your patches with first steps. :) Kind regards, PS: I'm subscribed to -www - -- Felipe Augusto van de Wiel (faw) "Debian. Freedom to code. Code to freedom!" -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHT2L0CjAO0JDlykYRArjDAJ4tTHWkbTe6NsUFeUxKrz4u/aApLACfQYXW 372Uc8NgqQn3pi/7BJwMetQ= =LhKS -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
On Thursday 29 November 2007, Steve Kemp wrote: > They shouldn't have anything to be translated in them (though right now > there are about three small strings that are there). Are you perhaps referring to strings like $credit discovered that $package contained a $type vulnerability. and No advisories found. in make-advisories? In that case it would be very nice if those were gettexted. The only problem I see is that some languages would need different declinations for male/female $credit (probably not a problem in practise :-) and maybe how to get $type and maybe even $date translated. signature.asc Description: This is a digitally signed message part.
Re: New security/audit pages not translatable
On Thursday 29 November 2007, Frans Pop wrote: > On Thursday 29 November 2007, Steve Kemp wrote: > > On Thu Nov 29, 2007 at 13:09:34 +0100, Frans Pop wrote: > > > You don't seem to be replying to the translation issue for the main > > > audit advisories page. > > > > I thought I was, or at least my failure to answer wasn't deliberate. > > I said that the files were there in CVS, and now you're suggesting > > they are not. > > There are two issues: > 1) http://www.debian.org/security/audit/advisories.html >The wml for this page is in CVS, has been translated, but translations >are not getting build. > > > > For that translations of the wml file _are_ available and > > > have been updated, but the builds fail for some reason. > > > > The build failure is a seperate issue to translations, so I'll ignore > > it. (Mostly on the grounds that I'm not terribly familiar with WML.) > > OK. Then I hope that someone else can look into that. Looking at the Makefile in the english directory, the problem is probably that it refers to the data dir in the current directory. But of course the translations do not have a data dir in _their_ current directory. I have no idea how to fix that while still ensuring that both the English pages and translations get rebuilt when the data changes. signature.asc Description: This is a digitally signed message part.
Re: New security/audit pages not translatable
On Thursday 29 November 2007, Steve Kemp wrote: > On Thu Nov 29, 2007 at 13:09:34 +0100, Frans Pop wrote: > > You don't seem to be replying to the translation issue for the main > > audit advisories page. > > I thought I was, or at least my failure to answer wasn't deliberate. > I said that the files were there in CVS, and now you're suggesting they > are not. There are two issues: 1) http://www.debian.org/security/audit/advisories.html The wml for this page is in CVS, has been translated, but translations are not getting build. 2) http://www.debian.org/security/audit/200X/index.html The original wml for these pages are not in CVS (or at least, I'm not getting them in my checkout; see below) and are thus not translatable. If they are auto-generated, it is IMO questionable whether they _should_ be in CVS at all. > > For that translations of the wml file _are_ available and > > have been updated, but the builds fail for some reason. > > The build failure is a seperate issue to translations, so I'll ignore > it. (Mostly on the grounds that I'm not terribly familiar with WML.) OK. Then I hope that someone else can look into that. > > > ./audit/2003/index.wml > > > ... > > > > > >are the very source which should be translated! > > > > Yes. Basically, because these files are not in CVS, there is nothing > > that can be translated and as they are generated automatically, there > > is not much point either in having them in CVS or translating them. > > These index.wml files *are* in CVS. Or at least appear to be so to me: Not to me: [EMAIL PROTECTED]:~/projects/debian/webwml/english/security/audit$ cvs up [EMAIL PROTECTED]:~/projects/debian/webwml/english/security/audit$ ls advisories.wml CVS faq.wmlmaintainers.wml Makefile tools.wml auditing.wml examples index.wml make-advisories packages.wml No directories for the years... Hmmm. That's weird. They are listed on: http://cvs.debian.org/webwml/english/security/audit/ Ah, 'cvs up -d' fixes that. /me blames cvs for being incomprehensible. OK. That fixes issue 2) completely. They are set up correctly with the fixed texts translatable and the content included. /me starts translating > (I half suspect we're talking past each other here, and we're neither > of us familiar enough with WML to make a really useful change, but if > I'm being confusing, unclear, or just not helpful please feel free to > tell me so. It isn't deliberate.) Yes, with a completely different starting position that is fully understandable :-) Sorry for the confusion due to my broken checkout and thanks for giving me the push that was needed to find the real problem. Cheers, FJP signature.asc Description: This is a digitally signed message part.
Re: New security/audit pages not translatable
On Thu Nov 29, 2007 at 13:09:34 +0100, Frans Pop wrote: > (Keeping you CC'ed as I'm not sure if you're subscribed...) I am. > > You don't seem to be replying to the translation issue for the main audit > advisories page. I thought I was, or at least my failure to answer wasn't deliberate. I said that the files were there in CVS, and now you're suggesting they are not. > For that translations of the wml file _are_ available and > have been updated, but the builds fail for some reason. The build failure is a seperate issue to translations, so I'll ignore it. (Mostly on the grounds that I'm not terribly familiar with WML.) > > ./audit/2003/index.wml > > ./audit/2004/index.wml > > ./audit/2005/index.wml > > ./audit/2006/index.wml > > ... > > > >are the very source which should be translated! > > Yes. Basically, because these files are not in CVS, there is nothing that > can be translated and as they are generated automatically, there is not > much point either in having them in CVS or translating them. These index.wml files *are* in CVS. Or at least appear to be so to me: [EMAIL PROTECTED]:~/webwml/english/security/audit/2007$ cvs log index.wml RCS file: /cvs/webwml/webwml/english/security/audit/2007/index.wml,v Working file: index.wml head: 1.3 branch: locks: strict access list: symbolic names: keyword substitution: kv total revisions: 3; selected revisions: 3 description: revision 1.3 date: 2007-11-02 21:54:36 +; author: skx; state: Exp; lines: +1 -1 Updated link to the advisories page, so it is correct. I guess you're suggesting that the *output* files are not in CVS? But they shouldn't be. THey shouldn't have anything to be translated in them (though right now there are about three small strings that are there). > The current build process is not optimal anyway. We now have auto-generated > WML files that, because they are present on www-master will show up as "to > be translated" on translation status pages [1]. This is contradictory: > pages should either be auto-generated, or in CVS and translatable. This process came about via the following thread: http://lists.debian.org/debian-www/2007/10/msg00392.html [Where I asked for advice because IW anted to generate pages from data files. The current solution is a result of that thread and help from Rhonda.] If you wish to change the way this works, to make it more translatable you're very welcome to do so. > IMO you should either directly generate HTML (using gettext for translatable > parts), or have stub WML pages with the fixed content (title and such) and > include the variable content in that. The latter is what I thought we were doing. The stub pages are 200N/index.wml, which include the variable content inside it. > There are probably different solutions possible for this, but I'm not > familiar enough with writing WML from scratch to suggest which is best. Me either. (I half suspect we're talking past each other here, and we're neither of us familiar enough with WML to make a really useful change, but if I'm being confusing, unclear, or just not helpful please feel free to tell me so. It isn't deliberate.) Steve -- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: New security/audit pages not translatable
(Keeping you CC'ed as I'm not sure if you're subscribed...) You don't seem to be replying to the translation issue for the main audit advisories page. For that translations of the wml file _are_ available and have been updated, but the builds fail for some reason. On Thursday 29 November 2007, Steve Kemp wrote: > On Thu Nov 29, 2007 at 05:16:27 +0100, Frans Pop wrote: > > It also does not seem possible to create translations for the yearly > > index pages such as http://www.debian.org/security/audit/2006/ because > > here is no "English source" file for them. > > > > If they are to be generated automatically, they should use gettext for > > the title, headers and last line (links to parent pages). > > They are generated in a two-step process: > 1. The data files get turned into a series of HTML .inc files. > 2. The inc files are included by a stub index.wml in each >directory. > > It seems to me that you're complaining there is no English source > to translate - when the files: > > ./audit/2003/index.wml > ./audit/2004/index.wml > ./audit/2005/index.wml > ./audit/2006/index.wml > ... > >are the very source which should be translated! Yes. Basically, because these files are not in CVS, there is nothing that can be translated and as they are generated automatically, there is not much point either in having them in CVS or translating them. The current build process is not optimal anyway. We now have auto-generated WML files that, because they are present on www-master will show up as "to be translated" on translation status pages [1]. This is contradictory: pages should either be auto-generated, or in CVS and translatable. IMO you should either directly generate HTML (using gettext for translatable parts), or have stub WML pages with the fixed content (title and such) and include the variable content in that. If the pages are to be generated automatically, that should of course be done automatically for _all_ translations too (or at least those that have a Makefile in ./audit). If you do want/need to generate WML pages as an in-between step, they should be deleted by the Makefile after the HTML has been generated to avoid them showing up on the translation stats pages, just like any temporary file. There are probably different solutions possible for this, but I'm not familiar enough with writing WML from scratch to suggest which is best. [1] http://www.debian.org/devel/website/stats/nl.html#untranslated (you have to scroll down a bit) signature.asc Description: This is a digitally signed message part.
Re: New security/audit pages not translatable
On Thu Nov 29, 2007 at 05:16:27 +0100, Frans Pop wrote: > It also does not seem possible to create translations for the yearly > index pages such as http://www.debian.org/security/audit/2006/ because > here is no "English source" file for them. > If they are to be generated automatically, they should use gettext for > the title, headers and last line (links to parent pages). They are generated in a two-step process: 1. The data files get turned into a series of HTML .inc files. 2. The inc files are included by a stub index.wml in each directory. It seems to me that you're complaining there is no English source to translate - when the files: ./audit/2003/index.wml ./audit/2004/index.wml ./audit/2005/index.wml ./audit/2006/index.wml ... are the very source which should be translated! If I've misunderstood the nature of your complaint then please do let me know. (I accept that the script which generates the .inc files shouldn't output any non-HTML, and should use gettext. I will investigate that ASAP - but right now it only uses minimal English in the output, so changing it shouldn't be difficult.) > P.S. Please CC me on replies as I'm currently not subscribed to the list. Noted. Steve -- # Commercial Debian GNU/Linux Support http://www.linux-administration.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
New security/audit pages not translatable
Hi, The recent change in structure of the audit pages does not allow for translation. Compare for example: - http://www.debian.org/security/audit/advisories - http://www.debian.org/security/audit/advisories.nl.html The builds fail with the following error: make[3]: Entering directory `/org/www.debian.org/webwml/dutch/security/audit' make[3]: *** No rule to make target `data/*.data', needed by `/security/audit/make-advisories'. Stop. make[3]: Leaving directory `/org/www.debian.org/webwml/dutch/security/audit' make[2]: [audit-install] Error 2 (ignored) It also does not seem possible to create translations for the yearly index pages such as http://www.debian.org/security/audit/2006/ because here is no "English source" file for them. If they are to be generated automatically, they should use gettext for the title, headers and last line (links to parent pages). Cheers, FJP P.S. Please CC me on replies as I'm currently not subscribed to the list. signature.asc Description: This is a digitally signed message part.