Re: New script to strip out entries from languages list

2024-01-03 Thread Holger Wansing



Am 2. Januar 2024 23:23:05 MEZ schrieb Holger Wansing :
>While my first approach was, to call this new script in 
>webwml/english/international/l10n/po/Makefile after the gen-files.sh run, I 
>now realize that the correct way is, to call strip-langs.sh in webmaster's 
>cron repo in lessoften-parts/1l10n-data, where the data/langs file is 
>created. (I somehow was in the assumption, that the gen-files.sh creates
>data/langs, but today I saw I was wrong here.)
>While both approaches worked so far, it's the cleaner (and more obvious) way, 
>to call strip-langs.sh via the cron script 1l10n-data directly after creating
>data/langs. 
>Thus changing it that way. 
>
>See
>https://salsa.debian.org/webmaster-team/cron/-/commit/9fdc0e492fbb044f11c675fc92f660c13ab74616
>and
>https://salsa.debian.org/webmaster-team/webwml/-/commit/e59bdd1ee162d9d1eb2faca9b587eac151c478a4

Calling strip-langs.sh from cron script directly does not work 
as intended, so reverting back to my previos version.

Sorry for this forward-backward dance...


Holger



-- 
Sent from /e/ OS on Fairphone3



Re: New script to strip out entries from languages list

2024-01-02 Thread Holger Wansing
Hi again,

Holger Wansing  wrote (Tue, 02 Jan 2024 17:03:28 +0100):
> Am 2. Januar 2024 09:29:05 MEZ schrieb Thomas Lange :
> >Hi Holger,
> >
> >this script looks good to me. Thanks a lot for your work on this.
> >I think you can merge it.
> 
> Just merged.

While looking at the logs now, I see that I had to change that once more:

While my first approach was, to call this new script in 
webwml/english/international/l10n/po/Makefile after the gen-files.sh run, I 
now realize that the correct way is, to call strip-langs.sh in webmaster's 
cron repo in lessoften-parts/1l10n-data, where the data/langs file is 
created. (I somehow was in the assumption, that the gen-files.sh creates
data/langs, but today I saw I was wrong here.)
While both approaches worked so far, it's the cleaner (and more obvious) way, 
to call strip-langs.sh via the cron script 1l10n-data directly after creating
data/langs. 
Thus changing it that way. 

See
https://salsa.debian.org/webmaster-team/cron/-/commit/9fdc0e492fbb044f11c675fc92f660c13ab74616
and
https://salsa.debian.org/webmaster-team/webwml/-/commit/e59bdd1ee162d9d1eb2faca9b587eac151c478a4


Holger

-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076



Re: New script to strip out entries from languages list

2024-01-02 Thread Holger Wansing
Hi,

Am 2. Januar 2024 09:29:05 MEZ schrieb Thomas Lange :
>Hi Holger,
>
>this script looks good to me. Thanks a lot for your work on this.
>I think you can merge it.

Just merged.


>> On Mon, 1 Jan 2024 23:39:09 +0100, Holger Wansing  
>> said:
>
>
>> In additional steps, we could also remove entries like de_AT, de_CH, 
> de_DE
>> and only leave 'de', as mentioned by Thomas.
>> But that's another discussion.
>I guess we do not want to remove those languages, but merge the
>variants into de. But maybe this need to be done in a different
>script, maybe in gen-files.pl.

Hmm. That will be out of my skills...


Holger


-- 
Sent from /e/ OS on Fairphone3



Re: New script to strip out entries from languages list

2024-01-02 Thread Thomas Lange
Hi Holger,

this script looks good to me. Thanks a lot for your work on this.
I think you can merge it.

> On Mon, 1 Jan 2024 23:39:09 +0100, Holger Wansing  
> said:


> In additional steps, we could also remove entries like de_AT, de_CH, de_DE
> and only leave 'de', as mentioned by Thomas.
> But that's another discussion.
I guess we do not want to remove those languages, but merge the
variants into de. But maybe this need to be done in a different
script, maybe in gen-files.pl.

-- 
regards Thomas