Bug#902555: radeon.4: Some fixes in the manual
On Fri, Jun 29, 2018 at 10:56:39AM +0200, Michel Dänzer wrote:
> On 2018-06-28 03:58 PM, G. Branden Robinson wrote:
> > At 2018-06-28T11:31:30+0200, Michel Dänzer wrote:
> >>
> >> Please send this kind of change directly upstream to the
> >> amd-...@lists.freedesktop.org list for review, split up into one patch
> >> per logical change.
> >
I sent the same patch upstream.
> > Well, a lot of these changes aren't "logical", they're stylistic.
>
> Funny. :) I'm sure you know what I meant though:
>
> Every item listed in Bjarni's report is logically a separate change.
> Mixing up logically separate changes (especially such a large number)
> makes for a hard to review patch. Hard to review patches are less likely
> to be applied.
>
> Anyway, Bjarni, if you can send a proper patch generated by git
> format-patch, I'm willing to make an exception this time.
>
I do not work that way with a text in a single file.
1) The extra work producing x patches instead of one for a man page is
a waste of time.
2) The changes are independent of each other.
3) Reviewing a patch for a man page with more than one "logical" change
is only hard for those who have never or too rarely done that or lack
the knowledge and do not want to gain it.
4) You can do the "splitting" to multiple patches yourself, and if not,
why should other want to do it?
5) Using the same rule (one patch for each "logical" type of change) in
all cases is simply ineffective.
Here is a script that shows changes caused by patches to man pages:
#!/bin/sh
# Compare two versions of a man page
#
set -efu
inputA=${1##*/}
inputB=${2##*/}
cp $1 /tmp/$inputA
cp $2 /tmp/$inputB
cd /tmp
MAN_KEEP_STDERR=yes
MANOPT='--warnings=w --no-justification --no-hyphenation'
MANWIDTH=80
export MAN_KEEP_STDERR MANOPT MANWIDTH
# Have no sentence space (.ss 12 0)
sed -e '/^.TH /i \
.ss 12 0' $inputA | man -l - > \
old.$inputA.txt 2> /dev/null
sed -e '/^.TH /i \
.ss 12 0' $inputB | man -l - > \
new.$inputA.txt 2> /dev/null
diff -adu old.$inputA.txt new.$inputA.txt > $inputA.txt.diff || :
# Difference in the output of "troff"
{ sed -e '/^.TH /i \
.ss 12 0\
.ad l' $inputA ; } | groff -t \
-rHY=0 -rF0 -mandoc -Z - > old.$inputA.ml 2> /dev/null
{ sed -e '/^.TH /i \
.ss 12 0\
.ad l' $inputB ; } | \
groff -t -rHY=0 -rF0 -mandoc -Z - > new.$inputA.ml 2> /dev/null
diff -adu old.$inputA.ml new.$inputA.ml > $inputA.ml.diff || :
less $inputA.txt.diff
less $inputA.ml.diff
--
Bjarni I. Gislason
Processed: tagging 900658, bug 900658 is forwarded to https://bugs.freedesktop.org/show_bug.cgi?id=106715
Processing commands for cont...@bugs.debian.org: > # Patch at https://patchwork.freedesktop.org/patch/229688/ -- linked from the > URL set as forwarded > tags 900658 + fixed-upstream patch upstream Bug #900658 [xserver-xorg-core] Intel HD graphics display rotation broken with 2:1.20.0-2 Added tag(s) fixed-upstream, upstream, and patch. > forwarded 900658 https://bugs.freedesktop.org/show_bug.cgi?id=106715 Bug #900658 [xserver-xorg-core] Intel HD graphics display rotation broken with 2:1.20.0-2 Set Bug forwarded-to-address to 'https://bugs.freedesktop.org/show_bug.cgi?id=106715'. > thanks Stopping processing here. Please contact me if you need assistance. -- 900658: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900658 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: your mail
Processing commands for cont...@bugs.debian.org: > tags 900110 fixed-upstream Bug #900110 [src:xserver-xorg-video-r128] xserver-xorg-video-r128: FTBFS with xserver 1.20 Added tag(s) fixed-upstream. > thanks Stopping processing here. Please contact me if you need assistance. -- 900110: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900110 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#902965: xserver-xorg-core: lxdm fails to start xserver with 2:1.20.0-3
On 2018-07-04 04:39 PM, Arthur Marsh wrote: > > radeon: Failed to deallocate virtual address for buffer: > radeon:size : 8355840 bytes > radeon:va: 0x10090 Looks like maybe you're running into https://bugs.freedesktop.org/105381 . In which case it's not specific to 2:1.20.0-3, you're just lucky when not hitting this issue with any Xorg 1.20. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
xserver-xorg-input-mouse_1.9.3-1_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Tue, 03 Jul 2018 16:38:04 +0200 Source: xserver-xorg-input-mouse Binary: xserver-xorg-input-mouse xserver-xorg-input-mouse-udeb Architecture: source Version: 1:1.9.3-1 Distribution: unstable Urgency: medium Maintainer: Debian X Strike Force Changed-By: Julien Cristau Description: xserver-xorg-input-mouse - X.Org X server -- mouse input driver xserver-xorg-input-mouse-udeb - X.Org X server -- mouse input driver (udeb) Changes: xserver-xorg-input-mouse (1:1.9.3-1) unstable; urgency=medium . * Team upload. * Add Matt Turner's key to signing-key.asc. * New upstream release. * Update Vcs-* URLs. Checksums-Sha1: 95e7754a2b20476a2954def95f9a775b2d9ac60c 2528 xserver-xorg-input-mouse_1.9.3-1.dsc 9252edb24f2788e3d97cfafa316388d83914df76 463247 xserver-xorg-input-mouse_1.9.3.orig.tar.gz 8c27828442921c45034e017ad12d0481af882e5c 879 xserver-xorg-input-mouse_1.9.3.orig.tar.gz.asc 6f5e78f6f65d13adf87d71f0174cd2dd38352d95 16627 xserver-xorg-input-mouse_1.9.3-1.diff.gz Checksums-Sha256: 1c94bc017d1cb433892e6c2cca3c70bf65f9e54123995dcdd8b48ad045c1d908 2528 xserver-xorg-input-mouse_1.9.3-1.dsc 71f3aa0a18dfe1ca5cb235ec9210f33571cf5fbbd90ac5b55306a954f67aa5c6 463247 xserver-xorg-input-mouse_1.9.3.orig.tar.gz 05a599079297a8462ef8f00d2ec81117c3f042258c737515e17c2e17e89793fc 879 xserver-xorg-input-mouse_1.9.3.orig.tar.gz.asc 3ba80edc7fbfe97b8499edc0a59d6a5fa4b232e41cf751b92d8bfd74c3c7daaf 16627 xserver-xorg-input-mouse_1.9.3-1.diff.gz Files: e1025539a99d97172a4c47b5931e493c 2528 x11 optional xserver-xorg-input-mouse_1.9.3-1.dsc b324b9e00cab5319d431b25254fb0562 463247 x11 optional xserver-xorg-input-mouse_1.9.3.orig.tar.gz 62a87dd473f5cf5115bb878fba4c1f3d 879 x11 optional xserver-xorg-input-mouse_1.9.3.orig.tar.gz.asc ad95cd1cbfc64177f108cdfe27f78e47 16627 x11 optional xserver-xorg-input-mouse_1.9.3-1.diff.gz -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEVXgdqzTmGgnvuIvhnbAjVVb4z60FAls7it8ACgkQnbAjVVb4 z61tKxAAjXVDo6QOG5iRB3XDbN35vS/HHMwABYXv1/GZMjLznVlUAEgoPupP6g1O y8D6dcXnH04FbyLqm4kE1hwhEjuNlU1MAeAh5ETNjysDs6OG8xFTjH5Xxm5ucSA/ 5loHGsrDo/k+1tltpWIdQH3QS7gEJSYeA2CJDMO2FFEVNlYFDnTpZr7aDzz8gMXw mZrOFOM3noLU1u7wdrHPKeED1meWBolp/tml/+vomr0TtejQQ2FPpkO1KrjA7b8H R0W5eQscg1hPN0b+/fOfNZEyqYy7BmaxwyOy4gB+mEolI88+W3n+JiVZrakpc683 2NshhKkPNEnL068FN9Z0YZX7rhO5YcfjrK0JRihaYxHgm8Zauv1ph3YJxrQHx+oS f0OxK3FPSTj/Vy9QWzGUKai/lZ/1bWsMmrsNuO2k6/FU4jvtYN1eCwHWbzYIqqCL ccmKhUDj+vdccrq70BMy0khfn3a3gva/7vf1mSL7o/XtFfqVSVgofuP5+RaWgKD8 TChTQ1se8xjuMuuFYGqUgi0rYRkMq+EcbU2W7+wRG01OvinM2xtr4QLVy1QYv619 mB/ydQeLJ0VHj4oGEgqjbyX30gZ9BDGhzFMTF4jL4JrZHqHiqH9N7rmlN5p2cCwh fG/rKiWM3luP8ChOJI9WjaXX5Att1WTRlxlMBjOa+TNO1Jv23rQ= =H5m2 -END PGP SIGNATURE- Thank you for your contribution to Debian.
Bug#902965: xserver-xorg-core: lxdm fails to start xserver with 2:1.20.0-3
Package: xserver-xorg-core Followup-For: Bug #902965 Dear Maintainer, *** Reporter, please consider answering these questions, where appropriate *** Failed startup /var/log/lxdm.log with xserver-xorg-core 2:1.20.0-3: ** Message: 11:08:32.447: find greeter (nil) ** Message: 11:08:32.447: find idle (nil) ** Message: 11:08:32.450: 1530668312: add xserver watch ** Message: 11:08:37.883: 1530668317: start xserver in 100 retry ** Message: 11:08:37.883: exit cb ** Message: 11:08:37.883: free session Successful /var/log/lxdm.log with xserver-xorg-core 2:1.20.0-2: ** Message: 13:13:42.892: find greeter (nil) ** Message: 13:13:42.892: find idle (nil) ** Message: 13:13:43.136: 1530675823: add xserver watch X.Org X Server 1.20.0 X Protocol Version 11, Revision 0 Build Operating System: Linux 4.9.0-6-amd64 x86_64 Debian Current Operating System: Linux am64 4.18.0-rc3+ #3128 SMP PREEMPT Wed Jul 4 12: 14:58 ACST 2018 x86_64 Kernel command line: BOOT_IMAGE=/vmlinuz-4.18.0-rc3+ root=UUID=39706f53-7c27-431 0-b22a-36c7b042d1a1 ro page_owner=on Build Date: 24 May 2018 04:23:27PM xorg-server 2:1.20.0-2 (https://www.debian.org/support) Current version of pixman: 0.34.0 Before reporting problems, check http://wiki.x.org to make sure that you have the latest version. Markers: (--) probed, (**) from config file, (==) default setting, (++) from command line, (!!) notice, (II) informational, (WW) warning, (EE) error, (NI) not implemented, (??) unknown. (==) Log file: "/var/log/Xorg.0.log", Time: Wed Jul 4 13:13:47 2018 (==) Using config file: "/etc/X11/xorg.conf" am64:/home/amarsh04# cat /var/log/lxdm.log ** Message: 13:13:42.892: find greeter (nil) ** Message: 13:13:42.892: find idle (nil) ** Message: 13:13:43.136: 1530675823: add xserver watch X.Org X Server 1.20.0 X Protocol Version 11, Revision 0 Build Operating System: Linux 4.9.0-6-amd64 x86_64 Debian Current Operating System: Linux am64 4.18.0-rc3+ #3128 SMP PREEMPT Wed Jul 4 12:14:58 ACST 2018 x86_64 Kernel command line: BOOT_IMAGE=/vmlinuz-4.18.0-rc3+ root=UUID=39706f53-7c27-4310-b22a-36c7b042d1a1 ro page_owner=on Build Date: 24 May 2018 04:23:27PM xorg-server 2:1.20.0-2 (https://www.debian.org/support) Current version of pixman: 0.34.0 Before reporting problems, check http://wiki.x.org to make sure that you have the latest version. Markers: (--) probed, (**) from config file, (==) default setting, (++) from command line, (!!) notice, (II) informational, (WW) warning, (EE) error, (NI) not implemented, (??) unknown. (==) Log file: "/var/log/Xorg.0.log", Time: Wed Jul 4 13:13:47 2018 (==) Using config file: "/etc/X11/xorg.conf" (==) Using system config directory "/usr/share/X11/xorg.conf.d" (II) [KMS] Kernel modesetting enabled. The XKEYBOARD keymap compiler (xkbcomp) reports: > Warning: Symbol map for key redefined > Using last definition for conflicting fields Errors from xkbcomp are not fatal to the X server ** Message: 13:14:00.597: 1530675840: start xserver in 96 retry ** Message: 13:14:00.597: add 0x560e3ea50380 ** Message: 13:14:00.597: prepare greeter on /var/run/lxdm/lxdm-:0.auth ** Message: 13:14:00.682: start greeter on /var/run/lxdm/lxdm-:0.auth Fontconfig error: failed reading config file Fontconfig error: failed reading config file Fontconfig error: failed reading config file Fontconfig error: failed reading config file Fontconfig error: failed reading config file ** Message: 13:14:17.481: greeter 0 session 0x560e3ea50380 ** Message: 13:14:17.481: user 0 session 0x560e3ea50380 cmd USER_LIST (II) AIGLX: Suspending AIGLX clients for VT switch radeon: Failed to deallocate virtual address for buffer: radeon:size : 8355840 bytes radeon:va: 0x10090 The XKEYBOARD keymap compiler (xkbcomp) reports: > Warning: Symbol map for key redefined > Using last definition for conflicting fields Errors from xkbcomp are not fatal to the X server xcb_connection_has_error() returned true (II) Server terminated successfully (0). Closing log file. xsetroot: unable to open display ':0' ** Message: 14:21:27.517: find greeter (nil) ** Message: 14:21:27.517: find idle (nil) ** Message: 14:21:27.621: 1530679887: add xserver watch X.Org X Server 1.20.0 X Protocol Version 11, Revision 0 Build Operating System: Linux 4.9.0-6-amd64 x86_64 Debian Current Operating System: Linux am64 4.18.0-rc3+ #3128 SMP PREEMPT Wed Jul 4 12:14:58 ACST 2018 x86_64 Kernel command line: BOOT_IMAGE=/vmlinuz-4.18.0-rc3+ root=UUID=39706f53-7c27-4310-b22a-36c7b042d1a1 ro page_owner=on Build Date: 24 May 2018 04:23:27PM xorg-server 2:1.20.0-2 (https://www.debian.org/support) Current version of pixman: 0.34.0 Before reporting problems, check http://wiki.x.org to make sure that you have the latest version. Markers: (--) probed, (**) from config file, (==) default setting, (++) from command line, (!!) notice, (II)
Processing of xserver-xorg-input-mouse_1.9.3-1_source.changes
xserver-xorg-input-mouse_1.9.3-1_source.changes uploaded successfully to localhost along with the files: xserver-xorg-input-mouse_1.9.3-1.dsc xserver-xorg-input-mouse_1.9.3.orig.tar.gz xserver-xorg-input-mouse_1.9.3.orig.tar.gz.asc xserver-xorg-input-mouse_1.9.3-1.diff.gz Greetings, Your Debian queue daemon (running on host usper.debian.org)
Bug#902965: xserver-xorg-core: lxdm fails to start xserver with 2:1.20.0-3
Control: tag -1 moreinfo On 07/04/2018 04:23 AM, Arthur Marsh wrote: > Package: xserver-xorg-core > Version: 2:1.20.0-3 > Severity: normal > > Dear Maintainer, > > *** Reporter, please consider answering these questions, where appropriate *** > >* What led up to the situation? > > upgrading to 2:1.20.0-3 results in lxdm failing to start xserver > >* What exactly did you do (or not do) that was effective (or > ineffective)? > > downgrading to 2:1.20.0-2 resulted in a working system > Please include lxdm logs? Cheers, Julien
Processed: Re: Bug#902965: xserver-xorg-core: lxdm fails to start xserver with 2:1.20.0-3
Processing control commands: > tag -1 moreinfo Bug #902965 [xserver-xorg-core] xserver-xorg-core: lxdm fails to start xserver with 2:1.20.0-3 Added tag(s) moreinfo. -- 902965: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902965 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
