Bug#1060332: /usr/share/man/man4/libinput.4.gz: Option ccelStepFallback" "float", Option ccelStepMotion" "float", .
On Tue, 9 Jan 2024 19:40:30 +0100 =?utf-8?B?0L3QsNCx?=
wrote:
Package: xserver-xorg-input-libinput
Version: 1.3.0-1
Severity: normal
File: /usr/share/man/man4/libinput.4.gz
do notice Option ccelStepFallback "float" and similar, clearly mangled.
I believe this is already fixed upstream by:
https://gitlab.freedesktop.org/xorg/driver/xf86-input-libinput/-/merge_requests/45/diffs
which was included in the upstream 1.4.0 release.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#173314: xcalc only accepts digits from the numeric pad
This should be fixed now in the new upstream xcalc-1.1.2 release. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#101937: [xwd] 'xwd -name windowtitle -frame' doesn't capture frame
This is operating as documented - in the xwd man page, it states:
-frame This option indicates that the window manager frame should be
included when manually selecting a window.
But using -name is selecting a window automatically, not waiting for the user
to manually click on it.
With the current implementation, you would instead need to do:
"xwininfo -name ... -children | grep Parent"
and use the id returned by that with the -id argument to xwd:
"xwd -id ... -out image"
Making -frame work with the automatic selection arguments (-id & -name)
might be a nice enhancement, but it's not a bug that it doesn't yet.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#201994: [xconsole] want mouse wheel to scroll log window
Previously translations for buttons 4 & 5 were only set for the scrollbar, so
required the mouse to be over the scrollbar to use the mouse wheel.
I've submitted a merge request upstream to handle buttons 4 & 5 in the text
area as well:
https://gitlab.freedesktop.org/xorg/app/xconsole/-/merge_requests/7
You should be able to edit the XConsole app-defaults file on your system
to do the same until a new release is published.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#173314: xcalc only accepts digits from the numeric pad
This is because the key mappings in the translation list in app-defaults
only list the main set of number keys with a modifier of "None", so they
don't work when NumLock is active. We can't remove that modifier since
then holding down shift and hitting one of them would enter the number
instead of doing the intended operation (!, *, (, or ) for instance).
Instead I've submitted a merge request upstream to add translations for
those keys with Mod2 (aka NumLock) in the modifier list - you should be
able to edit the XCalc app-defaults file on your system to do the same
until a new release is published:
https://gitlab.freedesktop.org/xorg/app/xcalc/-/merge_requests/11
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#92706: xcalc support for comma on numeric keypad
I believe this was fixed upstream a couple years after this bug was reported: 341. Added KP_Separator to symbols that can generate decimal() in xcalc (Egbert Eich). https://cgit.freedesktop.org/~libv/xfree86/commit/programs/xcalc/XCalc.ad?id=b4898b6e916dbc0f71daa5edaba1cc115ae5794d -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#720266: x11-apps: xman aborts closing search window
This is because xman was not installing a WM_DELETE_WINDOW handler for the search window, so window managers fall back to XKillClient() to shut down the entire program when the close button is clicked. Upstream fix: https://gitlab.freedesktop.org/xorg/app/xman/-/merge_requests/6 -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#742356: xkbprint(1): Some (typographical) corrections to the manual
Fixed upstream in xkbprint 1.0.5 by https://gitlab.freedesktop.org/xorg/app/xkbprint/-/commit/b968db6ca6fdb6ebb2384eaffaabe406c5cf783f -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Bug#726962: Bug #726962
The '..' macro was removed upstream in the xinit 1.4.0 release: https://gitlab.freedesktop.org/xorg/app/xinit/commit/52689362 The hair spaces between dashes recommended in this bug were added upstream in the xinit 1.4.1 release: https://gitlab.freedesktop.org/xorg/app/xinit/commit/752ef176 The issue in the previous comment about the Debian text accidentally inserted in the #ifdef __SCOMAN__ section appears have to been resolved by reworking that patch for the 1.4.0 release after the __SCOMAN__ ifdef was removed upstream. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/alanc
Bug#729812: Bug #729812, [libx11-doc] incorrect description of XkbGetNamedIndicator in man pages
Fixed upstream: https://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=c6dadd4cebd994aafb37a58b3adbaa82507c2d18 -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/alanc
Bug#761628: please do not use in xdmcp.xml
On 11/11/15 01:23 PM, Helmut Grohne wrote:
Hello Xorg developers,
While furthering Debian's multiarch capabilities I ran into the issue
that an xdmcp.txt generated from xdmcp.xml (in libxdmcp) would be
dependent on the version of xorg-sgml-doctools. Due to the
implementation of multiarch, the difference in file content breaks the
installation of libxdmcp. I am therefore proposing to drop the use of
in xdmcp.xml (see attached patch). Despite being motivated
by a technical constraint in Debian, this change makes sense
conceptually as well. The value of is independent of the
version of libxdmcp. I would not expect the version of a different tool
to show up in the header of the documentation for libxdmcp. I hope that
this makes sense to you as well. Please Cc me in your replies.
This is leftover from the old X11R6 monolithic releases, when everything
was released as one giant wad, and the was the version of
that wad. It's stayed around mainly because we've had no reason to drop
it until now.
Since we've not even done a X11R7 katamari release in years, it's pretty
meaningless today, so I've pushed your suggested fix to git master for
libXdmcp:
To ssh://git.freedesktop.org/git/xorg/lib/libXdmcp
b10f382..5021b93 master -> master
Thank you for your patch.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
Bug#749120: [PATCH libxtrans] Make sure LONG64 is defined if necessary
On 07/29/15 11:41 AM, Julien Cristau wrote:
Xtrans.h defines BytesReadable_t as int or long depending on whether
LONG64 is defined. We need to make sure Xmd.h is included so our idea
of BytesReadable_t is consistent across compilation units.
Debian bug#749120
Reported-by: Michael Tautschnig <m...@debian.org>
Signed-off-by: Julien Cristau <jcris...@debian.org>
---
Xtrans.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/Xtrans.h b/Xtrans.h
index 026fbd7..22e0440 100644
--- a/Xtrans.h
+++ b/Xtrans.h
@@ -52,6 +52,7 @@ from The Open Group.
#include
#include
+#include
#ifndef WIN32
#include
Reviewed-by: Alan Coopersmith <alan.coopersm...@oracle.com>
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
Bug#749120: [PATCH libFS] include X11/Xmd.h in fs_transport
On 07/26/15 11:16 AM, Julien Cristau wrote: Xtrans defines BytesReadable_t as int or long depending on whether LONG64 is defined. So on a 64bit build it would be int when building FSConnServ.c, but long for fs_transport.c. To fix this inconsistency, make fs_transport.c include X11/Xmd.h. Debian bug#749120 Reported-by: Michael Tautschnig m...@debian.org Signed-off-by: Julien Cristau jcris...@debian.org --- src/fs_transport.c | 1 + 1 file changed, 1 insertion(+) I'm not sure if this should be fixed in xtrans instead... Yeah - I think we should add the #include X11/Xmd.h to Xtrans.h, not force every consumer to add it before including Xtrans.h. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/55b52dab.6090...@oracle.com
Bug#726041: [PATCH] mi: fix typo in warning about overflowing queue
On 07/ 2/15 11:16 AM, Julien Cristau wrote: Debian bug#726041 Reported-by: Vincent Hobeïka vincent.hobe...@gmail.com Signed-off-by: Julien Cristau jcris...@debian.org --- mi/mieq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/mieq.c b/mi/mieq.c index 8907a6e..b7be193 100644 --- a/mi/mieq.c +++ b/mi/mieq.c @@ -599,7 +599,7 @@ mieqProcessInputEvents(void) ErrorF([mi] EQ processing has resumed after %lu dropped events.\n, (unsigned long) miEventQueue.dropped); ErrorF -([mi] This may be caused my a misbehaving driver monopolizing the server's resources.\n); +([mi] This may be caused by a misbehaving driver monopolizing the server's resources.\n); miEventQueue.dropped = 0; } Heh, it only took a minute of starting to see the subtle change of my to by. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/559582dc.3020...@oracle.com
Bug#701372: [PATCH] dix: add missing include for DeleteWindowFromAnySelections
On 07/27/13 03:09 AM, Julien Cristau wrote: Fixes build error with XACE disabled: window.c:886:5: error: implicit declaration of function 'DeleteWindowFromAnySelections' [-Werror=implicit-function-declaration] DeleteWindowFromAnySelections(pWin); ^ Debian bug#701372 Reported-by: Matthias Klose d...@debian.org Signed-off-by: Julien Cristau jcris...@debian.org --- dix/window.c |1 + 1 file changed, 1 insertion(+) diff --git a/dix/window.c b/dix/window.c index 8950f97..9fa51c2 100644 --- a/dix/window.c +++ b/dix/window.c @@ -126,6 +126,7 @@ Equipment Corporation. #ifdef COMPOSITE #include compint.h #endif +#include selection.h #include privates.h #include xace.h Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51f405b1.6060...@oracle.com
Bug#621702: [PATCH libXRes] Compute number of bytes correctly in XResQueryClientPixmapBytes
On 06/30/13 11:09 AM, Julien Cristau wrote: 64-bit servers send the upper 32-bit in bytes_overflow. We were multiplying by 2^32 - 1 instead of 2^32 when putting things back together. Debian bug#621702 Reported-by: Kevin Ryde use...@zip.com.au Signed-off-by: Julien Cristau jcris...@debian.org --- src/XRes.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XRes.c b/src/XRes.c index 51e905f..89fab82 100644 --- a/src/XRes.c +++ b/src/XRes.c @@ -240,7 +240,7 @@ Status XResQueryClientPixmapBytes ( } #ifdef LONG64 -*bytes = (rep.bytes_overflow * 4294967295) + rep.bytes; +*bytes = (rep.bytes_overflow * 4294967296UL) + rep.bytes; #else *bytes = rep.bytes_overflow ? 0x : rep.bytes; #endif Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51d86220.7020...@oracle.com
Bug#488535: [PATCH:xrdb] Ensure we don't read out of ClassName array bounds for unknown visual type
Should never happen, but has been reported as happening at least once:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=488535
Instead prints warning messages to stderr to help diagnose where the
bad visual information is coming from.
(Tested by temporarily commenting out names in the ClassName array.)
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xrdb.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/xrdb.c b/xrdb.c
index b7c9fa3..d42a519 100644
--- a/xrdb.c
+++ b/xrdb.c
@@ -605,6 +605,8 @@ static char *ClassNames[] = {
DirectColor
};
+#define NUM_CLASS_NAMES (int)(sizeof(ClassNames) / sizeof(ClassNames[0]))
+
static void
DoScreenDefines(Display *display, int scrno, String *defs)
{
@@ -625,9 +627,16 @@ DoScreenDefines(Display *display, int scrno, String *defs)
AddNum(defs, Y_RESOLUTION, Resolution(screen-height,screen-mheight));
AddNum(defs, PLANES, DisplayPlanes(display, scrno));
AddNum(defs, BITS_PER_RGB, visual-bits_per_rgb);
-AddDefQ(defs, CLASS, ClassNames[visual-class]);
-snprintf(name, sizeof(name), CLASS_%s, ClassNames[visual-class]);
-AddNum(defs, name, (int)visual-visualid);
+if (visual-class = 0 visual-class NUM_CLASS_NAMES) {
+ AddDefQ(defs, CLASS, ClassNames[visual-class]);
+ snprintf(name, sizeof(name), CLASS_%s, ClassNames[visual-class]);
+ AddNum(defs, name, (int)visual-visualid);
+}
+else {
+ fprintf(stderr,
+ %s: unknown visual type %d for default visual id 0x%lx\n,
+ ProgramName, visual-class, visual-visualid);
+}
switch(visual-class) {
case StaticColor:
case PseudoColor:
@@ -643,9 +652,16 @@ DoScreenDefines(Display *display, int scrno, String *defs)
break;
}
if (j 0) {
- snprintf(name, sizeof(name), CLASS_%s_%d,
- ClassNames[vinfos[i].class], vinfos[i].depth);
- AddNum(defs, name, (int)vinfos[i].visualid);
+ if (vinfos[i].class = 0 vinfos[i].class NUM_CLASS_NAMES) {
+ snprintf(name, sizeof(name), CLASS_%s_%d,
+ClassNames[vinfos[i].class], vinfos[i].depth);
+ AddNum(defs, name, (int)vinfos[i].visualid);
+ }
+ else {
+ fprintf(stderr,
+ %s: unknown visual type %d for visual id 0x%lx\n,
+ ProgramName, vinfos[i].class, vinfos[i].visualid);
+ }
}
}
XFree((char *)vinfos);
--
1.7.9.2
--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/1373137566-6437-1-git-send-email-alan.coopersm...@oracle.com
Re: [PATCH makedepend] Don't crash if an option's argument is missing
On 07/ 1/13 10:04 AM, Julien Cristau wrote:
Avoid dereferencing argv[argc].
See
http://www.forallsecure.com/bug-reports/011f1a55f79a5501b36008d6ee0d40e8b6644569/
Reported-by: Alexandre Rebert alexan...@cmu.edu
Signed-off-by: Julien Cristau jcris...@debian.org
---
main.c | 16
1 file changed, 16 insertions(+)
diff --git a/main.c b/main.c
index e42b0cf..6ccb09b 100644
--- a/main.c
+++ b/main.c
@@ -242,6 +242,8 @@ main(int argc, char *argv[])
break;
case 'D':
if (argv[0][2] == '\0') {
+if (argc 2)
+ fatalerr(Missing argument for -D\n);
Code is fine, but it appears that you've used spaces on the if line
tabs on the fatalerr() line in each place, making the indentation look
funny in a few spots - would be nice to do a quick global-replace to
clean that up.
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/51d20ebd.1020...@oracle.com
Re: [PATCH] xkb: don't call atoi(NULL) when parsing argv
On 07/ 1/13 10:39 AM, Julien Cristau wrote:
If the -ardelay or -arinterval options have no argument, there's no
point trying to read it.
See
http://www.forallsecure.com/bug-reports/feb3db57fc206d8df22ca53a6907f74973876272/
Reported-by: Alexandre Rebert alexan...@cmu.edu
Signed-off-by: Julien Cristau jcris...@debian.org
---
xkb/xkbInit.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/xkb/xkbInit.c b/xkb/xkbInit.c
index 5308a29..f72655f 100644
--- a/xkb/xkbInit.c
+++ b/xkb/xkbInit.c
@@ -759,13 +759,15 @@ XkbProcessArguments(int argc, char *argv[], int i)
if ((strcmp(argv[i], -ardelay) == 0) || (strcmp(argv[i], -ar1) == 0))
{ /* -ardelay int */
if (++i = argc)
UseMsg();
-XkbDfltRepeatDelay = (long) atoi(argv[i]);
+else
+XkbDfltRepeatDelay = (long) atoi(argv[i]);
return 2;
}
if ((strcmp(argv[i], -arinterval) == 0) || (strcmp(argv[i], -ar2) ==
0)) { /* -arinterval int */
if (++i = argc)
UseMsg();
-XkbDfltRepeatInterval = (long) atoi(argv[i]);
+else
+XkbDfltRepeatInterval = (long) atoi(argv[i]);
return 2;
}
return 0;
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/51d21112.60...@oracle.com
Bug#657215: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol
On 06/ 9/13 10:00 AM, Julien Cristau wrote:
The padding is *before* the rate field, so the rate is placed on a 32bit
boundary. This change adds explicit padding between height and rate,
and removes extraneous padding after the rate field, which the server
never sent and xlib never read.
This changes sizeof(xvEncodingInfo). Hopefully that's not a big deal as
clients only see the Xlib structure XvEncodingInfo.
Debian bug#657215
Reported-by: Kevin Ryde use...@zip.com.au
Signed-off-by: Julien Cristau jcris...@debian.org
This looked reasonable to me, but just to be sure, I threw together the
attached test program and confirmed it doesn't change where in the
struct the rate data appears, due to the compiler silently inserting
padding to reach 32-bit alignment.
In both 32-bit 64-bit, on both SPARC x86, all 4 returned:
OLD NEW
offsetof(rate): 12 12
offsetof(pad):20 10
sizeof(struct): 24 20
which matches my expectations, so:
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
#include stdio.h
#include stddef.h
#include X11/Xmd.h
#define XvEncodingID CARD32
typedef struct {
INT32 numerator B32;
INT32 denominator B32;
} xvRational;
typedef struct {
XvEncodingID encoding B32;
CARD16 name_size B16;
CARD16 width B16, height B16;
xvRational rate;
CARD16 pad B16;
} OLDxvEncodingInfo;
typedef struct {
XvEncodingID encoding B32;
CARD16 name_size B16;
CARD16 width B16, height B16;
CARD16 pad B16;
xvRational rate;
} NEWxvEncodingInfo;
int main(int argc, char **argv)
{
printf( OLD NEW\n);
printf(offsetof(rate): %2d %2d\n,
offsetof(OLDxvEncodingInfo, rate),
offsetof(NEWxvEncodingInfo, rate));
printf(offsetof(pad):%2d %2d\n,
offsetof(OLDxvEncodingInfo, pad),
offsetof(NEWxvEncodingInfo, pad));
printf(sizeof(struct): %2d %2d\n,
sizeof(OLDxvEncodingInfo),
sizeof(NEWxvEncodingInfo));
}
Re: [PATCH 00/18] Xfbdev Atari and Amiga support
On 04/24/13 10:28 PM, Geert Uytterhoeven wrote: On Thu, Apr 25, 2013 at 7:23 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/24/13 10:00 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: On 04/24/13 06:58 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: This broke my build: Undefined first referenced symbol in file c2p_unsupported ../../../miext/shadow/.libs/libshadow.a(shafb4.o) Builds fine with GCC; perhaps that figures out that this function can never be called? If I build with gcc 4.7.2 with -O2 it indeed optimizes it out. If I build with gcc 4.7.2 with -g and no -O flags, it fails the same way. Sorry, I forgot that unlike Linux kernel people, xorg people sometimes do compile without optimization. Or in the case I first hit this, with optimization using compilers that aren't gcc. (Xorg is built on several non-Linux platforms, with compilers such as clang or Solaris Studio.) That makes sense at least. We could either make c2p_unsupported call FatalError or just be a no-op. Any preference? I'd prefer at least a BUG_WARN() over a no-op, to give us a hint why stuff isn't working, though FatalError() also works for something that should be impossible to hit. Or assert(), or insert xorg favorite runtime check method here. This should be indeed impossible to hit, as all calls to the c2p functions use hardcoded parameters. I'm just a bit afraid that adding real error handling will slow down the code. Can it be dependent on DEBUG or so? Does it matter if the compiler optimizes out the call to c2p_unsupported? The performance should be the same for you. Or does this code even need to be built for non-68k platforms at all? (I'm still confused why we just took a big chunk of code for a platform with no active maintainer, but if Keith's willing to maintain it himself, that's his call. I do hope we can fix the license before release to be a standard license, not yet another one-off we all have to add to our packages to comply with the terms of.) -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5178c230.7020...@oracle.com
Re: [PATCH 00/18] Xfbdev Atari and Amiga support
On 04/24/13 10:00 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: On 04/24/13 06:58 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: This broke my build: Undefined first referenced symbol in file c2p_unsupported ../../../miext/shadow/.libs/libshadow.a(shafb4.o) Builds fine with GCC; perhaps that figures out that this function can never be called? If I build with gcc 4.7.2 with -O2 it indeed optimizes it out. If I build with gcc 4.7.2 with -g and no -O flags, it fails the same way. That makes sense at least. We could either make c2p_unsupported call FatalError or just be a no-op. Any preference? I'd prefer at least a BUG_WARN() over a no-op, to give us a hint why stuff isn't working, though FatalError() also works for something that should be impossible to hit. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5178bdb9.6090...@oracle.com
Re: [PATCH 00/18] Xfbdev Atari and Amiga support
On 04/24/13 06:58 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: This broke my build: Undefined first referenced symbol in file c2p_unsupported ../../../miext/shadow/.libs/libshadow.a(shafb4.o) Builds fine with GCC; perhaps that figures out that this function can never be called? If I build with gcc 4.7.2 with -O2 it indeed optimizes it out. If I build with gcc 4.7.2 with -g and no -O flags, it fails the same way. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5178b44e.7080...@oracle.com
Re: [PATCH 00/18] Xfbdev Atari and Amiga support
On 04/24/13 11:29 PM, Geert Uytterhoeven wrote: Hi Alan, Or does this code even need to be built for non-68k platforms at all? No. I don't think Xfbdev already limits some options to certain platforms? Not sure about that, I've not looked too closely at Xfbdev's build. (I'm still confused why we just took a big chunk of code for a platform with no active maintainer, but if Keith's willing to maintain it himself, that's his call. I do hope we can fix the license before release to be a standard license, not yet another one-off we all have to add to our packages to comply with the terms of.) I'm open for license changes. What's the recommended one? The recommended one is at the start of the COPYING file at the top level of the xserver source tree. It's key feature over all others is that the text of the license uses generic terms authors or copyright holders so that packagers distributors can comply by just adding each copyright notice, and not adding two additional paragraphs per copyright holder listing the exact set of warranties disclaimed by that copyright holder. As you can see from the COPYING file, we've still got a lot of mess to clean up, but I'd like to avoid making it worse in the interim. (And please do add your copyright notice to the set in the COPYING file in your patch, so we don't have to remember to do it later.) -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51798c02.1000...@oracle.com
Re: [PATCH 00/18] Xfbdev Atari and Amiga support
On 04/25/13 09:05 AM, Keith Packard wrote:
Alan Coopersmith alan.coopersm...@oracle.com writes:
I'd prefer at least a BUG_WARN() over a no-op, to give us a hint why
stuff isn't working, though FatalError() also works for something that
should be impossible to hit.
How about this:
commit e779402d531625ba4ed5d628d06c6b1e06b2ec7b
Author: Keith Packard kei...@keithp.com
Date: Thu Apr 25 09:02:31 2013 -0700
shadow: Define c2p_unsupported
Just make this call BUG_WARN(1) to indicate that something unexpected
happened
Signed-off-by: Keith Packard kei...@keithp.com
diff --git a/miext/shadow/c2p_core.h b/miext/shadow/c2p_core.h
index 252f93e..a48e223 100644
--- a/miext/shadow/c2p_core.h
+++ b/miext/shadow/c2p_core.h
@@ -41,7 +41,9 @@ static inline void _transp(CARD32 d[], unsigned int i1, unsign
}
-extern void c2p_unsupported(void);
+static inline void c2p_unsupported(void) {
+BUG_WARN(1);
+}
static inline CARD32 get_mask(unsigned int n)
{
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/51798c2d.1040...@oracle.com
Re: [PATCH 00/18] Xfbdev Atari and Amiga support
This broke my build: Undefined first referenced symbol in file c2p_unsupported ../../../miext/shadow/.libs/libshadow.a(shafb4.o) miext/shadow/c2p_core.h defines c2p_unsupported as an extern function, and calls it from some inline functions, but I see no file defining it. Perhaps a forgotten git add of a new source? But then it would also need to be added to a Makefile.am somewhere too. -alan- On Wed, Apr 24, 2013 at 2:15 PM, Keith Packard kei...@keithp.com wrote: Geert Uytterhoeven ge...@linux-m68k.org writes: Geert Uytterhoeven (16): miext/shadow/shpacked.c: Remove unused PickBit() define test/input: Fix double-aligned test in dix_valuator_alloc() on m68k KDrive: Bail out if screen initialization failed Xfbdev: Make char *fbdevDevicePath const Xfbdev: Handle unset fix.line_length Xfbdev: Add support for monochrome visuals Xfbdev: Treat 1 bpp pseudocolor as monochrome Shadow: Add c2p core Shadow: Add support for Atari iplan2p4 Shadow: Add support for Atari iplan2p8 Shadow: Add support for Amiga afb4 Shadow: Add support for Amiga afb8 Xfbdev: Reject unsupported frame buffer types Xfbdev: Force shadowfb for frame buffers with non-packed pixels Xfbdev: Wire up Atari iplan2p4 and iplan2p8 support Xfbdev: Wire up Amiga afb4 and afb8 support Merged. 53da26a..7ab98ba master - master -- keith.pack...@intel.com ___ xorg-de...@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/candsp+9bztctbq-g01qzedrrn+bty9p3wwwo84fy7bcyedm...@mail.gmail.com
Bug#696965: [PATCH] support for HW_SKIP_CONSOLE breaks use by blind people
On 12/31/12 05:36 PM, Samuel Thibault wrote: Michal Suchanek, le Mon 31 Dec 2012 19:22:13 +0100, a écrit : why is that patch needed? It is quite non-obvious why would dummy driver require a console under any circumstances. It does not render anything anywhere so does not use console for anything. The console *is* needed for keyboard input. Again, the use case is blind people who have use of possessing an actual screen, and thus don't have any, and thus have to use the dummy driver. So it sounds like that should be handled by the input driver, not the output driver. People who want to use dummy output with real input should have input devices configured - those who want an Xvfb like experience can use the dummy video driver and either use the void input driver or configure their servers to have no input drivers loaded. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50e24007.4030...@oracle.com
Bug#582650: [PATCH] Xephyr.man.pre: In OPTIONS mention that Xserver(1) are also accepted
Jari Aalto wrote: diff --git a/hw/kdrive/ephyr/Xephyr.man.pre b/hw/kdrive/ephyr/Xephyr.man.pre index eb80b96..3aece2a 100644 --- a/hw/kdrive/ephyr/Xephyr.man.pre +++ b/hw/kdrive/ephyr/Xephyr.man.pre @@ -39,6 +39,8 @@ uses the host X server window as framebuffer via fast SHM XImages. It also has support for visually debugging what the server is painting. .SH OPTIONS +The server accepts all the standard options of Xserver(__appmansuffix__) +and the following additional options: .TP 8 .BI -screen width x height sets the screen size. Thanks for the patch. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4c0cff89.1020...@oracle.com
Bug#382037: Missing programname and PID in syslog-log by PAM
Julien Cristau wrote: It seems that xdm doesn't call openlog(), so the identifier defaults to null when pam calls syslog(). Alan, do you know why the call to openlog() is conditional on __OpenBSD__? I think we should add it on linux too (something like the attached patch). That's the way we inherited it from XFree86 - from looking at their CVS, this was a set of changes from the OpenBSD team that XFree86 applied for OpenBSD only even though they were more widely applicable: 271. xdm updates from the OpenBSD team, including: - support for Kerberos IV authentication [enabled only in OpenBSD.cf, but could be enabled for other systems by setting HasdKrbIV] - use the arc4random(4) random number generator on OpenBSD - add a new resource allowRootLogin, which can be used to disable root logins through xdm - log failed logins to syslogd [OpenBSD only, but could be enabled on other systems] - verify that the shell is valid using /etc/shells [OpenBSD only] - verify that the account hasn't expired [OpenBSD only, but could be enabled on other system that use the same passwd aging structure] (#3948, 3980, OpenBSD team, Matthieu Herrb). I'd have no objections to using openlog() on other OS'es too, though I'd prefer an autoconf test for the openlog() function over just adding __linux__ (or just making it non-conditional for all OS'es if everyone has openlog()). -- -Alan Coopersmith- [EMAIL PROTECTED] Sun Microsystems, Inc. - X Window System Engineering -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#397956: xserver-xorg-core: Xorg man page claims to be for X11R6
Upstream fixed already for xorg-server-1.2.0: http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commitdiff;h=5f14c9a78b74017cdc66b79b63b3b1f68cf24911 -- -Alan Coopersmith- [EMAIL PROTECTED] Sun Microsystems, Inc. - X Window System Engineering -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Xfree86 4.4 vs Xorg Wrap-up
Francois Isabelle wrote: 3 - Xorg forked XFree86 due to these licensing considerations The X.Org Foundation is the latest incarnation of a string of organizations going back to the original MIT X Consortium that have produced the X Window System software releases for over 15 years. XFree86 forked from the X Consortium years ago, and ever since code has flowed back and forth both ways. Xorg is not a new fork of XFree86 - all that has happened is that the original X Window System open source distribution has been opened up to a more modern open source style development process and interest in it has picked back up. This was in progress for a year before XFree86 changed their license - the license change just gave more distributions incentive to change. To make it easier for them to do so, the XFree86 4.4 portions not covered by the new license were folded into the X11R6.6 tree to produce the upcoming X11R6.7 release. (The work on reviving X.Org came out of the traditional Unix vendors wanting to open up X.Org to greater participation from the Linux, BSD, and other open source communities, and from people dissatisfied with the governance of the XFree86 Project. See the archives of the [EMAIL PROTECTED] mailing list for all the various flamefests.) -- -Alan Coopersmith- [EMAIL PROTECTED] Sun Microsystems, Inc. - X Window System Engineering
